@yemi33/minions 0.1.370 → 0.1.372

package/CHANGELOG.md

@@ -1,12 +1,14 @@
 # Changelog
 
-## 0.1.370 (2026-04-06)
+## 0.1.372 (2026-04-06)
 
 ### Features
+- Fix review re-dispatch infinite loop (#226)
 - Add subagent guidance and health check preamble to playbooks (#225)
 - Fix 2 failing source-pattern test assertions (#224)
 
 ### Fixes
+-  restore dispatched_to on work items when marking done after retry
 -  copy button preserves markdown formatting
 
 ## 0.1.368 (2026-04-06)

package/engine/github.js

@@ -141,6 +141,13 @@ async function pollPrStatus(config) {
     else if (prData.state === 'closed') newStatus = PR_STATUS.ABANDONED;
     else if (prData.state === 'open') newStatus = PR_STATUS.ACTIVE;
 
+    // Track head SHA changes to detect new pushes (used for review re-dispatch gating)
+    if (prData.head?.sha && pr.headSha !== prData.head.sha) {
+      pr.headSha = prData.head.sha;
+      pr.lastPushedAt = new Date().toISOString();
+      updated = true;
+    }
+
     if (pr.status !== newStatus) {
       log('info', `PR ${pr.id} status: ${pr.status} → ${newStatus}`);
       pr.status = newStatus;
@@ -191,6 +198,9 @@ async function pollPrStatus(config) {
       if (states.some(s => s === 'CHANGES_REQUESTED')) newReviewStatus = 'changes-requested';
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = 'approved';
       else if (states.length > 0) newReviewStatus = 'pending';
+      // If all reviews were COMMENTED (filtered out), states is empty but reviews exist.
+      // Set to 'waiting' instead of leaving as 'pending' to prevent infinite review re-dispatch.
+      else if (states.length === 0 && reviews.length > 0 && newReviewStatus === 'pending') newReviewStatus = 'waiting';
 
       if (pr.reviewStatus !== newReviewStatus) {
         log('info', `PR ${pr.id} reviewStatus: ${pr.reviewStatus} → ${newReviewStatus}`);

package/engine/lifecycle.js

@@ -546,6 +546,8 @@ function updateWorkItemStatus(meta, status, reason) {
         delete target.failReason;
         delete target.failedAt;
         target.completedAt = ts();
+        // Restore agent info from dispatch metadata (cleared on retry reset)
+        if (meta._agentId && !target.dispatched_to) target.dispatched_to = meta._agentId;
       } else if (status === WI_STATUS.FAILED) {
         if (reason) target.failReason = reason;
         target.failedAt = ts();
@@ -727,6 +729,9 @@ function updatePrAfterReview(agentId, pr, project) {
 
   // Set reviewStatus to 'waiting' (single source of truth — synced from ADO/GitHub votes on next poll)
   target.reviewStatus = 'waiting';
+  // Track when this PR was last reviewed — used by engine.js to prevent re-dispatch
+  // until new commits are pushed (lastPushedAt > lastReviewedAt)
+  target.lastReviewedAt = ts();
   target.minionsReview = {
     reviewer: reviewerName,
     reviewedAt: ts(),
@@ -1160,7 +1165,10 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
     // If decomposition produced nothing, fall through to mark parent as done
   }
 
-  if (isSuccess && meta?.item?.id && !skipDoneStatus) updateWorkItemStatus(meta, WI_STATUS.DONE, '');
+  if (isSuccess && meta?.item?.id && !skipDoneStatus) {
+    meta._agentId = agentId;
+    updateWorkItemStatus(meta, WI_STATUS.DONE, '');
+  }
   if (!isSuccess && meta?.item?.id) {
     // Auto-retry: read fresh _retryCount from file (not stale dispatch-time snapshot)
     let retries = (meta.item._retryCount || 0);

package/engine.js

@@ -1268,9 +1268,11 @@ function discoverFromPrs(config, project) {
     // minionsReview tracks metadata (reviewer, note) but not the authoritative status
     const reviewStatus = pr.reviewStatus || 'pending';
 
-    // PRs needing review: pending or waiting (review dispatched but no verdict yet)
+    // PRs needing review: pending review status and not already reviewed without new commits
     const autoReview = config.engine?.autoReview !== false;
-    const needsReview = autoReview && reviewStatus === 'pending';
+    // Skip re-dispatch if already reviewed and no new commits pushed since last review
+    const alreadyReviewed = pr.lastReviewedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.lastReviewedAt);
+    const needsReview = autoReview && reviewStatus === 'pending' && !alreadyReviewed;
     if (needsReview) {
       const key = `review-${project?.name || 'default'}-${pr.id}`;
       if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.370",
+  "version": "0.1.372",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"