@yemi33/minions 0.1.365 → 0.1.367

package/CHANGELOG.md

@@ -1,8 +1,10 @@
 # Changelog
 
-## 0.1.365 (2026-04-06)
+## 0.1.367 (2026-04-06)
 
 ### Fixes
+-  low-severity dashboard polish — null guards, event params, UI gaps (#213)
+-  medium dashboard bugs — settings reset, work items, schedules, plans (#212)
 -  XSS vulnerabilities across dashboard components (#211)
 
 ## 0.1.364 (2026-04-06)

package/dashboard/js/render-dispatch.js

@@ -6,9 +6,9 @@ let _completedPage = 0;
 let _logPage = 0;
 
 function _completedPrev() { if (_completedPage > 0) { _completedPage--; refresh(); } }
-function _completedNext() { _completedPage++; refresh(); }
+function _completedNext() { _completedPage++; refresh(); } // clamped in renderDispatch
 function _logPrev() { if (_logPage > 0) { _logPage--; refresh(); } }
-function _logNext() { _logPage++; refresh(); }
+function _logNext() { _logPage++; refresh(); } // clamped in renderEngineLog
 
 function renderEngineStatus(engine) {
   const badge = document.getElementById('engine-badge');
@@ -153,6 +153,7 @@ function renderDispatch(dispatch) {
 
 function renderEngineLog(log) {
   const el = document.getElementById('engine-log');
+  if (!el) return;
   if (!log || log.length === 0) {
     el.innerHTML = '<div class="empty">No log entries yet.</div>';
     return;

package/dashboard/js/render-inbox.js

@@ -140,7 +140,7 @@ async function modalSaveEdit() {
 function modalCancelEdit() {
   const body = document.getElementById('modal-body');
   body.contentEditable = 'false';
-  body.textContent = _modalDocContext.content; // revert
+  body.innerHTML = renderMd(_modalDocContext.content); // revert (render Markdown, not raw text)
   body.style.border = '';
   body.style.padding = '';
   document.getElementById('modal-edit-btn').style.display = '';

package/dashboard/js/render-plans.js

@@ -255,7 +255,7 @@ function renderPlans(plans) {
         '<div><div class="plan-card-title">' + escHtml(p.summary || p.file) + versionBadge + '</div>' +
           '<div class="plan-card-meta">' +
             '<span style="font-weight:600;color:' + (statusColors[effectiveStatus] || 'var(--muted)') + '">' + label + '</span>' +
-            '<span>' + escHtml(p.project) + '</span>' +
+            (p.project ? '<span>' + escHtml(p.project) + '</span>' : '') +
             '<span>' + p.itemCount + ' items</span>' +
             (p.updatedAt ? '<span title="Last updated: ' + p.updatedAt + '">Updated ' + timeAgo(p.updatedAt) + '</span>' : '') +
             (p.completedAt ? '<span>' + p.completedAt.slice(0, 10) + '</span>' : '') +
@@ -370,6 +370,7 @@ async function planSubmitRevise(file) {
   try {
     const res = await fetch('/api/plans/revise', { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ file, feedback }) });
     const data = await res.json();
+    if (!res.ok) { showToast('cmd-toast', 'Revision failed: ' + (data.error || 'unknown'), false); return; }
     showToast('cmd-toast', 'Revision requested — agent will update the plan (' + data.workItemId + ')', true);
     planHideRevise(file);
     refreshPlans();

package/dashboard/js/render-prs.js

@@ -96,9 +96,10 @@ function openModal(i) {
 }
 
 function openAddPrModal() {
-  const projOpts = (typeof cmdProjects !== 'undefined' ? cmdProjects : []).map(p =>
-    '<option value="' + escHtml(p) + '">' + escHtml(p) + '</option>'
-  ).join('');
+  const projOpts = (typeof cmdProjects !== 'undefined' ? cmdProjects : []).map(p => {
+    const name = typeof p === 'object' ? p.name : p;
+    return '<option value="' + escHtml(name) + '">' + escHtml(name) + '</option>';
+  }).join('');
   const inputStyle = 'display:block;width:100%;margin-top:4px;padding:6px 8px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text);font-size:var(--text-md);font-family:inherit';
 
   document.getElementById('modal-title').textContent = 'Link Pull Request';

package/dashboard/js/render-schedules.js

@@ -484,6 +484,7 @@ function openEditScheduleModal(id) {
   document.getElementById('modal-body').innerHTML = _scheduleFormHtml(sched, true);
   window._editScheduleId = id;
   document.getElementById('modal').classList.add('open');
+  _updateCronPreview();
 }
 
 async function submitSchedule(isEdit) {

package/dashboard/js/render-work-items.js

@@ -84,7 +84,7 @@ function renderWorkItems(items) {
   allWorkItems = items;
   const el = document.getElementById('work-items-content');
   const countEl = document.getElementById('wi-count');
-  countEl.textContent = items.length;
+  if (countEl) countEl.textContent = items.length;
   if (!items.length) {
     el.innerHTML = '<p class="empty">No work items. Add tasks via Command Center above.</p>';
     return;
@@ -151,14 +151,14 @@ function editWorkItem(id, source) {
       '</label>' +
       '<div style="display:flex;justify-content:flex-end;gap:8px;margin-top:8px">' +
         '<button onclick="closeModal()" class="pr-pager-btn" style="padding:6px 16px;font-size:var(--text-md)">Cancel</button>' +
-        '<button onclick="submitWorkItemEdit(\'' + escHtml(id) + '\',\'' + escHtml(source || '') + '\')" style="padding:6px 16px;font-size:var(--text-md);background:var(--blue);color:#fff;border:none;border-radius:var(--radius-sm);cursor:pointer">Save</button>' +
+        '<button onclick="submitWorkItemEdit(\'' + escHtml(id) + '\',\'' + escHtml(source || '') + '\',event)" style="padding:6px 16px;font-size:var(--text-md);background:var(--blue);color:#fff;border:none;border-radius:var(--radius-sm);cursor:pointer">Save</button>' +
       '</div>' +
     '</div>';
   document.getElementById('modal').classList.add('open');
 }
 
-async function submitWorkItemEdit(id, source) {
-  var btn = event?.target; if (btn) { btn.disabled = true; btn.textContent = 'Saving...'; }
+async function submitWorkItemEdit(id, source, e) {
+  var btn = (e || window.event)?.target; if (btn) { btn.disabled = true; btn.textContent = 'Saving...'; }
   const title = document.getElementById('wi-edit-title').value.trim();
   const description = document.getElementById('wi-edit-desc').value;
   const type = document.getElementById('wi-edit-type').value;
@@ -320,7 +320,7 @@ function openCreateWorkItemModal() {
   const typeOpts = ['implement', 'fix', 'explore', 'test', 'review', 'ask', 'plan', 'verify', 'decompose', 'meeting'].map(t =>
     '<option value="' + t + '"' + (t === 'implement' ? ' selected' : '') + '>' + t + '</option>'
   ).join('');
-  const priOpts = ['high', 'medium', 'low'].map(p =>
+  const priOpts = ['critical', 'high', 'medium', 'low'].map(p =>
     '<option value="' + p + '"' + (p === 'medium' ? ' selected' : '') + '>' + p + '</option>'
   ).join('');
   const agentOpts = (typeof cmdAgents !== 'undefined' ? cmdAgents : []).map(a =>
@@ -349,7 +349,7 @@ function openCreateWorkItemModal() {
       '<label id="wi-new-skippr-row" style="color:var(--text);font-size:var(--text-md);display:flex;gap:8px;align-items:center;cursor:pointer"><input type="checkbox" id="wi-new-skippr"> Skip PR creation (push branch only)</label>' +
       '<div style="display:flex;justify-content:flex-end;gap:8px;margin-top:4px">' +
         '<button onclick="closeModal()" class="pr-pager-btn">Cancel</button>' +
-        '<button onclick="_submitCreateWorkItem()" style="padding:6px 16px;background:var(--blue);color:#fff;border:none;border-radius:var(--radius-sm);cursor:pointer">Create</button>' +
+        '<button onclick="_submitCreateWorkItem(event)" style="padding:6px 16px;background:var(--blue);color:#fff;border:none;border-radius:var(--radius-sm);cursor:pointer">Create</button>' +
       '</div>' +
     '</div>';
   document.getElementById('modal').classList.add('open');
@@ -365,8 +365,8 @@ function openCreateWorkItemModal() {
   setTimeout(() => document.getElementById('wi-new-title')?.focus(), 100);
 }
 
-async function _submitCreateWorkItem() {
-  var btn = event?.target; if (btn) { btn.disabled = true; btn.textContent = 'Creating...'; }
+async function _submitCreateWorkItem(e) {
+  var btn = (e || window.event)?.target; if (btn) { btn.disabled = true; btn.textContent = 'Creating...'; }
   const title = document.getElementById('wi-new-title')?.value?.trim();
   if (!title) { if (btn) { btn.disabled = false; btn.textContent = 'Create'; } alert('Title is required'); return; }
   const desc = document.getElementById('wi-new-desc')?.value || '';

package/dashboard/js/utils.js

@@ -38,7 +38,7 @@ function timeAgo(isoStr) {
 }
 
 function statusColor(s) {
-  return s === 'working' ? 'working' : s === 'done' ? 'done' : '';
+  return s === 'working' ? 'working' : s === 'done' ? 'done' : s === 'error' ? 'error' : '';
 }
 
 function llmCopyBtn() {

package/dashboard.js

@@ -959,15 +959,18 @@ const server = http.createServer(async (req, res) => {
       }
       if (!wiPath) return jsonReply(res, 404, { error: 'source not found' });
 
-      const items = JSON.parse(safeRead(wiPath) || '[]');
-      const idx = items.findIndex(i => i.id === id);
-      if (idx === -1) return jsonReply(res, 404, { error: 'item not found' });
-
-      const item = items[idx];
-
-      // Remove item from work-items file
-      items.splice(idx, 1);
-      safeWrite(wiPath, items);
+      let item = null;
+      let found = false;
+      mutateJsonFileLocked(wiPath, (items) => {
+        if (!Array.isArray(items)) return items;
+        const idx = items.findIndex(i => i.id === id);
+        if (idx === -1) return items;
+        item = items[idx];
+        items.splice(idx, 1);
+        found = true;
+        return items;
+      }, { defaultValue: [] });
+      if (!found) return jsonReply(res, 404, { error: 'item not found' });
 
       // Clean dispatch entries + kill running agent
       const dispatchRemoved = cleanDispatchEntries(d =>
@@ -1080,6 +1083,7 @@ const server = http.createServer(async (req, res) => {
       if (body.agents) item.agents = body.agents;
       if (body.references) item.references = body.references;
       if (body.acceptanceCriteria) item.acceptanceCriteria = body.acceptanceCriteria;
+      if (body.skipPr) item.skipPr = true;
       items.push(item);
       safeWrite(wiPath, items);
       return jsonReply(res, 200, { ok: true, id });
@@ -3297,6 +3301,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       config.claude = { ...shared.DEFAULT_CLAUDE };
       config.agents = { ...shared.DEFAULT_AGENTS };
       safeWrite(path.join(MINIONS_DIR, 'config.json'), config);
+      reloadConfig();
+      invalidateStatusCache();
       return jsonReply(res, 200, { ok: true });
     } catch (e) { return jsonReply(res, 500, { error: e.message }); }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.365",
+  "version": "0.1.367",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"