@yemi33/minions 0.1.360 → 0.1.362

package/CHANGELOG.md

@@ -1,12 +1,14 @@
 # Changelog
 
-## 0.1.360 (2026-04-06)
+## 0.1.362 (2026-04-06)
 
 ### Features
+- Null-safe safeJson wrappers + dashboard crash guards (#203)
 -  pipeline plan stage uses LLM to generate structured plan from meeting
 -  show 'Converting to PRD' status instead of 'In Progress' during plan conversion
 
 ### Fixes
+-  archived PRD picker uses file key instead of positional index
 -  check pull-requests.json for existing PRs before no-PR retry
 -  smart no-PR handling — distinguish MCP stall from intentional no-PR
 

package/dashboard/js/render-prd.js

@@ -148,8 +148,11 @@ function renderPrdProgress(prog) {
 
     // Linked work item info
     const wi = wiById[i.id];
+    const wiAgent = wi?.dispatched_to ? (agentData.find(a => a.id === wi.dispatched_to) || {}) : null;
     const wiLabel = wi ? '<span style="font-size:9px;color:var(--muted);background:var(--surface);padding:1px 5px;border-radius:3px;border:1px solid var(--border)" title="Work item: ' + escHtml(wi.id) + '">' +
-      escHtml(wi.id) + (wi.dispatched_to ? ' → ' + escHtml(wi.dispatched_to) : '') + '</span>' : '';
+      escHtml(wi.id) + '</span>' : '';
+    const agentLabel = wiAgent ? '<span style="font-size:9px;color:var(--muted)" title="' + escHtml(wiAgent.name || wi.dispatched_to) + '">' +
+      (wiAgent.emoji || '') + ' ' + escHtml(wiAgent.name || wi.dispatched_to) + '</span>' : '';
 
     // Requeue button for failed items
     const canRequeue = wi && (wi.status === 'failed' || i.status === 'failed');
@@ -170,6 +173,7 @@ function renderPrdProgress(prog) {
       '<span class="prd-item-id">' + escHtml(i.id) + '</span>' +
       '<span class="prd-item-name" title="' + escHtml(i.name) + '">' + escHtml(i.name) + '</span>' +
       wiLabel +
+      agentLabel +
       requeueBtn +
       (projBadges ? '<span>' + projBadges + '</span>' : '') +
       (prLinks ? '<span>' + prLinks + '</span>' : '') +
@@ -320,7 +324,9 @@ function renderPrdProgress(prog) {
         const borderColor = statusColor(i.status);
         const src = escHtml(i.source || '');
         const iid = escHtml(i.id || '');
-        const agent = wi[i.id]?.dispatched_to || '';
+        const agentId = wi[i.id]?.dispatched_to || '';
+        const agentInfo = agentId ? (agentData.find(a => a.id === agentId) || {}) : null;
+        const agentDisplay = agentInfo ? (agentInfo.emoji || '') + ' ' + escHtml(agentInfo.name || agentId) : (agentId ? escHtml(agentId) : '');
         const deps = (i.depends_on || []).join(', ');
         const wipAnim = i.status === 'dispatched' ? 'animation:prdWipPulse 2s infinite;' : '';
         html += '<div onclick="prdItemEdit(\'' + src + '\',\'' + iid + '\')" ' +
@@ -333,7 +339,7 @@ function renderPrdProgress(prog) {
           '<div style="color:var(--text);font-size:11px;line-height:1.3;margin-bottom:3px;overflow:hidden;text-overflow:ellipsis;display:-webkit-box;-webkit-line-clamp:2;-webkit-box-orient:vertical">' + escHtml(i.name) + '</div>' +
           '<div style="display:flex;gap:4px;flex-wrap:wrap;align-items:center">' +
             '<span class="prd-item-priority ' + (i.priority || '') + '" style="font-size:8px;padding:1px 4px">' + escHtml(i.priority || '') + '</span>' +
-            (agent ? '<span style="font-size:8px;color:var(--muted)">' + escHtml(agent) + '</span>' : '') +
+            (agentDisplay ? '<span style="font-size:8px;color:var(--muted)">' + agentDisplay + '</span>' : '') +
             (function() {
               const w = wi[i.id];
               if (!w) return '';
@@ -484,7 +490,7 @@ function openArchivedPrdModal() {
       const done = g.items.filter(it => it.status === 'done').length;
       const failed = g.items.filter(it => it.status === 'failed').length;
       const completed = g.completedAt ? new Date(g.completedAt).toLocaleDateString() : '';
-      return '<div class="plan-card" style="cursor:pointer;margin-bottom:8px" onclick="showArchivedPrdDetail(' + i + ')">' +
+      return '<div class="plan-card" style="cursor:pointer;margin-bottom:8px" onclick="showArchivedPrdDetail(\'' + escHtml(g.file) + '\')">' +
         '<div class="plan-card-title" style="font-size:13px">' + escHtml(g.summary || g.file) + '</div>' +
         '<div class="plan-card-meta">' +
           (g.project ? '<span>' + escHtml(g.project) + '</span>' : '') +
@@ -504,16 +510,17 @@ function openArchivedPrdModal() {
   document.getElementById('modal').classList.add('open');
 }
 
-function showArchivedPrdDetail(idx) {
+function showArchivedPrdDetail(idxOrFile) {
   const groups = window._archivedPrdGroups || [];
+  const idx = typeof idxOrFile === 'string' ? groups.findIndex(g => g.file === idxOrFile) : idxOrFile;
   const g = groups[idx];
   if (!g) return;
 
   // View mode toggle for archived
   const isGraph = window._archivedPrdViewMode !== 'list';
   const toggleHtml = '<div style="display:flex;gap:4px;margin-bottom:8px">' +
-    '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'graph\';showArchivedPrdDetail(' + idx + ')">Graph</button>' +
-    '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (!isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'list\';showArchivedPrdDetail(' + idx + ')">List</button>' +
+    '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'graph\';showArchivedPrdDetail(\'' + escHtml(g.file) + '\')">Graph</button>' +
+    '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (!isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'list\';showArchivedPrdDetail(\'' + escHtml(g.file) + '\')">List</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;color:var(--green);margin-left:auto" onclick="triggerVerify(\'' + escHtml(g.file) + '\')">Trigger Verify</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px" onclick="planUnarchive(\'' + escHtml(g.file) + '\',this)">Unarchive</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px" onclick="openArchivedPrdModal()">Back</button>' +

package/dashboard/js/settings.js

@@ -25,7 +25,7 @@ async function openSettings() {
     '<h3 style="font-size:13px;color:var(--blue);margin-bottom:8px">Engine</h3>' +
     '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
       settingsField('Tick Interval', 'set-tickInterval', e.tickInterval || 60000, 'ms', 'How often the engine runs discovery + dispatch') +
-      settingsField('Max Concurrent Agents', 'set-maxConcurrent', e.maxConcurrent || 3, '', 'Max agents working simultaneously') +
+      settingsField('Max Concurrent Agents', 'set-maxConcurrent', e.maxConcurrent || 5, '', 'Max agents working simultaneously') +
       settingsField('Consolidation Threshold', 'set-inboxConsolidateThreshold', e.inboxConsolidateThreshold || 5, 'notes', 'Inbox notes before auto-consolidation') +
       settingsField('Agent Timeout', 'set-agentTimeout', e.agentTimeout || 18000000, 'ms', 'Kill agent after this duration') +
       settingsField('Max Turns', 'set-maxTurns', e.maxTurns || 100, '', 'Claude CLI --max-turns per agent') +

package/dashboard.js

@@ -14,7 +14,7 @@ const shared = require('./engine/shared');
 const queries = require('./engine/queries');
 const os = require('os');
 
-const { safeRead, safeReadDir, safeWrite, safeJson, safeUnlink, mutateJsonFileLocked, getProjects: _getProjects, DONE_STATUSES } = shared;
+const { safeRead, safeReadDir, safeWrite, safeJson, safeJsonObj, safeJsonArr, safeUnlink, mutateJsonFileLocked, getProjects: _getProjects, DONE_STATUSES } = shared;
 const { getAgents, getAgentDetail, getPrdInfo, getWorkItems, getDispatchQueue,
   getSkills, getInbox, getNotesWithMeta, getPullRequests,
   getEngineLog, getMetrics, getKnowledgeBaseEntries, timeSince,
@@ -1206,7 +1206,7 @@ const server = http.createServer(async (req, res) => {
       const planPath = resolvePlanPath(body.source);
       if (!fs.existsSync(planPath)) return jsonReply(res, 404, { error: 'plan file not found' });
       // Pre-check: verify item exists before taking the lock
-      const preCheck = safeJson(planPath);
+      const preCheck = safeJsonObj(planPath);
       const preItem = (preCheck.missing_features || []).find(f => f.id === body.itemId);
       if (!preItem) return jsonReply(res, 404, { error: 'item not found in plan' });
 
@@ -1258,7 +1258,7 @@ const server = http.createServer(async (req, res) => {
       if (!body.source || !body.itemId) return jsonReply(res, 400, { error: 'source and itemId required' });
       const planPath = resolvePlanPath(body.source);
       if (!fs.existsSync(planPath)) return jsonReply(res, 404, { error: 'plan file not found' });
-      const plan = safeJson(planPath);
+      const plan = safeJsonObj(planPath);
       const idx = (plan.missing_features || []).findIndex(f => f.id === body.itemId);
       if (idx < 0) return jsonReply(res, 404, { error: 'item not found in plan' });
 
@@ -2048,7 +2048,7 @@ If nothing to do: { "duplicates": [], "reclassify": [], "remove": [] }`;
       if (!body.source) return jsonReply(res, 400, { error: 'source required' });
       const planPath = resolvePlanPath(body.source);
       if (!fs.existsSync(planPath)) return jsonReply(res, 404, { error: 'plan file not found' });
-      const plan = safeJson(planPath);
+      const plan = safeJsonObj(planPath);
       const planItems = plan.missing_features || [];
 
       let reset = 0, kept = 0, newCount = 0;
@@ -2127,7 +2127,7 @@ If nothing to do: { "duplicates": [], "reclassify": [], "remove": [] }`;
       }
       for (const wiPath of wiPaths) {
         try {
-          const items = safeJson(wiPath);
+          const items = safeJsonArr(wiPath);
           const filtered = items.filter(w => w.sourcePlan !== body.file);
           if (filtered.length < items.length) {
             cleaned += items.length - filtered.length;
@@ -2834,7 +2834,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       if (!fs.existsSync(target)) return jsonReply(res, 400, { error: 'Directory not found: ' + target });
 
       const configPath = path.join(MINIONS_DIR, 'config.json');
-      const config = safeJson(configPath);
+      const config = safeJsonObj(configPath);
       if (!config.projects) config.projects = [];
 
       // Check if already linked

package/engine/shared.js

@@ -73,6 +73,12 @@ function safeJson(p) {
   }
 }
 
+/** Null-safe safeJson wrapper — returns {} when file is missing/corrupt. */
+function safeJsonObj(p) { return safeJson(p) || {}; }
+
+/** Null-safe safeJson wrapper — returns [] when file is missing/corrupt. */
+function safeJsonArr(p) { return safeJson(p) || []; }
+
 /**
  * Monotonic counter for generating unique temp file names within this process.
  * Assumes single-thread execution (no worker_threads). If worker_threads are
@@ -422,7 +428,7 @@ const DEFAULT_AGENTS = {
 
 const DEFAULT_CLAUDE = {
   binary: 'claude',
-  outputFormat: 'json',
+  outputFormat: 'stream-json',
   allowedTools: 'Edit,Write,Read,Bash,Glob,Grep,Agent,WebFetch,WebSearch',
 };
 
@@ -623,7 +629,7 @@ module.exports = {
   log,
   safeRead,
   safeReadDir,
-  safeJson,
+  safeJson, safeJsonObj, safeJsonArr,
   safeWrite,
   safeUnlink,
   withFileLock,

package/engine.js

@@ -1416,7 +1416,12 @@ function discoverFromWorkItems(config, project) {
     // This protects against persisted state drift from old runtime versions.
     try {
       mutateDispatch((dp) => {
-        dp.completed = Array.isArray(dp.completed) ? dp.completed.filter(d => d.meta?.dispatchKey !== key) : [];
+        const prev = Array.isArray(dp.completed) ? dp.completed : [];
+        const next = [];
+        for (let i = 0; i < prev.length; i++) {
+          if (prev[i].meta?.dispatchKey !== key) next.push(prev[i]);
+        }
+        dp.completed = next;
         return dp;
       });
       dispatchCooldowns.delete(key);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.360",
+  "version": "0.1.362",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"