@yemi33/minions 0.1.325 → 0.1.327

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.327 (2026-04-03)
+
+### Fixes
+-  eliminate all legacy done-status writers, add CANCELLED to WI_STATUS
+-  stop writing legacy done aliases, add migration, keep read compat
+
 ## 0.1.325 (2026-04-03)
 
 ### Fixes

package/engine/cleanup.js

@@ -431,17 +431,17 @@ function runCleanup(config, verbose = false) {
     }
   } catch (e) { log('warn', 'KB watchdog check: ' + e.message); }
 
-  // 6. Migrate legacy work-item statuses to canonical values
+  // 6. Migrate legacy work-item statuses to canonical 'done'
   // in-pr, implemented, complete → done (one-time correction per item)
-  const LEGACY_DONE_STATUSES = shared.DONE_STATUSES;
+  const LEGACY_DONE_ALIASES = new Set(['in-pr', 'implemented', 'complete']);
   for (const project of projects) {
     try {
       const wiPath = projectWorkItemsPath(project);
       const items = safeJson(wiPath) || [];
       let migrated = 0;
       for (const item of items) {
-        if (LEGACY_DONE_STATUSES.has(item.status)) {
-          item.status = 'done';
+        if (LEGACY_DONE_ALIASES.has(item.status)) {
+          item.status = shared.WI_STATUS.DONE;
           delete item._pendingReason;
           migrated++;
         }
@@ -458,8 +458,8 @@ function runCleanup(config, verbose = false) {
     const centralItems = safeJson(centralPath) || [];
     let migrated = 0;
     for (const item of centralItems) {
-      if (LEGACY_DONE_STATUSES.has(item.status)) {
-        item.status = 'done';
+      if (LEGACY_DONE_ALIASES.has(item.status)) {
+        item.status = shared.WI_STATUS.DONE;
         delete item._pendingReason;
         migrated++;
       }
@@ -485,8 +485,8 @@ function runCleanup(config, verbose = false) {
       if (!prd?.missing_features) continue;
       let migrated = 0;
       for (const feat of prd.missing_features) {
-        if (LEGACY_DONE_STATUSES.has(feat.status)) {
-          feat.status = 'done';
+        if (LEGACY_DONE_ALIASES.has(feat.status)) {
+          feat.status = shared.WI_STATUS.DONE;
           migrated++;
         }
       }

package/engine/lifecycle.js

@@ -789,13 +789,13 @@ async function handlePostMerge(pr, project, config, newStatus) {
         const plan = safeJson(path.join(prdDir, pf));
         if (!plan?.missing_features) continue;
         const feature = plan.missing_features.find(f => f.id === mergedItemId);
-        if (feature && feature.status !== 'implemented') {
-          feature.status = 'implemented';
+        if (feature && feature.status !== WI_STATUS.DONE) {
+          feature.status = WI_STATUS.DONE;
           shared.safeWrite(path.join(prdDir, pf), plan);
           updated++;
         }
       }
-      if (updated > 0) log('info', `Post-merge: marked ${mergedItemId} as implemented for ${pr.id}`);
+      if (updated > 0) log('info', `Post-merge: marked ${mergedItemId} as done for ${pr.id}`);
     } catch (err) { log('warn', `Post-merge PRD update: ${err.message}`); }
 
     // Mark work item as done
@@ -806,9 +806,9 @@ async function handlePostMerge(pr, project, config, newStatus) {
         const items = safeJson(wiPath);
         if (!items) continue;
         const item = items.find(i => i.id === mergedItemId);
-        if (item && item.status !== 'done') {
+        if (item && item.status !== WI_STATUS.DONE) {
           log('info', `Post-merge: marking work item ${mergedItemId} as done (was ${item.status}) for ${pr.id}`);
-          item.status = 'done';
+          item.status = WI_STATUS.DONE;
           item.completedAt = ts();
           item._mergedVia = pr.id;
           shared.safeWrite(wiPath, items);
@@ -1070,7 +1070,7 @@ function handleDecompositionResult(stdout, meta, config) {
     if (!parent) continue;
 
     // Mark parent as decomposed
-    parent.status = 'decomposed';
+    parent.status = WI_STATUS.DECOMPOSED;
     parent._decomposed = true;
     delete parent._decomposing;
     parent._subItemIds = subItems.map(s => s.id);

package/engine/shared.js

@@ -393,9 +393,12 @@ const ENGINE_DEFAULTS = {
 
 const WI_STATUS = {
   PENDING: 'pending', DISPATCHED: 'dispatched', DONE: 'done', FAILED: 'failed',
-  PAUSED: 'paused', QUEUED: 'queued', NEEDS_REVIEW: 'needs-human-review', DECOMPOSED: 'decomposed',
+  PAUSED: 'paused', QUEUED: 'queued', NEEDS_REVIEW: 'needs-human-review',
+  DECOMPOSED: 'decomposed', CANCELLED: 'cancelled',
 };
-const DONE_STATUSES = new Set([WI_STATUS.DONE, 'in-pr', 'implemented', 'complete']); // includes legacy aliases
+// Read-side: accept legacy aliases for backward compat with old data/clients.
+// Write-side: only WI_STATUS.DONE is written (cleanup.js migrates old values on each run).
+const DONE_STATUSES = new Set([WI_STATUS.DONE, 'in-pr', 'implemented', 'complete']);
 const WORK_TYPE = {
   IMPLEMENT: 'implement', IMPLEMENT_LARGE: 'implement:large', FIX: 'fix', REVIEW: 'review',
   VERIFY: 'verify', PLAN: 'plan', PLAN_TO_PRD: 'plan-to-prd', DECOMPOSE: 'decompose',

package/engine.js

@@ -1182,7 +1182,7 @@ function materializePlansAsWorkItems(config) {
         for (const wi of existingItems) {
           if (wi.status !== WI_STATUS.PENDING || wi.sourcePlan !== file) continue;
           if (!currentPrdIds.has(wi.id)) {
-            wi.status = 'cancelled';
+            wi.status = WI_STATUS.CANCELLED;
             wi.cancelledAt = ts();
             wi.cancelReason = `PRD item removed from ${file}`;
             cancelled++;
@@ -1504,7 +1504,7 @@ function discoverFromWorkItems(config, project) {
         const cpCount = (item._checkpointCount || 0) + 1;
         if (cpCount > 3) {
           log('warn', `Work item ${item.id} exceeded 3 checkpoint-resumes — marking as needs-human-review`);
-          item.status = 'needs-human-review';
+          item.status = WI_STATUS.NEEDS_REVIEW;
           item._checkpointCount = cpCount;
           needsWrite = true;
           continue;
@@ -1918,7 +1918,7 @@ function discoverCentralWorkItems(config) {
           const cpCount = (item._checkpointCount || 0) + 1;
           if (cpCount > 3) {
             log('warn', `Work item ${item.id} exceeded 3 checkpoint-resumes — marking as needs-human-review`);
-            item.status = 'needs-human-review';
+            item.status = WI_STATUS.NEEDS_REVIEW;
             item._checkpointCount = cpCount;
             continue;
           }
@@ -2425,7 +2425,7 @@ async function tickInner() {
               const wi = items.find(i => i.id === item.meta.item.id);
               if (wi && wi.status === WI_STATUS.DISPATCHED) {
                 // completeDispatch didn't update the work item — re-queue manually
-                wi.status = 'pending';
+                wi.status = WI_STATUS.PENDING;
                 wi._retryCount = (wi._retryCount || 0) + 1;
                 wi._lastRetryReason = 'spawnAgent returned null';
                 wi._lastRetryAt = ts();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.325",
+  "version": "0.1.327",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"