@yemi33/minions 0.1.324 → 0.1.326

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.324 (2026-04-03)
+## 0.1.326 (2026-04-03)
 
 ### Fixes
+-  stop writing legacy done aliases, add migration, keep read compat
+
+## 0.1.325 (2026-04-03)
+
+### Fixes
+-  guard retry-counter write path against unreadable work items file
 -  7 bugs from engine audit — runtime crashes, race conditions, stale state
 -  scan skips NugetCache, OneDrive, .vs, packages + validates .git/HEAD
 

package/engine/cleanup.js

@@ -431,16 +431,16 @@ function runCleanup(config, verbose = false) {
     }
   } catch (e) { log('warn', 'KB watchdog check: ' + e.message); }
 
-  // 6. Migrate legacy work-item statuses to canonical values
+  // 6. Migrate legacy work-item statuses to canonical 'done'
   // in-pr, implemented, complete → done (one-time correction per item)
-  const LEGACY_DONE_STATUSES = shared.DONE_STATUSES;
+  const LEGACY_DONE_ALIASES = new Set(['in-pr', 'implemented', 'complete']);
   for (const project of projects) {
     try {
       const wiPath = projectWorkItemsPath(project);
       const items = safeJson(wiPath) || [];
       let migrated = 0;
       for (const item of items) {
-        if (LEGACY_DONE_STATUSES.has(item.status)) {
+        if (LEGACY_DONE_ALIASES.has(item.status)) {
           item.status = 'done';
           delete item._pendingReason;
           migrated++;
@@ -458,7 +458,7 @@ function runCleanup(config, verbose = false) {
     const centralItems = safeJson(centralPath) || [];
     let migrated = 0;
     for (const item of centralItems) {
-      if (LEGACY_DONE_STATUSES.has(item.status)) {
+      if (LEGACY_DONE_ALIASES.has(item.status)) {
         item.status = 'done';
         delete item._pendingReason;
         migrated++;
@@ -485,7 +485,7 @@ function runCleanup(config, verbose = false) {
       if (!prd?.missing_features) continue;
       let migrated = 0;
       for (const feat of prd.missing_features) {
-        if (LEGACY_DONE_STATUSES.has(feat.status)) {
+        if (LEGACY_DONE_ALIASES.has(feat.status)) {
           feat.status = 'done';
           migrated++;
         }

package/engine/dispatch.js

@@ -134,7 +134,8 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
             ? path.join(MINIONS_DIR, 'work-items.json')
             : item.meta.project?.name ? projectWorkItemsPath({ name: item.meta.project.name, localPath: item.meta.project.localPath }) : null;
           if (wiPath) {
-            const items = safeJson(wiPath) || [];
+            const items = safeJson(wiPath);
+            if (!items || !Array.isArray(items)) throw new Error('work items unreadable');
             const wi = items.find(i => i.id === item.meta.item.id);
             if (wi && wi.status !== WI_STATUS.PAUSED) {
               wi._retryCount = retries + 1;

package/engine/lifecycle.js

@@ -789,13 +789,13 @@ async function handlePostMerge(pr, project, config, newStatus) {
         const plan = safeJson(path.join(prdDir, pf));
         if (!plan?.missing_features) continue;
         const feature = plan.missing_features.find(f => f.id === mergedItemId);
-        if (feature && feature.status !== 'implemented') {
-          feature.status = 'implemented';
+        if (feature && feature.status !== WI_STATUS.DONE) {
+          feature.status = WI_STATUS.DONE;
           shared.safeWrite(path.join(prdDir, pf), plan);
           updated++;
         }
       }
-      if (updated > 0) log('info', `Post-merge: marked ${mergedItemId} as implemented for ${pr.id}`);
+      if (updated > 0) log('info', `Post-merge: marked ${mergedItemId} as done for ${pr.id}`);
     } catch (err) { log('warn', `Post-merge PRD update: ${err.message}`); }
 
     // Mark work item as done

package/engine/shared.js

@@ -395,7 +395,9 @@ const WI_STATUS = {
   PENDING: 'pending', DISPATCHED: 'dispatched', DONE: 'done', FAILED: 'failed',
   PAUSED: 'paused', QUEUED: 'queued', NEEDS_REVIEW: 'needs-human-review', DECOMPOSED: 'decomposed',
 };
-const DONE_STATUSES = new Set([WI_STATUS.DONE, 'in-pr', 'implemented', 'complete']); // includes legacy aliases
+// Read-side: accept legacy aliases for backward compat with old data/clients.
+// Write-side: only WI_STATUS.DONE is written (cleanup.js migrates old values on each run).
+const DONE_STATUSES = new Set([WI_STATUS.DONE, 'in-pr', 'implemented', 'complete']);
 const WORK_TYPE = {
   IMPLEMENT: 'implement', IMPLEMENT_LARGE: 'implement:large', FIX: 'fix', REVIEW: 'review',
   VERIFY: 'verify', PLAN: 'plan', PLAN_TO_PRD: 'plan-to-prd', DECOMPOSE: 'decompose',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.324",
+  "version": "0.1.326",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"