@yemi33/minions 0.1.321 → 0.1.323

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.323 (2026-04-03)
+
+### Fixes
+-  scan skips NugetCache, OneDrive, .vs, packages + validates .git/HEAD
+
+### Other
+- refactor: final magic string replacements in engine, lifecycle, cleanup
+
 ## 0.1.321 (2026-04-03)
 
 ### Fixes

package/dashboard.js

@@ -2897,7 +2897,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
       // Find git repos recursively (same logic as minions.js findGitRepos)
       const skipDirs = new Set(['node_modules', '.git', '.hg', 'AppData', '$Recycle.Bin', 'Windows',
-        'Program Files', 'Program Files (x86)', '.cache', '.npm', '.yarn', '.nuget', 'worktrees', '.minions', '.squad']);
+        'Program Files', 'Program Files (x86)', '.cache', '.npm', '.yarn', '.nuget', 'NugetCache',
+        'worktrees', '.minions', '.squad', '.vs', '.vscode', 'obj', 'bin', 'packages',
+        'OneDrive', 'OneDrive - Microsoft', '.copilot', 'marketplace-cache']);
       const repos = [];
       function walk(dir, depth) {
         if (depth > maxDepth) return;
@@ -2905,7 +2907,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         try { entries = fs.readdirSync(dir, { withFileTypes: true }); } catch { return; }
         for (const e of entries) {
           if (!e.isDirectory()) continue;
-          if (e.name === '.git') { repos.push(dir); return; }
+          if (e.name === '.git') {
+            // Validate it's a real repo — must have HEAD file
+            try { if (fs.existsSync(path.join(dir, '.git', 'HEAD'))) repos.push(dir); } catch {}
+            return;
+          }
           if (e.name.startsWith('.') || skipDirs.has(e.name)) continue;
           walk(path.join(dir, e.name), depth + 1);
         }

package/engine/cleanup.js

@@ -111,7 +111,7 @@ function runCleanup(config, verbose = false) {
     const prs = safeJson(projectPrPath(project)) || [];
     const mergedBranches = new Set();
     for (const pr of prs) {
-      if (pr.status === 'merged' || pr.status === 'abandoned' || pr.status === 'completed') {
+      if (pr.status === shared.PR_STATUS.MERGED || pr.status === shared.PR_STATUS.ABANDONED || pr.status === shared.PLAN_STATUS.COMPLETED) {
         if (pr.branch) mergedBranches.add(pr.branch);
       }
     }
@@ -223,7 +223,7 @@ function runCleanup(config, verbose = false) {
       const freshPrs = safeJson(projectPrPath(project)) || [];
       const freshMergedBranches = new Set();
       for (const pr of freshPrs) {
-        if (pr.status === 'merged' || pr.status === 'abandoned' || pr.status === 'completed') {
+        if (pr.status === shared.PR_STATUS.MERGED || pr.status === shared.PR_STATUS.ABANDONED || pr.status === shared.PLAN_STATUS.COMPLETED) {
           if (pr.branch) freshMergedBranches.add(pr.branch);
         }
       }

package/engine/lifecycle.js

@@ -197,7 +197,7 @@ function checkPlanCompletion(meta, config) {
       const prs = (safeJson(shared.projectPrPath(p)) || [])
         .filter(pr => {
           const linkedId = prLinks[pr.id];
-          return pr.status === 'active' && linkedId && doneItems.find(w => w.id === linkedId);
+          return pr.status === PR_STATUS.ACTIVE && linkedId && doneItems.find(w => w.id === linkedId);
         });
       if (prs.length > 0) {
         projectPrs[p.name] = { project: p, prs, mainBranch: p.mainBranch || 'main' };
@@ -693,7 +693,7 @@ function updatePrAfterReview(agentId, pr, project) {
   // Record the reviewer — actual verdict comes from ADO/GitHub votes via pollPrStatus.
   // Set to 'waiting' so pollPrStatus updates it with the real vote on next cycle.
   const dispatch = getDispatch();
-  const completedEntry = (dispatch.completed || []).find(d => d.agent === agentId && d.type === 'review');
+  const completedEntry = (dispatch.completed || []).find(d => d.agent === agentId && d.type === WORK_TYPE.REVIEW);
 
   // Set reviewStatus to 'waiting' (single source of truth — synced from ADO/GitHub votes on next poll)
   target.reviewStatus = 'waiting';
@@ -988,7 +988,7 @@ function updateMetrics(agentId, dispatchItem, result, taskUsage, prsCreatedCount
   if (result === DISPATCH_RESULT.SUCCESS) {
     m.tasksCompleted++;
     if (prsCreatedCount > 0) m.prsCreated = (m.prsCreated || 0) + prsCreatedCount;
-    if (dispatchItem.type === 'review') m.reviewsDone++;
+    if (dispatchItem.type === WORK_TYPE.REVIEW) m.reviewsDone++;
   } else if (result === 'retry') {
     // Auto-retry: count cost but not as a final outcome
     m.tasksRetried = (m.tasksRetried || 0) + 1;
@@ -1243,7 +1243,7 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
   }
 
   // Detect implement tasks that completed without creating a PR
-  if (isSuccess && (type === 'implement' || type === 'implement:large' || type === 'fix') && prsCreatedCount === 0 && meta?.item?.id) {
+  if (isSuccess && (type === WORK_TYPE.IMPLEMENT || type === WORK_TYPE.IMPLEMENT_LARGE || type === WORK_TYPE.FIX) && prsCreatedCount === 0 && meta?.item?.id) {
     // Check if a PR already exists linked to this work item (from a previous attempt)
     const projects = shared.getProjects(config);
     const existingPrFound = Object.values(getPrLinks()).includes(meta.item.id);
@@ -1280,8 +1280,8 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
     }
   }
 
-  if (type === 'review') updatePrAfterReview(agentId, meta?.pr, meta?.project);
-  if (type === 'fix') updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
+  if (type === WORK_TYPE.REVIEW) updatePrAfterReview(agentId, meta?.pr, meta?.project);
+  if (type === WORK_TYPE.FIX) updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
   checkForLearnings(agentId, config.agents[agentId], dispatchItem.task);
   if (isSuccess) extractSkillsFromOutput(stdout, agentId, dispatchItem, config);
   updateAgentHistory(agentId, dispatchItem, result);
@@ -1311,14 +1311,14 @@ function syncPrdFromPrs(config) {
     for (const project of allProjects) {
       const wiPath = projectWorkItemsPath(project);
       const items = safeJson(wiPath) || [];
-      const hasPending = items.some(wi => wi.status === 'pending' && !wi._pr);
+      const hasPending = items.some(wi => wi.status === WI_STATUS.PENDING && !wi._pr);
       if (!hasPending) continue;
       const reconciled = reconcileItemsWithPrs(items, allPrs);
       if (reconciled > 0) {
         safeWrite(wiPath, items);
         // Sync done status to PRD JSON for each newly reconciled item
         for (const wi of items) {
-          if (wi.status === 'done') syncPrdItemStatus(wi.id, 'done', wi.sourcePlan);
+          if (wi.status === WI_STATUS.DONE) syncPrdItemStatus(wi.id, 'done', wi.sourcePlan);
         }
         totalReconciled += reconciled;
       }

package/engine.js

@@ -1319,7 +1319,7 @@ function discoverFromPrs(config, project) {
     }
 
     // PRs with build failures — route to author (has session context from implementing)
-    if (pr.status === 'active' && pr.buildStatus === 'failing') {
+    if (pr.status === PR_STATUS.ACTIVE && pr.buildStatus === 'failing') {
       const key = `build-fix-${project?.name || 'default'}-${pr.id}`;
       if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) continue;
       const agentId = resolveAgent('fix', config, pr.agent);
@@ -1638,7 +1638,7 @@ function materializeSpecsAsWorkItems(config, project) {
 
   const prs = getPrs(project);
   const mergedPrs = prs.filter(pr =>
-    (pr.status === 'merged' || pr.status === 'completed') &&
+    (pr.status === PR_STATUS.MERGED || pr.status === PLAN_STATUS.COMPLETED) &&
     !tracker.processedPrs[pr.id]
   );
 

package/minions.js

@@ -257,7 +257,9 @@ function findGitRepos(rootDir, maxDepth = 3) {
       // Skip common non-project dirs
       const base = path.basename(dir);
       if (['node_modules', '.git', '.hg', 'AppData', '$Recycle.Bin', 'Windows', 'Program Files',
-           'Program Files (x86)', '.cache', '.npm', '.yarn', '.nuget', 'worktrees', '.minions'].includes(base)) return;
+           'Program Files (x86)', '.cache', '.npm', '.yarn', '.nuget', 'NugetCache',
+           'worktrees', '.minions', '.squad', '.vs', '.vscode', 'obj', 'bin', 'packages',
+           'OneDrive', 'OneDrive - Microsoft', '.copilot', 'marketplace-cache'].includes(base)) return;
       // Skip minions home directory itself
       if (path.resolve(dir) === path.resolve(MINIONS_HOME)) return;
 
@@ -271,6 +273,8 @@ function findGitRepos(rootDir, maxDepth = 3) {
             if (content.trimStart().startsWith('gitdir:')) return; // worktree, skip
           } catch {}
         }
+        // Validate it's a real repo — must have HEAD file
+        if (stat.isDirectory() && !fs.existsSync(path.join(gitDir, 'HEAD'))) return;
         repos.push(dir);
         return; // Don't recurse into git repos (they may have nested submodules)
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.321",
+  "version": "0.1.323",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"