@yemi33/minions 0.1.320 → 0.1.321

package/CHANGELOG.md

@@ -1,10 +1,13 @@
 # Changelog
 
-## 0.1.320 (2026-04-03)
+## 0.1.321 (2026-04-03)
 
 ### Fixes
 -  project scan finds git repos — .git was in skipDirs
 
+### Other
+- refactor: replace magic strings in remaining engine files with constants
+
 ## 0.1.319 (2026-04-03)
 
 ### Other

package/engine/ado.js

@@ -5,7 +5,7 @@
 
 const path = require('path');
 const shared = require('./shared');
-const { exec, getAdoOrgBase, addPrLink, log, dateStamp } = shared;
+const { exec, getAdoOrgBase, addPrLink, log, dateStamp, PR_STATUS } = shared;
 const { getPrs } = require('./queries');
 
 // Lazy require to avoid circular dependency — only needed for engine().handlePostMerge
@@ -80,7 +80,7 @@ async function forEachActivePr(config, token, callback) {
     if (!project.adoOrg || !project.adoProject || !project.repositoryId) continue;
 
     const prs = getPrs(project);
-    const activePrs = prs.filter(pr => pr.status === 'active');
+    const activePrs = prs.filter(pr => pr.status === PR_STATUS.ACTIVE);
     if (activePrs.length === 0) continue;
 
     let projectUpdated = 0;
@@ -123,18 +123,18 @@ async function pollPrStatus(config) {
     const prData = await adoFetch(`${repoBase}?api-version=7.1`, token);
 
     let newStatus = pr.status;
-    if (prData.status === 'completed') newStatus = 'merged';
-    else if (prData.status === 'abandoned') newStatus = 'abandoned';
-    else if (prData.status === 'active') newStatus = 'active';
+    if (prData.status === 'completed') newStatus = PR_STATUS.MERGED;
+    else if (prData.status === 'abandoned') newStatus = PR_STATUS.ABANDONED;
+    else if (prData.status === 'active') newStatus = PR_STATUS.ACTIVE;
 
     if (pr.status !== newStatus) {
       log('info', `PR ${pr.id} status: ${pr.status} → ${newStatus}`);
       pr.status = newStatus;
       updated = true;
 
-      if (newStatus === 'merged' || newStatus === 'abandoned') {
+      if (newStatus === PR_STATUS.MERGED || newStatus === PR_STATUS.ABANDONED) {
         if (pr.reviewStatus === 'waiting') {
-          pr.reviewStatus = newStatus === 'merged' ? 'approved' : 'pending';
+          pr.reviewStatus = newStatus === PR_STATUS.MERGED ? 'approved' : 'pending';
           log('info', `PR ${pr.id} reviewStatus: waiting → ${pr.reviewStatus} (${newStatus})`);
         }
         await engine().handlePostMerge(pr, project, config, newStatus);
@@ -157,7 +157,7 @@ async function pollPrStatus(config) {
       .map(r => r.displayName)
       .filter(Boolean);
     // Fallback: if PR was merged and no decisive votes, use completedBy
-    if (!reviewedBy.length && newStatus === 'merged' && prData.closedBy?.displayName) {
+    if (!reviewedBy.length && newStatus === PR_STATUS.MERGED && prData.closedBy?.displayName) {
       reviewedBy.push(prData.closedBy.displayName);
     }
     if (JSON.stringify(pr.reviewedBy || []) !== JSON.stringify(reviewedBy)) {
@@ -184,7 +184,7 @@ async function pollPrStatus(config) {
       }
     }
 
-    if (newStatus !== 'active') return updated;
+    if (newStatus !== PR_STATUS.ACTIVE) return updated;
 
     const statusData = await adoFetch(`${repoBase}/statuses?api-version=7.1`, token);
 

package/engine/cli.js

@@ -6,7 +6,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeRead, safeJson, safeWrite } = shared;
+const { safeRead, safeJson, safeWrite, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT } = shared;
 const queries = require('./queries');
 const { getConfig, getControl, getDispatch, getAgentStatus,
   MINIONS_DIR, ENGINE_DIR, AGENTS_DIR, PLANS_DIR, PRD_DIR, CONTROL_PATH, DISPATCH_PATH } = queries;
@@ -159,8 +159,8 @@ const commands = {
               const wiPath = path.join(MINIONS_DIR, "projects", item.meta.project.name, "work-items.json");
               const wiItems = safeJson(wiPath) || [];
               const wi = wiItems.find(w => w.id === item.meta.item.id);
-              if (wi && wi.status !== 'dispatched') {
-                wi.status = 'dispatched';
+              if (wi && wi.status !== WI_STATUS.DISPATCHED) {
+                wi.status = WI_STATUS.DISPATCHED;
                 wi.dispatched_to = wi.dispatched_to || agentId;
                 wi.dispatched_at = wi.dispatched_at || new Date().toISOString();
                 safeWrite(wiPath, wiItems);
@@ -210,7 +210,7 @@ const commands = {
           if (!hasResult && !hasError) continue;
 
           const isSuccess = hasResult && !hasError;
-          const result = isSuccess ? 'success' : 'error';
+          const result = isSuccess ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR;
 
           e.log('info', `Orphan recovery: ${agentId} (${item.id}) completed while engine was down — result: ${result}`);
 
@@ -222,7 +222,7 @@ const commands = {
 
           // Update work item status
           if (item.meta?.item?.id) {
-            const status = isSuccess ? 'done' : 'failed';
+            const status = isSuccess ? WI_STATUS.DONE : WI_STATUS.FAILED;
             try {
               lifecycle.updateWorkItemStatus(item.meta, status, isSuccess ? '' : 'Completed while engine was down');
             } catch {
@@ -286,8 +286,8 @@ const commands = {
           const items = safeJson(wiPath) || [];
           let changed = false;
           for (const item of items) {
-            if (item.status === 'dispatched' && !activeIds.has(item.id)) {
-              item.status = 'pending';
+            if (item.status === WI_STATUS.DISPATCHED && !activeIds.has(item.id)) {
+              item.status = WI_STATUS.PENDING;
               delete item.dispatched_at;
               delete item.dispatched_to;
               changed = true;
@@ -656,7 +656,7 @@ const commands = {
       id: `W${String(items.length + 1).padStart(3, '0')}`,
       title: title,
       type: opts.type || 'implement',
-      status: 'queued',
+      status: WI_STATUS.QUEUED,
       priority: opts.priority || 'medium',
       complexity: opts.complexity || 'medium',
       description: opts.description || title,
@@ -750,7 +750,7 @@ const commands = {
     }
 
     const id = e.addToDispatch({
-      type: 'plan-to-prd',
+      type: WORK_TYPE.PLAN_TO_PRD,
       agent: agentId,
       agentName: config.agents[agentId]?.name,
       agentRole: config.agents[agentId]?.role,
@@ -815,13 +815,13 @@ const commands = {
         }
         if (exists && name === 'pullRequests') {
           const prs = safeJson(filePath) || [];
-          const pending = prs.filter(p => p.status === 'active' && (p.reviewStatus === 'pending' || p.reviewStatus === 'waiting'));
-          const needsFix = prs.filter(p => p.status === 'active' && p.reviewStatus === 'changes-requested');
+          const pending = prs.filter(p => p.status === PR_STATUS.ACTIVE && (p.reviewStatus === 'pending' || p.reviewStatus === 'waiting'));
+          const needsFix = prs.filter(p => p.status === PR_STATUS.ACTIVE && p.reviewStatus === 'changes-requested');
           console.log(`    PRs: ${pending.length} pending review, ${needsFix.length} need fixes`);
         }
         if (exists && name === 'workItems') {
           const items = safeJson(filePath) || [];
-          const queued = items.filter(i => i.status === 'queued');
+          const queued = items.filter(i => i.status === WI_STATUS.QUEUED);
           console.log(`    Items: ${queued.length} queued`);
         }
         if (name === 'specs' || name === 'mergedDesignDocs') {
@@ -853,7 +853,7 @@ const commands = {
     const killed = dispatch.active || [];
     for (const item of killed) {
       if (item.meta) {
-        e.updateWorkItemStatus(item.meta, 'pending', '');
+        e.updateWorkItemStatus(item.meta, WI_STATUS.PENDING, '');
         const itemId = item.meta.item?.id;
         if (itemId) {
           const wiPath = (item.meta.source === 'central-work-item' || item.meta.source === 'central-work-item-fanout')
@@ -865,7 +865,7 @@ const commands = {
             const items = safeJson(wiPath) || [];
             const target = items.find(i => i.id === itemId);
             if (target) {
-              target.status = 'pending';
+              target.status = WI_STATUS.PENDING;
               delete target.dispatched_at;
               delete target.dispatched_to;
               delete target.failReason;

package/engine/github.js

@@ -5,7 +5,7 @@
  */
 
 const shared = require('./shared');
-const { exec, getProjects, projectPrPath, projectWorkItemsPath, safeJson, safeWrite, MINIONS_DIR, addPrLink, getPrLinks, log, dateStamp } = shared;
+const { exec, getProjects, projectPrPath, projectWorkItemsPath, safeJson, safeWrite, MINIONS_DIR, addPrLink, getPrLinks, log, dateStamp, PR_STATUS } = shared;
 const { getPrs } = require('./queries');
 const path = require('path');
 
@@ -53,7 +53,7 @@ async function forEachActiveGhPr(config, callback) {
     if (!slug) continue;
 
     const prs = getPrs(project);
-    const activePrs = prs.filter(pr => pr.status === 'active');
+    const activePrs = prs.filter(pr => pr.status === PR_STATUS.ACTIVE);
     if (activePrs.length === 0) continue;
 
     let projectUpdated = 0;
@@ -79,7 +79,7 @@ async function forEachActiveGhPr(config, callback) {
   // Also poll manually-linked PRs from central pull-requests.json (extract slug from URL)
   const centralPath = path.join(MINIONS_DIR, 'pull-requests.json');
   const centralPrs = safeJson(centralPath) || [];
-  const activeCentral = centralPrs.filter(pr => pr.status === 'active' && pr.url);
+  const activeCentral = centralPrs.filter(pr => pr.status === PR_STATUS.ACTIVE && pr.url);
   let centralUpdated = 0;
   for (const pr of activeCentral) {
     const ghMatch = pr.url.match(/github\.com\/([^/]+\/[^/]+)\/pull\/(\d+)/);
@@ -123,19 +123,19 @@ async function pollPrStatus(config) {
 
     // Map GitHub PR state to minions status
     let newStatus = pr.status;
-    if (prData.merged) newStatus = 'merged';
-    else if (prData.state === 'closed') newStatus = 'abandoned';
-    else if (prData.state === 'open') newStatus = 'active';
+    if (prData.merged) newStatus = PR_STATUS.MERGED;
+    else if (prData.state === 'closed') newStatus = PR_STATUS.ABANDONED;
+    else if (prData.state === 'open') newStatus = PR_STATUS.ACTIVE;
 
     if (pr.status !== newStatus) {
       log('info', `PR ${pr.id} status: ${pr.status} → ${newStatus}`);
       pr.status = newStatus;
       updated = true;
 
-      if (newStatus === 'merged' || newStatus === 'abandoned') {
+      if (newStatus === PR_STATUS.MERGED || newStatus === PR_STATUS.ABANDONED) {
         // Resolve stale 'waiting' review status — won't be polled again after this
         if (pr.reviewStatus === 'waiting') {
-          pr.reviewStatus = newStatus === 'merged' ? 'approved' : 'pending';
+          pr.reviewStatus = newStatus === PR_STATUS.MERGED ? 'approved' : 'pending';
           log('info', `PR ${pr.id} reviewStatus: waiting → ${pr.reviewStatus} (${newStatus})`);
         }
         await engine().handlePostMerge(pr, project, config, newStatus);

package/engine/meeting.js

@@ -6,7 +6,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, safeRead, uid, log, ENGINE_DEFAULTS } = shared;
+const { safeJson, safeWrite, safeRead, uid, log, ENGINE_DEFAULTS, WORK_TYPE, DISPATCH_RESULT } = shared;
 const queries = require('./queries');
 const { getDispatch, getConfig } = queries;
 const { renderPlaybook } = require('./playbook');
@@ -118,7 +118,7 @@ function discoverMeetingWork(config) {
       if (!prompt) continue;
 
       work.push({
-        type: 'meeting',
+        type: WORK_TYPE.MEETING,
         agent: concluder,
         agentName: agents[concluder]?.name || concluder,
         agentRole: agents[concluder]?.role || 'Agent',
@@ -165,7 +165,7 @@ function discoverMeetingWork(config) {
       if (!prompt) continue;
 
       work.push({
-        type: 'meeting',
+        type: WORK_TYPE.MEETING,
         agent: agentId,
         agentName: agents[agentId]?.name || agentId,
         agentRole: agents[agentId]?.role || 'Agent',
@@ -278,7 +278,7 @@ function _killMeetingDispatches(meetingId) {
       dp.active = (dp.active || []).filter(d => d.meta?.meetingId !== meetingId);
       dp.completed = dp.completed || [];
       for (const d of toKill) {
-        dp.completed.push({ ...d, result: 'error', reason: 'Meeting ended/advanced by human', completed_at: new Date().toISOString() });
+        dp.completed.push({ ...d, result: DISPATCH_RESULT.ERROR, reason: 'Meeting ended/advanced by human', completed_at: new Date().toISOString() });
       }
       if (dp.completed.length > 100) dp.completed = dp.completed.slice(-100);
       return dp;

package/engine/pipeline.js

@@ -7,7 +7,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked } = shared;
+const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS } = shared;
 const { parseCronExpr, shouldRunNow } = require('./scheduler');
 
 const PIPELINES_DIR = path.join(__dirname, '..', 'pipelines');
@@ -172,7 +172,7 @@ function executeTaskStage(stage, stageState, run, config) {
       type: item.type || stage.taskType || 'explore',
       priority: item.priority || stage.priority || 'medium',
       agent: item.agent || stage.agent || '',
-      status: 'pending',
+      status: WI_STATUS.PENDING,
       created: ts(),
       createdBy: 'pipeline:' + run.pipelineId,
       branch: `pipeline/${run.pipelineId}/${stage.id}`,
@@ -243,9 +243,9 @@ function executePlanStage(stage, stageState, run, config) {
     workItems.push({
       id: wiId,
       title: `Convert plan to PRD: ${path.basename(filePath)}`,
-      type: 'plan-to-prd',
+      type: WORK_TYPE.PLAN_TO_PRD,
       priority: 'high',
-      status: 'pending',
+      status: WI_STATUS.PENDING,
       planFile: path.basename(filePath),
       created: ts(),
       createdBy: 'pipeline:' + run.pipelineId,
@@ -347,7 +347,7 @@ function isStageComplete(stage, stageState, run, config) {
       if (ids.length === 0) return false;
       return ids.every(id => {
         const wi = workItems.find(w => w.id === id);
-        return !wi || wi.status === 'done' || wi.status === 'failed'; // missing = treat as done
+        return !wi || wi.status === WI_STATUS.DONE || wi.status === WI_STATUS.FAILED; // missing = treat as done
       });
     }
     case 'meeting': {
@@ -372,7 +372,7 @@ function isStageComplete(stage, stageState, run, config) {
       const prdWiIds = artifacts.workItems || [];
       const prdDone = prdWiIds.every(id => {
         const wi = all.find(w => w.id === id);
-        return !wi || wi.status === 'done' || wi.status === 'failed'; // missing = treat as done
+        return !wi || wi.status === WI_STATUS.DONE || wi.status === WI_STATUS.FAILED; // missing = treat as done
       });
       if (!prdDone) return false;
 
@@ -390,7 +390,7 @@ function isStageComplete(stage, stageState, run, config) {
         }
         // Find materialized work items for discovered PRDs
         for (const prdFile of (artifacts.prds || [])) {
-          const prdItems = all.filter(w => w.sourcePlan === prdFile && w.type !== 'plan-to-prd');
+          const prdItems = all.filter(w => w.sourcePlan === prdFile && w.type !== WORK_TYPE.PLAN_TO_PRD);
           for (const wi of prdItems) {
             if (!(artifacts.workItems || []).includes(wi.id)) {
               artifacts.workItems = artifacts.workItems || [];
@@ -405,8 +405,8 @@ function isStageComplete(stage, stageState, run, config) {
         for (const prdFile of artifacts.prds) {
           const prdPath = path.join(prdDir, prdFile);
           const prd = safeJson(prdPath);
-          if (prd && prd.status === 'awaiting-approval') {
-            prd.status = 'approved';
+          if (prd && prd.status === PLAN_STATUS.AWAITING_APPROVAL) {
+            prd.status = PLAN_STATUS.APPROVED;
             prd.approvedAt = ts();
             prd.approvedBy = 'pipeline:' + run.pipelineId;
             safeWrite(prdPath, prd);
@@ -420,7 +420,7 @@ function isStageComplete(stage, stageState, run, config) {
       if (implementIds.length === 0 && artifacts.prds?.length > 0) return false; // items not materialized yet
       return implementIds.every(id => {
         const wi = all.find(w => w.id === id);
-        return !wi || wi.status === 'done' || wi.status === 'failed'; // missing = treat as done
+        return !wi || wi.status === WI_STATUS.DONE || wi.status === WI_STATUS.FAILED; // missing = treat as done
       });
     }
     case 'merge-prs': {
@@ -431,7 +431,7 @@ function isStageComplete(stage, stageState, run, config) {
         const prs = safeJson(shared.projectPrPath(project)) || [];
         for (const prId of prIds) {
           const pr = prs.find(p => p.id === prId);
-          if (pr && pr.status !== 'merged' && pr.status !== 'abandoned') return false;
+          if (pr && pr.status !== PR_STATUS.MERGED && pr.status !== PR_STATUS.ABANDONED) return false;
         }
       }
       return true;

package/engine/playbook.js

@@ -9,7 +9,7 @@ const path = require('path');
 const shared = require('./shared');
 const queries = require('./queries');
 
-const { safeJson, safeRead, getProjects, log, dateStamp } = shared;
+const { safeJson, safeRead, getProjects, log, dateStamp, WI_STATUS, WORK_TYPE, PR_STATUS, DISPATCH_RESULT } = shared;
 const { getConfig, getDispatch, getNotes, getAgentCharter, getPrs, AGENTS_DIR } = queries;
 
 const MINIONS_DIR = path.resolve(__dirname, '..');
@@ -135,7 +135,7 @@ function resolveTaskContext(item, config) {
         // Check work-items to find which plan file this agent created
         const workItems = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
         const agentPlanItems = workItems.filter(w =>
-          w.type === 'plan' && w.dispatched_to === agent.id && w.status === 'done' && w._planFileName
+          w.type === WORK_TYPE.PLAN && w.dispatched_to === agent.id && w.status === WI_STATUS.DONE && w._planFileName
         ).sort((a, b) => (b.completedAt || '').localeCompare(a.completedAt || ''));
 
         if (agentPlanItems.length > 0) {
@@ -390,7 +390,7 @@ function buildAgentContext(agentId, config, project) {
 
   // Recent completions (last 5, not 10)
   const recentCompleted = (dispatch.completed || []).slice(-5).reverse().map(d =>
-    `- **${d.agent}** ${d.result === 'success' ? 'completed' : 'failed'}: ${(d.task || '').slice(0, 80)}${d.resultSummary ? ' — ' + d.resultSummary.slice(0, 100) : ''}`
+    `- **${d.agent}** ${d.result === DISPATCH_RESULT.SUCCESS ? 'completed' : 'failed'}: ${(d.task || '').slice(0, 80)}${d.resultSummary ? ' — ' + d.resultSummary.slice(0, 100) : ''}`
   );
   if (recentCompleted.length > 0) {
     context += `## Recently Completed\n\n${recentCompleted.join('\n')}\n\n`;
@@ -400,13 +400,13 @@ function buildAgentContext(agentId, config, project) {
   const projects = getProjects(config);
   const allPrs = [];
   for (const p of projects) {
-    const prs = getPrs(p).filter(pr => pr.status === 'active' || pr.status === 'linked');
+    const prs = getPrs(p).filter(pr => pr.status === PR_STATUS.ACTIVE || pr.status === 'linked');
     for (const pr of prs) allPrs.push({ ...pr, _project: p.name });
   }
   // Also check central pull-requests.json
   try {
     const centralPrs = safeJson(path.join(MINIONS_DIR, 'pull-requests.json')) || [];
-    for (const pr of centralPrs.filter(pr => pr.status === 'active' || pr.status === 'linked')) {
+    for (const pr of centralPrs.filter(pr => pr.status === PR_STATUS.ACTIVE || pr.status === 'linked')) {
       if (!allPrs.some(p => p.id === pr.id)) allPrs.push({ ...pr, _project: 'central' });
     }
   } catch (e) { log('warn', 'read central pull-requests: ' + e.message); }
@@ -450,10 +450,10 @@ function buildBaseVars(agentId, config, project) {
 }
 
 function selectPlaybook(workType, item) {
-  if (item?.branchStrategy === 'shared-branch' && (workType === 'implement' || workType === 'implement:large')) {
+  if (item?.branchStrategy === 'shared-branch' && (workType === WORK_TYPE.IMPLEMENT || workType === WORK_TYPE.IMPLEMENT_LARGE)) {
     return 'implement-shared';
   }
-  if (workType === 'review' && !item?._pr && !item?.pr_id) {
+  if (workType === WORK_TYPE.REVIEW && !item?._pr && !item?.pr_id) {
     return 'work-item';
   }
   const typeSpecificPlaybooks = ['explore', 'review', 'test', 'plan-to-prd', 'plan', 'ask', 'verify', 'decompose', 'meeting-investigate', 'meeting-debate', 'meeting-conclude'];

package/engine/scheduler.js

@@ -24,7 +24,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, mutateJsonFileLocked } = shared;
+const { safeJson, safeWrite, mutateJsonFileLocked, WI_STATUS } = shared;
 
 const SCHEDULE_RUNS_PATH = path.join(__dirname, 'schedule-runs.json');
 
@@ -125,7 +125,7 @@ function discoverScheduledWork(config) {
         type: sched.type || 'implement',
         priority: sched.priority || 'medium',
         description: sched.description || sched.title,
-        status: 'pending',
+        status: WI_STATUS.PENDING,
         created: new Date().toISOString(),
         createdBy: 'scheduler',
         agent: sched.agent || null,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.320",
+  "version": "0.1.321",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"