@yemi33/minions 0.1.316 → 0.1.317

package/CHANGELOG.md

@@ -1,12 +1,13 @@
 # Changelog
 
-## 0.1.316 (2026-04-03)
+## 0.1.317 (2026-04-03)
 
 ### Fixes
 -  deduplicate PRs in pull-requests.json on write
 -  show reviewer names in dashboard Signed Off By column
 
 ### Other
+- refactor: use constants in lifecycle.js and timeout.js
 - refactor: extract status/type/result constants to shared.js
 - cleanup: remove evaluate.md (re-created by agents), fix stale references
 - perf: CC message handling — debounce localStorage, cap array, batch scroll

package/engine/lifecycle.js

@@ -1263,15 +1263,16 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
           wi.noPr = true;
           wi.failReason = 'Completed without creating a pull request';
           const retries = wi._retryCount || 0;
-          if (retries < 3) {
-            wi.status = 'pending';
+          const maxR = ENGINE_DEFAULTS.maxRetries;
+          if (retries < maxR) {
+            wi.status = WI_STATUS.PENDING;
             wi._retryCount = retries + 1;
             delete wi.dispatched_at;
             delete wi.dispatched_to;
-            e.log('info', `Auto-retry ${retries + 1}/3 for ${meta.item.id} (no PR created)`);
+            e.log('info', `Auto-retry ${retries + 1}/${maxR} for ${meta.item.id} (no PR created)`);
           } else {
-            wi.status = 'failed';
-            e.log('warn', `${meta.item.id} failed after 3 retries — no PR created`);
+            wi.status = WI_STATUS.FAILED;
+            e.log('warn', `${meta.item.id} failed after ${maxR} retries — no PR created`);
           }
           shared.safeWrite(wiPath, items);
         }

package/engine/timeout.js

@@ -8,7 +8,8 @@ const path = require('path');
 const shared = require('./shared');
 const queries = require('./queries');
 
-const { safeRead, safeWrite, safeJson, getProjects, projectWorkItemsPath, log, ts, ENGINE_DEFAULTS: DEFAULTS } = shared;
+const { safeRead, safeWrite, safeJson, getProjects, projectWorkItemsPath, log, ts,
+  ENGINE_DEFAULTS: DEFAULTS, WI_STATUS, DISPATCH_RESULT } = shared;
 const { getDispatch, getAgentStatus } = queries;
 const AGENTS_DIR = queries.AGENTS_DIR;
 const MINIONS_DIR = shared.MINIONS_DIR;
@@ -140,7 +141,7 @@ function checkTimeouts(config) {
           safeWrite(outputLogPath, `# Output for dispatch ${item.id}\n# Exit code: ${isSuccess ? 0 : 1}\n# Completed: ${ts()}\n# Detected via output scan\n\n## Result\n${text || '(no text)'}\n`);
         } catch (e) { log('warn', 'parse output result: ' + e.message); }
 
-        completeDispatch(item.id, isSuccess ? 'success' : 'error', 'Completed (detected from output)');
+        completeDispatch(item.id, isSuccess ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR, 'Completed (detected from output)');
 
         // Run post-completion hooks via shared helper
         runPostCompletionHooks(item, item.agent, isSuccess ? 0 : 1, liveLog, config);
@@ -215,7 +216,7 @@ function checkTimeouts(config) {
 
   // Clean up dead items
   for (const { item, reason } of deadItems) {
-    completeDispatch(item.id, 'error', reason);
+    completeDispatch(item.id, DISPATCH_RESULT.ERROR, reason);
   }
 
   // Agent status is now derived from dispatch.json at read time (getAgentStatus).
@@ -232,7 +233,7 @@ function checkTimeouts(config) {
     if (!items || !Array.isArray(items)) continue;
     let changed = false;
     for (const item of items) {
-      if (item.status !== 'dispatched') continue;
+      if (item.status !== WI_STATUS.DISPATCHED) continue;
       // Check if any active dispatch references this item
       // Dispatch keys include project name: work-{project}-{id} or central-work-{id}
       const projectNames = getProjects(config).map(p => p.name);
@@ -244,19 +245,20 @@ function checkTimeouts(config) {
         (dispatchData.active || []).some(d => d.meta?.item?.id === item.id);
       if (!isActive) {
         // Don't revive items that were explicitly failed for non-retryable reasons
-        if (item.status === 'failed' && item.failReason && !item.failReason.includes('Agent died')) continue;
+        if (item.status === WI_STATUS.FAILED && item.failReason && !item.failReason.includes('Agent died')) continue;
         const retries = (item._retryCount || 0);
-        if (retries < 3) {
-          log('info', `Reconcile: work item ${item.id} agent died — auto-retry ${retries + 1}/3`);
-          item.status = 'pending';
+        const maxRetries = DEFAULTS.maxRetries;
+        if (retries < maxRetries) {
+          log('info', `Reconcile: work item ${item.id} agent died — auto-retry ${retries + 1}/${maxRetries}`);
+          item.status = WI_STATUS.PENDING;
           item._retryCount = retries + 1;
           delete item.dispatched_at;
           delete item.dispatched_to;
           delete item._pendingReason;
         } else {
           log('warn', `Reconcile: work item ${item.id} failed after ${retries} retries — marking as failed`);
-          item.status = 'failed';
-          item.failReason = 'Agent died or was killed (3 retries exhausted)';
+          item.status = WI_STATUS.FAILED;
+          item.failReason = `Agent died or was killed (${maxRetries} retries exhausted)`;
           item.failedAt = ts();
           delete item._pendingReason;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.316",
+  "version": "0.1.317",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"