@yemi33/minions 0.1.306 → 0.1.308

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.308 (2026-04-03)
+
+### Features
+- Fix PR write race conditions in lifecycle.js
+
 ## 0.1.306 (2026-04-03)
 
 ### Features

package/engine/lifecycle.js

@@ -142,7 +142,8 @@ function checkPlanCompletion(meta, config) {
   if (wrote) log('info', `PRD completion summary written to notes/inbox/`);
 
   // Persist status and _completionNotified atomically BEFORE creating work items
-  plan._completionNotified = true;
+  // NOTE: Do NOT set plan._completionNotified in-memory before persist —
+  // if persist fails, the in-memory flag would prevent retry on next tick.
   mutateJsonFileLocked(planPath, (data) => {
     data.status = 'completed';
     data.completedAt = plan.completedAt;
@@ -154,7 +155,11 @@ function checkPlanCompletion(meta, config) {
   // Resolve the primary project for writing new work items (PR, verify)
   const projectName = plan.project;
   const primaryProject = projectName
-    ? projects.find(p => p.name?.toLowerCase() === projectName?.toLowerCase()) : projects[0];
+    ? projects.find(p => p.name?.toLowerCase() === projectName?.toLowerCase()) : (projects[0] || null);
+  if (!primaryProject) {
+    log('warn', `checkPlanCompletion: no project available (projects array ${projects.length === 0 ? 'empty' : 'no match for ' + projectName}) — skipping PR/verify creation for ${planFile}`);
+    return;
+  }
   const wiPath = primaryProject ? shared.projectWorkItemsPath(primaryProject) : null;
   const workItems = wiPath ? (safeJson(wiPath) || []) : [];
 
@@ -424,6 +429,10 @@ function chainPlanToPrd(dispatchItem, meta, config) {
 
   const projectName = meta?.item?.project || meta?.project?.name;
   const projects = shared.getProjects(config);
+  if (projects.length === 0) {
+    log('error', 'Plan chaining: no projects configured — cannot chain plan to PRD');
+    return;
+  }
   const targetProject = projectName
     ? projects.find(p => p.name === projectName) || projects[0]
     : projects[0];
@@ -584,7 +593,11 @@ function syncPrsFromOutput(output, agentId, meta, config) {
   if (prMatches.size === 0) return 0;
 
   const projects = shared.getProjects(config);
-  const defaultProject = (meta?.project?.name && projects.find(p => p.name === meta.project.name)) || projects[0];
+  if (projects.length === 0 && !meta?.project?.name) {
+    log('warn', `syncPrsFromOutput: no projects configured and no project in meta — cannot sync PRs`);
+    return 0;
+  }
+  const defaultProject = (meta?.project?.name && projects.find(p => p.name === meta.project.name)) || (projects[0] || null);
   const useCentral = !defaultProject;
 
   // Match each PR to its correct project by finding which repo URL appears near the PR number in output
@@ -612,47 +625,51 @@ function syncPrsFromOutput(output, agentId, meta, config) {
   const agentName = config.agents?.[agentId]?.name || agentId;
   let added = 0;
   const centralPrPath = path.join(MINIONS_DIR, 'pull-requests.json');
-  // Track which PR files need writing — keyed by target name
-  const dirtyTargets = new Map(); // name -> { prs, prPath }
 
+  // Group PR matches by target file so we take one lock per target
+  const targetPrIds = new Map(); // targetName -> { prPath, prIds: [{ prId, fullId }] }
   for (const prId of prMatches) {
     const fullId = `PR-${prId}`;
     const targetProject = useCentral ? null : resolveProjectForPr(prId);
     const targetName = targetProject ? targetProject.name : '_central';
     const prPath = targetProject ? shared.projectPrPath(targetProject) : centralPrPath;
-
-    // Load PRs for this target (cache per target)
-    if (!dirtyTargets.has(targetName)) {
-      dirtyTargets.set(targetName, { prs: safeJson(prPath) || [], prPath });
-    }
-    const entry = dirtyTargets.get(targetName);
-    if (entry.prs.some(p => p.id === fullId || String(p.id) === String(prId))) continue;
-
-    let title = meta?.item?.title || '';
-    const titleMatch = output.match(new RegExp(`${prId}[^\\n]*?[—–-]\\s*([^\\n]+)`, 'i'));
-    if (titleMatch) title = titleMatch[1].trim();
-    if (title.includes('session_id') || title.includes('is_error') || title.includes('uuid') || title.length > 120) {
-      title = meta?.item?.title || '';
+    if (!targetPrIds.has(targetName)) {
+      targetPrIds.set(targetName, { prPath, prIds: [] });
     }
-    entry.prs.push({
-      id: fullId,
-      title: (title || `PR created by ${agentName}`).slice(0, 120),
-      agent: agentName,
-      branch: meta?.branch || '',
-      reviewStatus: 'pending',
-      status: 'active',
-      created: dateStamp(),
-      url: extractPrUrl(prId),
-      prdItems: meta?.item?.id ? [meta.item.id] : [],
-      sourcePlan: meta?.item?.sourcePlan || '',
-      itemType: meta?.item?.itemType || ''
-    });
-    if (meta?.item?.id) addPrLink(fullId, meta.item.id);
-    added++;
+    targetPrIds.get(targetName).prIds.push({ prId, fullId });
   }
 
-  for (const [name, entry] of dirtyTargets) {
-    shared.safeWrite(entry.prPath, entry.prs);
+  // For each target, read+modify+write inside a single locked callback
+  for (const [name, { prPath, prIds }] of targetPrIds) {
+    mutateJsonFileLocked(prPath, (prs) => {
+      if (!Array.isArray(prs)) prs = [];
+      for (const { prId, fullId } of prIds) {
+        if (prs.some(p => p.id === fullId || String(p.id) === String(prId))) continue;
+
+        let title = meta?.item?.title || '';
+        const titleMatch = output.match(new RegExp(`${prId}[^\\n]*?[—–-]\\s*([^\\n]+)`, 'i'));
+        if (titleMatch) title = titleMatch[1].trim();
+        if (title.includes('session_id') || title.includes('is_error') || title.includes('uuid') || title.length > 120) {
+          title = meta?.item?.title || '';
+        }
+        prs.push({
+          id: fullId,
+          title: (title || `PR created by ${agentName}`).slice(0, 120),
+          agent: agentName,
+          branch: meta?.branch || '',
+          reviewStatus: 'pending',
+          status: 'active',
+          created: dateStamp(),
+          url: extractPrUrl(prId),
+          prdItems: meta?.item?.id ? [meta.item.id] : [],
+          sourcePlan: meta?.item?.sourcePlan || '',
+          itemType: meta?.item?.itemType || ''
+        });
+        if (meta?.item?.id) addPrLink(fullId, meta.item.id);
+        added++;
+      }
+      return prs;
+    }, { defaultValue: [] });
     log('info', `Synced PR(s) from ${agentName}'s output to ${name === '_central' ? 'central' : name}/pull-requests.json`);
   }
   return added;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.306",
+  "version": "0.1.308",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"