@yemi33/minions 0.1.294 → 0.1.296

package/CHANGELOG.md

@@ -1,14 +1,21 @@
 # Changelog
 
-## 0.1.294 (2026-04-03)
+## 0.1.296 (2026-04-03)
 
 ### Features
+- fix 7 bugs across cooldown, spawn-agent, playbook, scheduler, consolidation
+
+## 0.1.295 (2026-04-03)
+
+### Features
+- fix engine.js race conditions — worktree TOCTOU, self-heal, dispatch dedup
 - fix dashboard.js race conditions, input validation, and watcher leaks
 - fix cleanup.js — worktree TOCTOU, readdirSync isolation, KB restore verify
 - harden shared.js — backup verification, lock TOCTOU, docs
 -  all doc-chats use Sonnet with full tools (agent change)
 
 ### Fixes
+-  address PR-124 review feedback — safeJson regression, read-only lock, filter cleanup
 -  address review feedback on PR-122
 -  add behavioral tests for CRITICAL propagation and stale lock ENOENT
 -  CRITICAL errors in safeJson now propagate to callers

package/engine/consolidation.js

@@ -224,12 +224,22 @@ function consolidateWithLLM(items, existingNotes, files, config) {
       let newContent = current + entry;
 
       if (newContent.length > 50000) {
-        const sections = newContent.split('\n---\n\n### ');
-        if (sections.length > 10) {
-          const header = sections[0];
-          const recent = sections.slice(-8);
-          newContent = header + '\n---\n\n### ' + recent.join('\n---\n\n### ');
-          log('info', `Pruned notes.md: removed ${sections.length - 9} old sections`);
+        // Truncate on section boundary — scan backward for last \n# before byte limit
+        // Never cut mid-section to preserve readability
+        const limit = 50000;
+        const lastSectionBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
+        if (lastSectionBoundary > 0) {
+          newContent = newContent.slice(0, lastSectionBoundary);
+          log('info', `Pruned notes.md at section boundary (pos ${lastSectionBoundary}) to stay under ${limit} bytes`);
+        } else {
+          // Fallback: use the old section-count approach
+          const sections = newContent.split('\n---\n\n### ');
+          if (sections.length > 10) {
+            const header = sections[0];
+            const recent = sections.slice(-8);
+            newContent = header + '\n---\n\n### ' + recent.join('\n---\n\n### ');
+            log('info', `Pruned notes.md: removed ${sections.length - 9} old sections`);
+          }
         }
       }
 
@@ -312,8 +322,9 @@ function consolidateWithRegex(items, files) {
   const seen = new Map();
   const deduped = [];
   for (const insight of allInsights) {
-    const fpWords = insight.fingerprint.split(' ').filter(w => w.length > 4).slice(0, 5);
+    const fpWords = insight.fingerprint.split(' ').filter(w => w.length > 4 && w.length <= 200).slice(0, 5);
     // Use word-boundary regex to avoid substring false positives (e.g. 'fix' matching 'prefix')
+    // Cap word length at 200 chars to prevent ReDoS on pathological input
     if (fpWords.length >= 3 && fpWords.every(w => new RegExp(`\\b${w.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(existingNotes))) continue;
     const existing = seen.get(insight.fingerprint);
     if (existing) { if (!existing.sources.includes(insight.agent)) existing.sources.push(insight.agent); continue; }
@@ -355,8 +366,14 @@ function consolidateWithRegex(items, files) {
   const current = getNotes();
   let newContent = current + entry;
   if (newContent.length > 50000) {
-    const sections = newContent.split('\n---\n\n### ');
-    if (sections.length > 10) { newContent = sections[0] + '\n---\n\n### ' + sections.slice(-8).join('\n---\n\n### '); }
+    const limit = 50000;
+    const lastBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
+    if (lastBoundary > 0) {
+      newContent = newContent.slice(0, lastBoundary);
+    } else {
+      const sections = newContent.split('\n---\n\n### ');
+      if (sections.length > 10) { newContent = sections[0] + '\n---\n\n### ' + sections.slice(-8).join('\n---\n\n### '); }
+    }
   }
   safeWrite(NOTES_PATH, newContent);
   classifyToKnowledgeBase(items);

package/engine/cooldown.js

@@ -38,7 +38,11 @@ function saveCooldowns() {
       if (now - v.timestamp > 24 * 60 * 60 * 1000) dispatchCooldowns.delete(k);
     }
     const obj = Object.fromEntries(dispatchCooldowns);
-    safeWrite(COOLDOWN_PATH, obj);
+    try {
+      safeWrite(COOLDOWN_PATH, obj);
+    } catch (err) {
+      log('warn', `saveCooldowns failed writing ${COOLDOWN_PATH}: ${err.message}`);
+    }
   }, 1000); // debounce — write at most once per second
 }
 

package/engine/playbook.js

@@ -285,6 +285,14 @@ function renderPlaybook(type, vars) {
     content = content.replace(new RegExp(`\\{\\{${key}\\}\\}`, 'g'), String(val));
   }
 
+  // Warn when a substituted value itself contains {{...}} patterns (potential self-reference)
+  const selfRefVars = Object.entries(allVars)
+    .filter(([, val]) => /\{\{\w+\}\}/.test(String(val)))
+    .map(([key]) => key);
+  if (selfRefVars.length > 0) {
+    log('warn', `Playbook "${type}": substituted values contain unresolved {{...}} patterns (potential self-reference): ${selfRefVars.join(', ')}`);
+  }
+
   // Warn on variables that resolved to empty string
   const emptyVars = Object.entries(allVars)
     .filter(([, val]) => String(val) === '')

package/engine/scheduler.js

@@ -114,7 +114,7 @@ function discoverScheduledWork(config) {
   mutateJsonFileLocked(SCHEDULE_RUNS_PATH, (runs) => {
     for (const sched of schedules) {
       if (!sched.id || !sched.cron || !sched.title) continue;
-      if (sched.enabled === false) continue;
+      if (sched.enabled !== true) continue; // explicit true required — undefined/null/false all skip
 
       const lastRun = runs[sched.id] || null;
       if (!shouldRunNow(sched, lastRun)) continue;

package/engine/shared.js

@@ -57,16 +57,12 @@ function safeJson(p) {
         // Verify the restored file matches expected content
         const verifyData = JSON.parse(fs.readFileSync(p, 'utf8'));
         if (JSON.stringify(verifyData) !== JSON.stringify(backupData)) {
-          const errMsg = `[safeJson] CRITICAL: backup restore verification failed for ${p} — written data does not match backup`;
-          console.error(errMsg);
-          throw new Error(errMsg);
+          console.error(`[safeJson] CRITICAL: backup restore verification failed for ${p} — written data does not match backup`);
         }
       } catch (restoreErr) {
-        // Re-throw CRITICAL errors so they propagate to callers
-        if (restoreErr.message && restoreErr.message.includes('CRITICAL')) throw restoreErr;
-        const errMsg = `[safeJson] CRITICAL: backup restore failed for ${p}: ${restoreErr.message}`;
-        console.error(errMsg);
-        throw new Error(errMsg);
+        // Restore-to-primary is best-effort — backupData is already parsed and valid.
+        // Don't throw: disk-full / permission errors should not discard valid data.
+        console.error(`[safeJson] restore write failed for ${p}: ${restoreErr.message}`);
       }
       return backupData;
     } catch (outerErr) {
@@ -158,8 +154,7 @@ function withFileLock(lockPath, fn, {
             // ENOENT: another process deleted the lock between stat and unlink — safe to retry
             if (unlinkErr.code !== 'ENOENT') throw unlinkErr;
           }
-          sleepMs(retryDelayMs); // avoid busy-loop on contention
-          continue;
+          continue; // lock just removed — retry immediately
         }
       } catch (staleErr) {
         // ENOENT from statSync: lock file disappeared between EEXIST and stat — retry will succeed

package/engine/spawn-agent.js

@@ -154,17 +154,31 @@ const pidFile = promptFile.replace(/prompt-/, 'pid-').replace(/\.md$/, '.pid');
 fs.writeFileSync(pidFile, String(proc.pid || ''));
 
 // Send prompt via stdin — if system prompt was truncated, prepend the full context
-if (!isResume && Buffer.byteLength(sysPrompt) >= 30000) {
-  // System prompt was too large for CLI — prepend full context to user prompt
-  proc.stdin.write(`## Full Agent Context\n\n${sysPrompt}\n\n---\n\n## Your Task\n\n${prompt}`);
-} else {
-  proc.stdin.write(prompt);
+try {
+  if (!isResume && Buffer.byteLength(sysPrompt) >= 30000) {
+    // System prompt was too large for CLI — prepend full context to user prompt
+    proc.stdin.write(`## Full Agent Context\n\n${sysPrompt}\n\n---\n\n## Your Task\n\n${prompt}`);
+  } else {
+    proc.stdin.write(prompt);
+  }
+  proc.stdin.end();
+} catch (err) {
+  console.error(`FATAL: stdin write failed (broken pipe): ${err.message}`);
+  fs.appendFileSync(debugPath, `STDIN ERROR: ${err.message}\n`);
+  try { proc.kill('SIGTERM'); } catch { /* process may already be dead */ }
+  process.exit(1);
 }
-proc.stdin.end();
 
 // Clean up temp file (only created for non-resume sessions)
 if (!isResume) setTimeout(() => { try { fs.unlinkSync(sysTmpPath); } catch { /* cleanup */ } }, 5000);
 
+// Register exit handler to clean up orphaned temp files (system prompt tmp)
+function _cleanupSpawnTempFiles() {
+  try { fs.unlinkSync(sysTmpPath); } catch { /* may already be cleaned */ }
+}
+process.on('exit', _cleanupSpawnTempFiles);
+process.on('SIGTERM', () => { _cleanupSpawnTempFiles(); process.exit(143); });
+
 // Capture stderr separately for debugging
 let stderrBuf = '';
 proc.stderr.on('data', (chunk) => {

package/engine.js

@@ -91,6 +91,7 @@ const safeJson = shared.safeJson;
 const safeRead = shared.safeRead;
 const safeWrite = shared.safeWrite;
 const mutateJsonFileLocked = shared.mutateJsonFileLocked;
+const withFileLock = shared.withFileLock;
 
 // ─── Dispatch Management (extracted to engine/dispatch.js) ───────────────────
 
@@ -352,10 +353,15 @@ function spawnAgent(dispatchItem, config) {
                   if (alreadyUsed) {
                     const existingWtPath = findExistingWorktree(rootDir, branchName);
                     if (existingWtPath && fs.existsSync(existingWtPath)) {
-                      const dispatch = safeJson(DISPATCH_PATH) || {};
-                      const activelyUsed = (dispatch.active || []).some(d => {
-                        const dBranch = d.meta?.branch ? sanitizeBranch(d.meta.branch) : '';
-                        return dBranch === branchName && d.id !== id;
+                      // Bug fix: read dispatch under file lock so check-and-act is atomic
+                      // Uses withFileLock directly (read-only) — no unnecessary disk write
+                      let activelyUsed = false;
+                      withFileLock(DISPATCH_PATH + '.lock', () => {
+                        const dp = safeJson(DISPATCH_PATH) || {};
+                        activelyUsed = (dp.active || []).some(d => {
+                          const dBranch = d.meta?.branch ? sanitizeBranch(d.meta.branch) : '';
+                          return dBranch === branchName && d.id !== id;
+                        });
                       });
                       if (activelyUsed) {
                         log('warn', `Branch ${branchName} actively used by another agent at ${existingWtPath} — cannot create worktree`);
@@ -2354,9 +2360,17 @@ async function tickInner() {
   // Only dispatch to agents that aren't already busy (one task per agent at a time).
   // Build set of agents currently active.
   const busyAgents = new Set((dispatch.active || []).map(d => d.agent));
+  // Bug fix #14: deduplicate pending by dispatch ID to prevent double-dispatch.
+  // This guards against the same item appearing twice in the in-memory pending array.
+  const seenPendingIds = new Set();
   const toDispatch = [];
   for (const item of dispatch.pending) {
     if (toDispatch.length >= slotsAvailable) break;
+    if (seenPendingIds.has(item.id)) {
+      log('warn', `Duplicate dispatch ID ${item.id} in pending queue — skipping`);
+      continue;
+    }
+    seenPendingIds.add(item.id);
     if (busyAgents.has(item.agent)) continue; // agent already has an active task
     toDispatch.push(item);
     busyAgents.add(item.agent); // mark busy for this dispatch round too

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.294",
+  "version": "0.1.296",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"