@yemi33/minions 0.1.291 → 0.1.292

package/CHANGELOG.md

@@ -1,11 +1,14 @@
 # Changelog
 
-## 0.1.291 (2026-04-03)
+## 0.1.292 (2026-04-03)
 
 ### Features
+- harden shared.js — backup verification, lock TOCTOU, docs
 -  all doc-chats use Sonnet with full tools (agent change)
 
 ### Fixes
+-  add behavioral tests for CRITICAL propagation and stale lock ENOENT
+-  CRITICAL errors in safeJson now propagate to callers
 -  defer plan archiving until verify completes, add 20 verify tests
 -  enforce worktree isolation — 4 code paths fixed
 - ' not 'Evaluate:'

package/engine/shared.js

@@ -52,14 +52,37 @@ function safeJson(p) {
       const backupData = JSON.parse(fs.readFileSync(backupPath, 'utf8'));
       // Backup is valid — restore it to the primary file (atomic via safeWrite)
       console.log(`[safeJson] restored ${path.basename(p)} from .backup sidecar`);
-      try { safeWrite(p, backupData); } catch { /* best-effort restore */ }
+      try {
+        safeWrite(p, backupData);
+        // Verify the restored file matches expected content
+        const verifyData = JSON.parse(fs.readFileSync(p, 'utf8'));
+        if (JSON.stringify(verifyData) !== JSON.stringify(backupData)) {
+          const errMsg = `[safeJson] CRITICAL: backup restore verification failed for ${p} — written data does not match backup`;
+          console.error(errMsg);
+          throw new Error(errMsg);
+        }
+      } catch (restoreErr) {
+        // Re-throw CRITICAL errors so they propagate to callers
+        if (restoreErr.message && restoreErr.message.includes('CRITICAL')) throw restoreErr;
+        const errMsg = `[safeJson] CRITICAL: backup restore failed for ${p}: ${restoreErr.message}`;
+        console.error(errMsg);
+        throw new Error(errMsg);
+      }
       return backupData;
-    } catch {
+    } catch (outerErr) {
+      // Let CRITICAL errors propagate — callers must know about data integrity failures
+      if (outerErr.message && outerErr.message.includes('CRITICAL')) throw outerErr;
       return null;
     }
   }
 }
 
+/**
+ * Monotonic counter for generating unique temp file names within this process.
+ * Assumes single-thread execution (no worker_threads). If worker_threads are
+ * introduced, this must be replaced with an atomic or thread-safe counter to
+ * avoid temp file name collisions.
+ */
 let _tmpCounter = 0;
 
 function safeWrite(p, data) {
@@ -129,10 +152,19 @@ function withFileLock(lockPath, fn, {
       try {
         const stat = fs.statSync(lockPath);
         if (Date.now() - stat.mtimeMs > LOCK_STALE_MS) {
-          try { fs.unlinkSync(lockPath); } catch { /* race: another process removed it */ }
-          continue; // retry immediately after removing stale lock
+          try {
+            fs.unlinkSync(lockPath);
+          } catch (unlinkErr) {
+            // ENOENT: another process deleted the lock between stat and unlink — safe to retry
+            if (unlinkErr.code !== 'ENOENT') throw unlinkErr;
+          }
+          sleepMs(retryDelayMs); // avoid busy-loop on contention
+          continue;
         }
-      } catch { /* lock file disappeared between EEXIST and stat — retry will succeed */ }
+      } catch (staleErr) {
+        // ENOENT from statSync: lock file disappeared between EEXIST and stat — retry will succeed
+        if (staleErr.code !== 'ENOENT') throw staleErr;
+      }
       sleepMs(retryDelayMs);
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.291",
+  "version": "0.1.292",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"