@yemi33/minions 0.1.2450 → 0.1.2451

package/dashboard/js/render-inbox.js

@@ -19,13 +19,44 @@ function _timeSinceMs(mtimeMs) {
   return days + 'd ago';
 }
 
+// Per-file content cache keyed by name → { mtimeMs, content }. The inbox can
+// hold thousands of notes; without a cache every 4 s refresh re-fetched EVERY
+// file's body. Firing that many fetches at once exhausted the browser socket
+// pool and flooded the console with `net::ERR_INSUFFICIENT_RESOURCES` on every
+// page (the refresh loop runs regardless of the active page). Caching by
+// (name, mtimeMs) means steady-state refreshes re-fetch nothing — only new or
+// edited notes are pulled — and the pool below bounds the initial load so the
+// socket pool is never saturated. (W-mscjlch1005qdc11)
+const _inboxContentCache = new Map();
+// Max concurrent /state/notes/inbox/<file> fetches. Chrome caps same-host HTTP/1
+// connections at 6; 8 keeps the pipe full without tripping ERR_INSUFFICIENT_RESOURCES.
+const INBOX_FETCH_CONCURRENCY = 8;
+
+// Run async `worker(item)` over `items` with at most `limit` in flight at once.
+// Preserves input order in the returned results array. Used to bound the inbox
+// per-file content fetches so a large inbox can't exhaust the browser's socket pool.
+async function _mapWithConcurrency(items, limit, worker) {
+  const results = new Array(items.length);
+  let next = 0;
+  async function run() {
+    while (next < items.length) {
+      const i = next++;
+      results[i] = await worker(items[i], i);
+    }
+  }
+  const pool = [];
+  for (let i = 0; i < Math.min(limit, items.length); i++) pool.push(run());
+  await Promise.all(pool);
+  return results;
+}
+
 // Fetch the inbox via the /state/notes/inbox directory listing + per-file
 // content fetch. The listing call returns {entries:[{name, mtimeMs, size,
-// isDir}]} and is cheap (one statSync per entry). The per-file fetches run
-// in parallel with their own mtime+size ETag so unchanged files 304 with
-// no body. Issue #2949 — the staleness fix applies here too: the inbox
-// directory mtime advances on every new note, and per-file ETags surface
-// content edits within one 4 s poll.
+// isDir}]} and is cheap (one statSync per entry). Per-file bodies are fetched
+// through a bounded-concurrency pool and cached by (name, mtimeMs), so unchanged
+// notes are served from memory and only new/edited notes hit the network. Issue
+// #2949 — the staleness fix applies here too: the inbox directory mtime advances
+// on every new note, and the mtime cache key surfaces content edits within one 4 s poll.
 async function fetchInboxFromDisk() {
   try {
     const listResp = await fetch('/state/notes/inbox');
@@ -35,21 +66,27 @@ async function fetchInboxFromDisk() {
     const mdFiles = entries
       .filter((e) => e && !e.isDir && typeof e.name === 'string' && e.name.endsWith('.md'))
       .sort((a, b) => (b.mtimeMs || 0) - (a.mtimeMs || 0));
-    const items = await Promise.all(mdFiles.map(async (e) => {
+    // Drop cache entries for notes that no longer exist so the cache can't grow
+    // unbounded across the lifetime of the page.
+    const liveNames = new Set(mdFiles.map((e) => e.name));
+    for (const key of _inboxContentCache.keys()) {
+      if (!liveNames.has(key)) _inboxContentCache.delete(key);
+    }
+    const items = await _mapWithConcurrency(mdFiles, INBOX_FETCH_CONCURRENCY, async (e) => {
+      const cached = _inboxContentCache.get(e.name);
+      if (cached && cached.mtimeMs === e.mtimeMs) {
+        return { name: e.name, mtime: e.mtimeMs, age: _timeSinceMs(e.mtimeMs), content: cached.content };
+      }
       try {
         const r = await fetch('/state/notes/inbox/' + encodeURIComponent(e.name));
         if (!r.ok) return null;
         const content = await r.text();
-        return {
-          name: e.name,
-          mtime: e.mtimeMs,
-          age: _timeSinceMs(e.mtimeMs),
-          content,
-        };
+        _inboxContentCache.set(e.name, { mtimeMs: e.mtimeMs, content });
+        return { name: e.name, mtime: e.mtimeMs, age: _timeSinceMs(e.mtimeMs), content };
       } catch {
         return null;
       }
-    }));
+    });
     return items.filter(Boolean);
   } catch {
     return null;

package/dashboard.js

@@ -3690,6 +3690,19 @@ function handleStateRead(req, res) {
   let lstat;
   try { lstat = fs.lstatSync(resolved); }
   catch {
+    // A not-yet-created but allowlisted top-level state directory (e.g. the
+    // meetings dir before the first meeting is recorded) is an EMPTY directory,
+    // not a missing resource. Returning 404 here made the dashboard's directory-
+    // listing clients (render-meetings.js) log a console error on every refresh.
+    // List it as empty instead so "no items yet" is a clean 200. Missing FILES
+    // and missing nested paths still 404. (W-mscjlch1005qdc11)
+    if (isSingleSegment && STATE_READ_ALLOWED_DIRS.has(top)) {
+      res.statusCode = 200;
+      res.setHeader('Content-Type', 'application/json; charset=utf-8');
+      res.setHeader('Cache-Control', 'private, max-age=0, must-revalidate');
+      res.end(JSON.stringify({ path: rel.replace(/\\/g, '/'), entries: [] }));
+      return;
+    }
     res.statusCode = 404;
     res.setHeader('Content-Type', 'application/json');
     res.end(JSON.stringify({ error: 'not found' }));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2450",
+  "version": "0.1.2451",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"