@yemi33/minions 0.1.2448 → 0.1.2449

package/engine/{pr-fix-target-store.js → persistence/pr-fix-target-store.js}

@@ -1,4 +1,4 @@
-// engine/pr-fix-target-store.js — SQL-backed remembered execution-target
+// engine/persistence/pr-fix-target-store.js — SQL-backed remembered execution-target
 // choices, keyed per repo scope.
 //
 // Plan: projectless-pr-actions, Phase 3, item P-ppa10009 — "Remember
@@ -6,10 +6,10 @@
 // (github:owner/repo / ado:org/proj/repo) in the pr_fix_target_prefs table
 // (migration 014). When a remembered choice exists, a repeat fix on that repo
 // skips the execution-target prompt and routes straight to the executor
-// (engine/pr-fix-target.js#planPrFix consults getRemembered). Absence of a row
+// (engine/providers/pr-fix-target.js#planPrFix consults getRemembered). Absence of a row
 // still prompts — the safe "never clone silently" default.
 //
-// Mirrors the shape of engine/steering-store.js:
+// Mirrors the shape of engine/persistence/steering-store.js:
 //   - routes every read/write through getDb() (no JSON sidecar)
 //   - emits emitStateEvent('pr-fix-target-prefs', {repoScope, target}) on every
 //     write/clear so the dashboard's MAX(events.id) cache check fires.
@@ -29,7 +29,7 @@ function _isValidTarget(target) {
   // Validate against the canonical execution-target list. Lazy require avoids a
   // load-time cycle (pr-fix-target.js requires this store at module top).
   try {
-    const { isValidExecutionTarget } = require('./pr-fix-target');
+    const { isValidExecutionTarget } = require('../providers/pr-fix-target');
     return isValidExecutionTarget(target);
   } catch {
     // If pr-fix-target can't load (shouldn't happen), fall back to a minimal
@@ -63,7 +63,7 @@ function remember(repoScope, target) {
     throw new Error(`pr-fix-target-store.remember: invalid execution target ${JSON.stringify(target)}`);
   }
 
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const db = getDb();
   const now = Date.now();
   db.prepare(`
@@ -87,7 +87,7 @@ function getRecord(repoScope) {
   const scope = _normScope(repoScope);
   if (!scope) return null;
   let db;
-  try { const { getDb } = require('./db'); db = getDb(); }
+  try { const { getDb } = require('../db'); db = getDb(); }
   catch { return null; }
   const row = db.prepare('SELECT * FROM pr_fix_target_prefs WHERE repo_scope = ?').get(scope);
   return _rowToRecord(row);
@@ -97,7 +97,7 @@ function getRecord(repoScope) {
 function clear(repoScope) {
   const scope = _normScope(repoScope);
   if (!scope) return false;
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const db = getDb();
   const info = db.prepare('DELETE FROM pr_fix_target_prefs WHERE repo_scope = ?').run(scope);
   const removed = (info && info.changes) > 0;
@@ -108,7 +108,7 @@ function clear(repoScope) {
 /** All remembered choices, newest-updated first. */
 function list() {
   let db;
-  try { const { getDb } = require('./db'); db = getDb(); }
+  try { const { getDb } = require('../db'); db = getDb(); }
   catch { return []; }
   const rows = db.prepare('SELECT * FROM pr_fix_target_prefs ORDER BY updated_at DESC, repo_scope ASC').all();
   return rows.map(_rowToRecord);

package/engine/{pull-requests-store.js → persistence/pull-requests-store.js}

@@ -1,4 +1,4 @@
-// engine/pull-requests-store.js — SQL-backed scoped pull-request storage.
+// engine/persistence/pull-requests-store.js — SQL-backed scoped pull-request storage.
 //
 //   readPullRequestsForScope(scope)        -> [pr, pr, ...]
 //   applyPullRequestsMutation(scope, fn)   -> diff-then-apply,
@@ -19,8 +19,20 @@ function _parseRow(row) {
   catch { return null; }
 }
 
+// Typed projection for the `author` column: display name → login → id. Kept
+// local (no shared.js require) so this low-level store stays dependency-light;
+// the canonical structured identity always lives in the `data` JSON.
+function _authorLabel(author) {
+  if (!author) return null;
+  if (typeof author === 'string') return author.trim().slice(0, 200) || null;
+  if (typeof author !== 'object') return null;
+  const label = author.displayName || author.login || author.id || '';
+  const s = String(label).trim();
+  return s ? s.slice(0, 200) : null;
+}
+
 function readPullRequestsForScope(scope) {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const db = getDb();
 
   const rows = db.prepare(`
@@ -38,7 +50,7 @@ function readPullRequestsForScope(scope) {
 }
 
 function readAllPullRequests() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const db = getDb();
 
   const rows = db.prepare('SELECT data, scope FROM pull_requests ORDER BY rowid').all();
@@ -81,12 +93,13 @@ function _applyPullRequestsDiff(db, diff) {
   if (diff.toUpsert.length === 0 && diff.toDelete.length === 0) return false;
   const now = Date.now();
   const upsertStmt = db.prepare(`
-    INSERT INTO pull_requests (id, scope, status, review_status, agent, branch, pr_number, created_at, last_polled_at, data, updated_at)
-    VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+    INSERT INTO pull_requests (id, scope, status, review_status, agent, author, branch, pr_number, created_at, last_polled_at, data, updated_at)
+    VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     ON CONFLICT(scope, id) DO UPDATE SET
       status         = excluded.status,
       review_status  = excluded.review_status,
       agent          = excluded.agent,
+      author         = excluded.author,
       branch         = excluded.branch,
       pr_number      = excluded.pr_number,
       created_at     = excluded.created_at,
@@ -103,6 +116,7 @@ function _applyPullRequestsDiff(db, diff) {
       String(pr.status || 'active'),
       pr.reviewStatus || null,
       pr.agent || null,
+      _authorLabel(pr.author),
       pr.branch || null,
       Number.isFinite(pr.prNumber) ? pr.prNumber : null,
       _toMs(pr.created),
@@ -118,7 +132,7 @@ function _applyPullRequestsDiff(db, diff) {
 }
 
 function applyPullRequestsMutation(scope, mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   const db = getDb();
 
   return withTransaction(db, () => {
@@ -145,7 +159,7 @@ function applyPullRequestsMutation(scope, mutator) {
 // applyPullRequestsMutation's callers (see shared.js mutatePullRequests).
 function dropScope(scope) {
   try {
-    const { getDb } = require('./db');
+    const { getDb } = require('../db');
     const result = getDb().prepare('DELETE FROM pull_requests WHERE scope = ?').run(scope);
     if (result && result.changes > 0) {
       try { require('./db-events').emitStateEvent('pull_requests'); } catch { /* optional */ }

package/engine/{small-state-store.js → persistence/small-state-store.js}

@@ -1,4 +1,4 @@
-// SQL stores for low-traffic runtime state.
+// engine/persistence/small-state-store.js — Low-traffic SQL state stores.
 
 function _toMs(v) {
   if (v == null) return null;
@@ -21,12 +21,12 @@ function _readEngineStateFromSql(db) {
 }
 
 function readEngineState() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readEngineStateFromSql(getDb());
 }
 
 function applyEngineStateMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -63,12 +63,12 @@ function _readScheduleRunsFromSql(db) {
 }
 
 function readScheduleRuns() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readScheduleRunsFromSql(getDb());
 }
 
 function applyScheduleRunsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -119,12 +119,12 @@ function _readPipelineRunsFromSql(db) {
 }
 
 function readPipelineRuns() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readPipelineRunsFromSql(getDb());
 }
 
 function applyPipelineRunsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -190,12 +190,12 @@ function _readManagedProcessesFromSql(db) {
 }
 
 function readManagedProcesses() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readManagedProcessesFromSql(getDb());
 }
 
 function applyManagedProcessesMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -258,12 +258,12 @@ function _readWorktreePoolFromSql(db) {
 }
 
 function readWorktreePool() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readWorktreePoolFromSql(getDb());
 }
 
 function applyWorktreePoolMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -312,7 +312,7 @@ function applyWorktreePoolMutation(mutator) {
 // Shape: [ {id, runbookId, targetName, project, workItemId, status, startedAt,
 //           completedAt, createdAt, artifacts, summary, ...}, ... ]
 // SQL:   row per id, extracted query columns + JSON blob `data`.
-// Pattern: mirrors watches-store (top-level array, id-keyed diff).
+// Pattern: mirrors watches/store (top-level array, id-keyed diff).
 
 function _readQaRunsFromSqlOnly(db) {
   const rows = db.prepare('SELECT data FROM qa_runs ORDER BY created_at, rowid').all();
@@ -324,12 +324,12 @@ function _readQaRunsFromSqlOnly(db) {
 }
 
 function readQaRuns() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readQaRunsFromSqlOnly(getDb());
 }
 
 function applyQaRunsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -420,12 +420,12 @@ function _readQaSessionsFromSqlOnly(db) {
 }
 
 function readQaSessions() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readQaSessionsFromSqlOnly(getDb());
 }
 
 function applyQaSessionsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -501,12 +501,12 @@ function _readPrLinksFromSql(db) {
 }
 
 function readPrLinks() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readPrLinksFromSql(getDb());
 }
 
 function applyPrLinksMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -557,12 +557,12 @@ function _readCooldownsFromSql(db) {
 }
 
 function readCooldowns() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readCooldownsFromSql(getDb());
 }
 
 function applyCooldownsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -614,12 +614,12 @@ function _readPendingRebasesFromSql(db) {
 }
 
 function readPendingRebases() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readPendingRebasesFromSql(getDb());
 }
 
 function applyPendingRebasesMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -664,12 +664,12 @@ function _readCcSessionsFromSql(db) {
 }
 
 function readCcSessions() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readCcSessionsFromSql(getDb());
 }
 
 function applyCcSessionsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -707,7 +707,7 @@ function applyCcSessionsMutation(mutator) {
 }
 
 function readCcGlobalSession() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const row = getDb().prepare('SELECT data FROM cc_sessions WHERE id = ?').get(CC_GLOBAL_SESSION_ID);
   if (!row) return null;
   try {
@@ -719,7 +719,7 @@ function readCcGlobalSession() {
 }
 
 function applyCcGlobalSessionMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -769,7 +769,7 @@ function _normalizeCcQueueEntry(entry) {
 
 function readCcQueue(tabId) {
   if (!tabId) return [];
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   const rows = getDb()
     .prepare('SELECT message, intent_metadata FROM cc_queued_messages WHERE tab_id = ? ORDER BY position')
     .all(String(tabId));
@@ -789,7 +789,7 @@ function readCcQueue(tabId) {
 
 function replaceCcQueue(tabId, messages) {
   if (!tabId) return { wrote: false, count: 0 };
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -820,7 +820,7 @@ function replaceCcQueue(tabId, messages) {
 
 function clearCcQueue(tabId) {
   if (!tabId) return { wrote: false };
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }
@@ -845,12 +845,12 @@ function _readDocSessionsFromSql(db) {
 }
 
 function readDocSessions() {
-  const { getDb } = require('./db');
+  const { getDb } = require('../db');
   return _readDocSessionsFromSql(getDb());
 }
 
 function applyDocSessionsMutation(mutator) {
-  const { getDb, withTransaction } = require('./db');
+  const { getDb, withTransaction } = require('../db');
   let db;
   try { db = getDb(); }
   catch (e) { throw new Error(`small-state-store: SQLite unavailable (${e.message})`); }