@yemi33/minions 0.1.2447 → 0.1.2448

package/dashboard/js/command-center.js

@@ -1175,9 +1175,14 @@ async function _ccDoSend(message, skipUserMsg, forceTabId, intentMetadata) {
 
   if (!skipUserMsg) addMsg('user', escHtml(message) + _ccAttachmentBadge(sendImages.length));
 
-  // Remove queue indicator before processing (it'll be re-added if more queued)
-  var existingQueueEl = document.getElementById('cc-queue-indicator');
-  if (existingQueueEl) existingQueueEl.remove();
+  // NOTE: no queue-indicator teardown here on purpose. This used to remove a
+  // single `#cc-queue-indicator` element, a vestige of an older one-node design;
+  // that id has not existed since indicators became one `.cc-queue-item` node per
+  // queued message, so the call was a silent no-op. _renderQueueIndicator() clears
+  // every `.cc-queue-item` before re-rendering, so it solely owns their lifecycle.
+  // Re-adding a removal here would wipe the indicators the drain loop and retry
+  // path render for STILL-queued messages immediately before calling this
+  // function, hiding them for the whole in-flight request.
 
   var ccStartTime = Date.now();
   var reconnectAttempts = 0;

package/dashboard/js/qa.js

@@ -28,7 +28,6 @@
 // navigates.
 
 let _qaRunsPollInterval = null;
-let _qaTargetsCache = [];
 let _qaRunbooksCache = [];
 
 function _stopQaRunsPoll() {
@@ -84,8 +83,6 @@ async function loadQaTargets() {
       '<p class="empty" style="color:var(--red)">Failed to load targets: ' + escHtml(err.message || String(err)) + '</p>'
     );
     root.replaceChildren(frag);
-    _qaTargetsCache = [];
-    _qaPopulateTargetDropdown();
     return;
   }
 
@@ -130,9 +127,6 @@ async function loadQaTargets() {
     });
   }
 
-  _qaTargetsCache = targets;
-  _qaPopulateTargetDropdown();
-
   if (!targets.length) {
     const frag = document.createRange().createContextualFragment(
       '<p class="empty">No live targets. Spawn a service via <code>meta.managed_spawn</code> or <code>meta.keep_processes</code> to populate this list. Full inventory on <a href="/engine">/engine</a>.</p>'
@@ -163,25 +157,13 @@ async function loadQaTargets() {
   root.replaceChildren(frag);
 }
 
-function _qaPopulateTargetDropdown() {
-  const sel = document.getElementById('qa-runbook-target');
-  if (!sel) return;
-  const current = sel.value;
-  // Build option nodes via DOM API — no innerHTML.
-  while (sel.firstChild) sel.removeChild(sel.firstChild);
-  const placeholder = document.createElement('option');
-  placeholder.value = '';
-  placeholder.textContent = '— select a target —';
-  sel.appendChild(placeholder);
-  for (const t of _qaTargetsCache) {
-    const opt = document.createElement('option');
-    opt.value = t.name;
-    const projLabel = t.project ? ' (' + t.project + ')' : '';
-    opt.textContent = t.name + projLabel + ' [' + t.source + ']';
-    sel.appendChild(opt);
-  }
-  if (current) sel.value = current;
-}
+// W-mpxp7a3e000g0a49 removed the inline "Start QA Session" / runbook form from
+// dashboard/pages/qa.html, taking the `qa-runbook-target` <select> with it
+// (asserted absent by test/unit/qa-tab-ui.test.js). The _qaPopulateTargetDropdown
+// helper that filled it was left behind as an unreachable no-op and has been
+// deleted (W-ms5dlone012i457a-b), along with the `_qaTargetsCache` module state
+// that existed only to feed it — loadQaTargets renders its rows directly.
+// Runbook targets are chosen via Command Center.
 
 // ── Section 2: Runbooks ────────────────────────────────────────────────────
 async function loadQaRunbooks() {

package/dashboard-build.js

@@ -44,21 +44,40 @@ const DASHBOARD_JS_FILES = [
 /**
  * Read a page fragment and substitute any sub-fragment markers declared for it.
  * Shared by both assemblers so a sub-fragment can never be wired into one only.
+ *
+ * When `sources` is an array, every file read here is pushed to it as
+ * `{file, content}` holding that file's RAW text — the parent separately from
+ * each sub-fragment — so static-audit callers can report violations against
+ * each source file's own true line numbers.
  */
-function readPageFragment(dashDir, page) {
-  let content = safeRead(path.join(dashDir, 'pages', page + '.html'));
+function readPageFragment(dashDir, page, sources) {
+  const raw = safeRead(path.join(dashDir, 'pages', page + '.html'));
+  let content = raw;
   const subs = DASHBOARD_PAGE_SUB_FRAGMENTS[page];
   if (subs) {
     for (const [marker, basename] of Object.entries(subs)) {
       const fragment = safeRead(path.join(dashDir, 'pages', basename + '.html'));
+      if (sources) sources.push({ file: `dashboard/pages/${basename}.html`, content: fragment });
       // Function replacer: fragment text may contain `$&`/`$1` patterns.
       content = content.replace(marker, () => fragment);
     }
   }
+  if (sources) sources.push({ file: `dashboard/pages/${page}.html`, content: raw });
   return content;
 }
 
-function buildDashboardHtml() {
+/**
+ * Assemble the classic dashboard's constituent parts.
+ *
+ * Exported (as `_buildClassicParts`) so static-audit tests can inspect the exact
+ * page HTML and JS bundle the server ships without reimplementing — or drifting
+ * from — the concatenation performed here.
+ *
+ * @returns {{layout: string, css: string, pageHtml: string, jsHtml: string,
+ *            jsSources: Array<{file: string, content: string}>,
+ *            pageSources: Array<{file: string, content: string}>}}
+ */
+function _buildClassicParts() {
   const dashDir = path.join(MINIONS_DIR, 'dashboard');
   const layoutPath = path.join(dashDir, 'layout.html');
 
@@ -69,25 +88,38 @@ function buildDashboardHtml() {
   const layout = safeRead(layoutPath);
   const css = safeRead(path.join(dashDir, 'styles.css'));
 
+  const pageSources = [];
   const pages = DASHBOARD_PAGES;
   let pageHtml = '';
   for (const p of pages) {
-    const content = readPageFragment(dashDir, p);
+    // readPageFragment() collects each source file's RAW text into pageSources
+    // (parent and sub-fragments separately), so every file keeps its own true
+    // line numbers for violation reporting.
+    const content = readPageFragment(dashDir, p, pageSources);
     const activeClass = p === 'home' ? ' active' : '';
     pageHtml += `    <div class="page${activeClass}" id="page-${p}">\n${content}\n    </div>\n\n`;
   }
 
+  const jsSources = [];
   const jsFiles = DASHBOARD_JS_FILES;
   let jsHtml = '';
   for (const f of DASHBOARD_SHARED_JS) {
     const content = safeRead(path.join(dashDir, 'shared', f + '.js'));
+    jsSources.push({ file: `dashboard/shared/${f}.js`, content });
     jsHtml += `\n// ─── shared/${f}.js ────────────────────────────────────────\n${content}\n`;
   }
   for (const f of jsFiles) {
     const content = safeRead(path.join(dashDir, 'js', f + '.js'));
+    jsSources.push({ file: `dashboard/js/${f}.js`, content });
     jsHtml += `\n// ─── ${f}.js ────────────────────────────────────────\n${content}\n`;
   }
 
+  return { layout, css, pageHtml, jsHtml, jsSources, pageSources };
+}
+
+function buildDashboardHtml() {
+  const { layout, css, pageHtml, jsHtml } = _buildClassicParts();
+
   // Use function replacer to avoid $ special patterns in String.replace
   return layout
     .replace('/* __CSS__ */', () => css)
@@ -206,5 +238,8 @@ module.exports = {
   DASHBOARD_JS_FILES,
   readPageFragment,
   SLIM_JS_ORDER,
+  CLASSIC_PAGES: DASHBOARD_PAGES,
+  CLASSIC_JS_FILES: DASHBOARD_JS_FILES,
+  _buildClassicParts,
   _resetSlimPartsCacheForTest,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2447",
+  "version": "0.1.2448",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"