@yemi33/minions 0.1.2440 → 0.1.2442

package/dashboard/js/settings.js

@@ -503,7 +503,7 @@ async function openSettings() {
     '<h3>Polling</h3>' +
     '<div class="settings-pane-sub">Cadence for fetching PR build status, votes, and comments from the platforms. Disabling a provider here turns the matching Auto-fix gates into no-ops. The <em>Pause All Polling</em> kill-switch below overrides both provider toggles and inerts every PR auto-dispatch gate (Auto-fix Builds / Conflicts / Review / etc.) until cleared.</div>' +
     '<div class="settings-stack" style="margin-bottom:16px">' +
-      settingsToggle('🛑 Pause ALL polling', 'set-pollingPaused', !!e.pollingPaused, 'Halts every PR poll, reconciliation, rebase processing, and work-discovery scan on the next tick. Reversible without restart. Use when hitting API rate limits.') +
+      settingsToggle('🛑 Pause ALL polling', 'set-pollingPaused', !!e.pollingPaused, 'Halts every PR status/comment poll AND provider reconciliation (ADO + GitHub + shared-branch) on the next tick, and inerts every PR-derived auto-dispatch gate. Reversible without restart. Use when hitting API rate limits.') +
     '</div>' +
     '<div class="settings-pane-sub" style="margin-bottom:8px">Legacy bundle toggles — granular controls below override these when set.</div>' +
     '<div class="settings-stack" style="margin-bottom:12px">' +
@@ -511,7 +511,7 @@ async function openSettings() {
       settingsToggle('GitHub Polling', 'set-ghPollEnabled', e.ghPollEnabled !== false, 'Legacy bundle macro — when OFF, silences all three GitHub axes (status, comments, reconcile) and GitHub PR dispatch gates are inert when this is off. Per-axis flags below take priority when explicitly set. Keep ON unless you want a one-knob GitHub kill.') +
     '</div>' +
     '<details class="settings-collapsible" style="margin-bottom:12px"><summary>Granular per-poller controls (P-c4d8e1a3)</summary>' +
-    '<div class="settings-pane-sub" style="margin-top:8px">Override individual ADO/GitHub poll axes + the pending-rebase processor. Explicit values here win; if unset, the legacy ADO/GitHub Polling macros above apply; otherwise the default is ON. <strong>Status</strong> + <strong>Comments</strong> still honor the <em>Pause All Polling</em> kill-switch above; <strong>Reconcile</strong> and <strong>Process Pending Rebases</strong> are recovery sweeps and ignore it (by design).</div>' +
+    '<div class="settings-pane-sub" style="margin-top:8px">Override individual ADO/GitHub poll axes + the pending-rebase processor. Explicit values here win; if unset, the legacy ADO/GitHub Polling macros above apply; otherwise the default is ON. <strong>Status</strong>, <strong>Comments</strong> and <strong>Reconcile</strong> all honor the <em>Pause All Polling</em> kill-switch above (reconcile included since W-ms5eljc60090f0d5 — it issues provider API calls); only <strong>Process Pending Rebases</strong> ignores it (by design — it makes no provider poll call).</div>' +
     '<div class="settings-stack" style="margin-top:8px">' +
       settingsToggle('ADO PR Status Poll', 'set-adoPrStatusPollEnabled', e.adoPrStatusPollEnabled !== false, 'Granular: ADO PR build/merge/review status poll (section 2.6). Default ON. When OFF, ADO PR status will not refresh, but reconcile + comments still run (unless their own granular flag is OFF).') +
       settingsToggle('ADO PR Comments Poll', 'set-adoPrCommentsPollEnabled', e.adoPrCommentsPollEnabled !== false, 'Granular: ADO PR human-comments poll (section 2.7). Default ON. When OFF, ADO PR comments will not surface — auto-fix-human-comments still composes against this flag for ADO.') +

package/dashboard/slim/body.html

@@ -202,24 +202,24 @@
   </div>
 </div>
 
-<!-- Knowledge control panel — opened from the "Knowledge" status tile. One
-     unified box surfacing all three knowledge surfaces via tabs: Pinned
-     Context, Notes, and KB (knowledge base). Each tab is rendered lazily by
-     dashboard/slim/js/knowledge.js into #slim-knowledge-body. Backed by the
-     existing endpoints (no new server routes):
+<!-- Knowledge control panel — opened from the "Knowledge" status tile. Two
+     tabs: Pinned Context (slim-native, via pinned.js — there is no standalone
+     classic route for pinned, it lives on /home) and Notes & Knowledge, which
+     embeds the LITERAL classic /inbox screen (Notes Inbox + Team Notes +
+     Knowledge Base + memory search) in a chrome-off /inbox?embed=1 iframe
+     rather than a slim-native fork (CLAUDE.md "Slim UX vs Classic UX — reuse,
+     don't fork"). Rendered lazily by dashboard/slim/js/knowledge.js into
+     #slim-knowledge-body. Backed by the existing endpoints (no new routes):
        Pinned — /api/pinned (+ update/remove), surfaced via /api/status.
-       Notes  — /api/notes-full (read), /api/notes-save (edit notes.md),
-                /api/notes (add an inbox note).
-       KB     — /api/knowledge (list), /api/knowledge/:cat/:file (read),
-                /api/knowledge POST (create), /api/kb-pins(+/toggle). -->
+       Notes & Knowledge — the classic /inbox page (/api/notes*, /api/knowledge,
+                /api/kb-pins, memory search) inside the embedded iframe. -->
 <div class="modal-bg" id="slim-knowledge-modal">
   <div class="modal slim-knowledge-modal-inner">
     <div class="modal-header">
       <h3>Knowledge</h3>
       <div class="kn-tabs" id="slim-kn-tabs" role="tablist">
         <button class="kn-tab active" id="slim-kn-tab-pinned" data-kn-tab="pinned" type="button" role="tab" aria-selected="true" aria-controls="slim-knowledge-body">Pinned Context</button>
-        <button class="kn-tab" id="slim-kn-tab-notes" data-kn-tab="notes" type="button" role="tab" aria-selected="false" aria-controls="slim-knowledge-body">Notes</button>
-        <button class="kn-tab" id="slim-kn-tab-kb" data-kn-tab="kb" type="button" role="tab" aria-selected="false" aria-controls="slim-knowledge-body">KB</button>
+        <button class="kn-tab" id="slim-kn-tab-inbox" data-kn-tab="inbox" type="button" role="tab" aria-selected="false" aria-controls="slim-knowledge-body">Notes &amp; Knowledge</button>
       </div>
       <button id="slim-knowledge-close" class="icon-btn" title="Close" style="margin-left:auto">&times;</button>
     </div>

package/dashboard/slim/js/knowledge.js

@@ -1,34 +1,23 @@
 
-  // ── Knowledge control panel (Pinned Context + Notes + KB) ──────────
-  // One unified cockpit box over the three knowledge surfaces, replacing the
-  // old single "Pinned context" tile. Reuses the classic dashboard's existing
-  // endpoints (no new server routes):
-  //   Pinned — /api/pinned (+ update/remove); the Pinned-Context tab reuses the
-  //            editor + list renderer in pinned.js.
-  //   Notes  — /api/notes-full (read notes.md), /api/notes-save (edit notes.md),
-  //            /api/notes (add an inbox note for consolidation).
-  //   KB     — /api/knowledge (list), /api/knowledge/:cat/:file (read entry),
-  //            /api/knowledge POST (create), /api/kb-pins(+/toggle) (pin state).
+  // ── Knowledge control panel (Pinned Context + Notes & Knowledge) ────
+  // One cockpit box over the knowledge surfaces, replacing the old single
+  // "Pinned context" tile. Two tabs:
+  //   Pinned — slim-native (there is no standalone classic route for pinned;
+  //            it lives on /home). Reuses the editor + list renderer in
+  //            pinned.js, backed by /api/pinned (+ update/remove).
+  //   Notes & Knowledge — embeds the LITERAL classic /inbox screen (Notes
+  //            Inbox + Team Notes + Knowledge Base + memory search) in a
+  //            chrome-off /inbox?embed=1 iframe, per CLAUDE.md "Slim UX vs
+  //            Classic UX — reuse, don't fork". Zero forked rendering logic.
   //
   // Counts: pinned is live from the 5s status poll (renderKnowledgeTile is fed
   // by applyStatus). Notes + KB counts are fetched lazily — once shortly after
-  // load and again after any create/save — so the heavier /api/notes-full and
+  // load and again on modal open — so the heavier /api/notes-full and
   // /api/knowledge reads stay off the recurring poll.
 
   var _knowledgeCounts = { pinned: 0, notes: null, kb: null };
   var _knActiveTab = 'pinned';
-  var _kbData = null;      // cached /api/knowledge payload
-  var _kbPins = [];        // cached pinned KB keys ('knowledge/<cat>/<file>')
-
-  var KB_CAT_LABELS = {
-    architecture: 'Architecture', conventions: 'Conventions',
-    'project-notes': 'Project Notes', 'build-reports': 'Build Reports',
-    reviews: 'Reviews', learnings: 'Learnings', decisions: 'Decisions',
-    incidents: 'Incidents', 'api-notes': 'API Notes',
-  };
-  // Categories offered in the KB create form (mirrors the classic dashboard).
-  var KB_CREATE_CATS = ['architecture', 'conventions', 'project-notes', 'build-reports', 'reviews'];
-  var KB_LIST_CAP = 60;    // cap rendered rows; the KB can hold thousands
+  var _knInboxFrame = null;   // cached /inbox?embed=1 iframe (created once)
 
   // ── Cockpit tile ───────────────────────────────────────────────────
   // Called from applyStatus with the live pinned count each poll, and from the
@@ -68,35 +57,24 @@
     try {
       var kres = await fetch('/api/knowledge', { headers: { 'Accept': 'application/json' } });
       if (kres.ok) {
-        _kbData = await kres.json();
-        _knowledgeCounts.kb = _countKbEntries(_kbData);
+        _knowledgeCounts.kb = _countKbEntries(await kres.json());
       }
     } catch (e) { /* keep last-known */ }
     renderKnowledgeTile();
   }
 
-  async function loadKbPins() {
-    try {
-      var res = await fetch('/api/kb-pins', { headers: { 'Accept': 'application/json' } });
-      if (!res.ok) return;
-      var d = await res.json();
-      _kbPins = Array.isArray(d.pins) ? d.pins : [];
-    } catch (e) { _kbPins = _kbPins || []; }
-  }
-
-  function kbPinKey(cat, file) { return 'knowledge/' + cat + '/' + file; }
-  function isKbPinned(key) { return _kbPins.indexOf(key) !== -1; }
-
   // ── Modal open/close + tab switching ───────────────────────────────
   function openKnowledgeModal() {
     var modal = document.getElementById('slim-knowledge-modal');
     if (!modal) return;
-    renderKnowledgeTab();
+    renderKnowledgeTab();   // posts visibility=true to the embed if the inbox tab is active
     modal.classList.add('open');
   }
   function closeKnowledgeModal() {
     var modal = document.getElementById('slim-knowledge-modal');
     if (modal) modal.classList.remove('open');
+    // Suspend the embedded /inbox poll while the modal is closed.
+    _postKnEmbedVisibility(false);
   }
   function setKnowledgeTab(tab) {
     _knActiveTab = tab;
@@ -112,13 +90,81 @@
     if (body && activeTabId) body.setAttribute('aria-labelledby', activeTabId);
     renderKnowledgeTab();
   }
+  // Tab routing. The Pinned tab renders slim-native content into a transient
+  // container; the Notes & Knowledge tab shows a cached /inbox?embed=1 iframe
+  // (created once, kept mounted so a tab switch never reloads it).
   function renderKnowledgeTab() {
+    var c = _ensureKnContainers();
+    if (!c) return;
+    if (_knActiveTab === 'inbox') {
+      renderKnowledgeInboxTab();
+    } else {
+      c.host.hidden = true;
+      _postKnEmbedVisibility(false);
+      c.transient.textContent = '';
+      renderKnowledgePinnedTab(c.transient);
+    }
+  }
+
+  // Persistent containers inside #slim-knowledge-body: an embed host that holds
+  // the cached iframe (never wiped, so the iframe is never re-parented/reloaded)
+  // and a transient container for the Pinned tab's slim-native content. Built
+  // with createElement (no innerHTML) to satisfy the no-unsanitized lint gate.
+  function _ensureKnContainers() {
     var body = document.getElementById('slim-knowledge-body');
-    if (!body) return;
-    body.textContent = '';
-    if (_knActiveTab === 'notes') renderKnowledgeNotesTab(body);
-    else if (_knActiveTab === 'kb') renderKnowledgeKbTab(body);
-    else renderKnowledgePinnedTab(body);
+    if (!body) return null;
+    var host = document.getElementById('slim-kn-embed-host');
+    if (!host) {
+      host = document.createElement('div');
+      host.id = 'slim-kn-embed-host';
+      host.className = 'slim-kn-embed-host';
+      host.hidden = true;
+      body.appendChild(host);
+    }
+    var transient = document.getElementById('slim-kn-transient');
+    if (!transient) {
+      transient = document.createElement('div');
+      transient.id = 'slim-kn-transient';
+      transient.className = 'slim-kn-transient';
+      body.appendChild(transient);
+    }
+    return { host: host, transient: transient };
+  }
+
+  // Tell the embedded classic /inbox SPA whether its iframe is visible so it can
+  // suspend/resume its own /api/status poll (dashboard/js/refresh.js listens for
+  // this exact message shape). Same-origin, guarded defensively.
+  function _postKnEmbedVisibility(visible) {
+    try {
+      if (_knInboxFrame && _knInboxFrame.contentWindow) {
+        _knInboxFrame.contentWindow.postMessage(
+          { source: 'minions-slim-embed', type: 'visibility', visible: !!visible }, '*');
+      }
+    } catch (e) { /* defensive — same-origin means this should never throw */ }
+  }
+
+  // ── Tab: Notes & Knowledge (classic /inbox embed) ──────────────────
+  // Lazily creates ONE cached iframe pointing at the classic Notes+KB screen
+  // (/inbox?embed=1) and mounts it into the persistent embed host. Subsequent
+  // activations just re-show the same iframe (never recreated), so switching
+  // tabs never reloads it.
+  function renderKnowledgeInboxTab() {
+    var c = _ensureKnContainers();
+    if (!c) return;
+    c.transient.textContent = '';
+    if (!_knInboxFrame) {
+      var frame = document.createElement('iframe');
+      frame.className = 'slim-kn-embed';
+      frame.src = '/inbox?embed=1';
+      frame.title = 'Notes & Knowledge';
+      frame.addEventListener('load', function() {
+        _postKnEmbedVisibility(_knActiveTab === 'inbox');
+      });
+      c.host.appendChild(frame);
+      _knInboxFrame = frame;
+    }
+    c.host.hidden = false;
+    _postKnEmbedVisibility(true);
   }
 
   // ── Tab: Pinned Context ────────────────────────────────────────────
@@ -143,423 +189,10 @@
     renderSlimPinnedList();   // defined in pinned.js; renders into #slim-pinned-list
   }
 
-  // ── Tab: Notes ─────────────────────────────────────────────────────
-  function renderKnowledgeNotesTab(body) {
-    var intro = document.createElement('p');
-    intro.textContent = 'Consolidated team notes (notes.md). Edit and save, or add a note for the next consolidation sweep.';
-    body.appendChild(intro);
-
-    var msg = document.createElement('div');
-    msg.id = 'slim-notes-msg';
-    msg.className = 'kn-msg';
-    body.appendChild(msg);
-
-    var ta = document.createElement('textarea');
-    ta.id = 'slim-notes-content';
-    ta.className = 'linkpr-input kn-notes-textarea';
-    ta.rows = 12;
-    ta.value = 'Loading notes…';
-    ta.disabled = true;
-    body.appendChild(ta);
-
-    var saveRow = document.createElement('div');
-    saveRow.className = 'kn-toolbar kn-toolbar-end';
-    var saveBtn = document.createElement('button');
-    saveBtn.className = 'btn-primary';
-    saveBtn.type = 'button';
-    saveBtn.textContent = 'Save notes.md';
-    saveBtn.disabled = true;
-    saveBtn.addEventListener('click', saveKnowledgeNotes);
-    saveRow.appendChild(saveBtn);
-    body.appendChild(saveRow);
-
-    // Add-a-note (inbox) sub-form.
-    var addHead = document.createElement('div');
-    addHead.className = 'kn-section-head';
-    addHead.textContent = 'Add a note for consolidation';
-    body.appendChild(addHead);
-
-    var titleLabel = document.createElement('label');
-    titleLabel.className = 'linkpr-label';
-    titleLabel.textContent = 'Title';
-    var titleInput = document.createElement('input');
-    titleInput.id = 'slim-note-title';
-    titleInput.className = 'linkpr-input';
-    titleInput.type = 'text';
-    titleInput.placeholder = 'Short summary';
-    titleLabel.appendChild(titleInput);
-    body.appendChild(titleLabel);
-
-    var whatLabel = document.createElement('label');
-    whatLabel.className = 'linkpr-label';
-    whatLabel.textContent = 'Note';
-    var whatInput = document.createElement('textarea');
-    whatInput.id = 'slim-note-what';
-    whatInput.className = 'linkpr-input';
-    whatInput.rows = 3;
-    whatInput.placeholder = 'What did you learn / decide?';
-    whatLabel.appendChild(whatInput);
-    body.appendChild(whatLabel);
-
-    var addRow = document.createElement('div');
-    addRow.className = 'kn-toolbar kn-toolbar-end';
-    var addNoteMsg = document.createElement('span');
-    addNoteMsg.id = 'slim-note-msg';
-    addNoteMsg.className = 'kn-msg kn-msg-inline';
-    addRow.appendChild(addNoteMsg);
-    var addNoteBtn = document.createElement('button');
-    addNoteBtn.className = 'btn-secondary';
-    addNoteBtn.type = 'button';
-    addNoteBtn.textContent = 'Add note';
-    addNoteBtn.addEventListener('click', submitKnowledgeNote);
-    addRow.appendChild(addNoteBtn);
-    body.appendChild(addRow);
-
-    // Load notes.md into the textarea.
-    fetch('/api/notes-full', { headers: { 'Accept': 'text/plain' } })
-      .then(function(r) { return r.ok ? r.text() : Promise.reject(new Error('HTTP ' + r.status)); })
-      .then(function(text) {
-        if (document.getElementById('slim-notes-content') !== ta) return;  // tab switched away
-        ta.value = (text === 'No notes file found.') ? '' : text;
-        ta.disabled = false;
-        saveBtn.disabled = false;
-        _knowledgeCounts.notes = _countNotesEntries(text);
-        renderKnowledgeTile();
-      })
-      .catch(function(e) {
-        ta.value = '';
-        ta.disabled = false;
-        saveBtn.disabled = false;
-        if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Could not load notes: ' + (e.message || e); }
-      });
-  }
-
-  async function saveKnowledgeNotes() {
-    var ta = document.getElementById('slim-notes-content');
-    var msg = document.getElementById('slim-notes-msg');
-    if (!ta) return;
-    if (msg) { msg.style.color = 'var(--muted)'; msg.textContent = 'Saving…'; }
-    try {
-      var res = await fetch('/api/notes-save', {
-        method: 'POST', headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ content: ta.value, file: 'notes.md' }),
-      });
-      var d = await res.json().catch(function() { return {}; });
-      if (!res.ok) throw new Error(d.error || ('HTTP ' + res.status));
-      if (msg) { msg.style.color = 'var(--green)'; msg.textContent = 'Saved.'; }
-      _knowledgeCounts.notes = _countNotesEntries(ta.value);
-      renderKnowledgeTile();
-    } catch (e) {
-      if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Error: ' + (e && e.message ? e.message : 'failed'); }
-    }
-  }
-
-  async function submitKnowledgeNote() {
-    var titleEl = document.getElementById('slim-note-title');
-    var whatEl = document.getElementById('slim-note-what');
-    var msg = document.getElementById('slim-note-msg');
-    var title = titleEl ? (titleEl.value || '').trim() : '';
-    var what = whatEl ? (whatEl.value || '').trim() : '';
-    if (!title) {
-      if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Title is required.'; }
-      return;
-    }
-    if (msg) { msg.style.color = 'var(--muted)'; msg.textContent = 'Adding…'; }
-    try {
-      var res = await fetch('/api/notes', {
-        method: 'POST', headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ title: title, what: what }),
-      });
-      var d = await res.json().catch(function() { return {}; });
-      if (!res.ok) throw new Error(d.error || ('HTTP ' + res.status));
-      if (titleEl) titleEl.value = '';
-      if (whatEl) whatEl.value = '';
-      if (msg) { msg.style.color = 'var(--green)'; msg.textContent = 'Note added for consolidation.'; }
-    } catch (e) {
-      if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Error: ' + (e && e.message ? e.message : 'failed'); }
-    }
-  }
-
-  // ── Tab: KB ────────────────────────────────────────────────────────
-  function renderKnowledgeKbTab(body) {
-    var intro = document.createElement('p');
-    intro.textContent = 'Knowledge base — categorized entries written by consolidation. Click an entry to read it.';
-    body.appendChild(intro);
-
-    var toolbar = document.createElement('div');
-    toolbar.className = 'kn-toolbar';
-    var newBtn = document.createElement('button');
-    newBtn.className = 'linkpr-chip';
-    newBtn.type = 'button';
-    newBtn.textContent = '+ New entry';
-    newBtn.addEventListener('click', function() { toggleKbCreateForm(body); });
-    toolbar.appendChild(newBtn);
-    body.appendChild(toolbar);
-
-    var listMsg = document.createElement('div');
-    listMsg.id = 'slim-kb-list-msg';
-    listMsg.className = 'kn-msg';
-    body.appendChild(listMsg);
-
-    var listWrap = document.createElement('div');
-    listWrap.id = 'slim-kb-list';
-    body.appendChild(listWrap);
-
-    if (_kbData) renderKbList(listWrap);
-    else {
-      var loading = document.createElement('div');
-      loading.className = 'tile-empty';
-      loading.textContent = 'Loading knowledge base…';
-      listWrap.appendChild(loading);
-    }
-    // Always refresh list + pins on open so newly-swept entries appear.
-    Promise.all([
-      fetch('/api/knowledge', { headers: { 'Accept': 'application/json' } }).then(function(r) { return r.ok ? r.json() : null; }).catch(function() { return null; }),
-      loadKbPins(),
-    ]).then(function(results) {
-      if (results[0]) {
-        _kbData = results[0];
-        _knowledgeCounts.kb = _countKbEntries(_kbData);
-        renderKnowledgeTile();
-      }
-      if (_knActiveTab === 'kb') {
-        var lw = document.getElementById('slim-kb-list');
-        if (lw) renderKbList(lw);
-      }
-    });
-  }
-
-  function _kbAllItems() {
-    var items = [];
-    if (!_kbData) return items;
-    Object.keys(_kbData).forEach(function(cat) {
-      if (!Array.isArray(_kbData[cat])) return;
-      _kbData[cat].forEach(function(item) {
-        items.push({ file: item.file, category: cat, title: item.title, agent: item.agent, date: item.date, sortTs: item.sortTs, preview: item.preview });
-      });
-    });
-    return items;
-  }
-
-  function renderKbList(listWrap) {
-    listWrap.textContent = '';
-    var items = _kbAllItems();
-    if (!items.length) {
-      var empty = document.createElement('div');
-      empty.className = 'tile-empty';
-      empty.textContent = 'No knowledge entries yet. Notes are classified here after consolidation.';
-      listWrap.appendChild(empty);
-      return;
-    }
-    // Pinned first, then newest.
-    items.sort(function(a, b) {
-      var ap = isKbPinned(kbPinKey(a.category, a.file));
-      var bp = isKbPinned(kbPinKey(b.category, b.file));
-      if (ap !== bp) return ap ? -1 : 1;
-      return (b.sortTs || 0) - (a.sortTs || 0) || (b.date || '').localeCompare(a.date || '');
-    });
-    var shown = items.slice(0, KB_LIST_CAP);
-    shown.forEach(function(item) {
-      listWrap.appendChild(buildKbRow(item));
-    });
-    if (items.length > shown.length) {
-      var more = document.createElement('div');
-      more.className = 'tile-empty';
-      more.textContent = 'Showing ' + shown.length + ' of ' + items.length + ' entries (newest + pinned first).';
-      listWrap.appendChild(more);
-    }
-  }
-
-  function buildKbRow(item) {
-    var key = kbPinKey(item.category, item.file);
-    var pinned = isKbPinned(key);
-    var row = document.createElement('div');
-    row.className = 'kb-row' + (pinned ? ' kb-row-pinned' : '');
-
-    var top = document.createElement('div');
-    top.className = 'kb-row-top';
-
-    var pinBtn = document.createElement('button');
-    pinBtn.className = 'kb-pin-btn' + (pinned ? ' on' : '');
-    pinBtn.type = 'button';
-    pinBtn.title = pinned ? 'Unpin from KB' : 'Pin in KB';
-    pinBtn.textContent = pinned ? '★' : '☆';
-    pinBtn.addEventListener('click', function(ev) { ev.stopPropagation(); toggleKbPin(key); });
-    top.appendChild(pinBtn);
-
-    var title = document.createElement('span');
-    title.className = 'kb-row-title';
-    title.textContent = item.title || item.file || '(untitled)';
-    title.title = item.title || '';
-    top.appendChild(title);
-    row.appendChild(top);
-
-    var meta = document.createElement('div');
-    meta.className = 'kb-row-meta';
-    meta.textContent = [KB_CAT_LABELS[item.category] || item.category, item.agent || null, item.date || null]
-      .filter(Boolean).join(' · ');
-    row.appendChild(meta);
-
-    if (item.preview) {
-      var prev = document.createElement('div');
-      prev.className = 'kb-row-preview';
-      var t = String(item.preview);
-      prev.textContent = t.length > 200 ? t.slice(0, 200) + '…' : t;
-      row.appendChild(prev);
-    }
-
-    row.addEventListener('click', function() { openKbItem(item.category, item.file); });
-    return row;
-  }
-
-  async function toggleKbPin(key) {
-    var listMsg = document.getElementById('slim-kb-list-msg');
-    if (listMsg) { listMsg.style.color = ''; listMsg.textContent = ''; }
-    try {
-      var res = await fetch('/api/kb-pins/toggle', {
-        method: 'POST', headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ key: key }),
-      });
-      var d = await res.json().catch(function() { return {}; });
-      if (!res.ok) throw new Error(d.error || ('HTTP ' + res.status));
-      if (d.pinned) { if (_kbPins.indexOf(key) === -1) _kbPins.push(key); }
-      else { _kbPins = _kbPins.filter(function(k) { return k !== key; }); }
-      var lw = document.getElementById('slim-kb-list');
-      if (lw) renderKbList(lw);
-    } catch (e) {
-      if (listMsg) { listMsg.style.color = 'var(--red)'; listMsg.textContent = 'Pin toggle failed: ' + (e && e.message ? e.message : e); }
-    }
-  }
-
-  async function openKbItem(category, file) {
-    var body = document.getElementById('slim-knowledge-body');
-    if (!body) return;
-    body.textContent = '';
-    var backRow = document.createElement('div');
-    backRow.className = 'kn-toolbar';
-    var backBtn = document.createElement('button');
-    backBtn.className = 'btn-secondary';
-    backBtn.type = 'button';
-    backBtn.textContent = '← Back to list';
-    backBtn.addEventListener('click', function() { renderKnowledgeTab(); });
-    backRow.appendChild(backBtn);
-    body.appendChild(backRow);
-
-    var head = document.createElement('div');
-    head.className = 'kn-section-head';
-    head.textContent = file;
-    body.appendChild(head);
-
-    var pre = document.createElement('pre');
-    pre.className = 'kb-entry-content';
-    pre.textContent = 'Loading…';
-    body.appendChild(pre);
-
-    try {
-      var res = await fetch('/api/knowledge/' + encodeURIComponent(category) + '/' + encodeURIComponent(file));
-      if (!res.ok) throw new Error('HTTP ' + res.status);
-      var text = await res.text();
-      pre.textContent = text.replace(/^---[\s\S]*?---\n*/m, '');
-    } catch (e) {
-      pre.textContent = 'Failed to load entry: ' + (e && e.message ? e.message : e);
-    }
-  }
-
-  function toggleKbCreateForm(body) {
-    var existing = document.getElementById('slim-kb-create');
-    if (existing) { existing.parentNode.removeChild(existing); return; }
-    var form = document.createElement('div');
-    form.id = 'slim-kb-create';
-    form.className = 'kn-create-form';
-
-    var catLabel = document.createElement('label');
-    catLabel.className = 'linkpr-label';
-    catLabel.textContent = 'Category';
-    var catSel = document.createElement('select');
-    catSel.id = 'slim-kb-category';
-    catSel.className = 'linkpr-input';
-    KB_CREATE_CATS.forEach(function(c) {
-      var opt = document.createElement('option');
-      opt.value = c;
-      opt.textContent = KB_CAT_LABELS[c] || c;
-      catSel.appendChild(opt);
-    });
-    catLabel.appendChild(catSel);
-    form.appendChild(catLabel);
-
-    var titleLabel = document.createElement('label');
-    titleLabel.className = 'linkpr-label';
-    titleLabel.textContent = 'Title';
-    var titleInput = document.createElement('input');
-    titleInput.id = 'slim-kb-title';
-    titleInput.className = 'linkpr-input';
-    titleInput.type = 'text';
-    titleInput.placeholder = 'Entry title';
-    titleLabel.appendChild(titleInput);
-    form.appendChild(titleLabel);
-
-    var contentLabel = document.createElement('label');
-    contentLabel.className = 'linkpr-label';
-    contentLabel.textContent = 'Content';
-    var contentInput = document.createElement('textarea');
-    contentInput.id = 'slim-kb-content';
-    contentInput.className = 'linkpr-input';
-    contentInput.rows = 6;
-    contentInput.placeholder = 'Write your knowledge entry…';
-    contentLabel.appendChild(contentInput);
-    form.appendChild(contentLabel);
-
-    var row = document.createElement('div');
-    row.className = 'kn-toolbar kn-toolbar-end';
-    var msg = document.createElement('span');
-    msg.id = 'slim-kb-create-msg';
-    msg.className = 'kn-msg kn-msg-inline';
-    row.appendChild(msg);
-    var saveBtn = document.createElement('button');
-    saveBtn.className = 'btn-primary';
-    saveBtn.type = 'button';
-    saveBtn.textContent = 'Save entry';
-    saveBtn.addEventListener('click', submitKbEntry);
-    row.appendChild(saveBtn);
-    form.appendChild(row);
-
-    // Insert the form directly after the toolbar (before the list).
-    var listWrap = document.getElementById('slim-kb-list');
-    if (listWrap && listWrap.parentNode) listWrap.parentNode.insertBefore(form, listWrap);
-    else body.appendChild(form);
-  }
-
-  async function submitKbEntry() {
-    var catEl = document.getElementById('slim-kb-category');
-    var titleEl = document.getElementById('slim-kb-title');
-    var contentEl = document.getElementById('slim-kb-content');
-    var msg = document.getElementById('slim-kb-create-msg');
-    var category = catEl ? catEl.value : '';
-    var title = titleEl ? (titleEl.value || '').trim() : '';
-    var content = contentEl ? contentEl.value : '';
-    if (!title || !content.trim()) {
-      if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Title and content are required.'; }
-      return;
-    }
-    if (msg) { msg.style.color = 'var(--muted)'; msg.textContent = 'Saving…'; }
-    try {
-      var res = await fetch('/api/knowledge', {
-        method: 'POST', headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ category: category, title: title, content: content }),
-      });
-      var d = await res.json().catch(function() { return {}; });
-      if (!res.ok) throw new Error(d.error || ('HTTP ' + res.status));
-      // Refresh the list + count, then re-render the KB tab.
-      var kres = await fetch('/api/knowledge', { headers: { 'Accept': 'application/json' } });
-      if (kres.ok) { _kbData = await kres.json(); _knowledgeCounts.kb = _countKbEntries(_kbData); renderKnowledgeTile(); }
-      if (_knActiveTab === 'kb') renderKnowledgeTab();
-    } catch (e) {
-      if (msg) { msg.style.color = 'var(--red)'; msg.textContent = 'Error: ' + (e && e.message ? e.message : 'failed'); }
-    }
-  }
-
   // ── Wiring ─────────────────────────────────────────────────────────
-  bindModalClose('slim-knowledge-modal', 'slim-knowledge-close');
+  // onClose fires on every dismiss path (close-X, backdrop, Esc) so the
+  // embedded /inbox poll is suspended whenever the modal closes.
+  bindModalClose('slim-knowledge-modal', 'slim-knowledge-close', function() { _postKnEmbedVisibility(false); });
   (function bindKnowledgeUi() {
     var tabBar = document.getElementById('slim-kn-tabs');
     if (tabBar) {

package/dashboard/slim/styles.css

@@ -873,8 +873,9 @@
     .pinned-row-actions .btn-secondary { padding: 4px 12px; font-size: var(--text-base); }
     .pinned-row-unpin { color: var(--red); border-color: var(--red); }
 
-    /* Knowledge control panel (slim-knowledge-modal): Pinned Context / Notes /
-       KB tabs in one box. Reuses .tile-* and .pinned-row primitives. */
+    /* Knowledge control panel (slim-knowledge-modal): Pinned Context (slim-
+       native) + Notes & Knowledge (embedded classic /inbox) tabs in one box.
+       Reuses .tile-* and .pinned-row primitives. */
     .slim-knowledge-modal-inner { width: 720px; max-width: calc(100vw - 32px); }
     .kn-tabs { display: flex; gap: 6px; margin-left: 16px; }
     .kn-tab {
@@ -905,51 +906,13 @@
     }
     .kn-msg { font-size: var(--text-base); min-height: 16px; color: var(--muted); }
     .kn-msg-inline { margin-right: auto; }
-    .kn-notes-textarea { font-family: var(--mono, monospace); white-space: pre; }
-    .kn-create-form {
-      border: 1px solid var(--border);
-      border-radius: var(--radius);
-      background: var(--surface2);
-      padding: 12px;
-      margin-bottom: 12px;
-    }
-    /* KB list rows */
-    .kb-row {
-      border: 1px solid var(--border);
-      border-radius: var(--radius);
-      background: var(--surface2);
-      padding: 8px 10px;
-      margin-bottom: 8px;
-      cursor: pointer;
-    }
-    .kb-row:hover { border-color: var(--blue); }
-    .kb-row-pinned { border-color: var(--amber); }
-    .kb-row-top { display: flex; align-items: center; gap: 8px; }
-    .kb-row-title {
-      flex: 1; min-width: 0;
-      font-weight: 600; font-size: var(--text-md); color: var(--text);
-      overflow: hidden; text-overflow: ellipsis; white-space: nowrap;
-    }
-    .kb-pin-btn {
-      flex: 0 0 auto;
-      border: none; background: transparent; cursor: pointer;
-      color: var(--muted); font-size: var(--text-lg); line-height: 1; padding: 0 2px;
-    }
-    .kb-pin-btn.on { color: var(--amber); }
-    .kb-pin-btn:hover { color: var(--amber); }
-    .kb-row-meta { font-size: var(--text-base); color: var(--muted); margin-top: 3px; }
-    .kb-row-preview {
-      margin-top: 5px;
-      font-size: var(--text-base); color: var(--muted); line-height: 1.5;
-      word-break: break-word;
-    }
-    .kb-entry-content {
-      white-space: pre-wrap; word-break: break-word;
-      font-family: var(--mono, monospace); font-size: var(--text-base);
-      color: var(--text); line-height: 1.55;
-      background: var(--surface2); border: 1px solid var(--border);
-      border-radius: var(--radius); padding: 12px; margin: 0;
-      max-height: 60vh; overflow-y: auto;
+    /* Notes & Knowledge tab: the embedded classic /inbox screen. The host div
+       is toggled via the [hidden] attribute — a plain div defaults to
+       display:block when shown and the UA [hidden] rule forces display:none
+       when hidden, so no extra host rule is needed. */
+    .slim-kn-embed {
+      display: block; width: 100%; height: 62vh; min-height: 360px;
+      border: 0; background: var(--bg);
     }
 
     .chat-thinking {

package/docs/auto-discovery.md

@@ -28,8 +28,8 @@ tick()
        syncPrdFromPrs()          Backfill PRD item status from active PRs
        checkPlanCompletion()     Mark plans completed when all features are terminal (done/failed/cancelled)
   2.7 pollPrHumanComments()      Poll PR threads for human comments (wall-clock cadence from prPollCommentsEvery × tickInterval, default ≈ 12min)
-       reconcilePrs() (ADO+GH)   Reconciliation sweep (runs regardless of poll flags)
-      reconcileSharedBranchPrs() Backfill the PR store for shared-branch plans whose aggregate remote PR is untracked/under-linked (runs unconditionally, like the other recovery sweeps)
+       reconcilePrs() (ADO+GH)   Reconciliation sweep (honors the pollingPaused master kill-switch + the per-provider *PrReconcileEnabled flags)
+      reconcileSharedBranchPrs() Backfill the PR store for shared-branch plans whose aggregate remote PR is untracked/under-linked (skipped while pollingPaused is ON)
   2.9 stalled-dispatch sweep     Auto-retry failed items blocking pending deps (every 120 ticks)
   3a. pruneStalePrDispatchesAsync() Clear pending PR dispatches whose underlying PRs no longer warrant action
   3.  dispatch existing pending  Spawn agents for items already durable in dispatch.pending (up to maxConcurrent) — runs BEFORE discovery so a slow pre-dispatch validator can't starve already-queued work
@@ -74,7 +74,7 @@ Inside `discoverFromPrs()`, ADO and GitHub projects first resolve their own prov
 
 **`autoReReviewPrs` gates both re-review paths (`P-e8b1c4d2`).** Re-reviews fire from two places: (1) the open-loop **discovery** path in `engine.js:discoverFromPrs` (PR shows `reviewStatus=waiting` after a fix push), and (2) the **closure-loop** in `engine/lifecycle.js:dispatchReReviewForFix` (a fix WI completes whose meta carries `addresses_review_wi`, queuing the next review against the same PR). The `engine.autoReReviewPrs` toggle is read at BOTH sites so flipping it OFF mutes the entire re-review cycle — not just the discovery sweep. Default ON; flip via Dashboard → Settings → Auto-fix & Review Loop, or `engine.autoReReviewPrs: false` in `config.json`.
 
-**Hard-stop kill-switch (`pollingPaused`).** `engine.pollingPaused: true` is a master override that wins over both `adoPollEnabled` and `ghPollEnabled`. When ON, section 2.6/2.7 of the tick cycle skips `pollPrStatus` and `pollPrHumanComments` for both providers, and `discoverFromPrs` forces `pollEnabled=false` for every project so every per-PR auto-dispatch gate (`autoReviewPrs` / `autoFixBuilds` / `autoFixConflicts` / `autoFixReviewFeedback` / `autoFixHumanComments`) becomes inert. Reconciliation (the recovery sweep that follows section 2.7) is intentionally not gated. The engine logs `[engine] PR polling paused — …` once on the transition from unpaused → paused; routine PR poll log lines resume when cleared. Flip via Dashboard → Settings → Polling, or set `engine.pollingPaused: true` in `config.json`. Default OFF — fresh installs behave identically to before this knob existed.
+**Hard-stop kill-switch (`pollingPaused`).** `engine.pollingPaused: true` is a master override that wins over both `adoPollEnabled` and `ghPollEnabled`. When ON, section 2.6/2.7 of the tick cycle skips `pollPrStatus` and `pollPrHumanComments` for both providers, `discoverFromPrs` forces `pollEnabled=false` for every project so every per-PR auto-dispatch gate (`autoReviewPrs` / `autoFixBuilds` / `autoFixConflicts` / `autoFixReviewFeedback` / `autoFixHumanComments`) becomes inert, and — since W-ms5eljc60090f0d5 — the reconcile tail (`reconcilePrs`, `ghReconcilePrs`, `reconcileSharedBranchPrs`) is skipped too. Reconciliation was previously exempt as a "recovery sweep", but those sweeps walk every tracked PR and issue provider API calls, so the documented emergency pause did not actually stop provider network traffic. The per-provider `*PrReconcileEnabled` flags remain independent whenever the master switch is OFF. The engine logs `[engine] PR polling paused — …` once on the transition from unpaused → paused; routine PR poll log lines resume when cleared. Flip via Dashboard → Settings → Polling, `POST /api/engine/polling/pause`, or set `engine.pollingPaused: true` in `config.json`. Default OFF — fresh installs behave identically to before this knob existed.
 
 **Hard-stop kill-switch (`autoFixPaused`).** `engine.autoFixPaused: true` is a narrower master override that wins over every auto-fix dispatch gate. When ON, `discoverFromPrs` forces `autoFixBuilds` / `autoFixConflicts` / `autoFixReviewFeedback` / `autoFixHumanComments` to false for every project, so no fix agent is auto-dispatched against any PR. Review dispatch (`autoReviewPrs` / `autoReReviewPrs`), PR status / human-comment polling, and reconciliation are intentionally not gated — operators can pause a fix-storm during an incident while still seeing fresh review verdicts and build status. The engine logs `[engine] auto-fix paused — …` once on the transition from unpaused → paused; routine discovery resumes when cleared. Flip via Dashboard → Settings → Auto-fix & Review Loop, or set `engine.autoFixPaused: true` in `config.json`. Default OFF — fresh installs behave identically to before this knob existed.
 
@@ -84,10 +84,10 @@ Inside `discoverFromPrs()`, ADO and GitHub projects first resolve their own prov
 |------|---------|-------|--------------------------------|
 | `adoPrStatusPollEnabled` | `true` | Section 2.6 (ADO `pollPrStatus`) | Yes — status polls honor the master killswitch |
 | `adoPrCommentsPollEnabled` | `true` | Section 2.7 (ADO `pollPrHumanComments`) | Yes |
-| `adoPrReconcileEnabled` | `true` | Section 2.7 tail (ADO `reconcilePrs`) | No — reconcile is a recovery sweep |
+| `adoPrReconcileEnabled` | `true` | Section 2.7 tail (ADO `reconcilePrs`) | Yes — the master killswitch stops provider reconciliation too (W-ms5eljc60090f0d5) |
 | `ghPrStatusPollEnabled` | `true` | Section 2.6 (GitHub `ghPollPrStatus`) | Yes |
 | `ghPrCommentsPollEnabled` | `true` | Section 2.7 (GitHub `ghPollPrHumanComments`) | Yes |
-| `ghPrReconcileEnabled` | `true` | Section 2.7 tail (GitHub `ghReconcilePrs`) | No — reconcile is a recovery sweep |
+| `ghPrReconcileEnabled` | `true` | Section 2.7 tail (GitHub `ghReconcilePrs`) | Yes — the master killswitch stops provider reconciliation too (W-ms5eljc60090f0d5) |
 | `processPendingRebasesEnabled` | `true` | Section 2.6 tail (`processPendingRebases`) | No — rebase processor has no legacy macro |
 
 Resolution order (`shared.resolvePollFlag(engineCfg, granularKey, legacyMacroKey)`): (1) granular flag explicitly set → wins; (2) legacy macro is `false` → propagates `false` to all three axes of that provider (including reconcile); (3) otherwise → `ENGINE_DEFAULTS[granularKey]` (`true`).

package/docs/pr-auto-fix-dispatch.md

@@ -36,10 +36,10 @@ There are two independent operator-facing master flags:
 
 | Flag             | Default | Effect                                                                                                                                                                                                                                                                                          |
 |------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `pollingPaused`  | `false` | Skips `pollPrStatus` + `pollPrHumanComments` for both providers. Forces `pollEnabled=false` in `discoverFromPrs` so every per-PR auto-dispatch gate (`autoReviewPrs` / `autoFixBuilds` / …) becomes inert. Reconciliation (recovery sweep) intentionally still runs. Default OFF — fresh installs behave identically. |
+| `pollingPaused`  | `false` | Skips `pollPrStatus` + `pollPrHumanComments` for both providers, plus the reconcile tail (`reconcilePrs` / `ghReconcilePrs` / `reconcileSharedBranchPrs`) — the master switch stops ALL provider network polling (W-ms5eljc60090f0d5). Forces `pollEnabled=false` in `discoverFromPrs` so every per-PR auto-dispatch gate (`autoReviewPrs` / `autoFixBuilds` / …) becomes inert. Default OFF — fresh installs behave identically. |
 | `autoFixPaused`  | `false` | Narrower: forces `autoFixBuilds` / `autoFixConflicts` / `autoFixReviewFeedback` / `autoFixHumanComments` to `false` for every project. Review dispatch, polling, and reconciliation are intentionally not gated, so operators can stop a fix-storm while still seeing fresh verdicts and build status. Default OFF. |
 
-These compose: setting `pollingPaused: true` plus `autoFixPaused: true` halts *all* automated PR work (review + fix + polling). Setting only `autoFixPaused: true` halts only auto-fix dispatch. Setting only `pollingPaused: true` halts polling and effectively halts dispatch (because the per-PR gates rely on cached poll state), but leaves reconciliation running and lets manual `/api/pull-requests/observe` or operator-driven dispatch still proceed.
+These compose: setting `pollingPaused: true` plus `autoFixPaused: true` halts *all* automated PR work (review + fix + polling). Setting only `autoFixPaused: true` halts only auto-fix dispatch. Setting only `pollingPaused: true` halts polling *and reconciliation* (all provider network traffic) and effectively halts dispatch (because the per-PR gates rely on cached poll state), while still letting manual `/api/pull-requests/observe` or operator-driven dispatch proceed.
 
 Flip via Dashboard → Settings → Polling (`pollingPaused`) / Auto-fix & Review Loop (`autoFixPaused`), or set `engine.<flag>: true` in `config.json`.
 

package/engine/ado.js

@@ -774,6 +774,43 @@ function _hasPendingReReviewWi(pr) {
 
 let _adoTokenCache = { token: null, expiresAt: 0 };
 
+// W-ms5eljc60090f0d5 — Single-flight guard for token acquisition. `forEachActivePr`
+// runs up to five requests concurrently and `adoFetch` re-acquires on every HTML
+// (auth-redirect) body, so without this latch one expired token produced one
+// `az`/`azureauth` shell-out PER in-flight request (a refresh stampede that
+// degrades the whole engine host). Concurrent callers awaiting the same missing
+// token share this promise; it is cleared on BOTH success and failure so a
+// rejected acquisition can never wedge the latch permanently.
+let _adoTokenInflight = null;
+
+// Test seam for the acquisition shell-out. Production callers leave this null and
+// get `acquireAdoToken`; tests set it so `adoFetch`'s internal `getAdoToken()`
+// call (which takes no opts) can be exercised without spawning az/azureauth.
+let _adoTokenAcquireOverride = null;
+function _setAdoTokenAcquirerForTest(fn) { _adoTokenAcquireOverride = (typeof fn === 'function') ? fn : null; }
+
+/**
+ * Generation-safe cache invalidation. An ADO response only proves that the token
+ * IT used is dead — a slower request still carrying a superseded token must not
+ * evict the token a concurrent refresh already installed, or every late response
+ * re-opens the stampede window. Returns true only when the cache was actually
+ * cleared.
+ */
+function _invalidateAdoTokenIfCurrent(usedToken) {
+  const used = typeof usedToken === 'string' ? usedToken : '';
+  if (!used) return false;                                  // request had no token to invalidate
+  if (!_adoTokenCache.token) return false;                  // already cleared by a sibling response
+  if (_adoTokenCache.token !== used) return false;          // a NEWER token is cached — leave it alone
+  _adoTokenCache = { token: null, expiresAt: 0 };
+  return true;
+}
+
+/** Read-only cache peek — exported for testing only. */
+function _peekAdoTokenCacheForTest() { return { ..._adoTokenCache }; }
+
+/** Read-only in-flight peek — exported for testing only. */
+function _getAdoTokenInflightForTest() { return _adoTokenInflight; }
+
 // ── ADO token acquisition backoff + health (W-mqidhwcc000m897e) ──────────────
 // Graduated backoff replaces the old flat 10-min blackout: a single transient
 // blip (broker hiccup, az cold-start, network) now backs off 30s and doubles
@@ -965,13 +1002,30 @@ function isAdoAuthError(err) {
 
 async function getAdoToken(opts = {}) {
   // _acquire is a test seam — production callers pass no args (unchanged).
-  const acquire = opts._acquire || acquireAdoToken;
+  const acquire = opts._acquire || _adoTokenAcquireOverride || acquireAdoToken;
   if (_adoTokenCache.token && Date.now() < _adoTokenCache.expiresAt) {
     return _adoTokenCache.token;
   }
+  // Single-flight: an acquisition is already running, so join it instead of
+  // spawning a second `az`/`azureauth` process. Checked BEFORE the backoff gate
+  // because the in-flight attempt has not recorded a failure yet.
+  if (_adoTokenInflight) return _adoTokenInflight;
   // Graduated backoff — skip acquisition (return null) while backing off so a
   // transient blip doesn't blackout polling/reconciliation for the full cap.
   if (_adoTokenBackoff.isBackingOff()) return null;
+  // NOTE: everything from the cache read to this assignment is synchronous, so
+  // concurrent callers cannot interleave and both start an acquisition.
+  const inflight = _acquireAdoTokenOnce(acquire);
+  _adoTokenInflight = inflight;
+  // Clear on BOTH settle paths. `_acquireAdoTokenOnce` swallows its own errors,
+  // but the identity check keeps a late clear from clobbering a newer attempt.
+  const clear = () => { if (_adoTokenInflight === inflight) _adoTokenInflight = null; };
+  inflight.then(clear, clear);
+  return inflight;
+}
+
+/** One acquisition attempt. Never rejects — resolves to a token string or null. */
+async function _acquireAdoTokenOnce(acquire) {
   try {
     const { token } = await acquire({ execAsync, timeout: 15000 });
     _adoTokenCache = { token, expiresAt: Date.now() + 30 * 60 * 1000 };
@@ -1025,10 +1079,15 @@ async function adoFetch(url, token, opts = {}) {
   if (!res.ok) throw new Error(`ADO API ${method} ${res.status}: ${res.statusText}`);
   const text = await res.text();
   if (!text || text.trimStart().startsWith('<')) {
-    _adoTokenCache = { token: null, expiresAt: 0 };
+    // Generation-safe: only evict the cache when THIS request's token is still
+    // the cached one. A late response carrying a superseded token must not wipe
+    // the token a concurrent refresh already installed. Combined with the
+    // single-flight latch in getAdoToken, N concurrent HTML responses on one
+    // stale token cost exactly ONE acquisition, not N.
+    _invalidateAdoTokenIfCurrent(token);
     if (_retryCount < MAX_RETRIES) {
       const freshToken = await getAdoToken();
-      if (freshToken) {
+      if (freshToken && freshToken !== token) {
         log('info', 'ADO token expired mid-session — refreshed and retrying');
         return adoFetch(url, freshToken, { ...opts, _retryCount: _retryCount + 1 });
       }
@@ -2889,6 +2948,7 @@ function _setAdoThrottleForTest(state, orgBase = 'dev.azure.com/__test__') {
  *  Lets tests exercise functions that call getAdoToken() without invoking azureauth.
  *  Pass null to force getAdoToken() to return null synchronously (no exec). */
 function _setAdoTokenForTest(token) {
+  _adoTokenInflight = null;
   if (token == null) {
     // Clear cache AND open a long backoff window so getAdoToken short-circuits
     // to null without spawning azureauth — otherwise tests would hang on the
@@ -2907,6 +2967,8 @@ function _setAdoTokenForTest(token) {
 /** Reset all token backoff + health + dedup state — exported for testing only. */
 function _resetAdoTokenForTest() {
   _adoTokenCache = { token: null, expiresAt: 0 };
+  _adoTokenInflight = null;
+  _adoTokenAcquireOverride = null;
   _adoTokenBackoff._reset();
   _adoTokenHealth = { lastSuccessAt: 0, lastFailureReason: null, classification: null };
   _adoTokenAuthNoteSent = false;
@@ -3099,6 +3161,11 @@ module.exports = {
   _resetAdoTokenForTest, // exported for testing
   _setAdoTokenBackoffForTest, // exported for testing
   _setAdoTokenAuthNoteWriterForTest, // exported for testing
+  // W-ms5eljc60090f0d5 — single-flight acquisition + generation-safe invalidation
+  _invalidateAdoTokenIfCurrent, // exported for testing
+  _setAdoTokenAcquirerForTest, // exported for testing
+  _peekAdoTokenCacheForTest, // exported for testing
+  _getAdoTokenInflightForTest, // exported for testing
   isAdoThrottled,
   getAdoThrottleState,
   fetchAdoPrMetadata,

package/engine/shared.js

@@ -3201,8 +3201,12 @@ const ENGINE_DEFAULTS = {
   // autoReviewPrs / autoFixReviewFeedback / autoFixHumanComments) all
   // become inert. Default false so a fresh install behaves identically to
   // before this knob existed. Flip via Dashboard → Settings → Polling, or
-  // set `engine.pollingPaused: true` in config.json. Reconciliation still
-  // runs (it's a recovery sweep, not a convenience poll) — see section 2.7.
+  // set `engine.pollingPaused: true` in config.json. W-ms5eljc60090f0d5: the
+  // section 2.7 reconcile tail (reconcilePrs / ghReconcilePrs /
+  // reconcileSharedBranchPrs) is suppressed too — those sweeps walk every
+  // tracked PR and issue provider API calls, so an emergency pause that left
+  // them running did not actually stop provider network traffic. The
+  // per-provider *PrReconcileEnabled flags stay independent while this is off.
   pollingPaused: false, // hard-stop kill-switch / master override (see comment above)
   autoReReviewPrs: true, // auto-dispatch review agents after a PR fix is pushed
   autoFixReviewFeedback: true, // auto-dispatch fix agents for minions review changes-requested verdicts

package/engine.js

@@ -12158,13 +12158,69 @@ const TICK_TIMEOUT_MS = 300000; // 5 min — force-release tick lock if stuck
 // the entire tick loop indefinitely. The outer TICK_TIMEOUT_MS guard only
 // rescues the tick lock; withTickTimeout surfaces the hung operation as an
 // error on that tick so subsequent phases can still run.
-function withTickTimeout(fn, label, ms) {
+//
+// W-ms5eljc60090f0d5 — Promise.race does NOT cancel `fn()`. A phase that blew
+// its deadline keeps running, so a later tick used to launch a SECOND copy of
+// the same phase on top of it (two concurrent pollPrStatus sweeps re-issuing
+// the same provider requests, doubling token/API pressure). `_phaseInFlight`
+// tracks the real underlying promise per label and makes the next invocation
+// of a still-running phase a fast rejection (`tick-phase-busy: …`) instead of
+// an overlapping run. Every call site already catches and logs, so the tick
+// keeps making progress and pending dispatches are still reached.
+//
+// Escape hatch: a promise that NEVER settles would otherwise silence its label
+// forever (fatal for `discoverWork`). Once a slot is older than
+// TICK_PHASE_ABANDON_MS the guard abandons tracking of the wedged run, logs
+// loudly, and lets a fresh invocation through — bounding the pathological
+// overlap to once per abandon-window instead of once per 10s tick.
+const _phaseInFlight = new Map(); // label -> { promise, startedAt }
+
+/** How long a still-running phase may hold its slot before the guard gives up on
+ *  it. Deliberately generous (>= the outer tick-lock force-release window) so it
+ *  only ever fires for genuinely wedged work, never for a merely slow sweep. */
+const TICK_PHASE_ABANDON_MS = 300000; // 5 min
+
+/** True while `label`'s previous invocation is still running (even if it already
+ *  blew its tickOpTimeoutMs deadline). Exported for testing. */
+function isTickPhaseInFlight(label) { return _phaseInFlight.has(label); }
+
+/** Drop all phase-in-flight tracking — exported for testing only. */
+function _resetTickPhasesForTest() { _phaseInFlight.clear(); }
+
+function withTickTimeout(fn, label, ms, opts = {}) {
+  // abandonMs is a test seam — production callers pass no opts.
+  const abandonMs = Number.isFinite(opts.abandonMs) ? opts.abandonMs : TICK_PHASE_ABANDON_MS;
+  const existing = _phaseInFlight.get(label);
+  if (existing) {
+    const ageMs = Date.now() - existing.startedAt;
+    if (ageMs < abandonMs) {
+      return Promise.reject(new Error(`tick-phase-busy: ${label} skipped — a previous invocation is still running (${ageMs}ms)`));
+    }
+    // Wedged past the abandon window: stop waiting on it. The release handler
+    // below is identity-checked, so the abandoned run can never clear the
+    // successor's slot when (if ever) it finally settles.
+    log('warn', `[tick] abandoning wedged phase ${label} after ${ageMs}ms — starting a fresh invocation`);
+    _phaseInFlight.delete(label);
+  }
+  let started;
+  try {
+    started = Promise.resolve(fn());
+  } catch (e) {
+    return Promise.reject(e);
+  }
+  const entry = { promise: started, startedAt: Date.now() };
+  _phaseInFlight.set(label, entry);
+  // Release the slot only when the UNDERLYING work truly settles — not when the
+  // race below rejects. Identity check so a stale settle can't clear a successor.
+  const release = () => { if (_phaseInFlight.get(label) === entry) _phaseInFlight.delete(label); };
+  started.then(release, release);
+  let timer = null;
   return Promise.race([
-    fn(),
-    new Promise((_, reject) =>
-      setTimeout(() => reject(new Error(`tick-timeout: ${label} exceeded ${ms}ms`)), ms)
-    ),
-  ]);
+    started,
+    new Promise((_, reject) => {
+      timer = setTimeout(() => reject(new Error(`tick-timeout: ${label} exceeded ${ms}ms`)), ms);
+    }),
+  ]).finally(() => { if (timer) clearTimeout(timer); });
 }
 
 // P-c2e5a1d9-a — Generation counter that is incremented on every tick start
@@ -12496,9 +12552,14 @@ async function tickInner() {
   // P-a1f3c2d4: engine.pollingPaused is a hard-stop master switch — it overrides
   // both per-provider toggles. When ON, adoPollEnabled and ghPollEnabled are
   // forced to false so the status-poll and human-comment-poll gates below
-  // short-circuit without editing every per-call gate. Reconciliation (the
-  // final block below) is NOT gated — it's a recovery sweep, not a
-  // convenience poll. The same gate is mirrored inside discoverFromPrs.
+  // short-circuit without editing every per-call gate. The same gate is mirrored
+  // inside discoverFromPrs.
+  // W-ms5eljc60090f0d5: reconciliation is now gated too. It was previously exempt
+  // ("recovery sweep, not a convenience poll"), but reconcilePrs / ghReconcilePrs
+  // walk every tracked PR and issue provider API calls, so the documented
+  // emergency stop (POST /api/engine/polling/pause) did not actually stop
+  // provider network traffic. The per-provider *PrReconcileEnabled flags stay
+  // independent whenever the master switch is OFF.
   const pollingPaused = config.engine?.pollingPaused === true;
   if (pollingPaused && _shouldLogPollingPausedOnce()) {
     log('info', '[engine] PR polling paused — engine.pollingPaused=true overrides adoPollEnabled/ghPollEnabled');
@@ -12519,8 +12580,8 @@ async function tickInner() {
   const ghStatusPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'ghPrStatusPollEnabled', 'ghPollEnabled');
   const adoCommentsPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'adoPrCommentsPollEnabled', 'adoPollEnabled');
   const ghCommentsPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'ghPrCommentsPollEnabled', 'ghPollEnabled');
-  const adoReconcileEnabled = resolvePollFlag(config.engine, 'adoPrReconcileEnabled', 'adoPollEnabled');
-  const ghReconcileEnabled = resolvePollFlag(config.engine, 'ghPrReconcileEnabled', 'ghPollEnabled');
+  const adoReconcileEnabled = !pollingPaused && resolvePollFlag(config.engine, 'adoPrReconcileEnabled', 'adoPollEnabled');
+  const ghReconcileEnabled = !pollingPaused && resolvePollFlag(config.engine, 'ghPrReconcileEnabled', 'ghPollEnabled');
   const rebaseProcessorEnabled = resolvePollFlag(config.engine, 'processPendingRebasesEnabled', null);
   const prPollStatusEvery = Math.max(
     1,
@@ -12619,11 +12680,13 @@ async function tickInner() {
     }
     if (commentPolls.length) await Promise.allSettled(commentPolls);
     if (_isTickStale(myGeneration)) return;
-    // P-c4d8e1a3: reconcile gated by *PrReconcileEnabled (default true) — ungated
-    // by ADO/GH throttle trackers (recovery-sweep contract intact). Legacy
-    // adoPollEnabled/ghPollEnabled=false now also silences reconcile via
-    // resolvePollFlag's legacy-macro fallback (documented breaking change).
-    // ADO and GitHub reconciliation are independent and run in parallel.
+    // P-c4d8e1a3: legacy adoPollEnabled/ghPollEnabled=false also silences
+    // reconcile via resolvePollFlag's legacy-macro fallback (documented
+    // breaking change). ADO and GitHub reconcilers are independent and run in
+    // parallel; both are gated by *PrReconcileEnabled (default true) and by the
+    // engine.pollingPaused master kill-switch (W-ms5eljc60090f0d5, so "pause
+    // polling" means zero provider network traffic), but stay ungated by the
+    // ADO/GH throttle trackers (recovery-sweep contract intact).
     const reconcilePolls = [];
     if (adoReconcileEnabled) {
       reconcilePolls.push(withTickTimeout(() => reconcilePrs(config), 'reconcilePrs', tickOpTimeoutMs).catch(err => { log('warn', `ADO PR reconciliation error: ${err?.message || err}${err?.stack ? ' | ' + err.stack.split('\n')[1]?.trim() : ''}`); }));
@@ -12662,12 +12725,16 @@ async function tickInner() {
     // but is untracked / under-linked, so the dashboard renders the single
     // aggregate PR instead of N phantom per-item rows. Host-agnostic and fully
     // self-guarding (per-PRD/per-project try/catch, never creates a remote PR),
-    // so it runs unconditionally in the reconcile phase like the other recovery
-    // sweeps — independent of the ADO/GitHub poll + throttle gates.
-    try {
-      await withTickTimeout(() => reconcileSharedBranchPrs(config), 'reconcileSharedBranchPrs', tickOpTimeoutMs);
-    } catch (err) {
-      log('warn', `[shared-branch-reconcile] sweep error: ${err?.message || err}`);
+    // so it runs independently of the ADO/GitHub per-provider poll + throttle
+    // gates. W-ms5eljc60090f0d5: it DOES query the remote for an open PR, so the
+    // pollingPaused master kill-switch suppresses it too — "pause polling" must
+    // mean zero provider network traffic.
+    if (!pollingPaused) {
+      try {
+        await withTickTimeout(() => reconcileSharedBranchPrs(config), 'reconcileSharedBranchPrs', tickOpTimeoutMs);
+      } catch (err) {
+        log('warn', `[shared-branch-reconcile] sweep error: ${err?.message || err}`);
+      }
     }
     if (_isTickStale(myGeneration)) return;
   }
@@ -13618,6 +13685,8 @@ module.exports = {
   _isTickStale,
   // #421 — exported for testing the per-tick hard timeout path
   _resolveTickHardTimeoutMs,
+  // W-ms5eljc60090f0d5 — exported for testing the phase-in-flight re-entry guard
+  withTickTimeout, isTickPhaseInFlight, _resetTickPhasesForTest,
   _runScheduleBootstrapOnce, // exported for testing
   get _scheduleBootstrapDone() { return _scheduleBootstrapDone; },
   set _scheduleBootstrapDone(v) { _scheduleBootstrapDone = v; },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2440",
+  "version": "0.1.2442",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"