@yemi33/minions 0.1.2439 → 0.1.2440

package/dashboard/js/settings.js

@@ -1960,4 +1960,25 @@ window.MinionsSettings = { openSettings, saveSettings, addProject, removeProject
   } else {
     setTimeout(openWhenReady, 0);
   }
+  // FRESHNESS ON REOPEN (W-ms4ogdc800aa6931): the slim parent now CACHES this
+  // embedded /settings frame (created once, shown/hidden) instead of cold-booting
+  // it per open, so the iframe `load` — and thus the one-shot openSettings() boot
+  // above — fires only ONCE. Re-pull /api/settings + /api/features whenever the
+  // parent re-shows us (visible:true) so a value changed elsewhere isn't stale. A
+  // full openSettings() re-render is cheap here (the SPA is already booted — just
+  // two localhost fetches + a DOM render, no cold boot), so we prefer it over
+  // ad-hoc partial refresh. Reuses the SAME {source:'minions-slim-embed',
+  // type:'visibility'} channel refresh.js already honors (no second postMessage
+  // bus). Embed-mode gated by the isSettingsPath+isEmbed early return above, so a
+  // standalone /settings visit is completely unaffected.
+  try {
+    window.addEventListener('message', function(ev) {
+      if (!ev || ev.origin !== window.location.origin) return;
+      var d = ev.data;
+      if (!d || d.source !== 'minions-slim-embed' || d.type !== 'visibility') return;
+      if (d.visible && typeof openSettings === 'function') {
+        try { openSettings(); } catch (e) { /* transient — next show retries */ }
+      }
+    });
+  } catch (e) { /* defensive — never block the embed boot on this hook */ }
 })();

package/dashboard/slim/js/settings.js

@@ -18,16 +18,44 @@
   // — two stacked "Settings" bars was the duplicate-menu-bar bug
   // (W-mrpbzke4000ie609). Closing is driven from the embedded modal's own close
   // X (wired below to the parent), plus backdrop-click and Escape.
-  function openSlimSettings() {
-    var modal = document.getElementById('slim-settings-modal');
+  // CACHED settings iframe (W-ms4ogdc800aa6931). The old code discarded the
+  // frame on close and appended a BRAND-NEW `/settings?embed=1` iframe on every
+  // open, so each open cold-booted the entire classic SPA + full Settings render
+  // (/api/settings + /api/features + per-agent runtime dropdowns + projects +
+  // routing, plus the SPA's 4s /api/status poll) — the multi-second stall. We
+  // now mirror the cockpit-tile reuse contract (modals-tiles.js
+  // #_getOrCreateEmbedFrame / _showReusableEmbed): create the frame ONCE, keep
+  // it mounted (hidden), and show/hide it. A single background boot replaces N
+  // per-open cold boots; while hidden the embedded SPA's poll is suspended via
+  // the shared {source:'minions-slim-embed',type:'visibility'} message
+  // (refresh.js honors it in embed mode) so the cached frame doesn't poll
+  // /api/status forever off-screen.
+  var _slimSettingsFrame = null;
+
+  // Create (once) the cached settings iframe and return it. Built with
+  // createElement (no innerHTML) to satisfy the dashboard no-unsanitized lint
+  // gate. Starts hidden; a load-time visibility message suspends its poll until
+  // it is shown. Because the frame is cached, its `load` handler fires exactly
+  // ONCE — so the close/Escape wiring is installed here and persists across all
+  // hide/show cycles.
+  function _getOrCreateSettingsFrame() {
+    if (_slimSettingsFrame) return _slimSettingsFrame;
     var body = document.getElementById('slim-settings-body');
-    if (!modal || !body) return;
-    body.textContent = '';
+    if (!body) return null;
+    body.textContent = '';   // drop the "Loading settings…" placeholder (once)
     var frame = document.createElement('iframe');
     frame.className = 'slim-settings-embed';
     frame.src = '/settings?embed=1';
     frame.title = 'Settings';
+    frame.hidden = true;
     frame.addEventListener('load', function() {
+      // Suspend/resume the embedded SPA poll to match current visibility. On a
+      // visible:true the embedded classic Settings also re-pulls /api/settings +
+      // /api/features (see dashboard/js/settings.js#bootSettingsEmbed) — the
+      // same single postMessage channel, no second bus.
+      var modal = document.getElementById('slim-settings-modal');
+      var shown = !!(modal && modal.classList.contains('open'));
+      if (typeof _postEmbedVisibility === 'function') _postEmbedVisibility(frame, shown);
       var frameDocument = frame.contentDocument;
       if (!frameDocument) return;
       // Capture before the classic modal handler so only the parent modal closes.
@@ -53,20 +81,50 @@
       }
     });
     body.appendChild(frame);
+    _slimSettingsFrame = frame;
+    return frame;
+  }
+
+  function openSlimSettings() {
+    var modal = document.getElementById('slim-settings-modal');
+    var frame = _getOrCreateSettingsFrame();
+    if (!modal || !frame) return;
+    frame.hidden = false;
+    // Resume the embedded SPA poll + trigger a fresh /api/settings+/api/features
+    // re-pull (freshness on reopen — the cached frame's `load` fired only once,
+    // so without this a value changed elsewhere would show stale).
+    if (typeof _postEmbedVisibility === 'function') _postEmbedVisibility(frame, true);
     modal.classList.add('open');
   }
 
   function closeSlimSettings() {
-    document.getElementById('slim-settings-modal').classList.remove('open');
+    var modal = document.getElementById('slim-settings-modal');
+    if (!modal) return;
+    // Keep the frame MOUNTED for an instant reopen; just hide it and suspend its
+    // poll (so the cached frame stops polling /api/status in the background).
+    if (_slimSettingsFrame) {
+      if (typeof _postEmbedVisibility === 'function') _postEmbedVisibility(_slimSettingsFrame, false);
+      _slimSettingsFrame.hidden = true;
+    }
+    modal.classList.remove('open');
   }
 
   (function bindSettingsUi() {
     var btn = document.getElementById('slim-settings-btn');
     var backdrop = document.getElementById('slim-settings-modal');
-    if (btn) btn.addEventListener('click', openSlimSettings);
+    if (btn) {
+      btn.addEventListener('click', openSlimSettings);
+      // PREDICTIVE prewarm: the first hover / focus / press of the gear boots the
+      // cached settings frame before the click lands, so the open is an instant
+      // show. Fires at most once (the frame is cached thereafter).
+      var predictivePrewarm = function() { _getOrCreateSettingsFrame(); };
+      btn.addEventListener('pointerenter', predictivePrewarm, { once: true });
+      btn.addEventListener('pointerdown', predictivePrewarm, { once: true });
+      btn.addEventListener('focus', predictivePrewarm, { once: true });
+    }
     // No outer close button: the embedded classic Settings modal's own close X
-    // (wired to the parent in openSlimSettings) is the single close affordance,
-    // alongside backdrop-click and Escape below (W-mrpbzke4000ie609).
+    // (wired to the parent in _getOrCreateSettingsFrame) is the single close
+    // affordance, alongside backdrop-click and Escape below (W-mrpbzke4000ie609).
     if (backdrop) {
       backdrop.addEventListener('click', function(ev) {
         if (ev.target === backdrop) closeSlimSettings();
@@ -78,6 +136,22 @@
     });
   })();
 
+  // Deferred prewarm: boot the cached settings frame AFTER the cockpit's own hot
+  // embed prewarm (modals-tiles.js schedules that at ~800ms) so it never competes
+  // with slim cockpit initial paint. Idle-callback when available, else a delayed
+  // timeout — either way it runs well after first paint. First open then becomes
+  // an instant show instead of a cold boot.
+  (function scheduleSettingsPrewarm() {
+    var warm = function() { try { _getOrCreateSettingsFrame(); } catch (e) { /* skip prewarm */ } };
+    try {
+      if (typeof requestIdleCallback === 'function') {
+        requestIdleCallback(function() { setTimeout(warm, 1200); }, { timeout: 4000 });
+      } else {
+        setTimeout(warm, 1600);
+      }
+    } catch (e) { /* no timers available — skip prewarm, first open cold-boots */ }
+  })();
+
   // POST a feature-flag toggle; throws on a non-2xx so callers can branch on
   // failure. Used by the one-click returnToClassicDashboard().
   async function postFeatureToggle(id, enabled) {

package/dashboard/slim/styles.css

@@ -797,6 +797,12 @@
        outranks the class rules (no !important needed). */
     .slim-tile-embed-host, .slim-tile-transient { display: block; }
     #slim-tile-embed-host iframe[hidden] { display: none; }
+    /* Cached slim Settings frame (W-ms4ogdc800aa6931): like the tile embeds it is
+       created once and shown/hidden rather than cold-booted per open. The
+       .slim-settings-embed class rule above sets display:block, which outranks
+       [hidden]'s UA display:none — so a hidden cached frame must be forced back
+       to none. The id+attr selector outranks the class rule (no !important). */
+    #slim-settings-body iframe[hidden] { display: none; }
     /* Automation tile (Watches · Schedules · Pipelines) — a tabbed composite
        inside the shared wide tile-modal. The tab bar sits above the embedded
        classic screen, so the iframe height leaves room for it (vs the padless

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2439",
+  "version": "0.1.2440",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"