@yemi33/minions 0.1.2437 → 0.1.2438

package/dashboard/js/render-kb.js

@@ -205,17 +205,32 @@ async function kbSweep() {
 }
 
 let _memorySearchUiLoading = false;
+// Lazily loads /assets/memory-search.js, then opens the modal.
+//
+// Both failure paths matter (W-ms5dlone012i457a-c):
+//   - script.onerror  -> the network/404 case
+//   - script.onload but window.MinionsMemorySearch still undefined -> the
+//     script was served but did not register (e.g. a truncated/empty body, or
+//     it threw while evaluating). Dereferencing .open() here used to raise an
+//     uncaught TypeError.
+// In every path the loading latch must be cleared, otherwise the early-return
+// below permanently and silently bricks the button for the rest of the session.
 function openMemorySearchModal() {
   if (window.MinionsMemorySearch) return window.MinionsMemorySearch.open();
   if (_memorySearchUiLoading) return;
   _memorySearchUiLoading = true;
   const script = document.createElement('script');
   script.src = '/assets/memory-search.js';
-  script.onload = () => window.MinionsMemorySearch.open();
-  script.onerror = () => {
+  const fail = () => {
     _memorySearchUiLoading = false;
     showToast('kb-sweep-toast', 'Memory search UI failed to load', false);
   };
+  script.onload = () => {
+    _memorySearchUiLoading = false;
+    if (!window.MinionsMemorySearch) return fail();
+    window.MinionsMemorySearch.open();
+  };
+  script.onerror = fail;
   document.head.appendChild(script);
 }
 
@@ -262,7 +277,24 @@ async function submitKbEntry(e) {
 
 async function kbOpenItem(category, file) {
   try {
-    const content = await fetch('/api/knowledge/' + category + '/' + encodeURIComponent(file)).then(r => r.text());
+    const res = await fetch('/api/knowledge/' + category + '/' + encodeURIComponent(file));
+    // Without this check a 404/500 body was rendered as if it were the entry,
+    // and a 200-with-empty-body opened a completely blank modal with no error
+    // (W-ms5dlone012i457a-c). Surface the failure instead of rendering nothing.
+    if (!res.ok) {
+      document.getElementById('modal-title').textContent = file;
+      const failBody = document.getElementById('modal-body');
+      failBody.replaceChildren();
+      const msg = document.createElement('p');
+      msg.className = 'empty';
+      msg.textContent = res.status === 404
+        ? 'This knowledge entry no longer exists on disk (404). It may have been renamed or swept.'
+        : 'Could not load this knowledge entry (HTTP ' + res.status + ').';
+      failBody.appendChild(msg);
+      document.getElementById('modal').classList.add('open');
+      return;
+    }
+    const content = await res.text();
     const display = content.replace(/^---[\s\S]*?---\n*/m, '');
     document.getElementById('modal-title').textContent = file;
     const modalBody = document.getElementById('modal-body');

package/dashboard.js

@@ -9080,7 +9080,11 @@ const server = http.createServer(async (req, res) => {
       MINIONS_DIR,
     );
     const kbCatDir = path.join(MINIONS_DIR, 'knowledge', cat);
-    const content = safeRead(path.join(kbCatDir, file));
+    // safeReadOrNull (not safeRead): safeRead collapses ENOENT to '', which
+    // made this 404 guard dead code and served a missing entry as 200 with an
+    // empty body — render-kb.js#kbOpenItem then opened a blank modal with no
+    // error. Present-but-empty still reads as '' and correctly returns 200.
+    const content = safeReadOrNull(path.join(kbCatDir, file));
     if (content === null) return jsonReply(res, 404, { error: 'not found', code: 'not-found' });
     res.setHeader('Content-Type', 'text/plain; charset=utf-8');
     res.end(content);
@@ -15825,7 +15829,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       catch { return jsonReply(res, 400, { error: 'invalid path' }); }
       const agentsDir = path.join(MINIONS_DIR, 'agents');
       if (!safePath.startsWith(agentsDir + path.sep)) return jsonReply(res, 400, { error: 'path must be within agents/' });
-      const content = _agentApiCall('readOutputFile', safeRead, safePath);
+      // safeReadOrNull (not safeRead) so a missing log 404s instead of being
+      // served as 200 with an empty body — see the KB read above.
+      const content = _agentApiCall('readOutputFile', safeReadOrNull, safePath);
       if (content === null) return jsonReply(res, 404, { error: 'not found' });
       res.setHeader('Content-Type', 'text/plain; charset=utf-8');
       res.setHeader('Cache-Control', 'no-cache');
@@ -15834,7 +15840,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
     // Knowledge base
     { method: 'GET', path: '/assets/memory-search.js', desc: 'Serve the lazy-loaded structured memory search UI', handler: (req, res) => {
-      const content = safeRead(path.join(MINIONS_DIR, 'dashboard', 'js', 'memory-search.js'));
+      // safeReadOrNull (not safeRead): a 200 with an empty body still fires
+      // the loader's script.onload, leaving window.MinionsMemorySearch
+      // undefined so openMemorySearchModal() throws. 404 lets script.onerror
+      // surface the intended "failed to load" toast instead.
+      const content = safeReadOrNull(path.join(MINIONS_DIR, 'dashboard', 'js', 'memory-search.js'));
       if (content == null) { res.statusCode = 404; return res.end('not found'); }
       res.setHeader('Content-Type', 'application/javascript; charset=utf-8');
       res.setHeader('Cache-Control', 'no-cache');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2437",
+  "version": "0.1.2438",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"