@yemi33/minions 0.1.2424 → 0.1.2425

package/dashboard/js/memory-search.js

@@ -6,31 +6,94 @@
     return node;
   }
 
-  function open() {
-    document.getElementById('modal-title').textContent = 'Structured Memory';
-    const body = document.getElementById('modal-body');
-    body.textContent = '';
+  function chip(label, value) {
+    const span = el('span', 'kb-item-meta-chip');
+    span.textContent = value == null || value === '' ? label : label + ': ' + value;
+    return span;
+  }
+
+  // ── Filter controls ────────────────────────────────────────────────────────
+  function buildControls() {
     const controls = el('div');
-    controls.style.cssText = 'display:flex;gap:8px;margin-bottom:12px';
+    controls.style.cssText = 'display:flex;flex-wrap:wrap;gap:8px;margin-bottom:12px';
+
     const input = el('input');
     input.id = 'memory-search-query';
     input.placeholder = 'Search facts, episodes, paths, or lessons';
-    input.style.cssText = 'flex:1;padding:8px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text)';
+    input.style.cssText = 'flex:1;min-width:220px;padding:8px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text)';
+    input.addEventListener('keydown', event => { if (event.key === 'Enter') search(); });
+
     const status = el('select');
     status.id = 'memory-search-status';
-    for (const value of ['active', 'superseded', 'retracted', 'expired']) {
+    for (const value of ['active', 'candidate', 'superseded', 'retracted', 'expired']) {
       const option = el('option', '', value);
       option.value = value;
       status.appendChild(option);
     }
+
     const button = el('button', 'btn-primary-lg', 'Search');
     button.addEventListener('click', search);
-    input.addEventListener('keydown', event => { if (event.key === 'Enter') search(); });
     controls.append(input, status, button);
-    body.append(controls, el('div', 'empty', 'Searches structured memory across all scopes. Results include provenance and lifecycle status.'));
-    body.lastChild.id = 'memory-search-results';
+
+    // Optional diagnostics filters (P-1ed2fb5f). Blank values are omitted from
+    // the request so an unset filter never narrows the search.
+    const filters = el('div');
+    filters.style.cssText = 'display:flex;flex-wrap:wrap;gap:8px;width:100%';
+    for (const [id, placeholder] of [
+      ['memory-filter-project', 'project'],
+      ['memory-filter-author', 'author'],
+      ['memory-filter-audience', 'audience (author|project-team)'],
+      ['memory-filter-sourceType', 'source type'],
+      ['memory-filter-findingKey', 'finding key (project|pr|source)'],
+    ]) {
+      const field = el('input');
+      field.id = id;
+      field.placeholder = placeholder;
+      field.style.cssText = 'flex:1;min-width:150px;padding:6px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text);font-size:var(--text-base)';
+      field.addEventListener('keydown', event => { if (event.key === 'Enter') search(); });
+      filters.appendChild(field);
+    }
+
+    const wrap = el('div');
+    wrap.append(controls, filters, buildDecisionLookup());
+    return wrap;
+  }
+
+  function buildDecisionLookup() {
+    const row = el('div');
+    row.style.cssText = 'display:flex;flex-wrap:wrap;gap:8px;width:100%;margin-top:8px;padding-top:8px;border-top:1px solid var(--border)';
+    const label = el('span', '', 'Why was a lesson selected/excluded?');
+    label.style.cssText = 'align-self:center;font-size:var(--text-base);color:var(--text-dim)';
+    const wi = el('input');
+    wi.id = 'memory-decision-wi';
+    wi.placeholder = 'work item id';
+    wi.style.cssText = 'flex:1;min-width:150px;padding:6px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text);font-size:var(--text-base)';
+    const dispatch = el('input');
+    dispatch.id = 'memory-decision-dispatch';
+    dispatch.placeholder = 'dispatch id';
+    dispatch.style.cssText = wi.style.cssText;
+    const go = el('button', 'pr-pager-btn', 'Trace decision');
+    go.addEventListener('click', lookupDecision);
+    row.append(label, wi, dispatch, go);
+    return row;
+  }
+
+  function open() {
+    document.getElementById('modal-title').textContent = 'Structured Memory';
+    const body = document.getElementById('modal-body');
+    body.textContent = '';
+    body.append(buildControls());
+    const results = el('div', 'empty', 'Searches structured memory across all scopes. Results include provenance, lifecycle, and promotion state.');
+    results.id = 'memory-search-results';
+    body.appendChild(results);
     document.getElementById('modal').classList.add('open');
-    input.focus();
+    const input = document.getElementById('memory-search-query');
+    if (input) input.focus();
+  }
+
+  function filterValue(id) {
+    const node = document.getElementById(id);
+    return node && node.value ? node.value.trim() : '';
   }
 
   async function search() {
@@ -39,15 +102,30 @@
     const results = document.getElementById('memory-search-results');
     const query = input && input.value.trim();
     if (!query || !results) return;
+    results.className = '';
     results.textContent = 'Searching...';
+    const params = new URLSearchParams({
+      q: query,
+      status: status ? status.value : 'active',
+      limit: '30',
+    });
+    for (const [id, key] of [
+      ['memory-filter-project', 'project'],
+      ['memory-filter-author', 'author'],
+      ['memory-filter-audience', 'audience'],
+      ['memory-filter-sourceType', 'sourceType'],
+      ['memory-filter-findingKey', 'findingKey'],
+    ]) {
+      const value = filterValue(id);
+      if (value) params.set(key, value);
+    }
     try {
-      const url = '/api/memory-records/search?q=' + encodeURIComponent(query)
-        + '&status=' + encodeURIComponent(status ? status.value : 'active') + '&limit=30';
-      const response = await fetch(url);
+      const response = await fetch('/api/memory-records/search?' + params.toString());
       const data = await response.json();
       if (!response.ok) throw new Error(data.error || 'search failed');
       render(data.records || []);
     } catch (error) {
+      results.className = 'empty';
       results.textContent = 'Memory search failed: ' + error.message;
     }
   }
@@ -61,35 +139,293 @@
       results.textContent = 'No matching memory records.';
       return;
     }
-    for (const record of records) {
-      const item = el('div', 'kb-item');
-      item.style.marginBottom = '8px';
-      const body = el('div', 'kb-item-body');
-      body.appendChild(el('div', 'kb-item-title', record.title || record.id));
-      const meta = el('div', 'kb-item-meta');
-      const fields = [
-        record.memoryType,
-        record.scopeType + (record.scopeKey ? ':' + record.scopeKey : ''),
-        record.trust,
-        record.status,
-        record.sourceRef || record.sourcePath || record.sourceType,
-        Number.isFinite(record.ftsRank) ? 'rank ' + record.ftsRank.toFixed(2) : '',
-      ].filter(Boolean);
-      for (const field of fields) meta.appendChild(el('span', '', field));
-      body.appendChild(meta);
-      body.appendChild(el('div', 'kb-item-preview',
-        (record.body || '') + (record.bodyTruncated ? '\n\n[preview truncated]' : '')));
-      const actions = el('div');
-      actions.style.cssText = 'display:flex;gap:6px;margin-top:8px';
-      for (const action of ['pin', record.status === 'active' ? 'retract' : 'restore']) {
-        const button = el('button', 'pr-pager-btn', action);
-        button.addEventListener('click', () => update(record.id, action));
-        actions.appendChild(button);
-      }
-      body.appendChild(actions);
-      item.appendChild(body);
-      results.appendChild(item);
+    for (const record of records) results.appendChild(buildRecordCard(record));
+  }
+
+  // Promotion eligibility (P-1ed2fb5f): an unresolved candidate that has not yet
+  // been promoted or expired is eligible for promotion to an active lesson.
+  function promotionEligibility(record) {
+    const state = (record.metadata && record.metadata.candidateState) || null;
+    if (record.status !== 'candidate') {
+      return { eligible: false, label: 'not a candidate', state };
+    }
+    if (state === 'promoted' || state === 'expired') {
+      return { eligible: false, label: state, state };
+    }
+    return { eligible: true, label: 'promotion-eligible', state: state || 'unresolved' };
+  }
+
+  function buildRecordCard(record) {
+    const meta = record.metadata || {};
+    const item = el('div', 'kb-item');
+    item.style.marginBottom = '8px';
+    const body = el('div', 'kb-item-body');
+
+    // Title + state badge.
+    const header = el('div', 'kb-item-title');
+    header.textContent = record.title || record.id;
+    const state = el('span', 'badge');
+    state.textContent = record.status;
+    state.style.cssText = 'margin-left:8px;font-size:var(--text-sm)';
+    header.appendChild(state);
+    body.appendChild(header);
+
+    // Provenance + confidence + facets metadata row.
+    const metaRow = el('div', 'kb-item-meta');
+    metaRow.appendChild(chip('type', record.memoryType));
+    metaRow.appendChild(chip('scope', record.scopeType + (record.scopeKey ? ':' + record.scopeKey : '')));
+    metaRow.appendChild(chip('trust', record.trust));
+    if (Number.isFinite(record.confidence)) metaRow.appendChild(chip('confidence', record.confidence.toFixed(2)));
+    const provenance = record.sourceRef || record.sourcePath || record.sourceType;
+    if (provenance) metaRow.appendChild(chip('provenance', provenance));
+    if (meta.audience) metaRow.appendChild(chip('audience', meta.audience));
+    if (meta.area) metaRow.appendChild(chip('area', meta.area));
+    if (meta.disposition) metaRow.appendChild(chip('disposition', meta.disposition));
+    if (Number.isFinite(record.ftsRank)) metaRow.appendChild(chip('rank', record.ftsRank.toFixed(2)));
+    body.appendChild(metaRow);
+
+    // Facets (bounded).
+    const facets = Array.isArray(meta.facets) ? meta.facets.slice(0, 12) : [];
+    if (facets.length) {
+      const facetRow = el('div', 'kb-item-meta');
+      for (const facet of facets) facetRow.appendChild(chip('facet', String(facet)));
+      body.appendChild(facetRow);
+    }
+
+    // Promotion eligibility.
+    const eligibility = promotionEligibility(record);
+    const eligibilityRow = el('div', 'kb-item-meta');
+    const eligibilityChip = el('span', 'kb-item-meta-chip', eligibility.label);
+    if (eligibility.eligible) eligibilityChip.style.color = 'var(--good, #3fb950)';
+    eligibilityRow.appendChild(eligibilityChip);
+    if (eligibility.state) eligibilityRow.appendChild(chip('candidate-state', eligibility.state));
+    body.appendChild(eligibilityRow);
+
+    body.appendChild(el('div', 'kb-item-preview',
+      (record.body || '') + (record.bodyTruncated ? '\n\n[preview truncated]' : '')));
+
+    // Actions: existing pin/retract/restore + on-demand lifecycle timeline.
+    const actions = el('div');
+    actions.style.cssText = 'display:flex;gap:6px;margin-top:8px;flex-wrap:wrap';
+    for (const action of ['pin', record.status === 'active' ? 'retract' : 'restore']) {
+      const button = el('button', 'pr-pager-btn', action);
+      button.addEventListener('click', () => update(record.id, action));
+      actions.appendChild(button);
+    }
+    const timeline = el('div');
+    const lifecycleBtn = el('button', 'pr-pager-btn', 'lifecycle');
+    lifecycleBtn.addEventListener('click', () => loadLifecycle(record, timeline));
+    actions.appendChild(lifecycleBtn);
+
+    // Human-approved repository promotion (P-192d3660). Only surfaced for active
+    // review lessons the server marks eligible (high-confidence + >= 2 distinct
+    // valid findings). The action queues a reviewed work item; it never edits a
+    // checkout. `record.repoPromotion` is distinct from the candidate->lesson
+    // `promotionEligibility()` heuristic above.
+    const repo = record.repoPromotion;
+    const promoteHost = el('div');
+    if (repo && repo.eligible) {
+      const promoteBtn = el('button', 'btn-primary-lg', 'Promote to repo');
+      promoteBtn.style.cssText = 'padding:2px 10px;font-size:var(--text-sm)';
+      promoteBtn.addEventListener('click', () => togglePromoteForm(record, promoteHost));
+      actions.appendChild(promoteBtn);
+    } else if (repo && !repo.eligible && Array.isArray(repo.reasons) && repo.reasons.length) {
+      const reasonChip = chip('repo-promotion', repo.reasons.join(', '));
+      reasonChip.style.color = 'var(--text-dim)';
+      actions.appendChild(reasonChip);
+    }
+    body.appendChild(actions);
+    body.appendChild(promoteHost);
+    body.appendChild(timeline);
+
+    item.appendChild(body);
+    return item;
+  }
+
+  // ── Repository promotion form (active lesson -> project skill / instruction) ─
+  function togglePromoteForm(record, host) {
+    if (host.firstChild) { host.textContent = ''; return; }
+    const form = el('div');
+    form.style.cssText = 'border:1px solid var(--border);border-radius:var(--radius-sm);padding:10px;margin-top:6px;display:flex;flex-direction:column;gap:6px';
+    form.appendChild(el('div', 'kb-item-title', 'Promote lesson to repository guidance'));
+
+    const kind = el('select');
+    for (const [value, label] of [['project-skill', 'Project skill'], ['repository-instruction', 'Repository instruction file']]) {
+      const option = el('option', '', label);
+      option.value = value;
+      kind.appendChild(option);
+    }
+
+    const project = el('input');
+    project.value = record.scopeKey || '';
+    project.placeholder = 'project';
+
+    const targetPath = el('input');
+    const pathHint = el('div', 'kb-item-meta');
+    function refreshHint() {
+      pathHint.textContent = '';
+      const isSkill = kind.value === 'project-skill';
+      targetPath.placeholder = isSkill ? 'skill-slug (e.g. verify-branch-before-fix)' : 'CLAUDE.md';
+      pathHint.appendChild(chip('', isSkill
+        ? 'Creates <slug>/SKILL.md via a reviewed PR.'
+        : 'Allowed: CLAUDE.md, AGENTS.md (any dir), .github/copilot-instructions.md'));
+    }
+    kind.addEventListener('change', refreshHint);
+    refreshHint();
+
+    for (const [labelText, control] of [['Target', kind], ['Project', project], ['Path', targetPath]]) {
+      const row = el('div');
+      row.style.cssText = 'display:flex;gap:8px;align-items:center';
+      const label = el('label', '', labelText);
+      label.style.cssText = 'width:64px;font-size:var(--text-sm);color:var(--text-dim)';
+      control.style.cssText = 'flex:1;padding:6px;background:var(--bg);border:1px solid var(--border);border-radius:var(--radius-sm);color:var(--text)';
+      row.append(label, control);
+      form.appendChild(row);
+    }
+    form.appendChild(pathHint);
+
+    const confirm = el('button', 'btn-primary-lg', 'Confirm promotion');
+    confirm.style.cssText = 'align-self:flex-start;padding:4px 12px;font-size:var(--text-sm)';
+    confirm.addEventListener('click', () => submitPromotion(record.id, {
+      targetKind: kind.value,
+      project: project.value.trim(),
+      path: targetPath.value.trim(),
+    }, host));
+    form.appendChild(confirm);
+    host.appendChild(form);
+  }
+
+  async function submitPromotion(id, payload, host) {
+    try {
+      const response = await fetch('/api/memory-records/' + encodeURIComponent(id) + '/promote', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify(payload),
+      });
+      const data = await response.json();
+      if (!response.ok) throw new Error(data.error || 'promotion failed');
+      const message = data.duplicate
+        ? 'Promotion already queued as work item ' + data.workItemId
+        : 'Queued promotion work item ' + data.workItemId;
+      showToast('kb-sweep-toast', message, true);
+      host.textContent = '';
+    } catch (error) {
+      showToast('kb-sweep-toast', 'Promotion failed: ' + error.message, false);
+    }
+  }
+
+  // ── Lifecycle counters + timeline (on-demand per record) ───────────────────
+  async function loadLifecycle(record, container) {
+    container.textContent = 'Loading lifecycle...';
+    const meta = record.metadata || {};
+    const params = new URLSearchParams({ limit: '50' });
+    const findingKey = record.sourceType === 'review-learning'
+      ? (record.sourceRef || meta.findingKey || '') : (meta.findingKey || '');
+    if (findingKey) params.set('findingKey', findingKey);
+    else params.set('memoryId', record.id);
+    try {
+      const response = await fetch('/api/memory-records/lifecycle?' + params.toString());
+      const data = await response.json();
+      if (!response.ok) throw new Error(data.error || 'lifecycle failed');
+      container.textContent = '';
+      container.appendChild(buildLifecycleSection(data.summary || { counters: {}, total: 0 }, data.events || []));
+    } catch (error) {
+      container.textContent = 'Lifecycle failed: ' + error.message;
+    }
+  }
+
+  function buildLifecycleSection(summary, events) {
+    const section = el('div');
+    section.style.cssText = 'margin-top:8px;padding:8px;border:1px solid var(--border);border-radius:var(--radius-sm)';
+    const counters = el('div', 'kb-item-meta');
+    counters.appendChild(chip('events', String(summary.total || 0)));
+    for (const type of Object.keys(summary.counters || {})) {
+      counters.appendChild(chip(type, String(summary.counters[type])));
+    }
+    section.appendChild(counters);
+    if (!events.length) {
+      section.appendChild(el('div', 'kb-item-preview', 'No lifecycle events recorded.'));
+      return section;
+    }
+    const list = el('div');
+    for (const event of events.slice(0, 50)) {
+      const line = el('div', 'kb-item-meta');
+      line.appendChild(chip('when', new Date(event.createdAt).toISOString()));
+      line.appendChild(chip('event', event.eventType));
+      if (event.disposition) line.appendChild(chip('disposition', event.disposition));
+      if (event.agent) line.appendChild(chip('agent', event.agent));
+      if (event.workItemId) line.appendChild(chip('wi', event.workItemId));
+      list.appendChild(line);
+    }
+    section.appendChild(list);
+    return section;
+  }
+
+  // ── Retrieval decision (why selected / excluded) ───────────────────────────
+  async function lookupDecision() {
+    const results = document.getElementById('memory-search-results');
+    if (!results) return;
+    const wi = filterValue('memory-decision-wi');
+    const dispatch = filterValue('memory-decision-dispatch');
+    if (!wi && !dispatch) {
+      results.className = 'empty';
+      results.textContent = 'Enter a work item id or dispatch id to trace a retrieval decision.';
+      return;
+    }
+    const params = new URLSearchParams();
+    if (dispatch) params.set('dispatchId', dispatch);
+    if (wi) params.set('workItemId', wi);
+    results.className = '';
+    results.textContent = 'Tracing decision...';
+    try {
+      const response = await fetch('/api/memory-records/retrieval-decision?' + params.toString());
+      const data = await response.json();
+      if (!response.ok) throw new Error(data.error || 'decision lookup failed');
+      results.textContent = '';
+      results.appendChild(buildDecisionSection(data.trace));
+    } catch (error) {
+      results.className = 'empty';
+      results.textContent = 'Decision lookup failed: ' + error.message;
+    }
+  }
+
+  function buildDecisionSection(trace) {
+    const section = el('div', 'kb-item');
+    const body = el('div', 'kb-item-body');
+    if (!trace) {
+      body.appendChild(el('div', 'empty', 'No retrieval decision recorded for that work item or dispatch.'));
+      section.appendChild(body);
+      return section;
+    }
+    body.appendChild(el('div', 'kb-item-title', 'Retrieval decision'));
+    const metaRow = el('div', 'kb-item-meta');
+    metaRow.appendChild(chip('kind', trace.retrievalKind));
+    if (trace.project) metaRow.appendChild(chip('project', trace.project));
+    if (trace.workItemId) metaRow.appendChild(chip('wi', trace.workItemId));
+    if (trace.dispatchId) metaRow.appendChild(chip('dispatch', trace.dispatchId));
+    metaRow.appendChild(chip('candidates', String(trace.candidateCount)));
+    metaRow.appendChild(chip('selected', String(trace.selectedCount)));
+    if (trace.shadow) metaRow.appendChild(chip('shadow', 'yes'));
+    body.appendChild(metaRow);
+
+    const entries = Array.isArray(trace.decisionTrace) ? trace.decisionTrace : [];
+    if (!entries.length) {
+      body.appendChild(el('div', 'kb-item-preview', 'No per-candidate decision entries.'));
+    }
+    for (const entry of entries) {
+      const line = el('div', 'kb-item-meta');
+      const verdict = el('span', 'kb-item-meta-chip', entry.selected ? 'selected' : 'excluded');
+      verdict.style.color = entry.selected ? 'var(--good, #3fb950)' : 'var(--text-dim)';
+      line.appendChild(verdict);
+      if (entry.id) line.appendChild(chip('id', entry.id));
+      if (Number.isFinite(entry.rank)) line.appendChild(chip('rank', String(entry.rank)));
+      if (Number.isFinite(entry.score)) line.appendChild(chip('score', entry.score.toFixed(3)));
+      const reasons = Array.isArray(entry.reasons) ? entry.reasons : [];
+      for (const reason of reasons) line.appendChild(chip('reason', reason));
+      body.appendChild(line);
     }
+    section.appendChild(body);
+    return section;
   }
 
   async function update(id, action) {
@@ -108,5 +444,14 @@
     }
   }
 
-  window.MinionsMemorySearch = { open };
+  window.MinionsMemorySearch = {
+    open,
+    // Exposed for renderer/DOM-safety tests (P-1ed2fb5f).
+    buildRecordCard,
+    buildLifecycleSection,
+    buildDecisionSection,
+    promotionEligibility,
+    // Repository promotion (P-192d3660).
+    togglePromoteForm,
+  };
 })();

package/dashboard/js/modal-qa.js

@@ -301,12 +301,12 @@ function _qaBuildQueuedHtml(message) {
 }
 
 function _qaBuildLoadingHtml(loadingId, queueCount) {
-  const qaQueueBadge = queueCount > 0 ? ' <span style="font-size:var(--text-xs);color:var(--muted);background:var(--surface);padding:1px 5px;border-radius:8px;border:1px solid var(--border)">+' + queueCount + ' queued</span>' : '';
+  const qaQueueBadge = queueCount > 0 ? ' <span style="font-size:var(--text-sm);color:var(--muted);background:var(--surface);padding:1px 5px;border-radius:8px;border:1px solid var(--border)">+' + queueCount + ' queued</span>' : '';
   return '<div class="modal-qa-loading" id="' + loadingId + '">' +
     '<div class="dot-pulse"><span></span><span></span><span></span></div> ' +
     '<span id="' + loadingId + '-text">Thinking...</span> ' +
     '<span id="' + loadingId + '-time" style="font-size:var(--text-sm);color:var(--muted)"></span>' +
-    ' <button onclick="qaAbort()" style="font-size:var(--text-xs);padding:2px 8px;background:var(--surface2);border:1px solid var(--border);border-radius:4px;color:var(--red);cursor:pointer">Stop</button>' +
+    ' <button onclick="qaAbort()" style="font-size:var(--text-sm);padding:2px 8px;background:var(--surface2);border:1px solid var(--border);border-radius:4px;color:var(--red);cursor:pointer">Stop</button>' +
     qaQueueBadge + '</div>';
 }
 
@@ -357,7 +357,7 @@ function _qaBuildAssistantHtml(text, opts) {
   return '<div class="modal-qa-a" style="' + style + '">' +
     (opts?.isError ? '' : llmCopyBtn()) +
     body +
-    '<div style="font-size:var(--text-xs);color:var(--muted);margin-top:4px;text-align:right;' + pad + '">' + opts.elapsed + 's</div>' +
+    '<div style="font-size:var(--text-sm);color:var(--muted);margin-top:4px;text-align:right;' + pad + '">' + opts.elapsed + 's</div>' +
     '</div>';
 }
 
@@ -392,7 +392,7 @@ function _qaBuildActionFeedbackHtml(actionFeedback) {
 }
 
 function _qaBuildLiveProgressHtml(loadingId, label, elapsedSeconds, segments, queueCount) {
-  const qaQueueBadge = queueCount > 0 ? ' <span style="font-size:var(--text-xs);color:var(--muted);background:var(--surface);padding:1px 5px;border-radius:8px;border:1px solid var(--border)">+' + queueCount + ' queued</span>' : '';
+  const qaQueueBadge = queueCount > 0 ? ' <span style="font-size:var(--text-sm);color:var(--muted);background:var(--surface);padding:1px 5px;border-radius:8px;border:1px solid var(--border)">+' + queueCount + ' queued</span>' : '';
   // Wrap in a column-flex container so the interleaved chain-of-thought (tool
   // calls + partial text in arrival order, via ccSegmentsRender) stacks on top
   // and the progress block sits at the bottom. Overrides the parent
@@ -405,7 +405,7 @@ function _qaBuildLiveProgressHtml(loadingId, label, elapsedSeconds, segments, qu
     '<span class="dot-pulse"><span></span><span></span><span></span></span>' +
     '<span id="' + loadingId + '-text">' + escHtml(label) + '</span>' +
     '<span id="' + loadingId + '-time" style="font-size:var(--text-sm);color:var(--muted)">' + elapsedSeconds + 's</span>' +
-    '<button onclick="qaAbort()" style="font-size:var(--text-xs);padding:2px 8px;background:var(--surface2);border:1px solid var(--border);border-radius:4px;color:var(--red);cursor:pointer">Stop</button>' +
+    '<button onclick="qaAbort()" style="font-size:var(--text-sm);padding:2px 8px;background:var(--surface2);border:1px solid var(--border);border-radius:4px;color:var(--red);cursor:pointer">Stop</button>' +
     qaQueueBadge +
   '</div>';
   html += '</div>';

package/dashboard/js/qa.js

@@ -223,7 +223,7 @@ async function loadQaRunbooks() {
     return '<div class="qa-runbook-row">' +
       '<div class="qa-runbook-main">' +
         '<div class="qa-runbook-name">' + escHtml(rb.name || id) + '</div>' +
-        '<div class="qa-runbook-meta">target: <code>' + escHtml(rb.target || '?') + '</code> · ' +
+        '<div class="qa-runbook-meta">target: <code>' + escHtml(rb.targetName || rb.target || '?') + '</code> · ' +
           stepsCount + ' step' + (stepsCount === 1 ? '' : 's') + ' · ' +
           artifactsCount + ' expected artifact' + (artifactsCount === 1 ? '' : 's') +
         '</div>' +
@@ -267,12 +267,17 @@ async function qaRunRunbook(id) {
   if (!id) return;
   const rb = _qaRunbooksCache.find(function (r) { return (r.id || r.name) === id; });
   const label = rb ? (rb.name || id) : id;
+  const targetName = rb ? (rb.targetName || rb.target || '') : '';
+  if (!targetName) {
+    alert('Cannot dispatch runbook "' + label + '": targetName is missing.');
+    return;
+  }
   if (!confirm('Dispatch a validation agent for runbook "' + label + '"?')) return;
   try {
     const res = await fetch('/api/qa/runbooks/run', {
       method: 'POST',
       headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify({ id }),
+      body: JSON.stringify({ runbookId: id, targetName }),
     });
     if (!res.ok) {
       const txt = await res.text().catch(() => '');
@@ -295,7 +300,9 @@ async function loadQaRuns() {
     const res = await fetch('/api/qa/runs?limit=20');
     if (res.ok) {
       const data = await res.json();
-      items = Array.isArray(data && data.items) ? data.items : (Array.isArray(data) ? data : []);
+      if (data && Array.isArray(data.runs)) items = data.runs;
+      else if (data && Array.isArray(data.items)) items = data.items;
+      else if (Array.isArray(data)) items = data;
     } else if (res.status !== 404) {
       err = new Error('HTTP ' + res.status);
     }
@@ -326,8 +333,8 @@ function _qaRenderRunRow(run) {
   const id = run.id || run.runId || '';
   const status = run.status || 'unknown';
   const statusClass = 'qa-status-' + status.toLowerCase().replace(/[^a-z0-9-]/g, '-');
-  const runbook = run.runbookName || run.runbook || '';
-  const target = run.target || '';
+  const runbook = run.runbookId || run.runbookName || run.runbook || '';
+  const target = run.targetName || run.target || '';
   const ts = run.startedAt || run.createdAt || '';
   const workItemId = run.workItemId || run.workItem || '';
   const agentId = run.agentId || '';
@@ -423,39 +430,44 @@ function _qaRenderArtifactPreviews(runId, artifacts) {
   if (!runId || !Array.isArray(artifacts) || !artifacts.length) return '';
   const parts = [];
   for (const a of artifacts) {
-    // Accept either a string filename or { file, kind } shape. Strip any
-    // path separators so a malicious entry can't escape the /api/qa/artifacts/
-    // namespace — the server is canonical here, but client-side normalization
-    // keeps the URL pattern observable in source-inspection tests.
-    const fileRaw = (typeof a === 'string') ? a : (a && (a.file || a.name || a.path) || '');
+    // Canonical records use { path, type }; retain the retired { file, kind }
+    // shape for older persisted runs.
+    const fileRaw = (typeof a === 'string') ? a : (a && (a.path || a.file || a.name) || '');
     if (!fileRaw) continue;
-    const file = String(fileRaw).split(/[\\/]/).pop();
-    if (!file) continue;
-    const kindHint = (typeof a === 'object' && a && a.kind) ? String(a.kind).toLowerCase() : '';
+    let artifactPath = String(fileRaw).replace(/\\/g, '/');
+    const rootedPrefix = '/engine/qa-artifacts/' + runId + '/';
+    const rootedPath = artifactPath.startsWith('/') ? artifactPath : '/' + artifactPath;
+    const rootedIndex = rootedPath.indexOf(rootedPrefix);
+    if (rootedIndex >= 0) artifactPath = rootedPath.slice(rootedIndex + rootedPrefix.length);
+    const pathParts = artifactPath.split('/');
+    if (!pathParts.length || pathParts.some(p => !p || p === '.' || p === '..' || p.includes('..'))) continue;
+    const file = pathParts[pathParts.length - 1];
+    const typeRaw = (typeof a === 'object' && a) ? (a.type || a.kind || '') : '';
+    const typeHint = String(typeRaw).toLowerCase();
     const ext = (file.match(/\.([a-z0-9]+)$/i) || ['', ''])[1].toLowerCase();
-    const url = '/api/qa/artifacts/' + encodeURIComponent(runId) + '/' + encodeURIComponent(file);
-    if (kindHint === 'screenshot' || ['png', 'jpg', 'jpeg', 'gif', 'webp', 'svg'].includes(ext)) {
+    const url = '/api/qa/artifacts/' + encodeURIComponent(runId) + '/' + encodeURIComponent(artifactPath);
+    if (typeHint === 'screenshot' || ['png', 'jpg', 'jpeg', 'gif', 'webp', 'svg'].includes(ext)) {
       parts.push(
         '<div class="qa-artifact qa-artifact-image">' +
-          '<img src="' + escHtml(url) + '" alt="' + escHtml(file) + '" loading="lazy">' +
-          '<div class="qa-artifact-caption">' + escHtml(file) + '</div>' +
+          '<img src="' + escHtml(url) + '" alt="' + escHtml(artifactPath) + '" loading="lazy">' +
+          '<div class="qa-artifact-caption">' + escHtml(artifactPath) + '</div>' +
         '</div>'
       );
-    } else if (kindHint === 'video' || ['mp4', 'webm', 'ogg', 'mov'].includes(ext)) {
+    } else if (typeHint === 'video' || ['mp4', 'webm', 'ogg', 'mov'].includes(ext)) {
       parts.push(
         '<div class="qa-artifact qa-artifact-video">' +
           '<video controls src="' + escHtml(url) + '"></video>' +
-          '<div class="qa-artifact-caption">' + escHtml(file) + '</div>' +
+          '<div class="qa-artifact-caption">' + escHtml(artifactPath) + '</div>' +
         '</div>'
       );
     } else {
       // Log / text — render an asynchronously-filled <pre>; first 40 lines
       // fetched lazily so we don't N+1-flood the network on every poll.
-      const blockId = 'qa-log-' + runId + '-' + file.replace(/[^a-zA-Z0-9_-]/g, '_');
+      const blockId = 'qa-log-' + runId + '-' + artifactPath.replace(/[^a-zA-Z0-9_-]/g, '_');
       parts.push(
         '<div class="qa-artifact qa-artifact-log">' +
           '<div class="qa-artifact-caption">' +
-            escHtml(file) + ' ' +
+            escHtml(artifactPath) + ' ' +
             '<a href="' + escHtml(url) + '" target="_blank" rel="noopener" class="qa-artifact-fulllink">View full</a>' +
           '</div>' +
           '<pre id="' + escHtml(blockId) + '" class="qa-artifact-log-preview" data-qa-log-url="' + escHtml(url) + '">Loading…</pre>' +
@@ -851,11 +863,12 @@ function _qaSummarizeTarget(target) {
 
 async function _qaSessionPost(url, label, body) {
   try {
-    const res = await fetch(url, {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json' },
-      body: body ? JSON.stringify(body) : '{}',
-    });
+    const options = { method: 'POST' };
+    if (body !== undefined) {
+      options.headers = { 'Content-Type': 'application/json' };
+      options.body = JSON.stringify(body);
+    }
+    const res = await fetch(url, options);
     const json = await res.json().catch(() => ({}));
     if (!res.ok) {
       alert(label + ' failed (' + res.status + '): ' + (json.error || 'unknown'));