@yemi33/minions 0.1.2406 → 0.1.2408

package/dashboard/js/refresh.js

@@ -62,11 +62,11 @@ const _pageCounters = {
     return ws.length + '|' + ws.reduce(function(m, w) { return Math.max(m, new Date(w.last_triggered || 0).getTime() || 0); }, 0);
   },
   meetings: function(d) {
-    // Meetings total comes from /api/meetings-total; list from /state/meetings.
-    if (window._lastMeetingsTotal === undefined) return null;
-    const total = window._lastMeetingsTotal ?? 0;
-    const list = window._lastMeetings || [];
-    return total + '|' + list.reduce(function(s, m) { return s + (m.round || 0); }, 0);
+    // One server summary owns both the active count and signature. Do not mix
+    // independently resolving total/list requests or include terminal history.
+    if (!window._lastMeetingsSummary) return null;
+    const summary = window._lastMeetingsSummary;
+    return (summary.active || 0) + '|' + (summary.sig || '');
   },
   pipelines: function(d) {
     if (!Array.isArray(window._lastPipelines)) return null;
@@ -97,13 +97,17 @@ const _pageCounters = {
   },
 };
 let _prevCounts = {};
+function _isPageActivityRelevant(page, meetingSummary) {
+  return page !== 'meetings' || Number(meetingSummary?.active) > 0;
+}
 function _detectPageChanges(data) {
   var changes = {};
   for (var page in _pageCounters) {
     var sig = _pageCounters[page](data);
     if (sig === null) continue;  // cache not ready yet — skip both compare and record
     var sigStr = String(sig);
-    if (_prevCounts[page] !== undefined && sigStr !== _prevCounts[page]) changes[page] = true;
+    if (_prevCounts[page] !== undefined && sigStr !== _prevCounts[page]
+      && _isPageActivityRelevant(page, window._lastMeetingsSummary)) changes[page] = true;
     _prevCounts[page] = sigStr;
   }
   return changes;
@@ -425,6 +429,18 @@ function _fireCrossSliceRender(key, value) {
   return true;
 }
 
+let _meetingsSummaryRequestSeq = 0;
+function _applyMeetingsSummary(requestSeq, summary) {
+  if (requestSeq !== _meetingsSummaryRequestSeq) return false;
+  if (!summary || typeof summary.active !== 'number' || typeof summary.sig !== 'string') return false;
+  window._lastMeetingsSummary = summary;
+  if (!_isPageActivityRelevant('meetings', summary)) {
+    const link = document.querySelector('.sidebar-link[data-page="meetings"]');
+    if (link) clearNotifBadge(link);
+  }
+  return true;
+}
+
 function _refreshSidebarCounterSummaries() {
   fetch('/api/qa-runs-summary')
     .then(function (r) { return r.ok ? r.json() : null; })
@@ -437,9 +453,10 @@ function _refreshSidebarCounterSummaries() {
     .then(function (r) { return r.ok ? r.json() : null; })
     .then(function (s) { if (s && typeof s === 'object') window._lastQaSessionsSummary = s; })
     .catch(function () { /* sidebar badge degrades to empty */ });
+  const meetingsSummarySeq = ++_meetingsSummaryRequestSeq;
   fetch('/api/meetings-total')
     .then(function (r) { return r.ok ? r.json() : null; })
-    .then(function (s) { if (s && typeof s.total === 'number') window._lastMeetingsTotal = s.total; })
+    .then(function (s) { _applyMeetingsSummary(meetingsSummarySeq, s); })
     .catch(function () { /* optional */ });
   // /api/verify-guides is now fetched in parallel with /api/prd inside the
   // prdProgress block so renderPrd's guideByPlan lookup uses the SAME tick's

package/dashboard.js

@@ -13498,14 +13498,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         builder: () => qaSessionsMod.summarizeActiveSessionsForStatus(),
       });
     }},
-    { method: 'GET', path: '/api/meetings-total', desc: 'Total meeting count (sidebar activity-dot signal — cheaper than fetching /api/meetings)', handler: (req, res) => {
+    { method: 'GET', path: '/api/meetings-total', desc: 'Meeting summary {total, active, sig}; active-only fields drive the sidebar activity dot', handler: (req, res) => {
       return serveFreshJson(req, res, {
         tag: 'meetings-total',
         inputs: [path.join(MINIONS_DIR, 'meetings')],
-        builder: () => {
-          const meetings = meetingMod.getMeetings();
-          return { total: Array.isArray(meetings) ? meetings.length : 0 };
-        },
+        builder: () => meetingMod.summarizeMeetingsForStatus(),
       });
     }},
     { method: 'GET', path: '/api/browser-presence', desc: 'Whether a dashboard browser tab was recently active', handler: (req, res) => {

package/engine/comment-format.js

@@ -57,7 +57,7 @@ function linkifyBrandTrailer(text) {
 //   - model       concrete runtime execution model (optional)
 //   - no field may contain `--` (would close the HTML comment early)
 
-const { normalizeExecutionModel } = require('./execution-model');
+const { normalizeExecutionModel, UNKNOWN_MODEL } = require('./execution-model');
 
 const AGENT_ID_RE = /^[a-z][a-z0-9-]{0,30}$/;
 const KIND_RE = /^[a-z][a-z0-9-]{0,30}$/;
@@ -104,24 +104,63 @@ function _encodeMarkerModel(model) {
   return encoded.includes('--') ? encoded.replace(/-/g, '%2D') : encoded;
 }
 
+// A genuinely-absent model must NOT be recorded in the hidden marker — the
+// `unknown` sentinel is the signal that no runtime/model evidence exists, so we
+// omit the segment entirely (W-mryk8hf1) rather than persisting `model=unknown`.
+function _isKnownModel(model) {
+  return !!model && model !== UNKNOWN_MODEL;
+}
+
 function _buildMarker({ agentId, kind, workItemId, model }) {
   _validateMarkerInputs({ agentId, kind, workItemId, model });
   const wi = (workItemId !== undefined && workItemId !== null) ? ` wi=${workItemId}` : '';
-  const modelPart = model ? ` model=${_encodeMarkerModel(model)}` : '';
+  const modelPart = _isKnownModel(model) ? ` model=${_encodeMarkerModel(model)}` : '';
   return `<!-- minions:agent=${agentId} kind=${kind}${wi}${modelPart} -->`;
 }
 
 const MODEL_SIGNOFF_RE =
   /(\b(?:Review|Reviewed|Fixed|Verified|Rebased) by (?:Minions|\[Minions\]\([^)]+\)) \([^\r\n)]*? · )[^)\r\n]+(\))/g;
 
+// Matches the visible sign-off when its model segment is the `unknown` sentinel,
+// capturing everything up to (but excluding) the ` · unknown` so it can be
+// dropped — turning `(Ripley — Explorer · unknown)` into `(Ripley — Explorer)`.
+const UNKNOWN_MODEL_SIGNOFF_RE =
+  /(\b(?:Review|Reviewed|Fixed|Verified|Rebased) by (?:Minions|\[Minions\]\([^)]+\)) \([^\r\n)]*?) · unknown(\))/g;
+
+/**
+ * Stamp the concrete runtime execution model into the visible sign-off.
+ *
+ * Three cases, mirroring the execution-model resolver's evidence outcomes:
+ *   - known model            → replace the model segment with it.
+ *   - `unknown` sentinel      → the resolver positively determined no runtime/
+ *                               model evidence exists, so omit the whole
+ *                               ` · <model>` segment rather than printing it
+ *                               (W-mryk8hf1). The footer degrades to
+ *                               `(<name> — <role>)`.
+ *   - no opinion (falsy/null) → leave any concrete model the agent wrote
+ *                               intact, but still drop a bare ` · unknown`
+ *                               sentinel so the footer never advertises it.
+ */
 function stampExecutionModel(text, model) {
+  if (typeof text !== 'string') return text;
   const normalized = normalizeExecutionModel(model);
-  if (!normalized || typeof text !== 'string') return text;
-  return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${normalized}${suffix}`);
+  if (_isKnownModel(normalized)) {
+    return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${normalized}${suffix}`);
+  }
+  if (normalized === UNKNOWN_MODEL) {
+    // prefix ends with " · " — drop that separator along with the model segment.
+    return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix.replace(/ · $/, '')}${suffix}`);
+  }
+  return text.replace(UNKNOWN_MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${suffix}`);
 }
 
 function _stampLeadingMarkerModel(text, model) {
-  if (!model || typeof text !== 'string') return text;
+  if (typeof text !== 'string') return text;
+  // Rewrite the leading marker whenever a model value is supplied. A known model
+  // is recorded; the `unknown` sentinel rebuilds the marker without `model=`
+  // (buildMarker omits it), stripping any pre-existing stale model=. A
+  // genuinely-absent (falsy/null) model leaves the marker untouched.
+  if (!normalizeExecutionModel(model)) return text;
   return text.replace(MINIONS_COMMENT_MARKER_RE, (marker, agentId, kind, workItemId) => {
     if (marker !== text.slice(0, marker.length)) return marker;
     return _buildMarker({ agentId, kind, workItemId, model });

package/engine/meeting.js

@@ -399,6 +399,25 @@ function getMeetings() {
   return result;
 }
 
+function summarizeMeetingsForStatus() {
+  const meetings = getMeetings();
+  const activeEntries = [];
+  for (const meeting of meetings) {
+    if (!meeting || typeof meeting !== 'object') continue;
+    const status = String(meeting.status || '').toLowerCase();
+    if (!ACTIVE_MEETING_STATUSES.has(status)) continue;
+    const roundValue = Number(meeting.round);
+    const round = Number.isFinite(roundValue) ? roundValue : 0;
+    activeEntries.push((meeting.id || '') + ':' + status + ':' + round);
+  }
+  activeEntries.sort();
+  return {
+    total: meetings.length,
+    active: activeEntries.length,
+    sig: activeEntries.join(','),
+  };
+}
+
 function getMeeting(id) {
   const filePath = path.join(MEETINGS_DIR, id + '.json');
   const m = safeJson(filePath);
@@ -1023,7 +1042,7 @@ function checkMeetingTimeouts(config) {
   }
 }
 module.exports = {
-  MEETINGS_DIR, getMeetings, getMeeting, saveMeeting, mutateMeeting, createMeeting,
+  MEETINGS_DIR, getMeetings, summarizeMeetingsForStatus, getMeeting, saveMeeting, mutateMeeting, createMeeting,
   invalidateMeetingsCache,
   discoverMeetingWork, collectMeetingFindings, checkMeetingTimeouts,
   addMeetingNote, advanceMeetingRound, endMeeting, archiveMeeting, unarchiveMeeting, deleteMeeting,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2406",
+  "version": "0.1.2408",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"