@yemi33/minions 0.1.2406 → 0.1.2407

package/engine/comment-format.js

@@ -57,7 +57,7 @@ function linkifyBrandTrailer(text) {
 //   - model       concrete runtime execution model (optional)
 //   - no field may contain `--` (would close the HTML comment early)
 
-const { normalizeExecutionModel } = require('./execution-model');
+const { normalizeExecutionModel, UNKNOWN_MODEL } = require('./execution-model');
 
 const AGENT_ID_RE = /^[a-z][a-z0-9-]{0,30}$/;
 const KIND_RE = /^[a-z][a-z0-9-]{0,30}$/;
@@ -104,24 +104,63 @@ function _encodeMarkerModel(model) {
   return encoded.includes('--') ? encoded.replace(/-/g, '%2D') : encoded;
 }
 
+// A genuinely-absent model must NOT be recorded in the hidden marker — the
+// `unknown` sentinel is the signal that no runtime/model evidence exists, so we
+// omit the segment entirely (W-mryk8hf1) rather than persisting `model=unknown`.
+function _isKnownModel(model) {
+  return !!model && model !== UNKNOWN_MODEL;
+}
+
 function _buildMarker({ agentId, kind, workItemId, model }) {
   _validateMarkerInputs({ agentId, kind, workItemId, model });
   const wi = (workItemId !== undefined && workItemId !== null) ? ` wi=${workItemId}` : '';
-  const modelPart = model ? ` model=${_encodeMarkerModel(model)}` : '';
+  const modelPart = _isKnownModel(model) ? ` model=${_encodeMarkerModel(model)}` : '';
   return `<!-- minions:agent=${agentId} kind=${kind}${wi}${modelPart} -->`;
 }
 
 const MODEL_SIGNOFF_RE =
   /(\b(?:Review|Reviewed|Fixed|Verified|Rebased) by (?:Minions|\[Minions\]\([^)]+\)) \([^\r\n)]*? · )[^)\r\n]+(\))/g;
 
+// Matches the visible sign-off when its model segment is the `unknown` sentinel,
+// capturing everything up to (but excluding) the ` · unknown` so it can be
+// dropped — turning `(Ripley — Explorer · unknown)` into `(Ripley — Explorer)`.
+const UNKNOWN_MODEL_SIGNOFF_RE =
+  /(\b(?:Review|Reviewed|Fixed|Verified|Rebased) by (?:Minions|\[Minions\]\([^)]+\)) \([^\r\n)]*?) · unknown(\))/g;
+
+/**
+ * Stamp the concrete runtime execution model into the visible sign-off.
+ *
+ * Three cases, mirroring the execution-model resolver's evidence outcomes:
+ *   - known model            → replace the model segment with it.
+ *   - `unknown` sentinel      → the resolver positively determined no runtime/
+ *                               model evidence exists, so omit the whole
+ *                               ` · <model>` segment rather than printing it
+ *                               (W-mryk8hf1). The footer degrades to
+ *                               `(<name> — <role>)`.
+ *   - no opinion (falsy/null) → leave any concrete model the agent wrote
+ *                               intact, but still drop a bare ` · unknown`
+ *                               sentinel so the footer never advertises it.
+ */
 function stampExecutionModel(text, model) {
+  if (typeof text !== 'string') return text;
   const normalized = normalizeExecutionModel(model);
-  if (!normalized || typeof text !== 'string') return text;
-  return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${normalized}${suffix}`);
+  if (_isKnownModel(normalized)) {
+    return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${normalized}${suffix}`);
+  }
+  if (normalized === UNKNOWN_MODEL) {
+    // prefix ends with " · " — drop that separator along with the model segment.
+    return text.replace(MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix.replace(/ · $/, '')}${suffix}`);
+  }
+  return text.replace(UNKNOWN_MODEL_SIGNOFF_RE, (_match, prefix, suffix) => `${prefix}${suffix}`);
 }
 
 function _stampLeadingMarkerModel(text, model) {
-  if (!model || typeof text !== 'string') return text;
+  if (typeof text !== 'string') return text;
+  // Rewrite the leading marker whenever a model value is supplied. A known model
+  // is recorded; the `unknown` sentinel rebuilds the marker without `model=`
+  // (buildMarker omits it), stripping any pre-existing stale model=. A
+  // genuinely-absent (falsy/null) model leaves the marker untouched.
+  if (!normalizeExecutionModel(model)) return text;
   return text.replace(MINIONS_COMMENT_MARKER_RE, (marker, agentId, kind, workItemId) => {
     if (marker !== text.slice(0, marker.length)) return marker;
     return _buildMarker({ agentId, kind, workItemId, model });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2406",
+  "version": "0.1.2407",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"