@yemi33/minions 0.1.2391 → 0.1.2393

package/dashboard/js/qa.js

@@ -554,6 +554,8 @@ const QA_SESSION_TERMINAL_STATES = new Set(['done', 'failed', 'killed']);
 let _qaSessionsPollInterval = null;
 let _qaSessionsCache = [];
 let _qaRunnersCache = [];
+// Polling replaces the cards every three seconds, so disclosure state lives outside the DOM.
+const _qaExpandedFlows = new Set();
 
 function _stopQaSessionsPoll() {
   if (_qaSessionsPollInterval) {
@@ -706,6 +708,17 @@ function _qaAfterSessionsRender() {
   if (allTerminal) _stopQaSessionsPoll();
 }
 
+function qaSessionFlowsToggle(details) {
+  if (!details) return;
+  const isOpen = details.open;
+  const summary = details.querySelector('.qa-session-flows-summary');
+  if (summary) summary.setAttribute('aria-expanded', isOpen ? 'true' : 'false');
+  const id = details.getAttribute('data-session-id');
+  if (!id) return;
+  if (isOpen) _qaExpandedFlows.add(id);
+  else _qaExpandedFlows.delete(id);
+}
+
 function _qaRenderSessionCard(s) {
   const id = s && s.id || '';
   const state = (s && s.state) || 'unknown';
@@ -749,7 +762,19 @@ function _qaRenderSessionCard(s) {
 
   let body = '';
   if (flowsShort) {
-    body += '<div class="qa-session-flows"><strong>Flows:</strong> ' + escHtml(flowsShort) + '</div>';
+    const flowsOpen = _qaExpandedFlows.has(id);
+    body += '<details class="qa-session-flows"' + (flowsOpen ? ' open' : '') +
+      ' data-session-id="' + escHtml(id) + '" ontoggle="qaSessionFlowsToggle(this)">' +
+        '<summary class="qa-session-flows-summary" aria-expanded="' + (flowsOpen ? 'true' : 'false') + '">' +
+          '<strong class="qa-session-flows-label">Flows:</strong>' +
+          '<span class="qa-session-flows-preview">' + escHtml(flowsShort) + '</span>' +
+          '<span class="qa-session-flows-affordance">' +
+            '<span class="qa-session-flows-expand-label">Show full prompt</span>' +
+            '<span class="qa-session-flows-collapse-label">Hide full prompt</span>' +
+          '</span>' +
+        '</summary>' +
+        '<div class="qa-session-flows-full">' + escHtml(flowsRaw) + '</div>' +
+      '</details>';
   }
   if (state === 'failed' && (failureClass || error)) {
     body += '<div class="qa-session-error"><strong>' + escHtml(failureClass || 'failed') + ':</strong> ' + escHtml(error || summary || 'no details') + '</div>';

package/dashboard/js/refresh.js

@@ -155,7 +155,7 @@ const RENDER_VERSIONS = {
   // chip row into its own non-interactive "Branch" field (W-mr2qjr3b0002522f).
   // Bumped 8→9 for paused pre-dispatch evaluation guidance.
   // Bumped 9→10: row actions now preserve work-item source scope when IDs collide.
-  workItems: 10,
+  workItems: 11,
   skills: 1,
   commands: 1,
   mcpServers: 1,

package/dashboard/js/render-work-items.js

@@ -179,13 +179,9 @@ function wiRow(item) {
     : (item.branchStrategy === 'shared-branch' && item.status === 'done')
       ? '<span style="font-size:var(--text-xs);color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
       : '<span style="color:var(--muted)">—</span>';
-  // W-mqrdn6qq — Non-retryable failures surface their red failReason snippet in
-  // the PR column (not the Agent column). The engine prefixes failReason with
-  // "Non-retryable failure:" and stamps item._failureClass on non-retryable
-  // demotion (engine/dispatch.js writeDispatchResult / force-demote path).
-  var isNonRetryableFail = !!item._failureClass
-    || /^Non-retryable failure:/i.test(item.failReason || '')
-    || /^Project "[^"]+" not found\./i.test(item.failReason || '');
+  // W-mqrdn6qq / W-mrkqc0pl — ALL failure/error snippets (retryable AND
+  // non-retryable) surface their red failReason snippet in the PR column,
+  // never the Agent column.
   var failSnippet = item.failReason
     ? '<span style="display:block;font-size:var(--text-xs);color:var(--red)" title="' + escapeHtml(item.failReason) + '">' + escapeHtml(item.failReason.slice(0, 30)) + '</span>'
     : '';
@@ -234,9 +230,8 @@ function wiRow(item) {
       (item.completedAgents && item.completedAgents.length > 0
         ? '<span class="pr-agent">' + escapeHtml(item.completedAgents.join(', ')) + '</span>'
         : '<span class="pr-agent">' + escapeHtml(item.dispatched_to || item.agent || '—') + '</span>') +
-      (failSnippet && !isNonRetryableFail ? failSnippet : '') +
     '</td>' +
-    '<td>' + prLink + (failSnippet && isNonRetryableFail ? failSnippet : '') + '</td>' +
+    '<td>' + prLink + (failSnippet ? failSnippet : '') + '</td>' +
     '<td><span class="pr-date">' + escapeHtml((item.created || '').slice(0, 16).replace('T', ' ')) + '</span></td>' +
     '<td style="white-space:nowrap;font-size:var(--text-xs);color:var(--muted)">' +
       (function() {

package/dashboard/styles.css

@@ -1597,6 +1597,31 @@
     background: var(--surface); padding: var(--space-3);
     border-radius: var(--radius-sm); border: 1px solid var(--border);
   }
+  .qa-session-flows-summary {
+    display: grid; grid-template-columns: auto minmax(0, 1fr) auto;
+    align-items: start; gap: var(--space-2); cursor: pointer; list-style: none;
+  }
+  .qa-session-flows-summary::-webkit-details-marker { display: none; }
+  .qa-session-flows-summary::marker { content: ''; }
+  .qa-session-flows-summary:focus-visible {
+    outline: 2px solid var(--blue); outline-offset: 3px;
+    border-radius: var(--radius-sm);
+  }
+  .qa-session-flows-preview,
+  .qa-session-flows-full { overflow-wrap: anywhere; }
+  .qa-session-flows-affordance {
+    color: var(--blue); font-size: var(--text-xs); white-space: nowrap;
+  }
+  .qa-session-flows-affordance::before { content: '+ '; }
+  .qa-session-flows-collapse-label { display: none; }
+  .qa-session-flows[open] .qa-session-flows-preview { display: none; }
+  .qa-session-flows[open] .qa-session-flows-affordance::before { content: '- '; }
+  .qa-session-flows[open] .qa-session-flows-expand-label { display: none; }
+  .qa-session-flows[open] .qa-session-flows-collapse-label { display: inline; }
+  .qa-session-flows-full {
+    margin-top: var(--space-3); padding-top: var(--space-3);
+    border-top: 1px solid var(--border); white-space: pre-wrap;
+  }
   .qa-session-error {
     font-size: var(--text-base); color: var(--red);
     background: rgba(248, 81, 73, 0.08); padding: var(--space-3);

package/docs/deprecated.json

@@ -1,32 +1,32 @@
 [
   {
     "id": "agent-config-skills-field",
-    "description": "Legacy per-agent descriptive-metadata array `agents.<id>.skills` in config.json, renamed to `agents.<id>.expertise` to remove the name collision with executable runtime/harness skills (SKILL.md). The field is metadata only (capability tags like `architecture`, `bug-fixes`); nothing in the dispatch path reads it for behavior. A read-compat shim honors the old key so operator configs still carrying `skills` (and no `expertise`) keep working.",
+    "description": "Legacy per-agent descriptive-metadata array `agents.<id>.skills` in config.json, renamed to `agents.<id>.expertise` to remove the name collision with executable runtime/harness skills (SKILL.md). The tags appear in the agent identity prompt and provide a soft preference to `pickReReviewAgentHints` when selecting a re-reviewer; they are not hard routing constraints. A read-compat shim honors the old key so operator configs still carrying `skills` (and no `expertise`) keep working.",
     "code": [
       {
         "file": "engine/playbook.js",
-        "lines": "950",
+        "lines": "1094",
         "note": "buildSystemPrompt reads `agent.expertise ?? agent.skills ?? []` for the `Expertise:` identity line"
       },
       {
         "file": "engine/lifecycle.js",
-        "lines": "4620-4621",
+        "lines": "5317-5321",
         "note": "pickReReviewAgentHints reads `agent.expertise` with an `agent.skills` array fallback"
       },
       {
         "file": "engine/queries.js",
-        "lines": "731",
+        "lines": "830-832",
         "note": "getAgents normalizes `expertise: a.expertise ?? a.skills ?? []` so the dashboard/settings UI always receives `expertise`"
       },
       {
         "file": "dashboard.js",
-        "lines": "10708-10716",
+        "lines": "11245-11252",
         "note": "settings POST accepts a legacy `updates.skills` key, persists as `config.agents[id].expertise`, and deletes the old `skills` key"
       }
     ],
     "removalGate": "Telemetry / a config sweep across all known engines must show no persisted `config.agents.<id>.skills` key (only `expertise`) for >=30 consecutive days, confirming every operator config has been re-saved through the dashboard (which drops the legacy key) or hand-migrated.",
     "targetRemovalDate": "2026-09-17",
-    "notes": "Safe to remove on or after 2026-09-17 (~3 release windows) once the removal gate clears. Removal scope: drop the `?? agent.skills` / `?? a.skills` fallbacks in engine/playbook.js:950, engine/lifecycle.js:4620-4621, and engine/queries.js:731; drop the `updates.skills` legacy branch + `delete config.agents[id].skills` in dashboard.js:10708-10716; and update docs/named-agents.md to stop mentioning the legacy key. Does NOT touch the unrelated executable-skills system (queries.js harnesses, runtime adapters, dashboard renderSkills, SKILL.md tooling)."
+    "notes": "Safe to remove on or after 2026-09-17 (~3 release windows) once the removal gate clears. Removal scope: drop the `?? agent.skills` / `?? a.skills` fallbacks in engine/playbook.js:1094, engine/lifecycle.js:5317-5319, and engine/queries.js:832; drop the `updates.skills` legacy branch + `delete config.agents[id].skills` in dashboard.js:11245-11252; and update docs/named-agents.md to stop mentioning the legacy key. Does NOT touch the unrelated executable-skills system (queries.js harnesses, runtime adapters, dashboard renderSkills, SKILL.md tooling)."
   },
   {
     "id": "config-poll-key-migration",

package/docs/pr-auto-fix-dispatch.md

@@ -51,7 +51,7 @@ Independent of the master kill-switches, each PR tracks repeated no-op fix outco
 2. Click the red chip → `POST /api/pull-requests/clear-paused-cause` with `{ prId, cause }`.
 3. Direct API call to the same endpoint.
 
-This per-PR per-cause pause is unrelated to `autoFixPaused`. Cause keys are validated against `shared.PR_FIX_CAUSE` (e.g. `BUILD_FAILURE`, `REVIEW_FEEDBACK`, `HUMAN_FEEDBACK`, `MERGE_CONFLICT`, `PR_FIX`). Full mechanics in [`docs/pr-review-fix-loop.md`](pr-review-fix-loop.md) §4E.
+This per-PR per-cause pause is unrelated to `autoFixPaused`. Cause values are validated against `Object.values(shared.PR_FIX_CAUSE)` (`human-feedback`, `review-feedback`, `build-failure`, `merge-conflict`, or `pr-fix`). Full mechanics in [`docs/pr-review-fix-loop.md`](pr-review-fix-loop.md) §4E.
 
 ## Key files