@yemi33/minions 0.1.2390 → 0.1.2392

package/dashboard/js/refresh.js

@@ -155,7 +155,7 @@ const RENDER_VERSIONS = {
   // chip row into its own non-interactive "Branch" field (W-mr2qjr3b0002522f).
   // Bumped 8→9 for paused pre-dispatch evaluation guidance.
   // Bumped 9→10: row actions now preserve work-item source scope when IDs collide.
-  workItems: 10,
+  workItems: 11,
   skills: 1,
   commands: 1,
   mcpServers: 1,

package/dashboard/js/render-work-items.js

@@ -179,13 +179,9 @@ function wiRow(item) {
     : (item.branchStrategy === 'shared-branch' && item.status === 'done')
       ? '<span style="font-size:var(--text-xs);color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
       : '<span style="color:var(--muted)">—</span>';
-  // W-mqrdn6qq — Non-retryable failures surface their red failReason snippet in
-  // the PR column (not the Agent column). The engine prefixes failReason with
-  // "Non-retryable failure:" and stamps item._failureClass on non-retryable
-  // demotion (engine/dispatch.js writeDispatchResult / force-demote path).
-  var isNonRetryableFail = !!item._failureClass
-    || /^Non-retryable failure:/i.test(item.failReason || '')
-    || /^Project "[^"]+" not found\./i.test(item.failReason || '');
+  // W-mqrdn6qq / W-mrkqc0pl — ALL failure/error snippets (retryable AND
+  // non-retryable) surface their red failReason snippet in the PR column,
+  // never the Agent column.
   var failSnippet = item.failReason
     ? '<span style="display:block;font-size:var(--text-xs);color:var(--red)" title="' + escapeHtml(item.failReason) + '">' + escapeHtml(item.failReason.slice(0, 30)) + '</span>'
     : '';
@@ -234,9 +230,8 @@ function wiRow(item) {
       (item.completedAgents && item.completedAgents.length > 0
         ? '<span class="pr-agent">' + escapeHtml(item.completedAgents.join(', ')) + '</span>'
         : '<span class="pr-agent">' + escapeHtml(item.dispatched_to || item.agent || '—') + '</span>') +
-      (failSnippet && !isNonRetryableFail ? failSnippet : '') +
     '</td>' +
-    '<td>' + prLink + (failSnippet && isNonRetryableFail ? failSnippet : '') + '</td>' +
+    '<td>' + prLink + (failSnippet ? failSnippet : '') + '</td>' +
     '<td><span class="pr-date">' + escapeHtml((item.created || '').slice(0, 16).replace('T', ' ')) + '</span></td>' +
     '<td style="white-space:nowrap;font-size:var(--text-xs);color:var(--muted)">' +
       (function() {

package/dashboard/js/settings.js

@@ -33,6 +33,38 @@ function _isCurrentModelLoad(scope, key, token) {
   return _modelLoadEpochs[scope][key] === token;
 }
 
+// Per-open dedup cache for /api/runtimes/<name>/models payloads.
+// initRuntimeFleetUI() fans out one model fetch per agent PLUS default + CC.
+// When the whole fleet shares a runtime (the common case) those are
+// byte-identical requests, and each one makes the server reloadConfig() from
+// disk + re-run model discovery. Collapsing them to one request per distinct
+// runtime per Settings open removes the N+2 → 1 duplicate round-trips (measured
+// 10 → 1 for an 8-agent single-runtime fleet). forceRefresh (the ↻ button)
+// bypasses the cache and repopulates it with the fresh list. Transient
+// failures are NOT cached so a blip can't poison every agent cell for the open.
+let _modelFetchCache = new Map();
+function _resetModelFetchCache() { _modelFetchCache = new Map(); }
+function _fetchRuntimeModelsPayload(runtimeName, forceRefresh) {
+  if (!runtimeName) return Promise.resolve({ models: null });
+  if (!forceRefresh) {
+    const cached = _modelFetchCache.get(runtimeName);
+    if (cached) return cached;
+  }
+  const suffix = forceRefresh ? '/models/refresh' : '/models';
+  const p = fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + suffix, forceRefresh ? { method: 'POST' } : undefined)
+    .then(res => (res.ok ? res.json() : null))
+    .catch(() => null)
+    .then(payload => {
+      if (!payload || !Array.isArray(payload.models)) {
+        if (_modelFetchCache.get(runtimeName) === p) _modelFetchCache.delete(runtimeName);
+        return payload || { models: null };
+      }
+      return payload;
+    });
+  _modelFetchCache.set(runtimeName, p);
+  return p;
+}
+
 async function openSettings() {
   document.getElementById('modal-title').textContent = 'Settings';
   document.getElementById('modal-body').innerHTML = '<p style="color:var(--muted)">Loading...</p>';
@@ -719,8 +751,16 @@ async function openSettings() {
   // hides unmatched rows so operators can see results without tab-hopping.
   const searchInput = document.getElementById('settings-search');
   if (searchInput) {
+    // Debounce the filter: _applySettingsSearch runs several full-DOM
+    // querySelectorAll scans and reads textContent of every [data-search] row
+    // (a forced reflow). Firing that per-keystroke made typing janky on the
+    // large Settings DOM. The field itself stays instant; only the filter
+    // computation is coalesced to the last keystroke in a ~120ms window.
+    let _searchDebounce = null;
     searchInput.addEventListener('input', function() {
-      _applySettingsSearch(searchInput.value || '');
+      const val = searchInput.value || '';
+      if (_searchDebounce) clearTimeout(_searchDebounce);
+      _searchDebounce = setTimeout(function() { _applySettingsSearch(val); }, 120);
     });
   }
 
@@ -822,6 +862,9 @@ async function initRuntimeFleetUI(engineCfg, agentsCfg) {
   const ccCliSelect = document.getElementById('set-ccCli');
   if (!cliSelect || !ccCliSelect) return;
 
+  // Fresh cache per Settings open so a config change between opens is picked up.
+  _resetModelFetchCache();
+
   // Fetch the registry; render an empty fallback on failure so the rest of the
   // settings panel still works.
   let runtimes = [];
@@ -917,11 +960,7 @@ async function loadModelsForRuntime(runtimeName, inputId, currentValue, forceRef
     return;
   }
   let payload = { models: null };
-  try {
-    const suffix = forceRefresh ? '/models/refresh' : '/models';
-    const res = await fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + suffix, forceRefresh ? { method: 'POST' } : undefined);
-    if (res.ok) payload = await res.json();
-  } catch { /* fall through to free-text */ }
+  payload = await _fetchRuntimeModelsPayload(runtimeName, forceRefresh);
 
   if (!_isCurrentModelLoad('runtime', inputId, token)) return;
   const models = Array.isArray(payload.models) ? payload.models : null;
@@ -962,10 +1001,7 @@ async function loadModelsForAgent(agentId, runtimeName, currentValue) {
     return;
   }
   let payload = { models: null };
-  try {
-    const res = await fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + '/models');
-    if (res.ok) payload = await res.json();
-  } catch { /* fall through to free-text */ }
+  payload = await _fetchRuntimeModelsPayload(runtimeName, false);
 
   if (!_isCurrentModelLoad('agent', agentId, token)) return;
   const models = Array.isArray(payload.models) ? payload.models : null;

package/docs/deprecated.json

@@ -1,32 +1,32 @@
 [
   {
     "id": "agent-config-skills-field",
-    "description": "Legacy per-agent descriptive-metadata array `agents.<id>.skills` in config.json, renamed to `agents.<id>.expertise` to remove the name collision with executable runtime/harness skills (SKILL.md). The field is metadata only (capability tags like `architecture`, `bug-fixes`); nothing in the dispatch path reads it for behavior. A read-compat shim honors the old key so operator configs still carrying `skills` (and no `expertise`) keep working.",
+    "description": "Legacy per-agent descriptive-metadata array `agents.<id>.skills` in config.json, renamed to `agents.<id>.expertise` to remove the name collision with executable runtime/harness skills (SKILL.md). The tags appear in the agent identity prompt and provide a soft preference to `pickReReviewAgentHints` when selecting a re-reviewer; they are not hard routing constraints. A read-compat shim honors the old key so operator configs still carrying `skills` (and no `expertise`) keep working.",
     "code": [
       {
         "file": "engine/playbook.js",
-        "lines": "950",
+        "lines": "1094",
         "note": "buildSystemPrompt reads `agent.expertise ?? agent.skills ?? []` for the `Expertise:` identity line"
       },
       {
         "file": "engine/lifecycle.js",
-        "lines": "4620-4621",
+        "lines": "5317-5321",
         "note": "pickReReviewAgentHints reads `agent.expertise` with an `agent.skills` array fallback"
       },
       {
         "file": "engine/queries.js",
-        "lines": "731",
+        "lines": "830-832",
         "note": "getAgents normalizes `expertise: a.expertise ?? a.skills ?? []` so the dashboard/settings UI always receives `expertise`"
       },
       {
         "file": "dashboard.js",
-        "lines": "10708-10716",
+        "lines": "11245-11252",
         "note": "settings POST accepts a legacy `updates.skills` key, persists as `config.agents[id].expertise`, and deletes the old `skills` key"
       }
     ],
     "removalGate": "Telemetry / a config sweep across all known engines must show no persisted `config.agents.<id>.skills` key (only `expertise`) for >=30 consecutive days, confirming every operator config has been re-saved through the dashboard (which drops the legacy key) or hand-migrated.",
     "targetRemovalDate": "2026-09-17",
-    "notes": "Safe to remove on or after 2026-09-17 (~3 release windows) once the removal gate clears. Removal scope: drop the `?? agent.skills` / `?? a.skills` fallbacks in engine/playbook.js:950, engine/lifecycle.js:4620-4621, and engine/queries.js:731; drop the `updates.skills` legacy branch + `delete config.agents[id].skills` in dashboard.js:10708-10716; and update docs/named-agents.md to stop mentioning the legacy key. Does NOT touch the unrelated executable-skills system (queries.js harnesses, runtime adapters, dashboard renderSkills, SKILL.md tooling)."
+    "notes": "Safe to remove on or after 2026-09-17 (~3 release windows) once the removal gate clears. Removal scope: drop the `?? agent.skills` / `?? a.skills` fallbacks in engine/playbook.js:1094, engine/lifecycle.js:5317-5319, and engine/queries.js:832; drop the `updates.skills` legacy branch + `delete config.agents[id].skills` in dashboard.js:11245-11252; and update docs/named-agents.md to stop mentioning the legacy key. Does NOT touch the unrelated executable-skills system (queries.js harnesses, runtime adapters, dashboard renderSkills, SKILL.md tooling)."
   },
   {
     "id": "config-poll-key-migration",