@yemi33/minions 0.1.2378 → 0.1.2380

package/engine/prd-store.js

@@ -1,9 +1,6 @@
 // engine/prd-store.js
 //
-// SQL-authoritative PRD state. Paths are retained as stable identifiers for
-// existing callers, but no runtime PRD JSON is read or written here.
-
-const path = require('path');
+// SQL-authoritative PRD state.
 
 function _toMs(v) {
   if (v == null) return null;
@@ -13,28 +10,12 @@ function _toMs(v) {
 }
 function _bool01(v) { return v ? 1 : 0; }
 
-// Resolve <MINIONS_DIR>/prd/<f>.json → {filename, archived:0}; the
-// prd/archive/<f>.json variant → {filename, archived:1}; anything else → null.
-// Path comparison is normalized + case-insensitive on the directory prefix so
-// Windows drive-letter / separator differences don't cause a miss.
-function parsePrdPath(filePath) {
-  if (!filePath || typeof filePath !== 'string') return null;
-  let minionsDir;
-  try { minionsDir = require('./shared').MINIONS_DIR; } catch { return null; }
-  if (!minionsDir) return null;
-  const norm = (p) => path.resolve(p).replace(/\\/g, '/').toLowerCase();
-  const full = norm(filePath);
-  const prdRoot = norm(path.join(minionsDir, 'prd'));
-  const archiveRoot = norm(path.join(minionsDir, 'prd', 'archive'));
-  if (!full.endsWith('.json')) return null;
-  const base = path.basename(filePath);
-  if (full === norm(path.join(archiveRoot, base)) && full.startsWith(archiveRoot + '/')) {
-    return { filename: base, archived: 1 };
-  }
-  if (full === norm(path.join(prdRoot, base)) && full.startsWith(prdRoot + '/')) {
-    return { filename: base, archived: 0 };
+function _validatePrdFilename(filename) {
+  if (typeof filename !== 'string' || !filename.endsWith('.json')
+      || filename.includes('/') || filename.includes('\\') || filename === '.json') {
+    throw new TypeError('PRD filename must be a basename ending in .json');
   }
-  return null;
+  return filename;
 }
 
 // (filename, archived) → plans.id, preferring the same archived bucket.
@@ -48,6 +29,22 @@ function _resolvePlanId(db, sourcePlan, archived) {
 
 // Core upsert: write/replace the prds row + its prd_items + prd_verify_prs for
 // (filename, archived). Returns the prds.id. Runs inside a transaction.
+function _clearWorkItemLinks(db, prdId, predicate = '', params = []) {
+  db.prepare(`
+    UPDATE work_items SET prd_item_id=NULL
+    WHERE prd_item_id IN (
+      SELECT id FROM prd_items WHERE prd_id=? ${predicate}
+    )
+  `).run(prdId, ...params);
+}
+
+function _deletePrdRow(db, prdId) {
+  _clearWorkItemLinks(db, prdId);
+  db.prepare('DELETE FROM prd_items WHERE prd_id=?').run(prdId);
+  db.prepare('DELETE FROM prd_verify_prs WHERE prd_id=?').run(prdId);
+  db.prepare('DELETE FROM prds WHERE id=?').run(prdId);
+}
+
 function _upsertPrd(db, filename, archived, prd, now) {
   const sourcePlan = prd.source_plan || prd.sourcePlan || null;
   const planId = _resolvePlanId(db, sourcePlan, archived);
@@ -98,10 +95,13 @@ function _upsertPrd(db, filename, archived, prd, now) {
   for (const ft of features) { if (ft && typeof ft === 'object' && ft.id) keepIds.push(String(ft.id)); }
   // Drop id-bearing items no longer on the PRD, plus all NULL-feature_id rows.
   if (keepIds.length) {
+    const predicate = `AND feature_id IS NOT NULL AND feature_id NOT IN (${keepIds.map(() => '?').join(',')})`;
+    _clearWorkItemLinks(db, prdId, predicate, keepIds);
     db.prepare(
       `DELETE FROM prd_items WHERE prd_id=? AND feature_id IS NOT NULL AND feature_id NOT IN (${keepIds.map(() => '?').join(',')})`
     ).run(prdId, ...keepIds);
   } else {
+    _clearWorkItemLinks(db, prdId, 'AND feature_id IS NOT NULL');
     db.prepare('DELETE FROM prd_items WHERE prd_id=? AND feature_id IS NOT NULL').run(prdId);
   }
   db.prepare('DELETE FROM prd_items WHERE prd_id=? AND feature_id IS NULL').run(prdId);
@@ -181,27 +181,51 @@ function _upsertPrd(db, filename, archived, prd, now) {
   return prdId;
 }
 
-function writePrd(filePath, prd) {
-  const parsed = parsePrdPath(filePath);
-  if (!parsed || !prd || typeof prd !== 'object' || Array.isArray(prd)) {
-    throw new TypeError('prd-store.writePrd requires a PRD path and object');
+function writePrd(filename, prd, { archived = false } = {}) {
+  _validatePrdFilename(filename);
+  if (!prd || typeof prd !== 'object' || Array.isArray(prd)) {
+    throw new TypeError('prd-store.writePrd requires a filename and object');
   }
   const { getDb, withTransaction } = require('./db');
   const db = getDb();
-  const prdId = withTransaction(db, () => _upsertPrd(db, parsed.filename, parsed.archived, prd, Date.now()));
-  require('./db-events').emitStateEvent('prds', { filename: parsed.filename, archived: parsed.archived });
+  const archivedValue = archived ? 1 : 0;
+  const prdId = withTransaction(db, () => _upsertPrd(db, filename, archivedValue, prd, Date.now()));
+  require('./db-events').emitStateEvent('prds', { filename, archived: archivedValue });
   return { ok: true, id: prdId, plan: prd };
 }
 
-function mutatePrd(filePath, mutator, { defaultValue = {} } = {}) {
-  const parsed = parsePrdPath(filePath);
-  if (!parsed || typeof mutator !== 'function') {
-    throw new TypeError('prd-store.mutatePrd requires a PRD path and mutator');
+function createPrdUnique(baseFilename, prd) {
+  _validatePrdFilename(baseFilename);
+  if (!prd || typeof prd !== 'object' || Array.isArray(prd)) {
+    throw new TypeError('prd-store.createPrdUnique requires a PRD object');
+  }
+  const stem = baseFilename.slice(0, -'.json'.length);
+  const { getDb, withTransaction } = require('./db');
+  const db = getDb();
+  const filename = withTransaction(db, () => {
+    const exists = db.prepare('SELECT 1 FROM prds WHERE filename=? LIMIT 1');
+    for (let attempt = 0; attempt < 100; attempt++) {
+      const candidate = attempt === 0 ? baseFilename : `${stem}-${attempt}.json`;
+      if (exists.get(candidate)) continue;
+      _upsertPrd(db, candidate, 0, prd, Date.now());
+      return candidate;
+    }
+    throw new Error('Could not reserve unique PRD filename after 100 attempts');
+  });
+  require('./db-events').emitStateEvent('prds', { filename, archived: 0 });
+  return filename;
+}
+
+function mutatePrd(filename, mutator, { archived = false, defaultValue = {} } = {}) {
+  _validatePrdFilename(filename);
+  if (typeof mutator !== 'function') {
+    throw new TypeError('prd-store.mutatePrd requires a filename and mutator');
   }
   const { getDb, withTransaction } = require('./db');
   const db = getDb();
   const result = withTransaction(db, () => {
-    const row = db.prepare('SELECT data FROM prds WHERE filename=? AND archived=?').get(parsed.filename, parsed.archived);
+    const archivedValue = archived ? 1 : 0;
+    const row = db.prepare('SELECT data FROM prds WHERE filename=? AND archived=?').get(filename, archivedValue);
     let current = row ? JSON.parse(row.data) : structuredClone(defaultValue);
     if (!current || typeof current !== 'object' || Array.isArray(current)) current = structuredClone(defaultValue);
     const next = mutator(current);
@@ -209,36 +233,33 @@ function mutatePrd(filePath, mutator, { defaultValue = {} } = {}) {
     if (!finalData || typeof finalData !== 'object' || Array.isArray(finalData)) {
       throw new TypeError('PRD mutator must return an object or mutate in place');
     }
-    _upsertPrd(db, parsed.filename, parsed.archived, finalData, Date.now());
+    _upsertPrd(db, filename, archivedValue, finalData, Date.now());
     return finalData;
   });
-  require('./db-events').emitStateEvent('prds', { filename: parsed.filename, archived: parsed.archived });
+  require('./db-events').emitStateEvent('prds', { filename, archived: archived ? 1 : 0 });
   return result;
 }
 
-function deletePrd(filePath) {
-  const parsed = parsePrdPath(filePath);
-  if (!parsed) throw new TypeError('prd-store.deletePrd requires a PRD path');
+function deletePrd(filename, { archived = false } = {}) {
+  _validatePrdFilename(filename);
   const { getDb, withTransaction } = require('./db');
   const db = getDb();
   const removed = withTransaction(db, () => {
-    const row = db.prepare('SELECT id FROM prds WHERE filename=? AND archived=?').get(parsed.filename, parsed.archived);
+    const archivedValue = archived ? 1 : 0;
+    const row = db.prepare('SELECT id FROM prds WHERE filename=? AND archived=?').get(filename, archivedValue);
     if (!row) return false;
-    db.prepare('DELETE FROM prd_items WHERE prd_id=?').run(row.id);
-    db.prepare('DELETE FROM prd_verify_prs WHERE prd_id=?').run(row.id);
-    db.prepare('DELETE FROM prds WHERE id=?').run(row.id);
+    _deletePrdRow(db, row.id);
     return true;
   });
-  if (removed) require('./db-events').emitStateEvent('prds', { filename: parsed.filename, archived: parsed.archived, removed: true });
+  if (removed) require('./db-events').emitStateEvent('prds', { filename, archived: archived ? 1 : 0, removed: true });
   return removed;
 }
 
-function readPrd(filePath) {
-  const parsed = parsePrdPath(filePath);
-  if (!parsed) return null;
+function readPrd(filename, { archived = false } = {}) {
+  _validatePrdFilename(filename);
   const row = require('./db').getDb()
     .prepare('SELECT data FROM prds WHERE filename=? AND archived=?')
-    .get(parsed.filename, parsed.archived);
+    .get(filename, archived ? 1 : 0);
   return row ? JSON.parse(row.data) : null;
 }
 
@@ -262,9 +283,7 @@ function restorePrdFromArchive(filename) {
     if (!row) return null;
     const prd = JSON.parse(row.data);
     _upsertPrd(db, filename, 0, prd, Date.now());
-    db.prepare('DELETE FROM prd_items WHERE prd_id=?').run(row.id);
-    db.prepare('DELETE FROM prd_verify_prs WHERE prd_id=?').run(row.id);
-    db.prepare('DELETE FROM prds WHERE id=?').run(row.id);
+    _deletePrdRow(db, row.id);
     return prd;
   });
   if (restored) {
@@ -332,8 +351,8 @@ function listPrdRows() {
 }
 
 module.exports = {
-  parsePrdPath,
   writePrd,
+  createPrdUnique,
   mutatePrd,
   deletePrd,
   readPrd,

package/engine/preflight.js

@@ -266,11 +266,8 @@ function runPreflight(opts = {}) {
     // discoverFromWorkItems / discoverFromPrs return [] without logging.
     try {
       const projectWarns = shared.projectWorkSourceWarnings(opts.config, (project) => {
-        const wiPath = shared.projectWorkItemsPath(project);
-        const prPath = shared.projectPrPath(project);
-        const safeJson = shared.safeJson;
-        const wi = (() => { try { const a = safeJson(wiPath); return Array.isArray(a) ? a.length : 0; } catch { return 0; } })();
-        const pr = (() => { try { const a = safeJson(prPath); return Array.isArray(a) ? a.length : 0; } catch { return 0; } })();
+        const wi = (() => { try { return shared.readWorkItems(project).length; } catch { return 0; } })();
+        const pr = (() => { try { return shared.readPullRequests(project).length; } catch { return 0; } })();
         return { workItems: wi, pullRequests: pr };
       });
       for (const w of projectWarns) {

package/engine/projects.js

@@ -9,6 +9,7 @@ const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
 const dispatch = require('./dispatch');
+const queries = require('./queries');
 const projectDiscovery = require('./project-discovery');
 const { MINIONS_DIR } = shared;
 
@@ -86,9 +87,8 @@ function _centralDispatchDefaultedToProject(d, removedProject, projects) {
 }
 
 function _collectProjectlessCentralDispatchItemIds(removedProject, projects) {
-  const dispatchPath = path.join(MINIONS_DIR, 'engine', 'dispatch.json');
   const ids = new Set();
-  const state = shared.safeJsonObj(dispatchPath);
+  const state = queries.getDispatch();
   for (const queue of ['pending', 'active']) {
     for (const d of Array.isArray(state?.[queue]) ? state[queue] : []) {
       if (_centralDispatchDefaultedToProject(d, removedProject, projects)) ids.add(d.meta.item.id);
@@ -99,9 +99,8 @@ function _collectProjectlessCentralDispatchItemIds(removedProject, projects) {
 
 function _requeueProjectlessCentralWorkItems(itemIds) {
   if (!itemIds || itemIds.size === 0) return 0;
-  const wiPath = path.join(MINIONS_DIR, 'work-items.json');
   let requeued = 0;
-  shared.mutateWorkItems(wiPath, items => {
+  shared.mutateWorkItems('central', items => {
     if (!Array.isArray(items)) return items;
     for (const w of items) {
       if (!itemIds.has(w?.id) || w.status !== shared.WI_STATUS.DISPATCHED) continue;
@@ -124,10 +123,7 @@ function _requeueProjectlessCentralWorkItems(itemIds) {
  * @param {object} [options]
  * @param {'archive'|'keep'|'purge'} [options.dataMode='archive']
  *   archive: move projects/<name>/ to projects/.archived/<name>-YYYYMMDD/
- *   keep:    leave projects/<name>/ in place, but tombstone work-items.json /
- *            pull-requests.json into projects/<name>/.dropped/ so dropScope()
- *            (step 9) isn't immediately undone by the *-store.js resync-on-
- *            read path re-hydrating the still-present JSON (W-mr96oira000g979a)
+ *   keep:    leave projects/<name>/ in place
  *   purge:   rm -rf projects/<name>/
  * @returns {object} summary { ok, project, cancelledItems, killedAgents,
  *   drainedDispatches, cleanedWorktrees, disabledSchedules, archivedTo,
@@ -147,7 +143,6 @@ function removeProject(target, options = {}) {
     pipelineRefs: [],
     archivedTo: null,
     purgedDataDir: false,
-    tombstonedDataFiles: false,
     // P-bfa2d-remove-project-cleanup — soft-delete tag counts for entries in
     // the three central state files that survived the hard-cancel passes
     // (steps 1, 2). See step 7.5 for the orphan-tag policy rationale.
@@ -168,15 +163,14 @@ function removeProject(target, options = {}) {
   }
   summary.project = { name: project.name, localPath: project.localPath };
 
-  // 1. Cancel pending/queued work items linked to this project (project-local
-  //    file + central). Done items are preserved as history.
+  // 1. Cancel pending/queued work items linked to this project.
   summary.cancelledItems += dispatch.cancelPendingWorkItems(
-    shared.projectWorkItemsPath(project),
+    project,
     () => true,
     'project-removed',
   );
   summary.cancelledItems += dispatch.cancelPendingWorkItems(
-    path.join(MINIONS_DIR, 'work-items.json'),
+    'central',
     w => _workItemMatchesProject(w, project, projects),
     'project-removed',
   );
@@ -190,7 +184,7 @@ function removeProject(target, options = {}) {
   _requeueProjectlessCentralWorkItems(projectlessCentralItemIds);
 
   // 2.5. Managed-spawn cleanup (P-8a4d6f29). Centralised in managed-spawn.js
-  //      so no other module needs to know about engine/managed-processes.json.
+  //      so no other module needs to know the managed-process storage schema.
   //      Kills + unlinks every spec owned by this project, including the .log
   //      and .log.1 rotated sibling. Best-effort: failures only warn.
   try {
@@ -316,11 +310,8 @@ function removeProject(target, options = {}) {
   } catch (e) { writeError = e; }
   if (writeError) return { ...summary, error: 'Failed to write config: ' + writeError.message };
 
-  // 7.5. P-bfa2d-remove-project-cleanup — Tag dangling refs in the three
-  //      CENTRAL state files (`pull-requests.json`, `work-items.json`,
-  //      `engine/dispatch.json`) so downstream consumers can filter or sweep
-  //      them. Project-local files in `projects/<name>/` are handled by
-  //      step 8 (archive or purge), so this step only touches central state.
+  // 7.5. Tag dangling refs in central state so downstream consumers can filter
+  //      or sweep them. Project-scoped rows are removed in step 9.
   //
   //      Policy is soft-delete (`_orphaned_at` + `_orphaned_project` tags)
   //      rather than hard-delete: preserves history for debugging, lets users
@@ -330,17 +321,11 @@ function removeProject(target, options = {}) {
   //      survivors (non-pending WIs, central PRs, defense-in-depth dispatch
   //      survivors).
   //
-  //      Lock acquisition is sequential and uses the mutate-* helpers from
-  //      engine/dispatch.js and engine/shared.js so we never hold two file
-  //      locks simultaneously. Order: dispatch.json → pull-requests.json →
-  //      work-items.json (alphabetical by basename). Each helper acquires
-  //      its own lock, runs the synchronous mutator, then releases before
-  //      the next helper runs.
   try {
     const orphanedAt = new Date().toISOString();
     const orphanedProject = project.name;
 
-    // (a) engine/dispatch.json — defense-in-depth. cleanDispatchEntries in
+    // (a) Dispatch state — defense-in-depth. cleanDispatchEntries in
     //     step 2 should have already removed every matching entry; tag any
     //     survivor so the operator can see the residue.
     try {
@@ -361,11 +346,10 @@ function removeProject(target, options = {}) {
 
     // (b) Central PR registry. PRs in this scope lack an explicit project field; match by canonical scope
     //     (e.g. `github:owner/repo`) against the removed project's PR scope.
-    const centralPrPath = shared.centralPullRequestsPath();
     try {
       const projectScope = shared.getProjectPrScope(project);
       if (projectScope) {
-        shared.mutatePullRequests(centralPrPath, (prs) => {
+        shared.mutatePullRequests('central', (prs) => {
           for (const pr of prs) {
             if (!pr || pr._orphaned_at) continue;
             const canonical = shared.parseCanonicalPrId(pr.id);
@@ -383,9 +367,8 @@ function removeProject(target, options = {}) {
     //     were already CANCELLED by cancelPendingWorkItems in step 1; tag
     //     the remaining matchers (dispatched / done / failed / etc.) so
     //     downstream consumers can filter them.
-    const centralWiPath = path.join(MINIONS_DIR, 'work-items.json');
     try {
-      shared.mutateWorkItems(centralWiPath, (items) => {
+      shared.mutateWorkItems('central', (items) => {
         for (const w of items) {
           if (!w || w._orphaned_at) continue;
           if (w.status === shared.WI_STATUS.CANCELLED) continue;
@@ -424,40 +407,10 @@ function removeProject(target, options = {}) {
         summary.archiveError = e.code ? `${e.code}: ${e.message}` : e.message;
         summary.warnings.push('archive data dir: ' + e.message);
       }
-    } else if (dataMode === 'keep') {
-      // W-mr96oira000g979a — 'keep' leaves projects/<name>/ (and therefore
-      // work-items.json / pull-requests.json) at its normal, live-resolving
-      // path. dropScope() below DELETEs the SQL rows for this scope, but the
-      // *-store.js resync-on-read path (_resyncScopeIfJsonDiverged) treats a
-      // scope with an empty SQL table + a still-present JSON file as a
-      // fresh-install first-touch and re-hydrates straight from that JSON —
-      // silently undoing the drop the very next time anything reads this
-      // scope. Tombstone the two live-state files into a `.dropped/`
-      // subdirectory so `_filePathForScope(scope)` (and the read-side
-      // resync/fallback logic keyed off it) no longer resolves to them,
-      // while keeping the historical data on disk for manual inspection —
-      // exactly what 'keep' promises, minus the auto-resurrection.
-      try {
-        const droppedDir = path.join(dataDir, '.dropped');
-        const stamp = new Date().toISOString().replace(/[:.]/g, '-');
-        for (const fname of ['work-items.json', 'pull-requests.json']) {
-          const src = path.join(dataDir, fname);
-          if (!fs.existsSync(src)) continue;
-          fs.mkdirSync(droppedDir, { recursive: true });
-          let dest = path.join(droppedDir, `${fname}.${stamp}`);
-          let n = 1;
-          while (fs.existsSync(dest)) dest = path.join(droppedDir, `${fname}.${stamp}-${++n}`);
-          _renameWithRetry(src, dest);
-          summary.tombstonedDataFiles = true;
-        }
-      } catch (e) {
-        summary.warnings.push('tombstone kept data files: ' + e.message);
-      }
     }
   }
 
-  // 9. Drop SQL rows for the project's scope so safeJson shim reads no longer
-  //    surface the removed project after the JSON file is archived.
+  // 9. Drop SQL rows for the removed project scope.
   try { require('./work-items-store').dropScope(project.name); } catch { /* best-effort */ }
   try { require('./pull-requests-store').dropScope(project.name); } catch { /* best-effort */ }
 
@@ -571,7 +524,7 @@ async function addProject(target, options = {}) {
   assertProjectLinkOk(project);
 
   // 7. Ensure project state files (projects/<name>/...).
-  shared.ensureProjectStateFiles(project);
+  shared.initializeProjectState(project);
 
   // 8. Persist under config lock. Re-check inside the lock so a concurrent
   //    add can't insert a duplicate between our pre-check and the write.

package/engine/pull-requests-store.js

@@ -13,21 +13,6 @@ function _toMs(v) {
   return Number.isFinite(parsed) ? parsed : null;
 }
 
-function scopeForFilePath(filePath) {
-  const norm = String(filePath).replace(/\\/g, '/');
-  const m = norm.match(/projects\/([^/]+)\/pull-requests\.json$/);
-  if (m) return m[1];
-  return 'central';
-}
-
-// Compatibility adapter for callers that still pass a path-shaped scope token
-// into shared.mutatePullRequests. No file is read or written.
-function _filePathForScope(scope) {
-  const shared = require('./shared');
-  if (!scope || scope === 'central') return shared.centralPullRequestsPath(shared.MINIONS_DIR);
-  return require('path').join(shared.MINIONS_DIR, 'projects', scope, 'pull-requests.json');
-}
-
 function _parseRow(row) {
   if (!row || !row.data) return null;
   try { return JSON.parse(row.data); }
@@ -169,8 +154,6 @@ function dropScope(scope) {
 }
 
 module.exports = {
-  _filePathForScope,
-  scopeForFilePath,
   readPullRequestsForScope,
   readAllPullRequests,
   applyPullRequestsMutation,

package/engine/qa-runbooks.js

@@ -3,7 +3,7 @@
  *
  * Per-project QA runbook persistence + CRUD helpers. Runbooks are test plans
  * that travel with a project entry, mirroring the
- * projects/<name>/pull-requests.json precedent. Each runbook is one JSON file
+ * project-local definition precedent. Each runbook is one JSON file
  * at <MINIONS_DIR>/projects/<project>/runbooks/<id>.json.
  *
  * Pure persistence + validation only — this module does NOT spawn agents,
@@ -27,7 +27,7 @@ const _KEBAB_RE = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
 // keep this module self-contained for path-traversal hardening (review feedback
 // on PR #2694: id/project params previously flowed into path.join without
 // validation, so `..%2F..%2F..%2Fconfig` could read MINIONS_DIR/config.json
-// and DELETE could wipe dispatch.json).
+// and DELETE could wipe unrelated runtime state).
 const _PROJECT_NAME_RE = /^[a-zA-Z0-9_\-]{1,64}$/;
 
 const ARTIFACT_TYPES = ['screenshot', 'video', 'log', 'other'];

package/engine/qa-runs.js

@@ -33,7 +33,7 @@ const { mutateQaRuns, uid, ts, log } = shared;
 
 // Cap qa_runs so the table doesn't grow unboundedly
 // over months of nightly QA dispatch. Mirrors the 2500-entry cap on
-// engine/log.json. createRun trims oldest-by-createdAt when crossing the
+// the engine log. createRun trims oldest-by-createdAt when crossing the
 // threshold; terminal-status runs that have already shipped completion
 // notifications are safe to drop.
 const QA_RUNS_MAX_RECORDS = 2000;
@@ -80,12 +80,6 @@ const ALLOWED_TRANSITIONS = {
   [QA_RUN_STATUS.ERRORED]: new Set(),
 };
 
-// Dynamic paths — respect MINIONS_TEST_DIR for test isolation. Kept exported
-// for back-compat with tests that probe the JSON sidecar on disk.
-function qaRunsPath() {
-  return path.join(shared.MINIONS_DIR, 'engine', 'qa-runs.json');
-}
-
 function qaArtifactsDir() {
   return path.join(shared.MINIONS_DIR, 'engine', 'qa-artifacts');
 }
@@ -416,7 +410,6 @@ module.exports = {
   QA_RUN_STATUS,
   TERMINAL_STATUSES,
   ALLOWED_TRANSITIONS,
-  qaRunsPath,
   qaArtifactsDir,
   qaArtifactsDirForRun,
   createRun,