@yemi33/minions 0.1.2377 → 0.1.2378

package/dashboard/js/refresh.js

@@ -130,7 +130,8 @@ function _detectPageChanges(data) {
 // for the same input. Cross-restart safety lives in the dashboardBuildId
 // reload path below — RENDER_VERSIONS handles the within-process case.
 const RENDER_VERSIONS = {
-  agents: 2,
+  // Bumped 2→3 for client-ticked relative last-action timestamps.
+  agents: 3,
   prdProgress: 2,
   prdPrs: 1,
   inbox: 2,
@@ -516,17 +517,19 @@ function _processStatusUpdate(data, opts) {
   // the /api/work-items + /api/pull-requests .then handlers
   // (_fireCrossSliceRender) where the FRESH fetched lists are available.
   // Agents now come from /api/agents — a dedicated fresh-JSON endpoint with
-  // input-mtime ETag (issue #2949). No /api/status outer cache in the path.
+  // input-mtime ETag (issue #2949). Conditional requests keep unchanged polls
+  // from reparsing the roster and rebuilding every card/timer.
   // cmdUpdateAgentList consumes the same slice but renders the command-line
   // chip pop-up so we feed it the fresh array too.
   _safeRender('agents', function() {
     const seq = (window._refreshSeq = (window._refreshSeq || 0) + 1);
     window._lastRequestedSeq = window._lastRequestedSeq || {};
     window._lastRequestedSeq.agents = seq;
-    fetch('/api/agents')
-      .then(function (r) { return r.ok ? r.json() : Promise.reject(); })
-      .then(function (fresh) {
+    _condFetchJson('/api/agents')
+      .then(function (resp) {
         if (seq < (window._lastRequestedSeq.agents || 0)) return;
+        if (resp.notModified) return;
+        const fresh = resp.data;
         const list = Array.isArray(fresh) ? fresh : window._lastAgents;
         if (list) window._lastAgents = list;
         _safeRender('agents', function() { renderAgents(list); });

package/dashboard/js/render-agents.js

@@ -44,6 +44,34 @@ function _modelChipHtml(model) {
   return '<span class="agent-model-tag" title="Model: ' + escapeHtml(model) + '" style="font-size:var(--text-xs);font-weight:600;letter-spacing:0.4px;padding:1px 5px;margin-left:4px;border:1px solid var(--muted);border-radius:3px;color:var(--muted);background:transparent">' + escapeHtml(model) + '</span>';
 }
 
+function _agentHasTimedAction(agent) {
+  return !!(agent && agent.lastActionPrefix && Number.isFinite(Number(agent.lastActionAt)));
+}
+
+function _formatAgentAction(prefix, actionAt, fallback) {
+  var actionAtMs = Number(actionAt);
+  var text = prefix && Number.isFinite(actionAtMs)
+    ? String(prefix) + ' (' + timeAgo(actionAtMs) + ')'
+    : String(fallback || '');
+  return text.length > 120 ? text.slice(0, 120) + '...' : text;
+}
+
+function _agentLastActionText(agent) {
+  return _formatAgentAction(agent.lastActionPrefix, agent.lastActionAt, agent.lastAction);
+}
+
+function _agentTimedActionAttrs(agent) {
+  return _agentHasTimedAction(agent)
+    ? ' data-action-prefix="' + escapeHtml(agent.lastActionPrefix) + '" data-action-at="' + Number(agent.lastActionAt) + '"'
+    : '';
+}
+
+function _agentActionHtml(agent) {
+  var text = _agentLastActionText(agent);
+  var attrs = _agentTimedActionAttrs(agent);
+  return '<div class="agent-action"' + attrs + ' title="' + escapeHtml(text) + '">' + escapeHtml(text) + '</div>';
+}
+
 function renderAgents(agents) {
   agentData = agents;
   const grid = document.getElementById('agents-grid');
@@ -56,7 +84,7 @@ function renderAgents(agents) {
         <span class="status-badge ${escapeHtml(a.status)}">${escapeHtml(a.status)}</span>
       </div>
       <div class="agent-role">${escapeHtml(a.role)}</div>
-      <div class="agent-action" title="${escapeHtml(a.lastAction)}">${escapeHtml(a.lastAction)}</div>
+      ${_agentActionHtml(a)}
       ${(function() {
         var s = a.started_at, c = a.completed_at;
         if (s && c) { var d = new Date(c) - new Date(s); if (d > 0) { var sec = Math.floor(d/1000)%60, min = Math.floor(d/60000)%60, hr = Math.floor(d/3600000); return '<div style="font-size:var(--text-xs);color:var(--muted)">Last run: ' + (hr > 0 ? hr + 'h ' : '') + min + 'm ' + sec + 's</div>'; } }
@@ -144,7 +172,7 @@ async function openAgentDetail(id) {
   // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; status is an internal bounded enum and all user data is wrapped in escapeHtml()/renderMd() (fields: lastAction, blocking tool, resultSummary)
   document.getElementById('detail-status-line').innerHTML =
     '<span class="status-badge ' + badgeClass + '">' + agent.status.toUpperCase() + '</span> ' +
-    '<span style="color:var(--muted)">' + escapeHtml(agent.lastAction) + '</span>' +
+    '<span class="agent-detail-action"' + _agentTimedActionAttrs(agent) + ' style="color:var(--muted)">' + escapeHtml(_agentLastActionText(agent)) + '</span>' +
     (agent._blockingToolCall ? '<div style="margin-top:4px;padding:4px 8px;background:rgba(130,160,210,0.13);border:1px solid rgba(130,160,210,0.3);border-radius:4px;font-size:var(--text-base);color:var(--muted)">&#x23F3; Blocking tool call (' + escapeHtml(agent._blockingToolCall.tool) + ') &mdash; silent ' + Math.round(agent._blockingToolCall.silentMs/60000) + 'min, timeout in ' + Math.round(agent._blockingToolCall.remainingMs/60000) + 'min</div>' : '') +
     (agent.resultSummary ? '<div style="margin-top:4px;font-size:var(--text-base);color:var(--text);line-height:1.4">' + renderMd(agent.resultSummary.slice(0, 300)) + '</div>' : '');
 
@@ -168,11 +196,19 @@ async function openAgentDetail(id) {
 
 }
 
-// Tick running agent timers on cards every second
+// Tick wall-clock-derived card text every second.
 var _agentRuntimeTimer = null;
 function _tickAgentRuntimes() {
-  var els = document.querySelectorAll('.agent-runtime-tick');
-  if (els.length === 0) { if (_agentRuntimeTimer) { clearInterval(_agentRuntimeTimer); _agentRuntimeTimer = null; } return; }
+  var grid = document.getElementById('agents-grid');
+  var els = grid ? grid.querySelectorAll('.agent-runtime-tick') : [];
+  var actionEls = grid ? Array.from(grid.querySelectorAll('.agent-action[data-action-at]')) : [];
+  var detailStatus = document.getElementById('detail-status-line');
+  var detailAction = detailStatus && detailStatus.querySelector('.agent-detail-action[data-action-at]');
+  if (detailAction) actionEls.push(detailAction);
+  if (els.length === 0 && actionEls.length === 0) {
+    if (_agentRuntimeTimer) { clearInterval(_agentRuntimeTimer); _agentRuntimeTimer = null; }
+    return;
+  }
   var now = Date.now();
   els.forEach(function(el) {
     var ms = now - new Date(el.dataset.started).getTime();
@@ -180,13 +216,20 @@ function _tickAgentRuntimes() {
     var sec = Math.floor(ms / 1000) % 60, min = Math.floor(ms / 60000) % 60, hr = Math.floor(ms / 3600000);
     el.textContent = 'Running: ' + (hr > 0 ? hr + 'h ' : '') + min + 'm ' + sec + 's';
   });
+  actionEls.forEach(function(el) {
+    var text = _formatAgentAction(el.dataset.actionPrefix, Number(el.dataset.actionAt), el.textContent);
+    el.textContent = text;
+    el.title = text;
+  });
 }
-// Start ticker after each render if working agents exist
+// Start ticker after each render if any card has wall-clock-derived text.
 var _origRenderAgents = renderAgents;
 renderAgents = function(agents) {
   _origRenderAgents(agents);
   if (_agentRuntimeTimer) { clearInterval(_agentRuntimeTimer); _agentRuntimeTimer = null; }
-  if (agents.some(function(a) { return a.status === 'working' && a.started_at; })) {
+  if (agents.some(function(a) {
+    return (a.status === 'working' && a.started_at) || _agentHasTimedAction(a);
+  })) {
     _tickAgentRuntimes();
     _agentRuntimeTimer = setInterval(_tickAgentRuntimes, 1000);
   }

package/dashboard.js

@@ -2996,68 +2996,56 @@ function _stateReadContentType(ext) {
 // issue #2949 documented. This pattern bypasses both:
 //
 //   1. Caller supplies an array of input file paths.
-//   2. We statSync each one and take MAX(mtimeMs). That's the ETag.
+//   2. We asynchronously stat each one and take MAX(mtimeMs). That's the ETag.
 //   3. If the client's If-None-Match matches → 304 with no body.
 //   4. Otherwise call `builder()` to assemble the response from scratch
 //      (no outer cache layer to go stale).
 //   5. Stamp ETag + Content-Type and send.
 //
-// Cost per request when ETag matches: N statSync calls (microseconds).
-// Cost on a miss: same N statSync + the builder, which is exactly the
+// Cost per request when ETag matches: N asynchronous stat calls.
+// Cost on a miss: the same stat walk + the builder, which is exactly the
 // existing queries.getAgents() / getMetrics() / etc. that /api/status
 // already pays. Net change: same compute, no caching, always-fresh.
-function _maxInputMtimeMs(inputs) {
-  let max = 0;
-  for (const fp of inputs) {
-    try {
-      // Use lstatSync so a broken Windows junction (common after DevBox
-      // swap) or a circular symlink doesn't block the event loop on a
-      // ~30 s OS timeout trying to follow the link. Engine never writes
-      // symlinks into state dirs in normal operation, so an lstat that
-      // detects a symlink is treated as "skip" — the input is effectively
-      // not tracked. (Round-2 review finding #7.)
-      const s = fs.lstatSync(fp);
-      if (s.isSymbolicLink()) continue;
-      if (s.mtimeMs > max) max = s.mtimeMs;
-      // Directory inputs: dir mtime only advances on add/remove of
-      // immediate entries, not on in-place file edits. Walk two levels
-      // down so editing prd/<plan>.json in place (depth 1) and
-      // agents/<id>/live-output.log (depth 2) both bust the ETag.
-      // Steering edits at agents/<id>/inbox/steering-*.md (depth 3)
-      // currently rely on add/remove cadence rather than per-file content
-      // mtime — accept this lag rather than walking unbounded.
-      // (Review finding #6.)
-      if (s.isDirectory()) {
-        let level1;
-        try { level1 = fs.readdirSync(fp); } catch { level1 = []; }
-        for (const name of level1) {
-          const child = path.join(fp, name);
-          let cs;
-          try { cs = fs.lstatSync(child); } catch { continue; }
-          if (cs.isSymbolicLink()) continue;
-          if (cs.mtimeMs > max) max = cs.mtimeMs;
-          if (cs.isDirectory()) {
-            let level2;
-            try { level2 = fs.readdirSync(child); } catch { level2 = []; }
-            for (const inner of level2) {
-              try {
-                const is = fs.lstatSync(path.join(child, inner));
-                if (is.isSymbolicLink()) continue;
-                if (is.mtimeMs > max) max = is.mtimeMs;
-              } catch { /* skip unreadable */ }
-            }
-          }
-        }
-      }
-    } catch {
-      // Missing input = not yet on disk. Don't bust the ETag — a builder
-      // that legitimately depends on the file will surface its own empty
-      // state, and the ETag will move once the file appears.
-    }
+async function _freshnessEntryMtimeMs(fp, depth) {
+  let stat;
+  try {
+    // lstat avoids following broken Windows junctions or circular symlinks,
+    // which can incur long OS timeouts. State inputs never require symlinks.
+    stat = await fs.promises.lstat(fp);
+  } catch {
+    return 0;
   }
-  return Math.floor(max);
+  if (stat.isSymbolicLink()) return 0;
+
+  let max = stat.mtimeMs;
+  if (!stat.isDirectory() || depth <= 0) return max;
+
+  let names;
+  try {
+    names = await fs.promises.readdir(fp);
+  } catch {
+    return max;
+  }
+  const childMtimes = await Promise.all(
+    names.map(name => _freshnessEntryMtimeMs(path.join(fp, name), depth - 1)),
+  );
+  for (const childMtime of childMtimes) {
+    if (childMtime > max) max = childMtime;
+  }
+  return max;
+}
+
+async function _maxInputMtimeMs(inputs) {
+  // Directory mtime only advances on add/remove, not in-place edits. Walk two
+  // levels so prd/<plan>.json and agents/<id>/live-output.log both bust ETags.
+  // Deeper steering edits still rely on add/remove cadence, matching the prior
+  // bounded walk.
+  const mtimes = await Promise.all(
+    inputs.map(fp => _freshnessEntryMtimeMs(fp, 2)),
+  );
+  return Math.floor(mtimes.reduce((max, mtime) => Math.max(max, mtime), 0));
 }
-function serveFreshJson(req, res, opts) {
+async function serveFreshJson(req, res, opts) {
   const inputs = Array.isArray(opts && opts.inputs) ? opts.inputs : [];
   const builder = opts && typeof opts.builder === 'function' ? opts.builder : null;
   const tag = opts && opts.tag ? String(opts.tag) : 'v';
@@ -3067,7 +3055,7 @@ function serveFreshJson(req, res, opts) {
     res.end(JSON.stringify({ error: 'serveFreshJson: builder is required' }));
     return;
   }
-  const mtime = _maxInputMtimeMs(inputs);
+  const mtime = await _maxInputMtimeMs(inputs);
   const eventVersion = _getCurrentEventVersion();
   const etag = '"' + tag + '-' + mtime + '-' + eventVersion + '"';
   res.setHeader('ETag', etag);
@@ -7677,7 +7665,7 @@ const server = http.createServer(async (req, res) => {
       h = Math.imul(h ^ ((e.size || 0) >>> 0), 16777619);
       h = Math.imul(h ^ Math.floor(e.sortTs || 0), 16777619);
     }
-    const sweepMtime = _maxInputMtimeMs([
+    const sweepMtime = await _maxInputMtimeMs([
       path.join(ENGINE_DIR, 'kb-swept.json'),
       path.join(ENGINE_DIR, 'kb-sweep-state.json'),
     ]);

package/engine/queries.js

@@ -758,6 +758,8 @@ function getAgents(config) {
     const s = getAgentStatus(a.id); // derives from dispatch.json
 
     let lastAction = 'Waiting for assignment';
+    let lastActionPrefix = null;
+    let lastActionAt = null;
     // Show the dispatch task as a stable label for the whole run — don't swap
     // in the transient per-tool-call `_runningToolDescription`, which reads like
     // a task change to operators (e.g. an agent's own "Wait until temp dirs
@@ -768,17 +770,23 @@ function getAgents(config) {
     else if (s.status === 'error') lastAction = `Error: ${s.task}`;
     else if (steeringInboxFiles.length > 0) {
       const lastSteer = steeringInboxFiles[steeringInboxFiles.length - 1];
-      lastAction = `Pending steering: ${lastSteer.file} (${timeSince(lastSteer.createdAtMs)})`;
+      lastActionPrefix = `Pending steering: ${lastSteer.file}`;
+      lastActionAt = lastSteer.createdAtMs;
+      lastAction = `${lastActionPrefix} (${timeSince(lastActionAt)})`;
     }
     else if (inboxFiles.length > 0) {
       const lastOutput = path.join(INBOX_DIR, inboxFiles[inboxFiles.length - 1]);
-      try { lastAction = `Output: ${path.basename(lastOutput)} (${timeSince(fs.statSync(lastOutput).mtimeMs)})`; } catch { /* optional */ }
+      try {
+        lastActionPrefix = `Output: ${path.basename(lastOutput)}`;
+        lastActionAt = fs.statSync(lastOutput).mtimeMs;
+        lastAction = `${lastActionPrefix} (${timeSince(lastActionAt)})`;
+      } catch { /* optional */ }
     }
 
     const chartered = fs.existsSync(path.join(AGENTS_DIR, a.id, 'charter.md'));
     if (lastAction.length > 120) lastAction = lastAction.slice(0, 120) + '...';
     return {
-      ...a, runtime, model, status: s.status, lastAction,
+      ...a, runtime, model, status: s.status, lastAction, lastActionPrefix, lastActionAt,
       // Descriptive capability tags; tolerate legacy `skills` configs by
       // normalizing to `expertise` for the dashboard/settings UI.
       expertise: a.expertise ?? a.skills ?? [],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2377",
+  "version": "0.1.2378",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"