@yemi33/minions 0.1.2376 → 0.1.2377

package/dashboard/js/settings.js

@@ -890,13 +890,11 @@ async function initRuntimeFleetUI(engineCfg, agentsCfg) {
 }
 
 /**
- * Replace the input/select at `inputId` with a dropdown when the runtime
- * exposes a model list, or a free-text input when `{ models: null }` (e.g.
- * Claude or model-discovery disabled). The "Default (CLI chooses)" option is
- * always present and submits empty string.
+ * Render an editable model field backed by discovered-model suggestions.
+ * Discovery is advisory: staged/future/custom model IDs must remain typeable.
  */
-async function loadModelsForRuntime(runtimeName, inputId, currentValue) {
-  const wrap = document.getElementById(inputId)?.parentElement;
+async function loadModelsForRuntime(runtimeName, inputId, currentValue, forceRefresh) {
+  const wrap = document.getElementById(inputId + '-wrap') || document.getElementById(inputId)?.parentElement;
   if (!wrap) return;
   const token = _nextModelLoadToken('runtime', inputId);
   if (!runtimeName) {
@@ -906,42 +904,37 @@ async function loadModelsForRuntime(runtimeName, inputId, currentValue) {
   }
   let payload = { models: null };
   try {
-    const res = await fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + '/models');
+    const suffix = forceRefresh ? '/models/refresh' : '/models';
+    const res = await fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + suffix, forceRefresh ? { method: 'POST' } : undefined);
     if (res.ok) payload = await res.json();
   } catch { /* fall through to free-text */ }
 
   if (!_isCurrentModelLoad('runtime', inputId, token)) return;
   const models = Array.isArray(payload.models) ? payload.models : null;
-  if (!models || models.length === 0) {
-    // Free-text fallback — let the user type anything (custom Anthropic /
-    // OpenAI model IDs, future models, etc.).
-    // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escHtml() (fields: currentValue; inputId is an internal fixed DOM id)
-    wrap.innerHTML = '<input id="' + inputId + '" value="' + escHtml(currentValue || '') + '" placeholder="Default (CLI chooses)" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:var(--text-md)">';
-    return;
-  }
-  // Dropdown. The first option submits empty string → "Default (CLI chooses)".
-  let opts = '<option value=""' + (!currentValue ? ' selected' : '') + '>Default (CLI chooses)</option>';
-  for (const m of models) {
+  const listId = inputId + '-options';
+  let opts = '';
+  for (const m of (models || [])) {
     const id = m.id || m.name || '';
     if (!id) continue;
-    const label = m.name && m.name !== id ? (id + ' — ' + m.name) : id;
-    opts += '<option value="' + escHtml(id) + '"' + (id === currentValue ? ' selected' : '') + '>' + escHtml(label) + '</option>';
+    const label = m.name && m.name !== id ? m.name : '';
+    opts += '<option value="' + escHtml(id) + '"' + (label ? ' label="' + escHtml(label) + '"' : '') + '></option>';
   }
-  // If the current value isn't in the model list (custom / older choice),
-  // surface it as a selectable option so the user doesn't lose it on next save.
-  if (currentValue && !models.some(m => (m.id || m.name) === currentValue)) {
-    opts += '<option value="' + escHtml(currentValue) + '" selected>' + escHtml(currentValue) + ' (custom)</option>';
+  const title = forceRefresh ? 'Model list refreshed' : 'Refresh models from the selected CLI';
+  // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escHtml()
+  wrap.innerHTML = '<div style="display:flex;gap:4px"><input id="' + inputId + '" list="' + listId + '" value="' + escHtml(currentValue || '') + '" placeholder="Default (CLI chooses)" autocomplete="off" style="min-width:0;flex:1;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:var(--text-md)"><button type="button" data-model-refresh title="' + escHtml(title) + '" aria-label="Refresh model list" style="padding:3px 8px;background:var(--surface2);border:1px solid var(--border);border-radius:4px;color:var(--muted);cursor:pointer">↻</button></div><datalist id="' + listId + '">' + opts + '</datalist>';
+  const refresh = wrap.querySelector('[data-model-refresh]');
+  if (refresh) {
+    refresh.addEventListener('click', async function() {
+      const liveValue = document.getElementById(inputId)?.value || '';
+      refresh.disabled = true;
+      await loadModelsForRuntime(runtimeName, inputId, liveValue, true);
+    });
   }
-  // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escHtml() (fields: model id, model label, currentValue; inputId is an internal fixed DOM id)
-  wrap.innerHTML = '<select id="' + inputId + '" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:var(--text-md)">' + opts + '</select>';
 }
 
 /**
- * Per-agent model hydrator. Replaces the placeholder input in the cell
- * `[data-runtime-model="<agentId>"]` with a <select> of valid models for the
- * given runtime. Output element keeps `data-agent` + `data-field="model"` so
- * the existing save flow picks it up unchanged. Free-text input fallback
- * when the runtime returns no model list (Claude / discovery disabled).
+ * Per-agent model hydrator. The catalog is a datalist rather than a closed
+ * select so newly released and custom IDs stay available.
  */
 async function loadModelsForAgent(agentId, runtimeName, currentValue) {
   const cell = document.querySelector('[data-runtime-model="' + agentId + '"]');

package/dashboard.js

@@ -4502,6 +4502,7 @@ async function _preflightModelCheck({ runtime: cliOverride, model: modelOverride
   const resolvedModel = llm._resolveModelForRuntime(adapter, { model: modelOverride, engineConfig });
   if (!resolvedModel) return null;
   if (!adapter.capabilities || adapter.capabilities.modelDiscovery !== true) return null;
+  if (adapter.capabilities.strictModelCatalog === false) return null;
 
   let list;
   try {
@@ -10572,8 +10573,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           });
           writeCcEvent(envelope);
           liveState.donePayload = envelope;
-          _ccStreamEnded = true;
           if (liveState.endResponse) liveState.endResponse();
+          _ccStreamEnded = true;
           _scheduleCcLiveCleanup(tabId);
           _logCcStreamEnd(_ccTelemetry, 'error-preflight-model-unavailable', { runtime: preflightFailure.runtime });
           return;
@@ -10621,8 +10622,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           if (initial.missingRuntime) return initial;
 
           // Handle failure — non-zero exit with text = max_turns or partial success, still usable
-          if (!initial.text && wasResume && initial.code !== 0 && !req.destroyed) {
-            // Resume failed (stale/expired session) — auto-retry as fresh session (skip if client already disconnected)
+          if (!initial.text && wasResume && initial.code !== 0) {
+            // Resume failed (stale/expired session) — auto-retry as fresh. A
+            // briefly disconnected client can reattach to the live turn.
             console.log(`[CC-stream] Resume failed (code=${initial.code}) — retrying fresh`);
             const freshPreamble = buildCCStatePreamble();
             const freshCarryover = _buildTranscriptCarryover(body.transcript, { currentMessage: body.message });
@@ -10672,11 +10674,6 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         // treating an empty `text` as a failure. A genuinely empty turn has
         // both text and raw empty.
         if ((!result.text && !result.raw) || result.error) {
-          if (req.destroyed) {
-            _ccStreamEnded = true;
-            _logCcStreamEnd(_ccTelemetry, 'llm-empty-client-gone', { code: result.code });
-            return;
-          }
           // W-mpmwxni2000c25c7-b — surface the typed error envelope as a
           // distinct SSE `event: error` frame so the client renders a real
           // error UI (with a retry hint derived from `retriable`) instead of
@@ -11316,20 +11313,18 @@ What would you like to discuss or change? When you're happy, say "approve" and I
               knownForResolved = new Set(list.models.map(m => m.id || m.name).filter(Boolean));
             }
           } catch { /* unknown runtime */ }
-          if (knownForResolved && !knownForResolved.has(runtimeModelStr)) {
-            return `not a valid model for runtime "${resolvedRuntime}" (known: ${[...knownForResolved].slice(0, 4).join(', ')}${knownForResolved.size > 4 ? '…' : ''})`;
-          }
-          if (!knownForResolved) {
-            // Free-text runtime (Claude). Reject only if the raw model belongs to a different runtime's published list.
-            for (const rt of _engineRuntimes.listRuntimes()) {
-              if (rt === resolvedRuntime) continue;
-              try {
-                const otherList = await _engineModelDiscovery.getRuntimeModels(rt, { config });
-                if (Array.isArray(otherList?.models) && otherList.models.some(m => (m.id || m.name) === modelStr)) {
-                  return `belongs to runtime "${rt}" but resolved runtime is "${resolvedRuntime}" — incompatible combination`;
-                }
-              } catch { /* skip */ }
-            }
+          if (knownForResolved && knownForResolved.has(runtimeModelStr)) return null;
+          // Catalogs lag staged releases and local/custom providers. Unknown is
+          // therefore allowed, but a model positively published by a different
+          // runtime remains an actionable incompatible-combination error.
+          for (const rt of _engineRuntimes.listRuntimes()) {
+            if (rt === resolvedRuntime) continue;
+            try {
+              const otherList = await _engineModelDiscovery.getRuntimeModels(rt, { config });
+              if (Array.isArray(otherList?.models) && otherList.models.some(m => (m.id || m.name) === modelStr)) {
+                return `belongs to runtime "${rt}" but resolved runtime is "${resolvedRuntime}" — incompatible combination`;
+              }
+            } catch { /* skip */ }
           }
           return null;
         }
@@ -11486,15 +11481,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
               const resolvedCli = config.agents[id].cli || config.engine.defaultCli || 'copilot';
               const runtimeModelStr = _resolveModelForRuntime(candidate, resolvedCli);
               const knownModels = await _modelsFor(resolvedCli);
-              // Two validation paths:
-              //   1. If the runtime publishes a model list, enforce membership.
-              //   2. If the runtime doesn't (Claude), still reject when the
-              //      model belongs to a DIFFERENT runtime's list — that's how
-              //      we catch claude+gpt-5.5 (gpt-5.5 is in Copilot's list).
+              // Published membership is a positive signal, not a closed enum:
+              // staged releases/custom providers can legitimately be absent.
+              // Still reject IDs positively owned by a different runtime.
               let rejection = null;
-              if (knownModels && !knownModels.has(runtimeModelStr)) {
-                rejection = `not a valid model for runtime "${resolvedCli}" (known: ${[...knownModels].slice(0, 4).join(', ')}${knownModels.size > 4 ? '…' : ''})`;
-              } else if (!knownModels) {
+              if (!knownModels || !knownModels.has(runtimeModelStr)) {
                 const owner = await _ownerOfModel(candidate);
                 if (owner && owner !== resolvedCli) {
                   rejection = `belongs to runtime "${owner}" but agent uses "${resolvedCli}" — incompatible combination`;

package/engine/llm.js

@@ -591,8 +591,9 @@ function _createStreamAccumulator({
       if (!id || !onToolUpdate) return;
       onToolUpdate(id, status);
     },
-    toolUseAlreadySeen(name, input) {
+    toolUseAlreadySeen(name, input, id = null) {
       if (!name) return false;
+      if (id) return toolUses.some(t => t.id === id);
       const stringified = JSON.stringify(input || {});
       return toolUses.some(t => t.name === name && JSON.stringify(t.input) === stringified);
     },

package/engine/model-discovery.js

@@ -99,6 +99,13 @@ async function getRuntimeModels(runtimeName, { force = false, ttlMs = MODEL_CACH
   }
 
   const cachePath = adapter.modelsCache || null;
+  // Runtime catalogs are versioned with the CLI that produced them. Codex in
+  // particular ships new bundled model IDs with CLI releases, so a one-hour
+  // time-only cache otherwise hides new models immediately after an upgrade.
+  let modelCacheKey = null;
+  if (typeof adapter.getModelCacheKey === 'function') {
+    try { modelCacheKey = await adapter.getModelCacheKey(); } catch { /* optional hint */ }
+  }
 
   // Cache hit path — only on non-forced reads. We accept any cached payload
   // whose `cachedAt` parses to a valid timestamp within the TTL window;
@@ -110,7 +117,8 @@ async function getRuntimeModels(runtimeName, { force = false, ttlMs = MODEL_CACH
       const ts = Date.parse(cached.cachedAt);
       if (Number.isFinite(ts)) {
         const age = Date.now() - ts;
-        if (age >= 0 && age < ttlMs) {
+        const versionMatches = !modelCacheKey || cached.modelCacheKey === modelCacheKey;
+        if (age >= 0 && age < ttlMs && versionMatches) {
           const models = Array.isArray(cached.models) ? cached.models : null;
           return { runtime: runtimeName, models, cachedAt: cached.cachedAt };
         }
@@ -134,7 +142,12 @@ async function getRuntimeModels(runtimeName, { force = false, ttlMs = MODEL_CACH
 
   const cachedAt = new Date().toISOString();
   if (cachePath) {
-    _writeCacheFile(cachePath, { runtime: runtimeName, models, cachedAt });
+    _writeCacheFile(cachePath, {
+      runtime: runtimeName,
+      models,
+      cachedAt,
+      ...(modelCacheKey ? { modelCacheKey } : {}),
+    });
   }
   return { runtime: runtimeName, models, cachedAt };
 }

package/engine/runtimes/codex.js

@@ -320,6 +320,17 @@ function _normalizeConfigOverrides(configOverrides) {
   return [];
 }
 
+const _MIME_EXT = {
+  'image/png': 'png',
+  'image/jpeg': 'jpg',
+  'image/gif': 'gif',
+  'image/webp': 'webp',
+};
+
+function _mimeToExt(mimeType) {
+  return _MIME_EXT[String(mimeType || '').toLowerCase()] || 'bin';
+}
+
 function buildArgs(opts = {}) {
   const {
     model,
@@ -329,11 +340,13 @@ function buildArgs(opts = {}) {
     sandbox = 'workspace-write',
     skipGitRepoCheck = true,
     configOverrides,
+    images,
+    tmpDir,
   } = opts;
 
   const args = ['exec'];
-  if (sessionId) args.push('resume', String(sessionId));
-
+  // These are `exec` options, not `exec resume` options. Codex's resume
+  // parser rejects flags such as --color and --sandbox after the subcommand.
   args.push('--json', '--color', 'never');
   if (model) args.push('--model', String(model));
   if (sandbox) args.push('--sandbox', String(sandbox));
@@ -347,6 +360,20 @@ function buildArgs(opts = {}) {
     args.push('--config', override);
   }
 
+  if (sessionId) args.push('resume', String(sessionId));
+
+  // Codex accepts repeatable --image paths on fresh and resumed turns. The
+  // call-scoped tmpDir is removed by engine/llm.js after the process exits.
+  if (Array.isArray(images) && images.length && tmpDir) {
+    for (let i = 0; i < images.length; i++) {
+      const img = images[i];
+      if (!img || !img.dataBase64) continue;
+      const filePath = path.join(tmpDir, `img-${i}.${_mimeToExt(img.mimeType)}`);
+      fs.writeFileSync(filePath, Buffer.from(img.dataBase64, 'base64'));
+      args.push('--image', filePath);
+    }
+  }
+
   args.push('-');
   return args;
 }
@@ -544,6 +571,21 @@ function _extractToolUse(obj) {
   const itemType = String(item?.type || '');
   if (!/tool|function|command|web_search/i.test(type) && !/tool|command|web_search/i.test(itemType)) return null;
   const data = item || obj.data || obj;
+  const id = _pickString(data.id, obj?.item_id, obj?.itemId, obj?.data?.item_id);
+  const rawStatus = String(data.status || obj?.status || '').toLowerCase();
+  const status = /fail|error|cancel/.test(rawStatus) ? 'failed'
+    : /complete|success/.test(rawStatus) ? 'completed'
+      : null;
+
+  if (/command_execution/i.test(itemType)) {
+    const command = _pickString(data.command, data.input);
+    if (!command) return null;
+    return { name: 'Bash', input: { command }, id: id || null, status };
+  }
+  if (/web_search/i.test(itemType)) {
+    const query = _pickString(data.query, data.input, data.arguments);
+    return { name: 'WebSearch', input: query ? { query } : {}, id: id || null, status };
+  }
   const name = _pickString(
     data.tool_name,
     data.toolName,
@@ -555,7 +597,7 @@ function _extractToolUse(obj) {
   );
   if (!name) return null;
   const input = data.arguments || data.args || data.input || data.function?.arguments || {};
-  return { name, input };
+  return { name, input, id: id || null, status };
 }
 
 function _usageFrom(obj) {
@@ -675,6 +717,17 @@ function parseError(rawOutput) {
   if (!text) return { message: '', code: null, retriable: true };
   const lower = text.toLowerCase();
 
+  if (/requires a newer version of codex|upgrade to the latest (?:app or )?cli|codex (?:cli )?is (?:too old|out of date)/i.test(text)) {
+    const name = _extractInvalidModelName(text)
+      || (text.match(/['"`]([A-Za-z0-9._\/-]+)['"`]/)?.[1])
+      || 'configured model';
+    return {
+      message: `The installed Codex CLI is too old for model "${name}". Upgrade Codex, refresh the model list, and try again.`,
+      code: 'config-error',
+      retriable: false,
+    };
+  }
+
   const hasAuth = /not authenticated|login required|please.*log.*in|api key.*invalid|invalid api key|\bunauthorized\b|\b401\b|\b403\b/i.test(text);
   if (hasAuth) {
     return { message: 'Codex authentication failed - run `codex login` or configure an OpenAI API key, then try again.', code: 'auth-failure', retriable: false };
@@ -773,6 +826,20 @@ async function listModels({ env = process.env, timeoutMs = 10000 } = {}) {
   }
 }
 
+function getModelCacheKey({ env = process.env, timeoutMs = 10000 } = {}) {
+  const resolved = resolveBinary({ env });
+  if (!resolved) return null;
+  try {
+    return _execFileCapture(resolved.bin, [...(resolved.leadingArgs || []), '--version'], {
+      env,
+      timeoutMs,
+      native: resolved.native,
+    }).trim() || null;
+  } catch {
+    return null;
+  }
+}
+
 function createStreamConsumer(ctx) {
   let deltaText = '';
   let terminalText = '';
@@ -789,7 +856,11 @@ function createStreamConsumer(ctx) {
     if (/reasoning|thinking/i.test(type)) ctx.notifyThinking();
 
     const toolUse = _extractToolUse(obj);
-    if (toolUse) ctx.pushToolUse(toolUse.name, toolUse.input);
+    if (toolUse) {
+      const seen = ctx.toolUseAlreadySeen(toolUse.name, toolUse.input, toolUse.id);
+      if (!seen) ctx.pushToolUse(toolUse.name, toolUse.input, toolUse.id);
+      if (toolUse.id && toolUse.status) ctx.updateToolUse(toolUse.id, toolUse.status);
+    }
 
     const delta = _extractDelta(obj);
     if (delta) {
@@ -823,6 +894,9 @@ const capabilities = {
   costTracking: false,
   modelShorthands: false,
   modelDiscovery: true,
+  // Bundled catalogs can lag staged/custom model availability. Let Codex
+  // validate unknown IDs so it can return its precise version/provider error.
+  strictModelCatalog: false,
   promptViaArg: false,
   budgetCap: false,
   bareMode: false,
@@ -830,9 +904,7 @@ const capabilities = {
   sessionPersistenceControl: false,
   resumePromptCarryover: true,
   streamConsumer: true,
-  // P-7b2e4d01: no image-input mechanism (CLI not installed during spike
-  // P-3f8a1c92). Engine code gates on this flag, never on runtime.name.
-  imageInput: false,
+  imageInput: true,
 };
 
 const INSTALL_HINT = 'install Codex CLI with `npm install -g @openai/codex` or `brew install --cask codex`, then run `codex login`.';
@@ -844,6 +916,7 @@ module.exports = {
   resolveBinary,
   capsFile: CAPS_FILE,
   listModels,
+  getModelCacheKey,
   modelsCache: MODELS_CACHE,
   spawnScript: path.join(ENGINE_DIR, 'spawn-agent.js'),
   installHint: INSTALL_HINT,
@@ -878,5 +951,6 @@ module.exports = {
   _extractModelsFromCatalog,
   _readCatalogIds,
   _extractInvalidModelName,
+  _extractToolUse,
   CAPS_SCHEMA_VERSION,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2376",
+  "version": "0.1.2377",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"