@yemi33/minions 0.1.2370 → 0.1.2372

package/bin/minions.js

@@ -10,7 +10,7 @@
  *   minions list                     List linked projects
  *   minions update [--no-wait]       Update to latest version (--no-wait backgrounds the post-update restart)
  *   minions version                  Show installed and package versions
- *   minions doctor [--harness]       Check prerequisites and runtime health (--harness: print harness propagation diagnostic)
+ *   minions doctor [--harness]       Check prerequisites and runtime health (--harness: print runtime harness inventory)
  *   minions restart [--open]         Stop + start engine + dashboard (--open forces a new browser tab)
  *   minions start [--open]           Start engine + dashboard if not already running (no-op when up)
  *   minions stop                     Stop the engine
@@ -29,7 +29,7 @@
  *   minions config set-cli <R> [--model M]  Persist default runtime/model
  *   minions bridge <subcmd>          Constellation bridge: status|health|enable|disable
  *   minions plan <file|text> [proj]  Run a plan
- *   minions mcp-sync                 Print harness propagation diagnostic (read-only; same source as `doctor --harness`)
+ *   minions mcp-sync                 Print runtime harness inventory (read-only; same source as `doctor --harness`)
  *   minions nuke --confirm           Factory reset runtime state/config
  *   minions uninstall --confirm      Remove Minions and uninstall package
  */
@@ -44,7 +44,6 @@
   if (!Number.isFinite(major) || major < 22 || major >= 24) return;
   const opts = String(process.env.NODE_OPTIONS || '');
   if (opts.includes('--experimental-sqlite')) return;
-  if (process.env.MINIONS_FORCE_JSON === '1') return; // explicit opt-out
   const { spawnSync } = require('child_process');
   const nextOpts = (opts + ' --experimental-sqlite').trim();
   const res = spawnSync(
@@ -319,12 +318,9 @@ function _openStdioLog(name) {
  * /api/work-items returns [] from the aggregate reader because the
  * Phase-9-canonical SQL path is unreachable.
  *
- * Honors NODE_OPTIONS / MINIONS_FORCE_JSON: if the caller already has the
- * flag set (via NODE_OPTIONS) or has opted out of SQL entirely
- * (MINIONS_FORCE_JSON=1), we add nothing — the child inherits the env.
+ * Honors NODE_OPTIONS: if the caller already has the flag, we add nothing.
  */
 function _sqliteSpawnFlags() {
-  if (process.env.MINIONS_FORCE_JSON === '1') return [];
   const major = parseInt(String(process.versions.node).split('.')[0], 10);
   if (!Number.isFinite(major) || major < 22 || major >= 24) return [];
   const nodeOpts = String(process.env.NODE_OPTIONS || '');
@@ -1212,7 +1208,7 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
     minions init                     Bootstrap ~/.minions/ (first time)
     minions update [--no-wait]       Update to latest version (--no-wait backgrounds the restart)
     minions version                  Show installed vs package version
-    minions doctor [--harness]       Check prerequisites and runtime health (--harness: print harness propagation diagnostic)
+    minions doctor [--harness]       Check prerequisites and runtime health (--harness: print runtime harness inventory)
     minions add <project-dir>        Link a project (interactive)
     minions remove <project-dir>     Unlink a project
     minions list                     List linked projects
@@ -1235,11 +1231,10 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
     minions config set-cli <R> [--model M]
                                       Persist default runtime/model without starting
     minions bridge <subcmd>          Constellation bridge: status|health|enable|disable
-    minions mcp-sync                 Print harness propagation diagnostic (read-only; same source as 'doctor --harness')
+    minions mcp-sync                 Print runtime harness inventory (read-only; same source as 'doctor --harness')
     minions cleanup                  Clean temp files, worktrees, zombies
     minions pr comment <repo> <n>    Post a marker-prepended PR comment via gh
                                        --agent <id> --kind <k> [--wi <id>] (--body-file <f> | --body <text>)
-                                       [--harness-file <f> | --harness-json <j>] folds in a "Harnesses used" section
     minions nuke --confirm           Factory reset (delete state, reset config to defaults)
     minions uninstall --confirm      Remove everything + uninstall npm package
 
@@ -1610,11 +1605,43 @@ ${fs.existsSync(path.join(PKG_ROOT, '.git')) ? `
   console.log('\n  Minions uninstalled. Your project repos were not touched.');
   console.log('\n  To re-install later, run:');
   console.log('    npm install -g @yemi33/minions && minions init\n');
+} else if (cmd === 'state') {
+  ensureInstalled();
+  const operations = require(path.join(MINIONS_HOME, 'engine', 'state-operations'));
+  const sub = rest[0];
+  try {
+    let result;
+    if (sub === 'check') result = operations.checkState();
+    else if (sub === 'backup') result = operations.backupState(rest[1]);
+    else if (sub === 'export') result = operations.exportState(rest[1]);
+    else if (sub === 'import-legacy-json') {
+      if (!rest.includes('--confirm')) throw new Error('legacy import requires --confirm');
+      const enginePid = readEnginePid(MINIONS_HOME);
+      if (enginePid) {
+        try {
+          process.kill(enginePid, 0);
+          throw new Error(`engine PID ${enginePid} is running; stop Minions before importing`);
+        } catch (e) {
+          if (!e.code) throw e;
+        }
+      }
+      result = operations.importLegacyJson(rest[1]);
+    }
+    else {
+      console.error('\n  Usage: minions state (check|backup <file>|export <file>|import-legacy-json <dir> --confirm)\n');
+      process.exit(2);
+    }
+    console.log(JSON.stringify(result, null, 2));
+    process.exit(result.ok === false ? 1 : 0);
+  } catch (e) {
+    console.error(`\n  State ${sub || 'operation'} failed: ${e.message}\n`);
+    process.exit(1);
+  }
 } else if (cmd === 'doctor') {
   ensureInstalled();
   const { doctor, runHarnessDoctor } = require(path.join(MINIONS_HOME, 'engine', 'preflight'));
   if (rest.includes('--harness')) {
-    // P-a3f9b2c1 — print the harness propagation diagnostic and exit. The
+    // Print the read-only runtime harness inventory and exit. The
     // legacy `minions doctor` still runs the full preflight + runtime fleet
     // sweep; `--harness` is a one-shot survey of the asset-propagation
     // surfaces only (see docs/harness-propagation.md).

package/dashboard/js/render-other.js

@@ -1024,12 +1024,12 @@ function renderHarnessDiagnostics(diag) {
     return;
   }
   const parts = [];
-  parts.push('<div style="font-size:var(--text-sm);color:var(--muted);margin-bottom:8px">Fleet-default runtime: <code style="color:var(--blue)">' + escHtml(diag.fleetDefaultCli || '?') + '</code></div>');
+  parts.push('<div style="font-size:var(--text-sm);color:var(--muted);margin-bottom:8px">Fleet-default runtime: <code style="color:var(--blue)">' + escHtml(diag.fleetDefaultCli || '?') + '</code>. Adapter inventory only: each CLI performs native discovery from its cwd and user configuration.</div>');
 
   // Per-runtime adapter rows
   for (const r of diag.runtimes || []) {
     parts.push('<details data-hkey="rt:' + escHtml(r.name) + '" style="margin:6px 0;border:1px solid var(--border);border-radius:6px;padding:8px 10px;background:var(--surface2)"><summary style="font-weight:600;cursor:pointer">Runtime: ' + escHtml(r.name) + '</summary>' +
-      _harnessRowsBlock('User asset dirs (--add-dir)', r.userAssetDirs) +
+      _harnessRowsBlock('User asset dirs (adapter inventory)', r.userAssetDirs) +
       _harnessRowsBlock('Skill roots (CLI native discovery)', r.skillRoots) +
       _harnessRowsBlock('Skill write targets', r.skillWriteTargets) +
       _harnessRowsBlock('Slash command roots', r.commandRoots) +
@@ -1037,17 +1037,6 @@ function renderHarnessDiagnostics(diag) {
     '</details>');
   }
 
-  // --add-dir snapshot for fleet default
-  const snap = diag.addDirSnapshot || [];
-  parts.push('<details data-hkey="addDirSnapshot" open style="margin:6px 0;border:1px solid var(--border);border-radius:6px;padding:8px 10px;background:var(--surface2)"><summary style="font-weight:600;cursor:pointer">--add-dir snapshot for ' + escHtml(diag.fleetDefaultCli || 'fleet default') + ' <span style="color:var(--muted);font-weight:400">(' + snap.length + ' dir' + (snap.length === 1 ? '' : 's') + ')</span></summary>' +
-    (snap.length === 0
-      ? '<div style="font-size:var(--text-sm);color:var(--muted);margin:6px 0 0 12px"><em>(no dirs attached — engine/spawn-agent.js unavailable or adapter has no asset dirs)</em></div>'
-      : snap.map(d =>
-          '<div style="font-family:monospace;font-size:var(--text-sm);margin-left:18px;display:flex;gap:8px;align-items:baseline"><span style="color:var(--green)">✓</span> <span>' + escHtml(d.path) + '</span> <span style="color:var(--muted)">[' + escHtml(d.scope) + ']</span></div>'
-        ).join('')
-    ) +
-  '</details>');
-
   // Suppressed assets
   const suppressed = diag.suppressed || [];
   if (suppressed.length > 0) {
@@ -1059,22 +1048,6 @@ function renderHarnessDiagnostics(diag) {
     '</details>');
   }
 
-  // Project-local-on-main footgun
-  const footgun = (diag.projectLocalOnMain || []).filter(e => e && e.uncommittedAssets && e.uncommittedAssets.length > 0);
-  if (footgun.length > 0) {
-    parts.push('<details data-hkey="footgun" open style="margin:6px 0;border:1px solid var(--orange);border-radius:6px;padding:8px 10px;background:var(--surface2)"><summary style="font-weight:600;cursor:pointer;color:var(--orange)">⚠ Project-local assets on main checkout (won\'t propagate to worktree)</summary>' +
-      footgun.map(entry =>
-        '<div style="margin:8px 0 0 12px">' +
-          '<div style="font-weight:600">' + escHtml(entry.project) + ' <span style="font-family:monospace;color:var(--muted);font-weight:400">' + escHtml(entry.localPath) + '</span></div>' +
-          '<div style="font-size:var(--text-sm);color:var(--muted);margin:4px 0 6px">' + escHtml(entry.footgunWarning || '') + '</div>' +
-          entry.uncommittedAssets.map(a =>
-            '<div style="font-family:monospace;font-size:var(--text-sm);margin-left:12px;display:flex;gap:8px;align-items:baseline"><span style="color:var(--orange)">⚠</span> <span>' + escHtml(a.file) + '</span> <span style="color:var(--muted)">[' + escHtml(a.kind) + ']</span></div>'
-          ).join('') +
-        '</div>'
-      ).join('') +
-    '</details>');
-  }
-
   // Missing dirs summary (aggregate)
   const missing = diag.missingDirs || [];
   if (missing.length > 0) {
@@ -1257,4 +1230,3 @@ async function killKeepPid(agentId, pid) {
 }
 
 window.MinionsKeepProcesses = { renderKeepProcesses, killKeepPid, mountKeepProcessesPanel, unmountKeepProcessesPanel };
-

package/dashboard/js/render-work-items.js

@@ -921,40 +921,6 @@ function _wiRenderDetail(item) {
   // a dead artifact link).
   if (arts.branch) html += field('Branch', '🌿 <code style="font-size:var(--text-sm);background:var(--surface2);padding:2px 6px;border-radius:var(--radius-sm)">' + escapeHtml(arts.branch) + '</code>');
 
-  // P-d5a6f7c4 (Harness Transparency, Stage 3 — surface). Render the harness
-  // usage the agent self-reported. Shape:
-  // { skills:[{name,source,path}], mcpServers:[{name,scope}],
-  //   commands:[{name,scope}], docs:[{path,why}] }. Every entry renders as a
-  // plain solid pill; the engine's internal grounding flag is not surfaced.
-  (function() {
-    var hu = item._harnessUsed;
-    if (!hu || typeof hu !== 'object') return;
-    var kinds = [
-      { key: 'skills', icon: '🧩', label: 'Skill', primary: 'name', secondary: 'source' },
-      { key: 'mcpServers', icon: '🔌', label: 'MCP', primary: 'name', secondary: 'scope' },
-      { key: 'commands', icon: '⌘', label: 'Command', primary: 'name', secondary: 'scope' },
-      { key: 'docs', icon: '📄', label: 'Doc', primary: 'path', secondary: 'why' },
-    ];
-    var pills = '';
-    var pStyle = 'display:inline-flex;align-items:center;gap:4px;padding:2px 8px;border-radius:10px;font-size:var(--text-sm);background:var(--surface2);border:1px solid var(--border);color:var(--text)';
-    kinds.forEach(function(k) {
-      var entries = Array.isArray(hu[k.key]) ? hu[k.key] : [];
-      entries.forEach(function(e) {
-        if (!e || typeof e !== 'object') return;
-        var primary = e[k.primary];
-        if (typeof primary !== 'string' || !primary) return;
-        var secondary = (typeof e[k.secondary] === 'string') ? e[k.secondary] : '';
-        var title = k.label + (secondary ? ' (' + secondary + ')' : '');
-        pills += '<span style="' + pStyle + '" title="' + escapeHtml(title) + '">'
-          + k.icon + ' ' + escapeHtml(primary)
-          + (secondary ? ' <span style="color:var(--muted);font-size:var(--text-xs)">' + escapeHtml(secondary) + '</span>' : '')
-          + '</span> ';
-      });
-    });
-    if (!pills) return;
-    html += field('Repo harnesses used', '<div style="display:flex;flex-wrap:wrap;gap:4px">' + pills + '</div>');
-  })();
-
   // P-34fa5d79 — Mentions: notes whose YAML frontmatter cites this WI
   // (work_item: / wi: / sourceItem:). Slim string[] field set by
   // engine/queries.js#getWorkItems from _buildNotesByWiMap. Each entry is

package/dashboard/js/settings.js

@@ -473,7 +473,6 @@ async function openSettings() {
       // Tooltip on copilotDisableBuiltinMcps MUST warn about the split-brain risk
       settingsToggle('Copilot: disable built-in MCPs', 'set-copilotDisableBuiltinMcps', e.copilotDisableBuiltinMcps !== false,
         '⚠ When OFF, Copilot agents can autonomously create PRs/labels/comments via the github-mcp-server, bypassing pull-requests.json tracking — Minions and Copilot end up with split views of the same PR. Keep ON unless you understand the risk.') +
-      settingsToggle('Copilot: suppress AGENTS.md', 'set-copilotSuppressAgentsMd', e.copilotSuppressAgentsMd !== false, '--no-custom-instructions: stops AGENTS.md auto-load from fighting Minions playbook prompts') +
       settingsToggle('Copilot: reasoning summaries', 'set-copilotReasoningSummaries', !!e.copilotReasoningSummaries, '--enable-reasoning-summaries (Anthropic-family models only)') +
     '</div>' +
     '<div class="settings-grid-2">' +
@@ -485,13 +484,13 @@ async function openSettings() {
         '</select>' +
       '</div>' +
       settingsField('Copilot fallback model', 'set-copilotFallbackModel', e.copilotFallbackModel || '', 'e.g. gpt-5.4', 'Copilot has no --fallback-model flag. On a MODEL_UNAVAILABLE (overloaded/503) retry, the engine OVERRIDES --model with this value (Copilot only).') +
-    '</div>' +
-    '<div class="settings-stack" style="margin-top:12px">' +
-      settingsField('Copilot: disable agent MCP servers', 'set-copilotAgentDisabledMcpServers',
-        Array.isArray(e.copilotAgentDisabledMcpServers) ? e.copilotAgentDisabledMcpServers.join(', ') : (e.copilotAgentDisabledMcpServers || ''),
-        'e.g. playwright, maestro, loop',
-        'Comma-separated MCP server names (from ~/.copilot/mcp-config.json) the engine disables for autonomous Copilot agent dispatches via --disable-mcp-server. Copilot loads your user MCP config on every spawn regardless of --add-dir/hermeticHarness; list the noisy local/UI servers (e.g. playwright, maestro) to keep them out of agents. Empty = inherit all.') +
-    '</div>';
+      '</div>' +
+      '<div class="settings-stack" style="margin-top:12px">' +
+        settingsField('Copilot: disable agent MCP servers', 'set-copilotAgentDisabledMcpServers',
+          Array.isArray(e.copilotAgentDisabledMcpServers) ? e.copilotAgentDisabledMcpServers.join(', ') : (e.copilotAgentDisabledMcpServers || ''),
+          'e.g. playwright, maestro, loop',
+          'Comma-separated MCP server names (from ~/.copilot/mcp-config.json) the engine disables for autonomous Copilot agent dispatches by filtering them out of the agent-only COPILOT_HOME. Copilot loads your user MCP config on every spawn regardless of --add-dir; list the noisy/auth-popping servers (e.g. playwright, maestro) to keep them out of agents. Empty = inherit all.') +
+      '</div>';
 
   const paneClaude =
     '<h3>Claude Tuning</h3>' +
@@ -509,20 +508,12 @@ async function openSettings() {
       'Permission bypass is runtime-owned: Claude agents use <code>--dangerously-skip-permissions</code>; Copilot agents use <code>--autopilot --allow-all --no-ask-user</code>. There is no dashboard permission-mode setting.' +
     '</div>';
 
-  // Harness propagation knobs (PL-seamless-harness-invocation, P-2bd84e91).
-  // All three flags govern what the spawned agent inherits from the operator's
-  // local CLI harness (user-scope skills/commands/MCPs, project-local-on-main
-  // assets, Claude workspace .mcp.json pre-approval). See docs/harness-propagation.md.
   const paneHarness =
-    '<h3>Harness Propagation</h3>' +
-    '<div class="settings-pane-sub">Controls what the spawned agent sees from your local CLI harness (skills, commands, MCPs). Defaults match the docs/harness-propagation.md contract — flip these only if you understand the tradeoff. The Tools tab\'s Harness diagnostics view shows the live propagated surface.</div>' +
+    '<h3>Native Runtime Integration</h3>' +
+    '<div class="settings-pane-sub">Repository instructions, skills, commands, and MCPs are discovered by the selected CLI in the dispatched checkout. Minions does not inject or suppress them.</div>' +
     '<div class="settings-stack" style="margin-bottom:12px">' +
-      settingsToggle('Propagate project-local harness on main', 'set-harnessPropagateProjectLocal', e.harnessPropagateProjectLocal !== false,
-        'P-08b62d49: surface uncommitted <repo>/.claude/skills, <repo>/.copilot/commands, etc. into the worktree dispatch via extra --add-dir entries. Default ON closes the worktree-uncommitted footgun. Turn OFF to fall back to the legacy "only committed assets are visible" behavior.') +
       settingsToggle('Claude: pre-approve workspace .mcp.json', 'set-claudePreApproveWorkspaceMcps', e.claudePreApproveWorkspaceMcps !== false,
-        'P-7d31a06b: pre-warms ~/.claude.json projects.<worktree>.enabledMcpjsonServers on every Claude spawn so the first invocation in a brand-new worktree skips the "trust this server?" prompt — which would otherwise be invisible behind --dangerously-skip-permissions and silently drop workspace MCPs. Claude-only (no-op on Copilot/Codex). Best-effort: failures never block dispatch.') +
-      settingsToggle('Hermetic harness (drop user-scope assets)', 'set-hermeticHarness', !!e.hermeticHarness,
-        '⚠ P-49e1c8b7 fleet-wide opt-out: when ON, --add-dir is exactly [minionsDir] (user-scope skill/command/MCP roots dropped), project-local propagation skipped, and Claude workspace .mcp.json pre-approval skipped. Use when you want a known-empty harness surface (reproducible CI runs, debugging "works in my CLI" bugs). Per-agent override available via agent.hermeticHarness. Default OFF.') +
+        'Pre-warms Claude workspace MCP trust so headless dispatch does not block on an invisible prompt. This enables the repository-native .mcp.json; it does not alter discovery.') +
     '</div>';
 
   const paneBudget =
@@ -614,7 +605,6 @@ async function openSettings() {
     '<div class="settings-stack">' +
       settingsToggle('Allow Temp Agents', 'set-allowTempAgents', !!e.allowTempAgents, 'Spawn ephemeral agents when all permanent agents are busy') +
       settingsToggle('Disable model discovery', 'set-disableModelDiscovery', !!e.disableModelDiscovery, 'Skip /api/runtimes/<name>/models REST calls fleet-wide. Settings UI falls back to free-text.') +
-      settingsToggle('QA: dual-write JSON sidecars', 'set-qaDualWriteJson', e.qaDualWriteJson !== false, 'Keep mirroring qa-runs.json and qa-sessions.json on every mutation alongside the SQLite source of truth. Default ON. Disable only once external tooling has been migrated off the JSON files — disabling drops the rollback path back to the JSON store.') +
     '</div>' +
     // W-mqk2s8q1 — dashboard refresh diagnostics, relocated here from the
     // floating bottom-left "diag" chip so it sits alongside the other
@@ -644,7 +634,7 @@ async function openSettings() {
     { id: 'worktree', label: 'Worker Pool & Worktrees', html: paneWorktree },
     { id: 'copilot', label: 'Copilot Tuning', html: paneCopilot },
     { id: 'claude', label: 'Claude Tuning', html: paneClaude },
-    { id: 'harness', label: 'Harness Propagation', html: paneHarness },
+    { id: 'harness', label: 'Runtime Harness', html: paneHarness },
     { id: 'budget', label: 'Budget', html: paneBudget },
     { id: 'maxturns', label: 'Max Turns', html: paneMaxTurns },
     { id: 'features', label: 'Feature Flags', html: paneFeatures },
@@ -1197,16 +1187,11 @@ async function saveSettings() {
       claudeBareMode: !!document.getElementById('set-claudeBareMode')?.checked,
       claudeFallbackModel: (document.getElementById('set-claudeFallbackModel')?.value ?? '').trim(),
       copilotFallbackModel: (document.getElementById('set-copilotFallbackModel')?.value ?? '').trim(),
+      copilotAgentDisabledMcpServers: (document.getElementById('set-copilotAgentDisabledMcpServers')?.value ?? '').trim(),
       copilotDisableBuiltinMcps: !!document.getElementById('set-copilotDisableBuiltinMcps')?.checked,
-      copilotSuppressAgentsMd: !!document.getElementById('set-copilotSuppressAgentsMd')?.checked,
       copilotStreamMode: document.getElementById('set-copilotStreamMode')?.value || 'on',
       copilotReasoningSummaries: !!document.getElementById('set-copilotReasoningSummaries')?.checked,
-      // Harness propagation knobs (P-2bd84e91). Booleans round-trip through
-      // handleSettingsUpdate's auto boolean-fields loop because all three live
-      // in ENGINE_DEFAULTS as booleans.
-      harnessPropagateProjectLocal: !!document.getElementById('set-harnessPropagateProjectLocal')?.checked,
       claudePreApproveWorkspaceMcps: !!document.getElementById('set-claudePreApproveWorkspaceMcps')?.checked,
-      hermeticHarness: !!document.getElementById('set-hermeticHarness')?.checked,
       maxBudgetUsd: (document.getElementById('set-maxBudgetUsd')?.value ?? '').trim(),
       disableModelDiscovery: !!document.getElementById('set-disableModelDiscovery')?.checked,
       qaDualWriteJson: !!document.getElementById('set-qaDualWriteJson')?.checked,

package/dashboard/pages/tools.html

@@ -11,6 +11,6 @@
         <div id="mcp-list"><p class="empty">No MCP servers synced.</p></div>
       </section>
       <section>
-        <h2>Harness Propagation <span class="qa-section-subtitle">what each runtime sees, what's attached via --add-dir, and which assets won't propagate to a fresh worktree</span></h2>
+        <h2>Runtime Harness Inventory <span class="qa-section-subtitle">native locations declared by each runtime adapter; inventory only, not proof of loading or use</span></h2>
         <div id="harness-diag"><p class="empty">Loading harness diagnostics…</p></div>
       </section>