@yemi33/minions 0.1.2353 → 0.1.2354

package/engine/pr-action.js

@@ -85,16 +85,20 @@ const PR_ACTION_FOLLOWUPS = Object.freeze([
   { kind: 'track-auto-fix', label: 'Track for auto-fix' },
 ]);
 
-/** Canonical `host:slug#number` id for a record/ref, or '' when unknowable. */
+/**
+ * Canonical `host:slug#number` id for a record/ref, or '' when unknowable.
+ *
+ * Thin wrapper over prResolve.prIdFromRef: normalizes the heterogeneous
+ * record shapes buildPrActionFollowups is called with — an explicit
+ * `record.prId`, a `record.ref` ref object, or a bare ref-shaped object
+ * (`{host, slug, number}`/`{id}`) — into the ref shape prIdFromRef expects,
+ * then delegates so the `host:slug#number` template literal has one owner.
+ */
 function _prIdForRecord(record) {
   if (!record) return '';
   if (record.prId) return record.prId;
   const ref = record.ref || record;
-  if (ref && ref.id) return ref.id;
-  if (ref && ref.host && ref.slug && (ref.number || ref.number === 0)) {
-    return `${ref.host}:${ref.slug}#${ref.number}`;
-  }
-  return '';
+  return prResolve.prIdFromRef(ref) || '';
 }
 
 /**
@@ -364,7 +368,8 @@ function buildPrActionPrompt(action, payload) {
     number: payload && payload.number,
     id: payload && payload.prId,
   };
-  const prId = ref.id || (ref.host && ref.slug && ref.number ? `${ref.host}:${ref.slug}#${ref.number}` : (payload && payload.slug ? `${payload.slug}#${payload.number}` : 'the pull request'));
+  const prId = prResolve.prIdFromRef(ref)
+    || (payload && payload.slug ? `${payload.slug}#${payload.number}` : 'the pull request');
   const guidance = PR_ACTION_GUIDANCE[act] || PR_ACTION_GUIDANCE.review;
 
   const sections = [