@yemi33/minions 0.1.2342 → 0.1.2343

package/engine/lifecycle.js

@@ -6758,10 +6758,26 @@ function collapseAllDuplicatePrRecords(config) {
 // meta.liveValidationFor === codingWiId AND meta.liveValidationType === type
 // blocks a second dispatch of that specific type, so multiple configured
 // types don't collide or skip each other.
+//
+// W-mr9u39az000db5c2 — guard against a self-referential recursive cascade.
+// When liveValidation.type overlaps with a coding WI's own type set (e.g.
+// ["test","verify","setup"] configured on a project that ALSO dispatches
+// "setup"/"test"/"fix" coding work), a completed validation WI (type
+// "setup") is itself a WI whose type is in liveValidation.type. The old
+// item.type-only filter let that validation WI's own completion re-trigger
+// this hook and spawn ANOTHER validation WI (title-prefixed "Validate:
+// Validate: ..."), repeating indefinitely. Any WI that was itself created
+// as a liveValidation follow-up (tagged via meta.liveValidationFor at
+// creation, below) must never re-trigger this hook, regardless of its type.
 function autoDispatchLiveValidationWi(meta, config) {
   const item = meta?.item;
   if (!item?.id || !item?.type) return;
 
+  // Never re-trigger off the completion of a WI that was itself auto-created
+  // as a live-validation follow-up — that's what causes the infinite
+  // "Validate: Validate: ..." cascade (W-mr9u39az000db5c2 / issue #708).
+  if (item.meta && item.meta.liveValidationFor) return;
+
   const projectName = meta?.project?.name;
   if (!projectName) return;
 
@@ -6819,9 +6835,19 @@ function autoDispatchLiveValidationWi(meta, config) {
           continue;
         }
 
+        const proposedTitle = 'Validate: ' + (item.title || codingWiId);
+        // Defense-in-depth (belt-and-suspenders alongside the meta.liveValidationFor
+        // guard above): never create a doubly-nested "Validate: Validate: ..."
+        // title even if some future caller manages to invoke this function
+        // directly on an already-validation-tagged item.
+        if (/^Validate:\s*Validate:/.test(proposedTitle)) {
+          log('warn', `liveValidation: refusing to create nested "Validate: Validate:" WI for ${codingWiId} (type=${validationType})`);
+          continue;
+        }
+
         const validationWi = {
           id: 'W-' + shared.uid(),
-          title: 'Validate: ' + (item.title || codingWiId),
+          title: proposedTitle,
           type: validationType,
           status: WI_STATUS.PENDING,
           depends_on: [codingWiId],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2342",
+  "version": "0.1.2343",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"