@yemi33/minions 0.1.2335 → 0.1.2337

package/docs/harness-transparency.md

@@ -125,7 +125,7 @@ evaluation pass) can see what tooling drove a dispatch:
    and ⚠️-marked), and returns `''` for an empty/absent record. The GitHub
    comment path folds it in via `engine/gh-comment.js#buildMinionsCommentBody`
    (optional `harnessUsed` arg, threaded through `postPrComment` /
-   `postPrReviewComment` / `postPrReview`); the Azure DevOps path mirrors it via
+   `postPrReviewComment`); the Azure DevOps path mirrors it via
    `engine/ado-comment.js#postAdoPrComment` (same builder, same `harnessUsed`
    arg). Both posters are reached from the `minions pr comment` CLI, which turns
    `--harness-file` / `--harness-json` into the grounded record and folds the

package/engine/gh-comment.js

@@ -210,50 +210,6 @@ function postPrReviewComment({
   }
 }
 
-const _REVIEW_EVENT_FLAGS = Object.freeze({
-  APPROVE: '--approve',
-  REQUEST_CHANGES: '--request-changes',
-  COMMENT: '--comment',
-});
-
-function postPrReview({
-  event,
-  repo,
-  prNumber,
-  body,
-  agentId,
-  kind,
-  workItemId,
-  harnessUsed,
-  skillSkipped,
-  timeoutMs = 30000,
-  execFileSync = _execFileSync,
-  resolveTokenForSlug,
-} = {}) {
-  const flag = _REVIEW_EVENT_FLAGS[event];
-  if (!flag) {
-    throw new Error(
-      `invalid event: ${JSON.stringify(event)} (expected APPROVE | REQUEST_CHANGES | COMMENT)`,
-    );
-  }
-  _validateRepo(repo);
-  _validatePrNumber(prNumber);
-  const finalBody = buildMinionsCommentBody({ agentId, kind, workItemId, body, harnessUsed, skillSkipped });
-  const file = _writeTempBodyFile(finalBody);
-  const env = _resolveTokenEnvForRepo(repo, resolveTokenForSlug);
-  try {
-    const output = _runGh(
-      execFileSync,
-      ['pr', 'review', String(prNumber), flag, '--repo', repo, '--body-file', file],
-      timeoutMs,
-      env,
-    );
-    return { output: String(output || '').trim(), bodyFile: file };
-  } finally {
-    try { fs.unlinkSync(file); } catch {}
-  }
-}
-
 module.exports = {
   // Builders / parsers (pure functions — usable from anywhere)
   buildMinionsCommentBody,
@@ -271,7 +227,6 @@ module.exports = {
   // gh wrappers (argv-form, --body-file)
   postPrComment,
   postPrReviewComment,
-  postPrReview,
   // Internal helpers exported for tests / advanced callers
   _buildMarker,
   _writeTempBodyFile,

package/engine/runtimes/claude.js

@@ -652,8 +652,26 @@ function createStreamConsumer(ctx) {
   let claudeJoinedText = '';
   const claudeStreamBlocks = new Map();
 
+  // Only the TRAILING run of text blocks (since the last non-text block)
+  // contributes to claudeJoinedText — a tool_use/thinking block closes the
+  // run so an earlier text block never welds onto a later one within the
+  // SAME message (W-mr9jj2vx000 — CC response duplicates/welds the final
+  // answer after ~15 tool calls). Claude can emit content as
+  // [text, tool_use, tool_use, ..., text] in one message when
+  // --include-partial-messages streams multiple parallel tool calls before
+  // a trailing answer; without this, content_block_delta blindly appended
+  // every text delta onto the same buffer regardless of the tool_use block
+  // in between, producing "<narration><tool icon><narration><answer>" with
+  // no paragraph break and no new segment (segmentSeq never bumped because
+  // stream-event tool_use blocks don't call ctx.pushToolUse).
   function _rebuildClaudeJoinedText() {
-    claudeJoinedText = Array.from(claudeStreamBlocks.keys()).sort((a, b) => a - b)
+    const indices = Array.from(claudeStreamBlocks.keys()).sort((a, b) => a - b);
+    let start = 0;
+    for (let i = indices.length - 1; i >= 0; i--) {
+      const block = claudeStreamBlocks.get(indices[i]);
+      if (!block || block.type !== 'text') { start = i + 1; break; }
+    }
+    claudeJoinedText = indices.slice(start)
       .map(index => claudeStreamBlocks.get(index))
       .filter(block => block && block.type === 'text' && block.text)
       .map(block => block.text)
@@ -673,6 +691,13 @@ function createStreamConsumer(ctx) {
       const block = event.content_block || {};
       claudeStreamBlocks.set(index, { type: block.type || '', text: block.text || '' });
       if (THINKING_BLOCK_TYPES.has(block.type)) ctx.notifyThinking();
+      // A non-text block (tool_use/thinking) closes the current text run —
+      // reset the hot-path accumulator so the NEXT text block starts fresh
+      // instead of welding onto text from before this block. `ctx.pushText`
+      // already opens a new segment when the pushed value doesn't extend
+      // `lastTextSent` (see engine/llm.js), so this reset is sufficient to
+      // both stop the weld and trigger the segment boundary.
+      if (block.type !== 'text') claudeJoinedText = '';
       // Out-of-order block landing: rebuild from the Map. Common case is
       // monotonic in-order arrival, where the trailing-append branch wins.
       const indices = Array.from(claudeStreamBlocks.keys());
@@ -735,21 +760,27 @@ function createStreamConsumer(ctx) {
 
     if (obj.type === 'assistant' && Array.isArray(obj.message?.content)) {
       // Claude assistant turn: content blocks (text + tool_use).
-      // Multi-text-block messages (with --include-partial-messages) need their
-      // text JOINED before pushText, otherwise each block overwrites the prior.
+      // Multi-text-block messages (with --include-partial-messages) need
+      // consecutive text blocks JOINED before pushText, otherwise each block
+      // overwrites the prior. But a tool_use block closes the current text
+      // run — reset the accumulator on tool_use so trailing text starts a
+      // fresh segment instead of welding onto text from before the tool
+      // call(s) (W-mr9jj2vx0004bbb9 follow-up: this full-envelope path hits
+      // the same weld bug as the stream_event path above).
       let assistantText = '';
       for (const block of obj.message.content) {
         if (block?.type === 'text' && block.text) {
           assistantText += block.text;
+          ctx.pushText(assistantText);
         } else if (THINKING_BLOCK_TYPES.has(block?.type)) {
           ctx.notifyThinking();
         } else if (block?.type === 'tool_use' && block.name) {
           // Thread the tool_use id so the dashboard can flip this chip from
           // pending → completed/failed when the matching tool_result lands.
           ctx.pushToolUse(block.name, block.input || {}, block.id);
+          assistantText = '';
         }
       }
-      if (assistantText) ctx.pushText(assistantText);
     }
 
     if (obj.type === 'user' && Array.isArray(obj.message?.content)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2335",
+  "version": "0.1.2337",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"