@yemi33/minions 0.1.2329 → 0.1.2331

package/engine/consolidation.js

@@ -1398,7 +1398,7 @@ function archiveInboxFiles(files) {
         const rel = path.relative(shared.MINIONS_DIR, dest).replace(/\\/g, '/');
         shared.rewriteInboxRefsAcrossProjects(f, rel);
       } catch (e) { log('warn', `Inbox-ref rewrite (${f}): ${e.message}`); }
-      fs.renameSync(path.join(INBOX_DIR, f), dest);
+      shared._retryFsOp(() => fs.renameSync(path.join(INBOX_DIR, f), dest), `archive inbox ${f}`);
     } catch (err) { log('warn', `Inbox archive: ${err.message}`); }
   }
 }

package/engine/kb-sweep.js

@@ -14,7 +14,7 @@ const path = require('path');
 const crypto = require('crypto');
 const shared = require('./shared');
 const queries = require('./queries');
-const { safeRead, safeWrite, safeJson, safeUnlink, log, ts } = shared;
+const { safeRead, safeReadOrNull, safeWrite, safeJson, safeUnlink, log, ts } = shared;
 const { MINIONS_DIR, ENGINE_DIR } = queries;
 
 const KB_DIR = path.join(MINIONS_DIR, 'knowledge');
@@ -58,11 +58,10 @@ function _serializeFrontmatter(fm, body) {
 }
 
 function _archiveKbFile(filePath, reason) {
-  if (!fs.existsSync(filePath)) return false;
   if (!fs.existsSync(SWEPT_DIR)) fs.mkdirSync(SWEPT_DIR, { recursive: true });
   const destPath = shared.uniquePath(path.join(SWEPT_DIR, path.basename(filePath)));
   try {
-    const content = safeRead(filePath);
+    const content = safeReadOrNull(filePath);
     if (content === null) return false;
     safeWrite(destPath, `<!-- swept: ${new Date().toISOString()} | reason: ${reason} -->\n${content}`);
     safeUnlink(filePath);
@@ -707,6 +706,7 @@ module.exports = {
   _parseFrontmatter,
   _serializeFrontmatter,
   _hashDedup,
+  _archiveKbFile,
   COMPRESS_THRESHOLD_BYTES,
   SWEPT_FLAG_KEY,
 };

package/engine/lifecycle.js

@@ -6715,8 +6715,15 @@ function autoDispatchLiveValidationWi(meta, config) {
 
   // Resolve PR reference: prefer the canonical stamped _pr field (set by
   // stampWiPrRef which runs earlier in runPostCompletionHooks), then fall
-  // back to extractWorkItemPrRef for structured fields / references[].
-  const prRef = item._pr || item._prUrl || shared.extractWorkItemPrRef(item) || null;
+  // back to extractStructuredWorkItemPrRef for structured fields /
+  // references[] ONLY. This function auto-dispatches for ANY configured
+  // liveValidation.type (not just type:'fix'), so we must NOT use
+  // extractWorkItemPrRef's prose-scan fallback here — that fallback is
+  // reserved for the type:'fix'-gated branch-derivation path
+  // (W-mq18ec6h000p7b87) and would otherwise let a non-fix WI (e.g.
+  // 'implement'/'docs') that merely *mentions* an unrelated PR number in
+  // prose trigger a live-validation dispatch against the wrong PR.
+  const prRef = item._pr || item._prUrl || shared.extractStructuredWorkItemPrRef(item) || null;
   if (!prRef) return;
 
   const codingWiId = item.id;

package/engine/managed-spawn.js

@@ -1053,7 +1053,19 @@ function waitForFirstHealth(spec, opts) {
     let lastError = null;
     const tick = async () => {
       if (stopped) return;
-      const result = await runHealthcheck(spec);
+      let result;
+      try {
+        result = await runHealthcheck(spec);
+      } catch (e) {
+        // A healthcheck implementation throwing instead of resolving
+        // {healthy:false, error} (probe bug, malformed spec, etc.) must not
+        // become an unhandled rejection and must not leave this promise
+        // hanging forever — resolve unhealthy so the caller's
+        // Promise.allSettled/timeout path still progresses.
+        if (stopped) return;
+        stopped = true;
+        return resolve({ healthy: false, error: String((e && e.message) || e), lastCheckAt: Date.now() });
+      }
       if (stopped) return;
       if (result.healthy) {
         stopped = true;
@@ -1302,7 +1314,7 @@ function _rotateManagedLog(logPath, cap) {
   try {
     try { fs.unlinkSync(rotated); }
     catch (e) { if (e && e.code !== 'ENOENT') throw e; }
-    fs.renameSync(logPath, rotated);
+    shared._retryFsOp(() => fs.renameSync(logPath, rotated), `rotate managed log ${logPath}`);
     return true;
   } catch (e) {
     log('warn', 'managed-spawn rotate: ' + logPath + ' failed: ' + e.message);

package/engine/pipeline.js

@@ -59,7 +59,15 @@ function savePipeline(pipeline) {
 function deletePipeline(id) {
   const filePath = path.join(PIPELINES_DIR, id + '.json');
   if (!fs.existsSync(filePath)) return false;
-  fs.unlinkSync(filePath);
+  try {
+    fs.unlinkSync(filePath);
+  } catch (e) {
+    // TOCTOU: a concurrent delete of the same id may win the race between
+    // existsSync and unlinkSync. Treat ENOENT as "already deleted" instead
+    // of throwing, mirroring deleteMeeting's unlink guard (engine/meeting.js).
+    if (e.code !== 'ENOENT') throw e;
+    return false;
+  }
   return true;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2329",
+  "version": "0.1.2331",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"