@yemi33/minions 0.1.2326 → 0.1.2328

package/dashboard.js

@@ -9105,6 +9105,29 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     }
   }
 
+  // W-mr5m9inn002d27e1 — safeWrite/safeUnlink can both throw or silently no-op
+  // (disk full, permission error, locked file on Windows). Previously the
+  // archive step's try/catch only logged to console.error while the handler
+  // still returned ok:true, so a failed archive left the note in
+  // notes/inbox/ (risking double-processing) with no operator-visible
+  // signal. Centralize the archive attempt so both call sites report
+  // {archived, archiveError} instead of swallowing the failure.
+  function _archiveInboxNote(inboxPath, archiveDestPath) {
+    try {
+      const _c = safeRead(inboxPath);
+      safeWrite(archiveDestPath, _c);
+      safeUnlink(inboxPath);
+      if (fs.existsSync(inboxPath)) {
+        // safeUnlink swallows its own errors, so a failed removal doesn't
+        // throw — detect it by checking the source file is actually gone.
+        return { archived: false, archiveError: 'inbox note could not be removed after archiving (unlink failed)' };
+      }
+      return { archived: true, archiveError: null };
+    } catch (e) {
+      return { archived: false, archiveError: e.message };
+    }
+  }
+
   async function handleInboxPersist(req, res) {
     try {
       const body = await readBody(req);
@@ -9150,9 +9173,12 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       // Move to archive
       const archiveDir = path.join(MINIONS_DIR, 'notes', 'archive');
       if (!fs.existsSync(archiveDir)) fs.mkdirSync(archiveDir, { recursive: true });
-      try { const _c = safeRead(inboxPath); safeWrite(path.join(archiveDir, `persisted-${name}`), _c); safeUnlink(inboxPath); } catch (e) { console.error('inbox archive:', e.message); }
+      const { archived, archiveError } = _archiveInboxNote(inboxPath, path.join(archiveDir, `persisted-${name}`));
+      if (!archived) console.error('inbox archive:', archiveError);
 
-      return jsonReply(res, 200, { ok: true, title });
+      return jsonReply(res, 200, archived
+        ? { ok: true, title, archived: true }
+        : { ok: true, title, archived: false, warning: `Persisted to notes.md, but the inbox note could not be archived: ${archiveError}. It remains in notes/inbox and may be reprocessed.` });
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
 
@@ -9215,9 +9241,12 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       // Move inbox item to archive
       const archiveDir = path.join(MINIONS_DIR, 'notes', 'archive');
       if (!fs.existsSync(archiveDir)) fs.mkdirSync(archiveDir, { recursive: true });
-      try { const _c = safeRead(inboxPath); safeWrite(path.join(archiveDir, `kb-${category}-${name}`), _c); safeUnlink(inboxPath); } catch (e) { console.error('inbox archive:', e.message); }
+      const { archived, archiveError } = _archiveInboxNote(inboxPath, path.join(archiveDir, `kb-${category}-${name}`));
+      if (!archived) console.error('inbox archive:', archiveError);
 
-      return jsonReply(res, 200, { ok: true, category, file: name });
+      return jsonReply(res, 200, archived
+        ? { ok: true, category, file: name, archived: true }
+        : { ok: true, category, file: name, archived: false, warning: `Promoted to knowledge/${category}/${name}, but the inbox note could not be archived: ${archiveError}. It remains in notes/inbox and may be reprocessed.` });
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
 

package/engine/cli.js

@@ -1488,7 +1488,7 @@ const commands = {
     }
 
     console.log('');
-    const metrics = shared.safeJson(path.join(ENGINE_DIR, 'metrics.json')) || {};
+    const metrics = shared.safeJsonObj(path.join(ENGINE_DIR, 'metrics.json'));
     const lifetimeCompleted = Object.entries(metrics).filter(([k]) => !k.startsWith('_')).reduce((sum, [, m]) => sum + (m.tasksCompleted || 0) + (m.tasksErrored || 0), 0);
     console.log(`Dispatch: ${dispatch.pending.length} pending | ${(dispatch.active || []).length} active | ${lifetimeCompleted} completed`);
     const pidSummary = summarizeActiveDispatchPids(dispatch.active || []);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2326",
+  "version": "0.1.2328",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"