@yemi33/minions 0.1.2317 → 0.1.2318

package/engine/dispatch.js

@@ -853,7 +853,19 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
         completedWorkItemFailure = isCompletedWorkItemForFailure(liveWi);
       } catch (e) { log('warn', 'read live work item before retry: ' + e.message); }
     }
-    if (result === DISPATCH_RESULT.ERROR && item.meta?.dispatchKey && retryableFailure && !completedWorkItemFailure) {
+    // #634 — cooldown backoff bookkeeping is independent of the retry decision.
+    // `retryableFailure` (== `agentRetryable`) governs whether the engine will
+    // ever re-dispatch this work; `setCooldownFailure` governs how aggressively
+    // it backs off between attempts. Previously this was gated on
+    // `retryableFailure`, so a caller marking a failure `agentRetryable: false`
+    // (structural/non-retryable classes like LIVE_CHECKOUT_WORKTREE_CONFLICT,
+    // WORKSPACE_MANIFEST_REPO, INVALID_WORKDIR, etc.) skipped cooldown
+    // bookkeeping entirely — leaving only the flat 15-minute `isAlreadyDispatched`
+    // dedup window as the sole re-dispatch gate, so the identical doomed
+    // dispatch key looped forever every ~15 minutes with zero backoff. Always
+    // record the failure here so `isOnCooldown`'s exponential backoff applies
+    // regardless of whether the failure is retryable.
+    if (result === DISPATCH_RESULT.ERROR && item.meta?.dispatchKey && !completedWorkItemFailure) {
       setCooldownFailure(item.meta.dispatchKey);
     }
 

package/engine/github.js

@@ -690,6 +690,15 @@ async function forEachActiveGhPr(config, callback) {
       for (const { before, after } of updatedCentralRecords) {
         const idx = currentPrs.findIndex(p => p.id === after.id);
         if (idx >= 0) {
+          // W-mr3gr4wl0004b8e3: never downgrade reviewStatus from 'approved' — it's a
+          // permanent terminal state. Mirrors the project-local write-back guard above
+          // (github.js:561-563) and ado.js's project/central write-backs (ado.js:1211-1213,
+          // :1360-1362). applyPrFieldDelta only merges fields changed during a given poll
+          // cycle, so this guard is the sole race protection against a stale/out-of-order
+          // GitHub poll response downgrading an already-approved PR.
+          if (currentPrs[idx].reviewStatus === REVIEW_STATUS.APPROVED && after.reviewStatus !== REVIEW_STATUS.APPROVED) {
+            after.reviewStatus = REVIEW_STATUS.APPROVED;
+          }
           // W-mp5trwh60008386d: same merged-status guard as project-local PRs.
           if (currentPrs[idx].status === PR_STATUS.MERGED && after.status !== PR_STATUS.MERGED) {
             after.status = PR_STATUS.MERGED;

package/engine.js

@@ -7185,7 +7185,19 @@ async function discoverFromPrs(config, project) {
         coalesceCurrentHumanFeedback();
         continue;
       }
-      if (blockedByCooldown && !alreadyDispatched) {
+      // #634 — only clear the cooldown when it holds no real failure history
+      // (i.e. it was created purely by `setCooldownWithContext` to park
+      // coalesced feedback while `fixThrottled`, and `failures` is still 0).
+      // A cooldown with `failures > 0` came from `setCooldownFailure` after an
+      // actual dispatch error — including non-retryable structural failures,
+      // which now always record a failure (see dispatch.js#completeDispatch).
+      // Clearing it just because the 15-min `isAlreadyDispatched` window
+      // closed would erase the exponential backoff and re-dispatch the same
+      // doomed key every ~15 minutes, defeating the whole point of the
+      // backoff. Only genuinely orphaned (never-attempted) cooldowns are
+      // cleared as stale.
+      const isGenuineFailureCooldown = (dispatchCooldowns.get(key)?.failures || 0) > 0;
+      if (blockedByCooldown && !alreadyDispatched && !isGenuineFailureCooldown) {
         staleCoalesced = drainCoalescedContexts(key);
         clearCooldown(key);
         log('info', `Cleared stale cooldown for ${key} — no matching dispatch history`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2317",
+  "version": "0.1.2318",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"