@yemi33/minions 0.1.2310 → 0.1.2312

package/dashboard/js/refresh.js

@@ -159,7 +159,7 @@ const RENDER_VERSIONS = {
   schedules: 1,
   watches: 3,
   meetings: 1,
-  pipelines: 1,
+  pipelines: 2,
   pinned: 1,
   kbPayload: 2,
   // settings is a modal-driven section, not a tick-driven render — but the

package/dashboard/js/render-pipelines.js

@@ -352,6 +352,11 @@ function renderPipelines(pipelines, opts) {
           '<span style="color:' + statusColor + ';font-size:var(--text-base);font-weight:600">' + escHtml(statusLabel) + '</span>' +
           (p.stopWhen ? '<span style="font-size:var(--text-xs);color:var(--yellow)" title="Auto-stops when condition met: ' + escHtml(typeof p.stopWhen === 'string' ? p.stopWhen : (p.stopWhen.check || 'condition')) + '">STOP-WHEN</span>' : '') +
           (p.enabled === false ? '<span style="font-size:var(--text-xs);color:var(--red)"' + (p._stopReason ? ' title="' + escHtml(p._stopReason) + '"' : '') + '>' + (p._stoppedBy ? 'AUTO-STOPPED' : 'DISABLED') + '</span>' : '') +
+          (p.enabled !== false
+            ? (activeRun
+                ? '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:2px 8px;color:var(--yellow);border-color:var(--yellow)" onclick="event.stopPropagation();_retriggerPipeline(\'' + escHtml(p.id) + '\',this)">Retrigger</button>'
+                : '<button class="btn-action btn-action-md" onclick="event.stopPropagation();_triggerPipeline(\'' + escHtml(p.id) + '\',this)">Run Now</button>')
+            : '') +
         '</div>' +
       '</div>' +
       resourcesHtml +
@@ -403,10 +408,12 @@ function openPipelineDetail(id) {
   html += '<div style="display:flex;justify-content:space-between;align-items:center">' +
     '<span style="font-size:var(--text-sm);color:var(--muted)">' + _renderPipelineTriggerLabel(p.trigger?.cron) + ' · ' + escHtml(_getPipelineStageLabel(p)) + '</span>' +
     '<div style="display:flex;gap:6px">' +
-      (activeRun
-        ? '<button class="btn-destructive btn-destructive-md" onclick="_abortPipeline(\'' + escHtml(id) + '\',this)">Abort</button>' +
-          '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:2px 8px;color:var(--yellow);border-color:var(--yellow)" onclick="_retriggerPipeline(\'' + escHtml(id) + '\',this)">Retrigger</button>'
-        : '<button class="btn-action btn-action-md" onclick="_triggerPipeline(\'' + escHtml(id) + '\',this)">Run Now</button>') +
+      (activeRun ? '<button class="btn-destructive btn-destructive-md" onclick="_abortPipeline(\'' + escHtml(id) + '\',this)">Abort</button>' : '') +
+      (p.enabled !== false
+        ? (activeRun
+            ? '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:2px 8px;color:var(--yellow);border-color:var(--yellow)" onclick="_retriggerPipeline(\'' + escHtml(id) + '\',this)">Retrigger</button>'
+            : '<button class="btn-action btn-action-md" onclick="_triggerPipeline(\'' + escHtml(id) + '\',this)">Run Now</button>')
+        : '') +
       '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:2px 8px;color:var(--blue);border-color:var(--blue)" onclick="openEditPipelineModal(\'' + escHtml(id) + '\')">Edit</button>' +
       '<button class="pr-pager-btn' + (_pipelineToggleInFlight.has(id) ? ' disabled' : '') + '" style="font-size:var(--text-xs);padding:2px 8px" onclick="_togglePipelineEnabled(\'' + escHtml(id) + '\',' + !p.enabled + ',this)">' + (p.enabled !== false ? 'Disable' : 'Enable') + '</button>' +
       '<button class="btn-destructive btn-destructive-md" onclick="_deletePipelineConfirm(\'' + escHtml(id) + '\')">Delete</button>' +

package/dashboard.js

@@ -447,6 +447,19 @@ function mergeSettingsConfigUpdate(current, candidate, body, patch = {}) {
       } else {
         delete currentProject.liveCheckoutAutoStash;
       }
+      // W-mr2pum3k000443c0 (checkout-mode pill snap-back) — mirror liveValidation
+      // the same way. handleSettingsUpdate validates + assigns liveValidation on
+      // `candidate` (and defensively deletes it there when the project moves off
+      // checkoutMode:'live'), but without this branch that value never reaches
+      // `current` before it's written to disk, so the hybrid pill flips back on
+      // the next status poll. Presence-of-own-property mirrors candidate's final
+      // state (set or delete) regardless of whether the request body even
+      // included the key, so the defensive-cleanup delete above also persists.
+      if (Object.prototype.hasOwnProperty.call(candidateProject, 'liveValidation')) {
+        currentProject.liveValidation = candidateProject.liveValidation;
+      } else {
+        delete currentProject.liveValidation;
+      }
       // W-mqiaw974 (issue #241): the field was renamed from the legacy
       // `worktreeMode`. Drop any stale legacy key on every settings save so a
       // migrated project never carries both fields.

package/engine/ado.js

@@ -527,6 +527,35 @@ function votesToReviewStatus(votes) {
   return REVIEW_STATUS.PENDING;
 }
 
+/**
+ * Issue #633 — ADO never clears a reviewer's numeric vote when new commits
+ * land on a PR, so a hard-reject -10 vote stays live forever unless the
+ * reviewer explicitly re-votes. Without this check, `reviewStatus` gets
+ * permanently stuck at 'changes-requested' after a fix is pushed, and the
+ * auto re-review-after-fix flow (engine.js needsReReview, which only fires on
+ * reviewStatus === 'waiting') can never dispatch again for that PR.
+ *
+ * Treat a live -10 vote as stale/superseded — i.e. resolve to 'waiting'
+ * instead of 'changes-requested' — once a fix has completed after the vote
+ * was (most recently) cast AND no further push has landed since that fix:
+ *   - `pr.minionsReview.fixedAt` is set (a fix dispatch completed), and
+ *   - the fix happened after the last minions review that produced the
+ *     rejection (`!pr.lastReviewedAt || fixedAt > pr.lastReviewedAt` —
+ *     mirrors the `fixedAfterReview` gate in engine.js needsReReview), and
+ *   - no push has landed since that fix completed
+ *     (`!pr.lastPushedAt || pr.lastPushedAt <= fixedAt`).
+ * If a new push lands after the fix without a following fix completion, or
+ * the last review (and its -10) postdates the recorded fix, the reject is
+ * still live/fresh and reviewStatus correctly stays 'changes-requested'.
+ */
+function isStaleAdoRejectVote(pr) {
+  const fixedAt = pr?.minionsReview?.fixedAt;
+  if (!fixedAt) return false;
+  const fixedAfterReview = !pr.lastReviewedAt || fixedAt > pr.lastReviewedAt;
+  const noPushSinceFix = !pr.lastPushedAt || pr.lastPushedAt <= fixedAt;
+  return fixedAfterReview && noPushSinceFix;
+}
+
 // ─── Reviewer Vote Snapshots (W-mpg58wv3) ────────────────────────────────────
 //
 // ADO's reviewer API does NOT include the source commit at which a reviewer
@@ -1569,11 +1598,7 @@ async function pollPrStatus(config) {
       }
     } else if (votes.length > 0) {
       if (votes.some(v => v === -10)) {
-        if (pr.reviewStatus === REVIEW_STATUS.WAITING && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
-          newReviewStatus = REVIEW_STATUS.WAITING;
-        } else {
-          newReviewStatus = REVIEW_STATUS.CHANGES_REQUESTED;
-        }
+        newReviewStatus = isStaleAdoRejectVote(pr) ? REVIEW_STATUS.WAITING : REVIEW_STATUS.CHANGES_REQUESTED;
       }
       else if (votes.some(v => v >= 5)) newReviewStatus = REVIEW_STATUS.APPROVED;
       else if (votes.some(v => v === -5)) newReviewStatus = REVIEW_STATUS.WAITING;
@@ -2346,7 +2371,16 @@ async function checkLiveReviewStatus(pr, project) {
     if (!prData) return null;
     const votes = (prData.reviewers || []).map(r => r.vote).filter(v => v !== undefined);
     if (votes.length === 0) return 'pending';
-    return votesToReviewStatus(votes);
+    const liveStatus = votesToReviewStatus(votes);
+    // Issue #633: the live vote check is the pre-dispatch gate for
+    // engine.js needsReReview — it must apply the same stale-reject-vote
+    // override as pollPrStatus, or a cached 'waiting' status set below by
+    // the poller gets immediately reverted back to 'changes-requested' here
+    // before a re-review can ever be dispatched.
+    if (liveStatus === REVIEW_STATUS.CHANGES_REQUESTED && isStaleAdoRejectVote(pr)) {
+      return REVIEW_STATUS.WAITING;
+    }
+    return liveStatus;
   } catch (e) {
     log('warn', `Live review check for ${pr.id}: ${e.message}`);
     return null;

package/engine/github.js

@@ -705,6 +705,24 @@ async function forEachActiveGhPr(config, callback) {
   return totalUpdated;
 }
 
+/**
+ * Issue #633 (mirror of engine/ado.js isStaleAdoRejectVote) — GitHub reviews
+ * generally get dismissed/replaced when a reviewer re-reviews, but a stale
+ * CHANGES_REQUESTED review from a login that never re-reviews after a fix can
+ * still pin `reviewStatus` at 'changes-requested' forever (the reviewer's
+ * review state persists until dismissed). Mirror the ADO fix so the same
+ * fixedAfterReview + no-push-since-fix override applies here: treat a live
+ * CHANGES_REQUESTED review as stale/superseded once a fix has completed after
+ * the review that produced it and no further push has landed since that fix.
+ */
+function isStaleGithubChangesRequested(pr) {
+  const fixedAt = pr?.minionsReview?.fixedAt;
+  if (!fixedAt) return false;
+  const fixedAfterReview = !pr.lastReviewedAt || fixedAt > pr.lastReviewedAt;
+  const noPushSinceFix = !pr.lastPushedAt || pr.lastPushedAt <= fixedAt;
+  return fixedAfterReview && noPushSinceFix;
+}
+
 // ─── PR Status Polling ──────────────────────────────────────────────────────
 
 async function pollPrStatus(config) {
@@ -999,11 +1017,7 @@ async function pollPrStatus(config) {
       if (pr.reviewStatus === REVIEW_STATUS.APPROVED) {
         newReviewStatus = REVIEW_STATUS.APPROVED;
       } else if (states.some(s => s === 'CHANGES_REQUESTED')) {
-        if (pr.reviewStatus === REVIEW_STATUS.WAITING && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
-          newReviewStatus = REVIEW_STATUS.WAITING;
-        } else {
-          newReviewStatus = REVIEW_STATUS.CHANGES_REQUESTED;
-        }
+        newReviewStatus = isStaleGithubChangesRequested(pr) ? REVIEW_STATUS.WAITING : REVIEW_STATUS.CHANGES_REQUESTED;
       }
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = REVIEW_STATUS.APPROVED;
       else if (states.length > 0) newReviewStatus = REVIEW_STATUS.PENDING;
@@ -1575,7 +1589,13 @@ async function checkLiveReviewStatus(pr, project) {
       latestByUser.set(r.user?.login || '', r.state);
     }
     const states = [...latestByUser.values()];
-    if (states.some(s => s === 'CHANGES_REQUESTED')) return REVIEW_STATUS.CHANGES_REQUESTED;
+    // Issue #633: mirror the pollPrStatus stale-reject override here — this
+    // live check is the pre-dispatch gate for engine.js needsReReview, and
+    // without the override it immediately reverts a cached 'waiting' status
+    // back to 'changes-requested' before a re-review can ever be dispatched.
+    if (states.some(s => s === 'CHANGES_REQUESTED')) {
+      return isStaleGithubChangesRequested(pr) ? REVIEW_STATUS.WAITING : REVIEW_STATUS.CHANGES_REQUESTED;
+    }
     if (states.some(s => s === 'APPROVED')) return REVIEW_STATUS.APPROVED;
     if (states.length > 0) return REVIEW_STATUS.PENDING;
     return REVIEW_STATUS.PENDING;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2310",
+  "version": "0.1.2312",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"