@yemi33/minions 0.1.2307 → 0.1.2308

package/dashboard/js/settings.js

@@ -1114,8 +1114,11 @@ async function saveSettings() {
       // Settings UI presents the idle timeout in minutes for readability; the
       // engine stores ms (ENGINE_DEFAULTS.ccWorkerIdleTimeoutMs). Convert here;
       // the server clamps to [60000, 28800000] ms. undefined when blank so the
-      // server keeps the prior value rather than zeroing it.
+      // server keeps the prior value rather than zeroing it. W-mr1qbj90000d30bd:
+      // the "Never idle-reap CC workers" toggle wins and submits the explicit
+      // `0` sentinel (bypasses the clamp server-side), ignoring the minutes field.
       ccWorkerIdleTimeoutMs: (function () {
+        if (document.getElementById('set-ccNeverIdleReap')?.checked) return 0;
         var m = Number(document.getElementById('set-ccWorkerIdleTimeoutMs')?.value);
         return (Number.isFinite(m) && m > 0) ? Math.round(m * 60000) : undefined;
       })(),

package/dashboard.js

@@ -258,8 +258,12 @@ function reloadConfig() {
   // Settings change takes effect without a dashboard restart (W-mr0qs0vw). The
   // pool stays dependency-free at load and relies on this push.
   try {
-    const idleMs = Number(CONFIG.engine?.ccWorkerIdleTimeoutMs)
-      || shared.ENGINE_DEFAULTS.ccWorkerIdleTimeoutMs;
+    // W-mr1qbj90000d30bd — 0 is the explicit "never idle-reap" sentinel and
+    // must NOT fall through to the default via `||` (0 is falsy in JS).
+    const cfgIdle = CONFIG.engine?.ccWorkerIdleTimeoutMs;
+    const idleMs = Number(cfgIdle) === 0
+      ? 0
+      : (Number(cfgIdle) || shared.ENGINE_DEFAULTS.ccWorkerIdleTimeoutMs);
     ccWorkerPool.setIdleTimeoutMs(idleMs);
   } catch { /* invalid value or pool unavailable — keep prior window */ }
 }
@@ -11063,12 +11067,6 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           // larger models); max 1h (matches CC_CALL_TIMEOUT_MS so the watchdog
           // never outlives the outer abort).
           ccTurnTimeoutMs: [10000, 3600000],
-          // W-mr0qs0vw — ACP worker idle-reaper window. 1min floor (anything
-          // shorter would reap a warm worker between a user's own messages and
-          // thrash cold-spawns); 8h ceiling (a config typo shouldn't pin a warm
-          // copilot process in memory indefinitely). Stored in ms; the Settings
-          // UI presents minutes and converts.
-          ccWorkerIdleTimeoutMs: [60000, 28800000],
           // W-mq9acoo800177bcb — bounded-concurrency for pre-dispatch validator.
           // 1 floor (sequential fallback) and 20 ceiling (above this the LLM
           // provider's per-second rate limits dominate; throughput gains taper).
@@ -11084,6 +11082,29 @@ What would you like to discuss or change? When you're happy, say "approve" and I
             _setEngineConfig(key, val);
           }
         }
+        // W-mr0qs0vw / W-mr1qbj90000d30bd — ACP worker idle-reaper window.
+        // 1min floor (anything shorter would reap a warm worker between a
+        // user's own messages and thrash cold-spawns); 8h ceiling (a config
+        // typo shouldn't pin a warm copilot process in memory indefinitely).
+        // Handled OUTSIDE the generic numericFields loop because `0` is a
+        // valid, deliberate sentinel meaning "never idle-reap" (only closeTab
+        // kills the warm worker) — it must bypass the [60000, 28800000]
+        // clamp for that one value instead of being clamped up to 60000 or
+        // falling back to the default via `Number(e[key]) || D[key]`
+        // (0 is falsy in JS). Stored in ms; the Settings UI presents minutes.
+        if (e.ccWorkerIdleTimeoutMs !== undefined) {
+          const rawIdle = Number(e.ccWorkerIdleTimeoutMs);
+          if (rawIdle === 0) {
+            _setEngineConfig('ccWorkerIdleTimeoutMs', 0);
+          } else {
+            let val = rawIdle || D.ccWorkerIdleTimeoutMs;
+            const raw = val;
+            val = Math.max(60000, val);
+            val = Math.min(28800000, val);
+            if (val !== raw) _clamped.push(`ccWorkerIdleTimeoutMs: ${raw} → ${val} (range: 60000–28800000)`);
+            _setEngineConfig('ccWorkerIdleTimeoutMs', val);
+          }
+        }
         // String fields
         if (e.worktreeRoot !== undefined) _setEngineConfig('worktreeRoot', String(e.worktreeRoot || D.worktreeRoot));
         // W-mpejf0fq000e84d6: operator login override. Empty string clears

package/engine/cc-worker-pool.js

@@ -38,7 +38,10 @@
  *   - closeTab                → `session/cancel` if inflight, then kill proc
  *   - Idle > timeout       → kill proc (reaper sweep every 60 s; window is
  *                            ENGINE_DEFAULTS.ccWorkerIdleTimeoutMs, default
- *                            30 min, pushed in via setIdleTimeoutMs())
+ *                            30 min, pushed in via setIdleTimeoutMs()). A
+ *                            timeout of 0 is the "never idle-reap" sentinel
+ *                            (W-mr1qbj90000d30bd) — the warm worker is only
+ *                            ever killed by an explicit closeTab.
  *
  * Auth precheck: when `copilot --acp` exits before the initialize handshake
  * completes, surface
@@ -171,11 +174,18 @@ let _reaperTimer = null;
 const _reapedTabs = new Map();
 
 // Update the idle-reaper window at runtime. Called by dashboard.js on every
-// reloadConfig() with `engine.ccWorkerIdleTimeoutMs`. Ignores non-finite /
-// non-positive values so a config typo can't disable reaping or set a negative
-// window; the floor of 1000ms keeps a misconfigured tiny value from thrashing.
+// reloadConfig() with `engine.ccWorkerIdleTimeoutMs`. `0` is the explicit
+// "never idle-reap" sentinel (W-mr1qbj90000d30bd) — it sets the window to
+// Infinity so `_reapIdleTabs()` never kills a warm worker for inactivity;
+// only an explicit `closeTab` does. Ignores non-finite / negative values so a
+// config typo can't disable reaping or set a negative window; the floor of
+// 1000ms keeps a misconfigured tiny positive value from thrashing.
 function setIdleTimeoutMs(ms) {
   const n = Number(ms);
+  if (n === 0) {
+    _idleReaperMs = Infinity;
+    return _idleReaperMs;
+  }
   if (!Number.isFinite(n) || n <= 0) return _idleReaperMs;
   _idleReaperMs = Math.max(1000, n);
   return _idleReaperMs;
@@ -876,6 +886,8 @@ function _ensureReaper() {
 }
 
 function _reapIdleTabs() {
+  // W-mr1qbj90000d30bd — idle-reap disabled entirely (sentinel: 0 → Infinity).
+  if (_idleReaperMs === Infinity) return;
   const now = _internals.now();
   for (const [tabId, worker] of [..._tabs]) {
     if (worker.inflight) continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2307",
+  "version": "0.1.2308",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"