@yemi33/minions 0.1.2306 → 0.1.2308

package/bin/minions.js

@@ -1580,6 +1580,7 @@ ${fs.existsSync(path.join(PKG_ROOT, '.git')) ? `
       isPortListening,
       confirmPortUp: tcpPortAccepts,
       isStopIntentSet: shared.isStopIntentSet || (() => false),
+      recordRespawn: shared.recordEngineRespawn,
     }).then(result => {
       // ALWAYS exit 0 — the scheduler must never see a failure for the
       // recovery we're trying to make boring. The `result` is logged by tick

package/dashboard/js/settings.js

@@ -289,6 +289,23 @@ async function openSettings() {
           '⚠ Live mode: dispatches run directly in this repo\'s checkout. Only one mutating dispatch runs at a time. Dirty working trees block dispatch — commit or stash before running.' +
         '</div>' +
       '</div>';
+    // W-mqtvnnj1000357fa — per-project live-checkout auto-stash override.
+    // Tri-state: "" (use fleet default → engine.liveCheckoutAutoStash), "on"
+    // (force stash), "off" (force fail-on-dirty). Only an explicit on/off
+    // overrides the fleet setting; the default option leaves p.liveCheckoutAutoStash
+    // unset so resolveLiveCheckoutAutoStash falls back to engine.
+    var autoStashRaw = (p.liveCheckoutAutoStash === true) ? 'on' : (p.liveCheckoutAutoStash === false) ? 'off' : '';
+    var autoStashSearch = 'live checkout auto-stash dirty tree stash dispatch';
+    var autoStashBlock =
+      '<div data-search="' + escHtml(autoStashSearch) + '" style="margin-bottom:6px">' +
+        '<label style="font-size:var(--text-sm);color:var(--muted);display:block;margin-bottom:2px">Live-checkout auto-stash</label>' +
+        '<select id="set-liveCheckoutAutoStash-' + escHtml(p.name) + '" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:var(--text-md)">' +
+          '<option value=""' + (autoStashRaw === '' ? ' selected' : '') + '>Use fleet default</option>' +
+          '<option value="on"' + (autoStashRaw === 'on' ? ' selected' : '') + '>On — auto-stash dirty tree</option>' +
+          '<option value="off"' + (autoStashRaw === 'off' ? ' selected' : '') + '>Off — fail on dirty tree</option>' +
+        '</select>' +
+        '<div style="font-size:var(--text-xs);color:var(--muted);margin-top:2px;line-height:1.4">Live mode only. On = `git stash push --include-untracked` a dirty tree before dispatch instead of failing; the engine never pops the stash (run `git stash pop` manually). Overrides the fleet-wide setting under Worktrees.</div>' +
+      '</div>';
     return '<div data-settings-project="' + escHtml(p.name) + '" data-search="project ' + escHtml(p.name.toLowerCase()) + '" style="border:1px solid var(--border);border-radius:6px;padding:10px 12px;margin-bottom:12px">' +
       '<div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:8px">' +
         '<div style="font-size:var(--text-md);font-weight:600">' + escHtml(p.name) + '</div>' +
@@ -297,6 +314,7 @@ async function openSettings() {
       pathRow +
       branchGrid +
       worktreeModeBlock +
+      autoStashBlock +
       driftNote +
       '<div style="display:flex;flex-direction:column;gap:6px;margin-top:8px">' +
       settingsToggle('Discover from PRs', 'set-ws-prs-' + p.name, p.workSources.pullRequests.enabled, 'Discovery gate: scan repo for open PRs and surface them as review tasks. Independent of ADO/GitHub polling — does not affect already-tracked PRs.') +
@@ -1050,6 +1068,7 @@ async function saveSettings() {
       autoCompletePrs: document.getElementById('set-autoCompletePrs').checked,
       ccUseWorkerPool: !!document.getElementById('set-ccUseWorkerPool')?.checked,
       autoReapOrphanWorktreeHolders: !!document.getElementById('set-autoReapOrphanWorktreeHolders')?.checked,
+      liveCheckoutAutoStash: !!document.getElementById('set-liveCheckoutAutoStash')?.checked,
       liveCheckoutAutoReset: !!document.getElementById('set-liveCheckoutAutoReset')?.checked,
       orphanHolderScanTimeoutMs: document.getElementById('set-orphanHolderScanTimeoutMs')?.value,
       statusProbeKillTimeoutMs: document.getElementById('set-statusProbeKillTimeoutMs')?.value,
@@ -1095,8 +1114,11 @@ async function saveSettings() {
       // Settings UI presents the idle timeout in minutes for readability; the
       // engine stores ms (ENGINE_DEFAULTS.ccWorkerIdleTimeoutMs). Convert here;
       // the server clamps to [60000, 28800000] ms. undefined when blank so the
-      // server keeps the prior value rather than zeroing it.
+      // server keeps the prior value rather than zeroing it. W-mr1qbj90000d30bd:
+      // the "Never idle-reap CC workers" toggle wins and submits the explicit
+      // `0` sentinel (bypasses the clamp server-side), ignoring the minutes field.
       ccWorkerIdleTimeoutMs: (function () {
+        if (document.getElementById('set-ccNeverIdleReap')?.checked) return 0;
         var m = Number(document.getElementById('set-ccWorkerIdleTimeoutMs')?.value);
         return (Number.isFinite(m) && m > 0) ? Math.round(m * 60000) : undefined;
       })(),
@@ -1155,10 +1177,18 @@ async function saveSettings() {
       // values.
       const wtModeInput = document.getElementById('set-checkoutMode-' + p.name);
       const wtModeValue = (wtModeInput && wtModeInput.value === 'live') ? 'live' : 'worktree';
+      // W-mqtvnnj1000357fa — per-project live-checkout auto-stash override.
+      // '' → null (clear override, fall back to engine fleet setting); 'on' →
+      // true; 'off' → false. The server deletes the field on null and validates
+      // booleans.
+      const autoStashInput = document.getElementById('set-liveCheckoutAutoStash-' + p.name);
+      const autoStashRaw = autoStashInput ? autoStashInput.value : '';
+      const autoStashValue = autoStashRaw === 'on' ? true : autoStashRaw === 'off' ? false : null;
       return {
         name: p.name,
         mainBranch: mainBranchValue || null,
         checkoutMode: wtModeValue,
+        liveCheckoutAutoStash: autoStashValue,
         workSources: {
           pullRequests: { enabled: document.getElementById('set-ws-prs-' + p.name)?.checked ?? true },
           workItems: { enabled: document.getElementById('set-ws-wi-' + p.name)?.checked ?? true }

package/dashboard/slim/body.html

@@ -226,28 +226,12 @@
   </div>
 </div>
 
-<!-- Plans + PRD control panel — opened from the "Plans" status tile. Two tabs:
-     Plans (.md plan drafts) and PRD (materialized PRDs). Each tab is rendered
-     lazily by dashboard/slim/js/plans.js into #slim-plans-body. Backed by the
-     existing endpoints (no new server routes):
-       Plans — /api/plans (list), /api/plans/:file (read), and the lifecycle
-               POSTs (/api/plans/{approve,execute,reject,pause,regenerate,
-               archive,delete,unarchive}).
-       PRD   — the .json entries from /api/plans plus /api/prd and the
-               read-only subset of /api/prd-items. -->
-<div class="modal-bg" id="slim-plans-modal">
-  <div class="modal slim-plans-modal-inner">
-    <div class="modal-header">
-      <h3>Plans</h3>
-      <div class="kn-tabs" id="slim-plans-tabs" role="tablist">
-        <button class="kn-tab active" id="slim-plans-tab-plans" data-plans-tab="plans" type="button" role="tab" aria-selected="true" aria-controls="slim-plans-body">Plans</button>
-        <button class="kn-tab" id="slim-plans-tab-prd" data-plans-tab="prd" type="button" role="tab" aria-selected="false" aria-controls="slim-plans-body">PRD</button>
-      </div>
-      <button id="slim-plans-close" class="icon-btn" title="Close" style="margin-left:auto">&times;</button>
-    </div>
-    <div class="modal-body" id="slim-plans-body" role="tabpanel" tabindex="0" aria-labelledby="slim-plans-tab-plans"></div>
-  </div>
-</div>
+<!-- Plans + PRD control panel — the "Plans" cockpit tile opens the LITERAL
+     classic /plans screen in a chrome-off iframe (/plans?embed=1), routed through
+     the standard TILE_VIEWS path in modals-tiles.js#renderPlansBody. There is no
+     slim-specific Plans/PRD flyout markup anymore (W-mr28ko750010199f / "reuse,
+     don't fork"): the classic /plans screen is the single source of truth for the
+     Plans + PRD tabs and every lifecycle action. -->
 
 <!-- Pin editor — create (Pin Content action / "+ Pin") or edit an existing
      note. Submits to POST /api/pinned (create) or /api/pinned/update (edit). -->

package/dashboard/slim/js/modals-tiles.js

@@ -17,7 +17,6 @@
   bindModalClose('slim-agent-modal', 'slim-agent-close', _stopAgentDetailRuntime);
   bindModalClose('slim-tools-modal', 'slim-tools-close');
   bindModalClose('slim-tile-modal', 'slim-tile-close');
-  bindModalClose('slim-plans-modal', 'slim-plans-close');
 
   function tileEmpty(body, text) {
     var d = document.createElement('div');
@@ -142,6 +141,25 @@
     body.appendChild(frame);
   }
 
+  // Plans tile body — reuses the LITERAL classic dashboard /plans screen instead
+  // of a slim-specific tabbed Plans/PRD flyout, so there is one Plans/PRD UI, not
+  // two (W-mr28ko750010199f / "reuse, don't fork" — mirrors renderQueuedWorkBody
+  // for the Work tile). Slim and classic are two separate IIFE bundles with no
+  // shared scope, so we embed the real /plans screen in an iframe with the
+  // chrome-off ?embed=1 mode. The iframed page IS the classic screen — the full
+  // Plans + PRD tabbed UI with every lifecycle action (approve/execute/reject/
+  // pause/regenerate/unarchive/archive/delete), backed by the same /api/plans +
+  // /api/prd data + endpoints — with zero duplicated rendering logic. Classic is
+  // reachable at /plans even with slim-ux ON (only / is taken over). Built with
+  // createElement (no innerHTML) to satisfy the dashboard no-unsanitized lint gate.
+  function renderPlansBody(body) {
+    var frame = document.createElement('iframe');
+    frame.className = 'slim-plans-embed';
+    frame.src = '/plans?embed=1';
+    frame.title = 'Plans';
+    body.appendChild(frame);
+  }
+
   function renderPrTileBody(body, data) {
     // Emoji glyphs make build/review status scannable at a glance; the
     // accompanying label keeps the row readable when the glyph alone is
@@ -264,6 +282,7 @@
     engine:     { title: 'Engine',            render: renderEngineTileBody },
     dispatches: { title: 'Active dispatches', render: function(body, data) { renderDispatchTileBody(body, data, true); } },
     queued:     { title: 'Queued work',       render: function(body) { renderQueuedWorkBody(body); } },
+    plans:      { title: 'Plans',             render: function(body) { renderPlansBody(body); } },
     prs:        { title: 'Pull requests',     render: renderPrTileBody },
     watches:    { title: 'Watches',           render: renderWatchTileBody },
   };
@@ -274,9 +293,6 @@
     // The Knowledge tile opens the unified Knowledge control panel (Pinned
     // Context + Notes + KB tabs) rather than the read-only tile detail view.
     if (key === 'knowledge') { openKnowledgeModal(); return; }
-    // The Plans tile opens the tabbed Plans/PRD control panel (rendered by
-    // dashboard/slim/js/plans.js) rather than the read-only tile detail view.
-    if (key === 'plans') { openPlansModal(); return; }
     var view = TILE_VIEWS[key];
     if (!view) return;
     var modal = document.getElementById('slim-tile-modal');
@@ -288,9 +304,11 @@
     // The "+ Link PR" header chip only applies to the PR list.
     var headerChip = document.getElementById('slim-tile-modal-linkpr');
     if (headerChip) headerChip.style.display = (key === 'prs') ? '' : 'none';
-    // The queued tile embeds the full classic /work screen in an iframe — widen
-    // the modal + drop the body padding so the embedded table gets real estate.
+    // The queued + plans tiles embed a full classic screen (/work, /plans) in an
+    // iframe — widen the modal + drop the body padding so the embedded screen
+    // gets real estate. Both reuse the shared wide-modal treatment.
     modal.classList.toggle('tile-modal--work', key === 'queued');
+    modal.classList.toggle('tile-modal--plans', key === 'plans');
     view.render(body, lastStatusData || {});
     modal.classList.add('open');
   }
@@ -316,22 +334,14 @@
     }
   })();
 
-  // ── Plans control-panel wiring ─────────────────────────────────────
-  // The Plans tile opens #slim-plans-modal (routed in openTileModal above).
-  // plans.js is the renderer only; the tab-switch + lazy tile-count wiring
-  // lives here, mirroring knowledge.js#bindKnowledgeUi. The plan/PRD count is
-  // not part of the /api/status poll, so it is fetched lazily from /api/plans
-  // shortly after first paint (and refreshed on each modal open by the renderer).
-  (function bindPlansUi() {
-    var tabBar = document.getElementById('slim-plans-tabs');
-    if (tabBar) {
-      tabBar.addEventListener('click', function(ev) {
-        var btn = ev.target && ev.target.closest ? ev.target.closest('.kn-tab') : null;
-        if (!btn) return;
-        var tab = btn.getAttribute('data-plans-tab');
-        if (tab && typeof setPlansTab === 'function') setPlansTab(tab);
-      });
-    }
+  // ── Plans tile wiring ──────────────────────────────────────────────
+  // The Plans tile opens the classic /plans screen in an iframe (routed through
+  // the standard TILE_VIEWS path in openTileModal above) — there is no
+  // slim-specific Plans/PRD flyout to wire. The cockpit tile's at-a-glance count
+  // is still slim-owned (the plan/PRD count is not part of the /api/status poll),
+  // so it is fetched lazily from /api/plans shortly after first paint, mirroring
+  // knowledge.js#loadKnowledgeCounts. See dashboard/slim/js/plans.js.
+  (function bindPlansTileCount() {
     if (typeof loadPlansCounts === 'function') setTimeout(loadPlansCounts, 1500);
   })();