@yemi33/minions 0.1.2294 → 0.1.2296

package/engine/lifecycle.js

@@ -60,6 +60,29 @@ function checkPlanCompletion(meta, config) {
   const workItemById = {};
   for (const w of planItems) { if (w.id) workItemById[w.id] = w; }
 
+  // Self-heal stale completion. checkPlanCompletion only ever ADVANCED a plan to
+  // `completed` — it never reverted. So a PRD that was completed and then gained
+  // a late item (e.g. a build-fix appended post-completion) or had an item
+  // regress / lose its WI got stuck `completed` forever: the materializer SKIPS
+  // `completed` PRDs (engine.js#materializePlansAsWorkItems), so the new item
+  // never materializes, and the gates below return early without clearing the
+  // flag — a permanent "completed PRD with a missing item" (the P-mqyp0006 /
+  // "Fix PR #341 failing build" incident). Re-open such a plan so the
+  // materializer recreates the missing WI and the normal completion flow resumes.
+  // Idempotent: once reverted (status active, flag cleared) the guard no-ops, so
+  // it cannot flap on subsequent scans while the item is genuinely incomplete.
+  const reopenStaleCompletedPlan = (reason) => {
+    if (plan.status !== PLAN_STATUS.COMPLETED && !plan._completionNotified) return false;
+    log('warn', `Plan ${planFile}: re-opening stale completed PRD — ${reason}`);
+    mutateJsonFileLocked(planPath, (data) => {
+      if (data.status === PLAN_STATUS.COMPLETED) data.status = PLAN_STATUS.ACTIVE;
+      delete data.completedAt;
+      data._completionNotified = false;
+      return data;
+    });
+    return true;
+  };
+
   // Check 1: every feature must have a work item (materialized)
   // Fallback: also accept features marked done directly in the PRD JSON (resolved externally)
   const unmaterialized = [...planFeatureIds].filter(id => {
@@ -69,6 +92,7 @@ function checkPlanCompletion(meta, config) {
   });
   if (unmaterialized.length > 0) {
     log('info', `Plan ${planFile}: ${unmaterialized.length}/${planFeatureIds.size} feature(s) not yet materialized as work items: ${unmaterialized.join(', ')}`);
+    reopenStaleCompletedPlan(`${unmaterialized.length} unmaterialized item(s): ${unmaterialized.join(', ')}`);
     return;
   }
 
@@ -88,6 +112,7 @@ function checkPlanCompletion(meta, config) {
   });
   if (notTerminal.length > 0) {
     log('info', `Plan ${planFile}: waiting for ${notTerminal.length}/${planFeatureIds.size} item(s) to reach terminal state: ${notTerminal.join(', ')}`);
+    reopenStaleCompletedPlan(`${notTerminal.length} non-terminal item(s): ${notTerminal.join(', ')}`);
     return;
   }
 

package/engine.js

@@ -9738,16 +9738,6 @@ async function tickInner() {
   } else if (!autoFixPaused) {
     _resetAutoFixPausedLogState();
   }
-  const adoPollEnabled = !pollingPaused && (config.engine?.adoPollEnabled ?? ENGINE_DEFAULTS.adoPollEnabled);
-  const ghPollEnabled = !pollingPaused && (config.engine?.ghPollEnabled ?? ENGINE_DEFAULTS.ghPollEnabled);
-  // P-c4d8e1a3 — granular per-poller flags. Each of the 6 PR-poll axes
-  // (ADO/GH × status/comments/reconcile) plus processPendingRebases gets
-  // its own resolution via shared.resolvePollFlag(...). Explicit granular
-  // values win; the legacy `adoPollEnabled` / `ghPollEnabled` macros
-  // silence their whole bundle as a fallback (including reconcile — a
-  // documented breaking change). Defaults: all true. pollingPaused (master
-  // killswitch) still composes with status + comments gates; reconcile and
-  // the rebase processor are recovery-sweep paths and are NOT gated by it.
   const adoStatusPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'adoPrStatusPollEnabled', 'adoPollEnabled');
   const ghStatusPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'ghPrStatusPollEnabled', 'ghPollEnabled');
   const adoCommentsPollEnabled = !pollingPaused && resolvePollFlag(config.engine, 'adoPrCommentsPollEnabled', 'adoPollEnabled');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2294",
+  "version": "0.1.2296",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"