@yemi33/minions 0.1.2290 → 0.1.2292

package/dashboard.js

@@ -6804,13 +6804,13 @@ const server = http.createServer(async (req, res) => {
       if (originWi) item._originWi = originWi;
       await copyWorkItemPrFields(item, body, null, { project: targetProject });
       // W-mq5wfh1v000e0da9 — Auto-enroll the PR into pull-requests.json when
-      // this is a `type: fix` WI carrying a structured PR pointer and the PR
-      // isn't tracked yet. Without this, the engine's `pr_not_found` gate
-      // skips the fix forever (engine.js dispatch loop). Idempotent — safe to
+      // this is a `type: fix/review/test` WI carrying a structured PR pointer and
+      // the PR isn't tracked yet. Without this, the engine's `pr_not_found` gate
+      // skips the WI forever (engine.js dispatch loop). Idempotent — safe to
       // call on every WI create. Failures are swallowed (best-effort belt;
       // engine.js#dispatch loop also calls this as defense-in-depth).
       try {
-        shared.autoEnrollPrFromFixWorkItem(item, targetProject, MINIONS_DIR);
+        shared.autoEnrollPrFromWorkItem(item, targetProject, MINIONS_DIR);
       } catch (e) {
         shared.log('warn', `auto-enroll PR for ${item.id}: ${e.message}`);
       }

package/docs/README.md

@@ -58,6 +58,7 @@ Architecture, design proposals, and lifecycle references for people working on t
 
 Operational runbooks for engine operators and fleet maintainers.
 
+- [notes.md](notes.md) — Consolidated team knowledge: patterns, conventions, bugs, and build findings accumulated from agent inbox notes. Read by the engine and injected into agent prompts as shared context.
 - [auto-discovery.md](auto-discovery.md) — Auto-discovery and execution pipeline: the per-tick orchestration loop and the four work-discovery sources.
 - [diagnostics-memory.md](diagnostics-memory.md) — Operator runbook for the in-process memory + perf observability surface: `/api/diagnostics/memory[/history]`, `/api/diagnostics/heap-snapshot` guard-token capture, `MEMORY_BASELINE` log emissions, `--cpu-prof`/`--heap-prof` capture, and the `test/perf/soak.test.js` heap-growth regression gate.
 - [engine-restart.md](engine-restart.md) — How agents survive an engine restart: state persistence, the 20-minute startup grace period, and orphan reattachment via PID files and `live-output.log`.

package/docs/command-center.md

@@ -63,7 +63,7 @@ Any violation rejects the **whole turn** with a typed error envelope (`code: 'in
 | Runtime | `imageInput` | Behavior |
 |---------|--------------|----------|
 | claude  | `true`  | Images delivered as an Anthropic Messages `content[]` envelope of base64 blocks over stream-json (`claude.buildPrompt` + `--input-format stream-json` in `claude.buildArgs`). |
-| copilot | `false` | Degraded — `engine/llm.js` `_resolveImageOpts` returns a typed `model-unavailable` envelope ("switch ccCli to a runtime with imageInput"). The Copilot worker-pool path also drops images. |
+| copilot | `true` | Images materialized to tmp files and passed as `--attachment <path>` (W-mqv7324u0021db5d). **Exception:** when the opt-in Copilot worker pool is active (`engine.ccUseWorkerPool: true`), images are silently dropped — the pool's ACP `stream()` does not forward images; a note in `_invokeCcStream` marks this intentional. |
 | codex   | `false` | Degraded — same typed `model-unavailable` envelope. |
 
 `_resolveImageOpts` (in `engine/llm.js`) is pure and unit-tested: it forwards the `images` list only when `runtime.capabilities.imageInput` is truthy, otherwise returns the typed error so CC/doc-chat surface the envelope instead of a silently-text-only reply. `_spawnProcess` re-applies the same gate (`if (!caps.imageInput) adapterOpts.images = undefined`) as defense in depth. Image **filenames** are run through the untrusted-input fence (`buildSource('cc-image-filename', …)`) before they reach prompt text, since they are user-supplied.

package/docs/plan-lifecycle.md

@@ -118,7 +118,7 @@ The verify agent does not call `archivePlan()`. After the testing guide and any
 
 Manual archive behavior:
 
-1. For PRD JSON files, the dashboard moves `prd/<file>.json` to `prd/archive/<file>.json`, marks the archived JSON with `status: "archived"` and `archivedAt`, and removes or neutralizes the active `.backup` sidecar so `safeJson()` cannot restore a stale completed PRD on restart.
+1. For PRD JSON files, the dashboard archives them **in-place** in `prd/` — the file is not moved. The JSON is stamped with `archived: true`, `status: "archived"`, and `archivedAt` (Phase 10 step 4.2b). The `.backup` sidecar is left intact since the file keeps its canonical path.
 2. If the PRD has `source_plan`, the matching `plans/<source>.md` is moved to `plans/archive/<source>.md`.
 3. Pending or queued work items linked to the archived PRD are cancelled with `_cancelledBy: "plan-archived"`; completed work items remain as history.
 4. Plan worktrees are cleaned up by the archive handler/lifecycle cleanup path.
@@ -148,7 +148,9 @@ After PRs are created, humans can leave comments containing `@minions` to trigge
 |------|---------|
 | `plans/*.md` | Source plans awaiting review or linked to active PRDs |
 | `prd/*.json` | Active PRDs with materializable items |
-| `plans/archive/`, `prd/archive/` | Manually archived plans and PRDs |
+| `plans/archive/` | Manually archived plan Markdown files |
+| `prd/*.json` (with `archived: true`) | PRDs archived in-place (Phase 10 step 4.2b — not moved; flag + `archivedAt` stamped on the file) |
+| `prd/archive/` | Legacy: PRDs archived before Phase 10 (still scanned for filename-collision detection) |
 | `playbooks/verify.md` | Verification task playbook |
 | `playbooks/implement.md` | Implementation playbook |
 | `playbooks/plan-to-prd.md` | Plan → PRD conversion playbook |

package/docs/runtime-adapters.md

@@ -81,6 +81,7 @@ real behavioral split appears between adapters.
 | `resumePromptCarryover` | ✗ | ✓ | ✓ | CC resume turns prepend recent visible Q&A in stdin when the runtime session store is opaque to Minions. |
 | `resumeBookkeepingTurn` | ✓ | — | — | Claude CLI injects a synthetic "Continue from where you left off." meta turn on `--resume`; CC prompts must tell the model not to treat it as user intent. |
 | `streamConsumer` | ✓ | ✓ | ✓ | Adapter implements `createStreamConsumer(ctx)` — required by `engine/llm.js` accumulator. |
+| `imageInput` | ✓ | ✓ | ✗ | Runtime accepts `images: [{mimeType, dataBase64}]` and delivers them to the CLI. Claude: Anthropic Messages base64 content-block envelope via `--input-format stream-json`. Copilot: base64 payloads materialized to tmp files and passed as `--attachment <path>` (W-mqv7324u0021db5d). When false, `_resolveImageOpts` returns a typed `model-unavailable` error. |
 
 When a behavior is genuinely uniform across all current adapters, it still gets
 a flag if a future runtime might disagree — flags are cheap.

package/engine/live-checkout.js

@@ -101,7 +101,6 @@ const shared = require('./shared');
 // still bounded. Threaded through `baseOpts` so every git call inherits it; the
 // injected `_git` mock in unit tests ignores opts so the seam is unaffected.
 const LIVE_CHECKOUT_GIT_MAX_BUFFER = 50 * 1024 * 1024;
-
 // PL-live-checkout-reliability-hardening — partial-clone / GVFS blob-fetch
 // signature match. On a Scalar/GVFS-managed ADO repo (blobless partial clone),
 // switching the working tree onto a branch whose tree differs from HEAD must

package/engine/pipeline.js

@@ -57,7 +57,7 @@ function getPipeline(id) {
 
 function savePipeline(pipeline) {
   if (!fs.existsSync(PIPELINES_DIR)) fs.mkdirSync(PIPELINES_DIR, { recursive: true });
-  safeWrite(path.join(PIPELINES_DIR, pipeline.id + '.json'), pipeline);
+  mutateJsonFileLocked(path.join(PIPELINES_DIR, pipeline.id + '.json'), () => pipeline, { defaultValue: {} });
 }
 
 function deletePipeline(id) {

package/engine/shared.js

@@ -7245,11 +7245,12 @@ function classifyPrRefForVerification(prRef, project = null) {
 // per the "structured-vs-loose split" — enrollment must be intentional.
 //
 // Returns:
-//   { skipped: true, reason }            — not a fix / no ref / no URL / upsert error
+//   { skipped: true, reason }            — not a pr-requiring type / no ref / no URL / upsert error
 //   { alreadyEnrolled: true, id }        — PR already in pull-requests.json
 //   { enrolled: true, id, prPath }       — newly enrolled
-function autoEnrollPrFromFixWorkItem(item, project, minionsDir) {
-  if (!item || item.type !== WORK_TYPE.FIX) return { skipped: true, reason: 'not-fix' };
+const _PR_REQUIRING_TYPES = new Set([WORK_TYPE.FIX, WORK_TYPE.REVIEW, WORK_TYPE.TEST]);
+function autoEnrollPrFromWorkItem(item, project, minionsDir) {
+  if (!item || !_PR_REQUIRING_TYPES.has(item.type)) return { skipped: true, reason: 'not-pr-requiring-type' };
   const prRef = extractStructuredWorkItemPrRef(item);
   if (!prRef) return { skipped: true, reason: 'no-structured-ref' };
   const url = deriveUrlForPrRef(prRef, project);
@@ -7280,10 +7281,12 @@ function autoEnrollPrFromFixWorkItem(item, project, minionsDir) {
       ? { enrolled: true, id: result.id, prPath }
       : { alreadyEnrolled: true, id: result.id };
   } catch (e) {
-    log('warn', `autoEnrollPrFromFixWorkItem ${item.id}: ${e.message}`);
+    log('warn', `autoEnrollPrFromWorkItem ${item.id}: ${e.message}`);
     return { skipped: true, reason: 'upsert-error', error: e.message };
   }
 }
+// Backward-compat alias — external callers that reference autoEnrollPrFromFixWorkItem keep working.
+const autoEnrollPrFromFixWorkItem = autoEnrollPrFromWorkItem;
 
 // ─── Cross-Platform Process Kill Helpers ─────────────────────────────────────
 
@@ -9015,6 +9018,7 @@ module.exports = {
   isContextOnlyPrRecord,
   upsertPullRequestRecord,
   isAutoManagedPrRecord, // W-mq5s5ttx000j7ab8-a — exported for engine + watch-plugin gate consolidation
+  autoEnrollPrFromWorkItem,
   autoEnrollPrFromFixWorkItem,
   deriveUrlForPrRef, // exported for testing
   classifyPrRefForVerification, // issue #246 — host routing for loose PR-ref verification

package/engine.js

@@ -8096,16 +8096,15 @@ function discoverFromWorkItems(config, project) {
       skipped.noAgent++; continue;
     }
 
-    // W-mq5wfh1v000e0da9 — defense-in-depth: auto-enroll the PR for fix WIs
+    // W-mq5wfh1v000e0da9 — defense-in-depth: auto-enroll the PR for fix/review/test WIs
     // carrying a structured PR pointer. Primary enrollment runs in the
     // dashboard `POST /api/work-items` handler, but WIs created via CLI / restored
     // from disk / older code paths might land here without the PR record.
-    // No-op if the PR is already tracked. Failures swallowed — the gate below
-    // still trips on missing PR records and surfaces `pr_not_found`.
+    // No-op if the PR is already tracked or if the type doesn't require a PR.
+    // Failures swallowed — the gate below still trips on missing PR records
+    // and surfaces `pr_not_found`.
     try {
-      if (item.type === WORK_TYPE.FIX) {
-        shared.autoEnrollPrFromFixWorkItem(item, project, MINIONS_DIR);
-      }
+      shared.autoEnrollPrFromWorkItem(item, project, MINIONS_DIR);
     } catch (e) { log('warn', `auto-enroll PR for ${item.id}: ${e.message}`); }
 
     const linkedPr = resolveWorkItemPrRecord(item, project);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2290",
+  "version": "0.1.2292",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"