@yemi33/minions 0.1.2282 → 0.1.2284

package/engine/lifecycle.js

@@ -749,6 +749,12 @@ function updateWorkItemStatus(meta, status, reason) {
 const _VALID_PRD_STATUSES = new Set([...Object.values(WI_STATUS), 'missing']);
 // (#984) PRD statuses that are stale when the work item is actually done
 const _STALE_PRD_STATUSES = new Set([WI_STATUS.DISPATCHED, WI_STATUS.FAILED, WI_STATUS.PENDING]);
+// (W-mquoejfa000xd6b6) PRD top-level statuses that are frozen — reconcilePrdStatuses must skip
+// these entirely to avoid spurious status transitions or WI dispatches on paused/rejected/
+// awaiting-approval PRDs. Previously only COMPLETED was skipped.
+const _PRD_FROZEN_STATUSES = new Set([
+  PLAN_STATUS.COMPLETED, PLAN_STATUS.PAUSED, PLAN_STATUS.REJECTED, PLAN_STATUS.AWAITING_APPROVAL,
+]);
 function syncPrdItemStatus(itemId, status, sourcePlan) {
   if (!itemId) return;
   if (!_VALID_PRD_STATUSES.has(status)) return;
@@ -826,8 +832,8 @@ function reconcilePrdStatuses(config) {
       const logMessages = [];
       mutateJsonFileLocked(fpath, (plan) => {
         if (!plan?.missing_features) return plan;
-        // Skip completed/archived PRDs — no reconciliation needed
-        if (plan.status === PLAN_STATUS.COMPLETED) return plan;
+        // Skip frozen PRDs — paused/rejected/awaiting-approval/completed require no reconciliation
+        if (_PRD_FROZEN_STATUSES.has(plan.status)) return plan;
 
         for (const feature of plan.missing_features) {
           if (feature.status === PRD_ITEM_STATUS.MISSING && doneWiById.has(feature.id)) {

package/engine/pipeline.js

@@ -522,15 +522,28 @@ function _findExistingPlanForMeeting(meetingIds, plansDir) {
   return slugMatch;
 }
 
-// Check if a PRD already exists for a given plan file (plan already converted)
+// Canonicalize a plan filename by stripping a trailing collision suffix
+// (`-2`, `-3`, …) that `uniquePath` appends AFTER the `-YYYY-MM-DD` date when a
+// same-name plan already exists. A pipeline run whose plan got collision-bumped
+// to `<name>-<date>-2.md` must still link to the PRD written for the canonical
+// `<name>-<date>.md` (a duplicate plan otherwise strands the PRD permanently
+// `awaiting-approval`, defeating the stage's autoApprove). Only strips the
+// suffix when the remainder ends in a full date, so real names are untouched.
+function _canonicalPlanName(planFile) {
+  return String(planFile || '').replace(/^(.*-\d{4}-\d{2}-\d{2})-\d+(\.md)$/i, '$1$2');
+}
+
+// Check if a PRD already exists for a given plan file (plan already converted).
+// Matches by canonical name so a collision-bumped plan still finds its PRD.
 function _findExistingPrdForPlan(planFile, prdDir) {
   if (!fs.existsSync(prdDir)) return null;
   const prdFiles = safeReadDir(prdDir).filter(f => f.endsWith('.json'));
+  const planKey = _canonicalPlanName(planFile);
   for (const pf of prdFiles) {
     // safeJsonNoRestore: PRDs are terminal artifacts — never restore archived
     // PRDs from a stale .backup sidecar (W-mouptdh1000h9f39).
     const prd = safeJsonNoRestore(path.join(prdDir, pf));
-    if (prd?.source_plan && path.basename(String(prd.source_plan)) === planFile) return pf;
+    if (prd?.source_plan && _canonicalPlanName(path.basename(String(prd.source_plan))) === planKey) return pf;
   }
   return null;
 }
@@ -925,10 +938,14 @@ function isStageComplete(stage, stageState, run, config) {
       const discoveredWiIds = [];
       const prdFiles = fs.existsSync(prdDir) ? safeReadDir(prdDir).filter(f => f.endsWith('.json')) : [];
       for (const planFile of plans) {
+        const planKey = _canonicalPlanName(planFile);
         for (const pf of prdFiles) {
           // safeJsonNoRestore — see _findExistingPrdForPlan above (W-mouptdh1000h9f39).
           const prd = safeJsonNoRestore(path.join(prdDir, pf));
-          if (prd?.source_plan && path.basename(String(prd.source_plan)) === planFile && !(artifacts.prds || []).includes(pf) && !discoveredPrds.includes(pf)) {
+          // Canonical match: a collision-bumped run plan (<name>-<date>-2.md)
+          // still links to the PRD written for <name>-<date>.md, so the stage's
+          // autoApprove reaches the PRD instead of stranding it awaiting-approval.
+          if (prd?.source_plan && _canonicalPlanName(path.basename(String(prd.source_plan))) === planKey && !(artifacts.prds || []).includes(pf) && !discoveredPrds.includes(pf)) {
             discoveredPrds.push(pf);
           }
         }
@@ -1244,5 +1261,5 @@ module.exports = {
   evaluateCondition, // exported for testing
   truncatePipelineContext, executeTaskStage, executePlanStage, executeScheduleStage, executeApiStage, executeMeetingStage, executeMergePrsStage, isStageComplete, resolveTemplate, // exported for testing
   _resolvePipelineProjects, // exported for testing
-  _findMeetingsInRun, _findExistingPlanForMeeting, _findExistingPrdForPlan, // exported for testing
+  _findMeetingsInRun, _findExistingPlanForMeeting, _findExistingPrdForPlan, _canonicalPlanName, // exported for testing
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2282",
+  "version": "0.1.2284",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"