@yemi33/minions 0.1.2275 → 0.1.2277

package/dashboard.js

@@ -8260,6 +8260,21 @@ const server = http.createServer(async (req, res) => {
         cleanupPlanWorktrees(body.file, planObj || {}, PROJECTS, getConfig());
       } catch (e) { console.error('plan worktree cleanup:', e.message); }
       safeUnlink(planPath);
+      // Neutralize the `.backup` sidecar so `safeJson` auto-restore can't
+      // RESURRECT the PRD we just deleted (the live file is gone, but a stray
+      // `prd/<plan>.json.backup` would be auto-restored on the next safeJson read
+      // — the PRD comes back, with its prior `status: approved/active`, and the
+      // materializer re-dispatches its work items). Mirrors the Archive handler's
+      // backup cleanup (handlePlansArchive). A PRD delete must remove the restore
+      // fuel, not just the live file.
+      if (body.file.endsWith('.json')) {
+        try {
+          const backupCleanup = shared.neutralizeJsonBackupSidecar(planPath);
+          if (!backupCleanup.ok) {
+            console.warn(`Delete backup cleanup failed for ${body.file}: unlink (${backupCleanup.unlinkError}) / neutralize (${backupCleanup.writeError})`);
+          }
+        } catch (e) { console.warn(`Delete backup cleanup threw for ${body.file}: ${e.message}`); }
+      }
 
       // Clean up materialized work items from all projects + central
       let cleaned = 0;

package/engine.js

@@ -8782,18 +8782,41 @@ function discoverCentralWorkItems(config) {
         // the renderPlaybook pass logs an "unresolved template variables" warning
         // every time a fresh plan-to-prd dispatches.
         vars.existing_prd_json = '';
-        // Check if a PRD already exists for this plan — reuse its filename to avoid duplicates (#884)
+        // Check if a PRD already exists for this plan — reuse its filename to
+        // avoid duplicates (#884). Match by BASENAME (not exact string) so a
+        // `plans/` prefix or separator difference between item.planFile and a
+        // PRD's source_plan can't fork a duplicate PRD (#415 class).
         let prdFilename = null;
+        const planKey = path.basename(String(item.planFile || ''));
         const prdFiles = safeReadDir(PRD_DIR).filter(f => f.endsWith('.json'));
         for (const pf of prdFiles) {
           const prd = safeJson(path.join(PRD_DIR, pf));
-          if (prd?.source_plan === item.planFile) {
+          if (planKey && prd && path.basename(String(prd.source_plan || '')) === planKey) {
             prdFilename = pf;
             try { vars.existing_prd_json = fs.readFileSync(path.join(PRD_DIR, pf), 'utf8'); } catch (_) { /* ignore */ }
             log('info', `plan-to-prd: reusing existing PRD "${pf}" for plan "${item.planFile}" (#884)`);
             break;
           }
         }
+        // Same-plan in-flight reuse (dedup hardening): no on-disk PRD found, but
+        // if ANOTHER plan-to-prd item for the SAME plan already pinned a
+        // _prdFilename — a sibling WI from a prior tick, or another item being
+        // prepared this same tick — REUSE it so concurrent/repeat plan-to-prd
+        // runs for one plan converge to a single PRD instead of splitting into
+        // <slug>-<date>.json / -2.json / -3.json. Match by basename.
+        if (!prdFilename && planKey) {
+          for (const otherItem of items) {
+            if (!otherItem || otherItem.id === item.id || !otherItem._prdFilename) continue;
+            if (path.basename(String(otherItem.planFile || '')) === planKey) { prdFilename = otherItem._prdFilename; break; }
+          }
+          if (!prdFilename) {
+            for (const [otherId, m] of mutations) {
+              if (otherId === item.id || !m || !m._prdFilename) continue;
+              if (m._planKey && m._planKey === planKey) { prdFilename = m._prdFilename; break; }
+            }
+          }
+          if (prdFilename) log('info', `plan-to-prd: reusing in-flight PRD "${prdFilename}" for plan "${item.planFile}" (same-plan dedup)`);
+        }
         if (!prdFilename) {
           // Generate unique PRD filename — check prd/, prd/archive/, AND any
           // _prdFilename already pinned by sibling work items (W-mozkn1bb001j66fd):
@@ -8832,7 +8855,9 @@ function discoverCentralWorkItems(config) {
           while (prdExisting.has(prdFilename)) { prdFilename = prdBase + '-' + prdCounter + '.json'; prdCounter++; }
         }
         vars.prd_filename = prdFilename;
-        mutations.set(item.id, Object.assign(mutations.get(item.id) || {}, { _prdFilename: prdFilename }));
+        // Pin _planKey alongside _prdFilename so the same-plan in-flight reuse
+        // above can recognize a sibling prepared earlier THIS tick by plan.
+        mutations.set(item.id, Object.assign(mutations.get(item.id) || {}, { _prdFilename: prdFilename, _planKey: planKey }));
         vars.branch_strategy_hint = item.branchStrategy
           ? `The user requested **${item.branchStrategy}** strategy. Use this unless the analysis strongly suggests otherwise.`
           : 'Choose the best strategy based on your analysis of item dependencies.';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2275",
+  "version": "0.1.2277",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"