@yemi33/minions 0.1.2273 → 0.1.2275

package/dashboard/slim/body.html

@@ -124,6 +124,17 @@
           </div>
         </div>
       </div>
+      <!-- Pending work items sub-section: lists work items with
+           status === 'pending'. Populated by renderPendingWorkItems() in
+           status.js from the /api/work-items poll slice; hidden via the
+           `hidden` attribute when there are zero pending items. -->
+      <div class="pending-section" id="pending-section" hidden>
+        <div class="pending-head">
+          Pending Work Items
+          <span class="pending-count" id="pending-count"></span>
+        </div>
+        <div class="pending-list" id="pending-list"></div>
+      </div>
     </div>
   </div>
 

package/dashboard/slim/js/history.js

@@ -514,6 +514,7 @@
         _slimSettle('/api/pull-requests', prev.pullRequests),
         _slimSettle('/api/pinned', prev.pinned),
         _slimSettle('/state/engine/watches.json', prev.watches),
+        _slimSettle('/api/work-items', prev.workItems),
       ]);
       var data = results[0] || {};
       data.dispatch = (results[1] && typeof results[1] === 'object') ? results[1] : {};
@@ -521,6 +522,7 @@
       data.pullRequests = Array.isArray(results[3]) ? results[3] : [];
       data.pinned = Array.isArray(results[4]) ? results[4] : [];
       data.watches = Array.isArray(results[5]) ? results[5] : [];
+      data.workItems = Array.isArray(results[6]) ? results[6] : [];
       applyStatus(data);
     } catch (e) {
       // Soft failure — leave previous values, surface in stamp

package/dashboard/slim/js/status.js

@@ -165,6 +165,11 @@
     // ── Team member cards ──────────────────────────────────────
     renderMembers(Array.isArray(data.agents) ? data.agents : []);
 
+    // ── Pending work items section ─────────────────────────────
+    // Surfaces WIs with status === 'pending' (W-mqtx516q). Sourced from the
+    // /api/work-items slice merged in by the slim poll (history.js).
+    renderPendingWorkItems(Array.isArray(data.workItems) ? data.workItems : []);
+
     // ── Stamps + history ───────────────────────────────────────
     var stamp = document.getElementById('cockpit-stamp');
     if (stamp) stamp.textContent = 'updated ' + relTime(data.timestamp || Date.now());
@@ -174,3 +179,94 @@
     if (hStamp) hStamp.textContent = relTime(data.timestamp || Date.now());
   }
 
+  // ── Pending work items renderer ────────────────────────────────
+  // Lists every work item with status === 'pending' in a dedicated section
+  // under the cockpit (W-mqtx516q). The section is hidden via the `hidden`
+  // attribute when there are zero pending items. Each row shows id, title,
+  // project, type, and the engine's _pendingReason as a small badge when set.
+  // Everything goes through textContent (no innerHTML) to keep the SEC-03
+  // baseline clean. A JSON fingerprint of the visible fields skips the DOM
+  // rebuild when nothing changed between 5s polls.
+  var _lastPendingJson = null;
+
+  function renderPendingWorkItems(items) {
+    var section = document.getElementById('pending-section');
+    var list = document.getElementById('pending-list');
+    if (!section || !list) return;
+
+    var pending = (Array.isArray(items) ? items : []).filter(function(w) {
+      return w && w.status === 'pending';
+    });
+
+    var fingerprint = JSON.stringify(pending.map(function(w) {
+      return [w.id, w.title, w.project || w._source, w.type, w._pendingReason];
+    }));
+    if (fingerprint === _lastPendingJson) return;
+    _lastPendingJson = fingerprint;
+
+    if (!pending.length) {
+      section.setAttribute('hidden', '');
+      list.textContent = '';
+      return;
+    }
+    section.removeAttribute('hidden');
+
+    var countEl = document.getElementById('pending-count');
+    if (countEl) countEl.textContent = String(pending.length);
+
+    list.textContent = '';
+    var frag = document.createDocumentFragment();
+    pending.forEach(function(w) {
+      var row = document.createElement('div');
+      row.className = 'pending-row';
+
+      // Top line: title + optional pending-reason badge.
+      var main = document.createElement('div');
+      main.className = 'pending-row-main';
+
+      var title = document.createElement('span');
+      title.className = 'pending-title';
+      title.textContent = w.title || w.id || '(untitled)';
+      title.title = (w.title || w.id || '') + (w.id ? ' (' + w.id + ')' : '');
+      main.appendChild(title);
+
+      if (w._pendingReason) {
+        var badge = document.createElement('span');
+        badge.className = 'pending-reason-badge';
+        badge.textContent = String(w._pendingReason).replace(/_/g, ' ');
+        badge.title = 'Pending reason: ' + w._pendingReason;
+        main.appendChild(badge);
+      }
+      row.appendChild(main);
+
+      // Meta line: id + project + type chips.
+      var meta = document.createElement('div');
+      meta.className = 'pending-row-meta';
+
+      var idEl = document.createElement('span');
+      idEl.className = 'pending-meta-id';
+      idEl.textContent = w.id || '';
+      meta.appendChild(idEl);
+
+      var project = w.project || w._source;
+      if (project) {
+        var projEl = document.createElement('span');
+        projEl.className = 'pending-meta-chip';
+        projEl.textContent = project;
+        meta.appendChild(projEl);
+      }
+
+      if (w.type) {
+        var typeEl = document.createElement('span');
+        typeEl.className = 'pending-meta-chip pending-meta-type';
+        typeEl.textContent = w.type;
+        meta.appendChild(typeEl);
+      }
+      row.appendChild(meta);
+
+      frag.appendChild(row);
+    });
+    list.appendChild(frag);
+  }
+
+

package/dashboard/slim/styles.css

@@ -1139,6 +1139,93 @@
     .team-section { margin-bottom: 14px; }
     .cockpit-section { padding-top: 14px; border-top: 1px solid var(--border); }
 
+    /* Pending work items section (W-mqtx516q). Sits under the cockpit tiles;
+       hidden via the `hidden` attribute when there are no pending WIs. */
+    .pending-section {
+      padding-top: 14px;
+      margin-top: 14px;
+      border-top: 1px solid var(--border);
+    }
+    .pending-section[hidden] { display: none; }
+    .pending-head {
+      font-size: var(--text-sm);
+      font-weight: 600;
+      color: var(--text);
+      letter-spacing: 0.02em;
+      text-transform: uppercase;
+      margin-bottom: 8px;
+      display: flex;
+      align-items: center;
+      gap: 6px;
+    }
+    .pending-count {
+      font-size: var(--text-xs);
+      font-weight: 600;
+      color: var(--orange);
+      background: rgba(214, 153, 34, 0.14);
+      border-radius: 9px;
+      padding: 0 7px;
+      line-height: 16px;
+    }
+    .pending-list {
+      display: flex;
+      flex-direction: column;
+      gap: 6px;
+    }
+    .pending-row {
+      background: var(--surface2);
+      border: 1px solid var(--border);
+      border-left: 3px solid var(--orange);
+      border-radius: var(--radius);
+      padding: 7px 9px;
+    }
+    .pending-row-main {
+      display: flex;
+      align-items: center;
+      gap: 6px;
+    }
+    .pending-title {
+      font-size: var(--text-md);
+      color: var(--text);
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+      min-width: 0;
+      flex: 1;
+    }
+    .pending-reason-badge {
+      flex: none;
+      font-size: var(--text-xs);
+      color: var(--orange);
+      border: 1px solid rgba(214, 153, 34, 0.5);
+      border-radius: 6px;
+      padding: 0 5px;
+      line-height: 15px;
+      white-space: nowrap;
+    }
+    .pending-row-meta {
+      display: flex;
+      align-items: center;
+      flex-wrap: wrap;
+      gap: 6px;
+      margin-top: 4px;
+    }
+    .pending-meta-id {
+      font-size: var(--text-xs);
+      color: var(--muted);
+      font-family: var(--mono, monospace);
+    }
+    .pending-meta-chip {
+      font-size: var(--text-xs);
+      color: var(--muted);
+      background: var(--surface);
+      border: 1px solid var(--border);
+      border-radius: 6px;
+      padding: 0 6px;
+      line-height: 15px;
+    }
+    .pending-meta-type { color: var(--blue); }
+
     /* Square member cards. Auto-fill so the column count adapts to the
        panel width; aspect-ratio keeps each card square regardless. */
     .member-grid {

package/engine/pre-dispatch-eval.js

@@ -168,14 +168,19 @@ async function validateAcceptanceCriteria(workItem, opts = {}) {
       model: _resolveModel(opts),
       maxTurns: 1,
       direct: true,
-      // Direct callLLM spawns the runtime CLI with cwd=MINIONS_DIR (engine/llm.js
-      // _spawnProcess). Without an allowedTools clamp the validator has full
-      // Edit/Write/Bash access to D:\squad and can leak partial implementations
-      // outside any worktree — confirmed in P-b5e2a481 (2026-06-01 23:44 UTC):
-      // the validator "previewed" the work by editing dashboard/js/refresh.js
-      // in MINIONS_DIR before the actual implement agent ran in its worktree.
-      // Read-only tools only — the eval is a JSON-decision call.
-      allowedTools: 'Read,Grep,Glob',
+      // No tools at all. Direct callLLM spawns the runtime CLI with
+      // cwd=MINIONS_DIR (engine/llm.js _spawnProcess). P-b5e2a481 (2026-06-01
+      // 23:44 UTC) removed write access (Edit/Write/Bash) after the validator
+      // "previewed" work by editing dashboard/js/refresh.js in MINIONS_DIR, but
+      // left Read/Grep/Glob in place. Those read tools made the model search the
+      // MINIONS_DIR codebase to "verify" whether the described code exists — but
+      // the cwd is always MINIONS_DIR, never the target project, so work items
+      // targeting other repos (e.g. Android in office/src) were searched against
+      // this Node.js codebase, found nothing, and were wrongly marked invalid.
+      // The pre-dispatch eval is a pure text-reasoning call ("is this clear,
+      // actionable, and testable?") and needs no filesystem access. Passing no
+      // allowedTools makes the runtime omit --allowedTools entirely so the model
+      // reasons only over the prompt text.
       engineConfig: opts.engineConfig,
     });
   } catch (e) {

package/engine/queries.js

@@ -1977,6 +1977,18 @@ function getWorkItems(config, opts) {
   // Use snapshot — sync access; cold start before any async warm returns [].
   // Best-effort enrichment for work item _artifacts.notes, not correctness-critical.
   const _kbEntries = getKnowledgeBaseEntriesSnapshot();
+  // PERF (dashboard event-loop freeze fix): the notes-linkage match below is
+  // `entry contains agentId AND entry contains itemId`. Filtering the FULL
+  // _kbEntries (can be ~10k) and _archiveFiles (~2k) per work item is O(items ×
+  // files) — on a busy instance that's millions of String.includes() per
+  // /api/work-items call, run synchronously, which hard-freezes the single
+  // dashboard event loop. Bucket the two large collections by agentId ONCE per
+  // distinct agent (lazily, like _agentDirCache above), then each item only
+  // scans its agent's much-smaller bucket for the itemId. Exact same match
+  // semantics; O(agents × files) one-time + O(items × bucket) instead of
+  // O(items × files). _inboxFiles stays a direct filter (tiny — a handful).
+  const _kbByAgent = {};      // agentId → kb entries whose source includes agentId
+  const _archiveByAgent = {}; // agentId → archive filenames that include agentId
   // P-34fa5d79 — pre-build the wiId → notes map so each item's _notes lookup
   // is O(1) instead of re-scanning inbox+archive per item.
   const _notesByWi = _buildNotesByWiMap();
@@ -1996,14 +2008,25 @@ function getWorkItems(config, opts) {
       // Notes: inbox → KB (via source field) → archive (fallback if KB was swept)
       const itemId = item.id || '___';
       const matchInbox = _inboxFiles.filter(f => f.includes(agentId) && f.includes(itemId));
-      const matchKb = _kbEntries.filter(kb => kb.source && kb.source.includes(agentId) && kb.source.includes(itemId));
+      // Lazily bucket KB by agentId (computed once per distinct agent), then
+      // filter the small bucket by itemId — same result as filtering all of
+      // _kbEntries by (agentId AND itemId), without the per-item full scan.
+      if (_kbByAgent[agentId] === undefined) {
+        _kbByAgent[agentId] = _kbEntries.filter(kb => kb.source && kb.source.includes(agentId));
+      }
+      const matchKb = _kbByAgent[agentId].filter(kb => kb.source.includes(itemId));
       const allNotes = [
         ...matchInbox,
         ...matchKb.map(kb => 'kb:' + kb.cat + '/' + kb.file),
       ];
-      // Archive fallback — only if nothing found in inbox or KB
+      // Archive fallback — only if nothing found in inbox or KB. Same agentId
+      // bucketing as KB so the (potentially large) archive list isn't fully
+      // re-scanned per item.
       if (allNotes.length === 0) {
-        const matchArchive = _archiveFiles.filter(f => f.includes(agentId) && f.includes(itemId));
+        if (_archiveByAgent[agentId] === undefined) {
+          _archiveByAgent[agentId] = _archiveFiles.filter(f => f.includes(agentId));
+        }
+        const matchArchive = _archiveByAgent[agentId].filter(f => f.includes(itemId));
         for (const f of matchArchive) allNotes.push('archive:' + f);
       }
       if (allNotes.length > 0) arts.notes = _mergeArtifactNotes(arts.notes, allNotes);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2273",
+  "version": "0.1.2275",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"