@yemi33/minions 0.1.2271 → 0.1.2272

package/engine/playbook.js

@@ -959,9 +959,45 @@ function renderPlaybook(type, vars) {
     content += inertAppendices.join('');
   }
 
+  _checkPlaybookSections(content, `playbook "${type}"`);
+
   return content;
 }
 
+// ─── Playbook Section Validator ──────────────────────────────────────────────
+
+// Required structural section patterns — warn (do not throw) when absent.
+// Pluralisation: /^## Tools?\b/m matches both '## Tool' and '## Tools'.
+const _REQUIRED_PROMPT_SECTIONS = [
+  { pattern: /^## Your Task\b/m,   label: '## Your Task' },
+  { pattern: /^## Tools?\b/m,      label: '## Tools' },
+  { pattern: /^## Constraints\b/m, label: '## Constraints' },
+];
+
+/**
+ * Validate that a rendered prompt string contains the required structural
+ * section headers. Logs a 'warn' for each missing section and returns an
+ * array of warning strings (empty when all sections are present).
+ *
+ * @param {string} content - The rendered prompt string to check.
+ * @param {string} [context] - Optional label for the log message, e.g.
+ *   'playbook "implement"'. Prepended as '<context>: ' when provided.
+ * @returns {string[]} warnings - One entry per missing section.
+ */
+function _checkPlaybookSections(content, context = '') {
+  if (typeof content !== 'string' || !content) return [];
+  const prefix = context ? `${context}: ` : '';
+  const warnings = [];
+  for (const { pattern, label } of _REQUIRED_PROMPT_SECTIONS) {
+    if (!pattern.test(content)) {
+      const msg = `${prefix}rendered prompt is missing required section "${label}"`;
+      warnings.push(msg);
+      log('warn', msg);
+    }
+  }
+  return warnings;
+}
+
 // ─── System Prompt Builder ──────────────────────────────────────────────────
 
 // Lean system prompt: agent identity + rules only (~2-4KB, never grows)
@@ -997,7 +1033,11 @@ function buildSystemPrompt(agentId, config, project) {
   prompt += `4. Write learnings to the path specified in the task prompt (format: \`notes/inbox/{agent}-{work-item-id}-{date}-{time}.md\`)\n`;
   prompt += `5. Agent status is managed by the engine via dispatch.json — agents do not need to track their own status\n\n`;
 
-  return prompt;
+  // The lean system prompt (identity + rules) does not contain task-dispatch
+  // sections (## Your Task, ## Tools, ## Constraints) by design — those live
+  // in the rendered playbook. Return an empty warnings array so callers can
+  // destructure { prompt, warnings } uniformly.
+  return { prompt, warnings: [] };
 }
 
 // E2.b (W-mp7goxe4000p75f7): build the `## Existing Skills (do not duplicate)`
@@ -1277,6 +1317,7 @@ module.exports = {
   PLAYBOOK_REQUIRED_VARS,
   PLAYBOOK_OPTIONAL_VARS,
   _parsePlaybookFrontmatter,
+  _checkPlaybookSections,
   buildSystemPrompt,
   buildAgentContext,
   selectPlaybook,

package/engine/shared.js

@@ -5830,7 +5830,9 @@ function resolveSpawnPaths(project, type, minionsDir, options) {
   // single decision point regardless of task type — read-only tasks in
   // live mode still report liveMode:true so downstream callers don't have
   // to re-resolve the project's checkout mode to know they're running in-place.
-  if (isLiveCheckoutProject(project)) {
+  // Pass `type` so hybrid projects (liveValidation) route coding WIs to
+  // worktrees and keep validation WIs in live checkout.
+  if (resolveCheckoutMode(project, type) === CHECKOUT_MODES.LIVE) {
     if (!project.localPath) {
       const err = new Error(
         'live-checkout mode requires project.localPath (checkoutMode === "live" but localPath is missing/falsy).'

package/engine.js

@@ -2137,7 +2137,7 @@ async function spawnAgent(dispatchItem, config) {
 
   // Build the initial prompt before worktree setup, then refresh shared-branch
   // work-item prompts after setup because reused worktrees can live at arbitrary paths.
-  const systemPrompt = buildSystemPrompt(agentId, config, project);
+  const { prompt: systemPrompt } = buildSystemPrompt(agentId, config, project);
   const agentContext = buildAgentContext(agentId, config, project);
   const pendingSteering = steering.buildPendingSteeringPrompt(agentId, { currentDispatchId: id });
   const completionReportPath = shared.dispatchCompletionReportPath(id);
@@ -9850,7 +9850,7 @@ async function tickInner() {
     const projName = d.project || d.meta?.project?.name || null;
     if (!projName) continue;
     const projCfg = shared.findProjectByName(shared.getProjects(config), projName);
-    if (shared.isLiveCheckoutProject(projCfg)) {
+    if (shared.resolveCheckoutMode(projCfg, d.type) === 'live') {
       liveProjectsInUse.add(projName);
     }
   }
@@ -10004,15 +10004,20 @@ async function tickInner() {
     // each other in the operator's localPath, so cap at 1 per project.
     // The branch-mutex check above is the more-specific reason when both
     // apply (same project + same branch), which is why this gate runs
-    // AFTER it.
+    // AFTER it. For hybrid projects (liveValidation): only gate when this
+    // item itself resolves to live mode — worktree-mode coding items on
+    // the same project remain uncapped.
     const itemProjName = item.project || item.meta?.project?.name || null;
     if (
       itemProjName
       && !READ_ONLY_ROOT_TASK_TYPES.has(item.type)
       && liveProjectsInUse.has(itemProjName)
     ) {
-      item._pendingReason = 'live_checkout_busy';
-      continue;
+      const _gateProjCfg = shared.findProjectByName(shared.getProjects(config), itemProjName);
+      if (shared.resolveCheckoutMode(_gateProjCfg, item.type) === 'live') {
+        item._pendingReason = 'live_checkout_busy';
+        continue;
+      }
     }
     if (generalSlots <= 0) continue;
     seenPendingIds.add(item.id);
@@ -10027,7 +10032,7 @@ async function tickInner() {
       && !READ_ONLY_ROOT_TASK_TYPES.has(item.type)
     ) {
       const projCfg = shared.findProjectByName(shared.getProjects(config), itemProjName);
-      if (shared.isLiveCheckoutProject(projCfg)) {
+      if (shared.resolveCheckoutMode(projCfg, item.type) === 'live') {
         liveProjectsInUse.add(itemProjName);
       }
     }
@@ -10105,7 +10110,7 @@ async function tickInner() {
     const projName = d.project || d.meta?.project?.name || null;
     if (!projName) continue;
     const projCfg = shared.findProjectByName(shared.getProjects(config), projName);
-    if (shared.isLiveCheckoutProject(projCfg)) {
+    if (shared.resolveCheckoutMode(projCfg, d.type) === 'live') {
       postLiveProjectsInUse.add(projName);
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2271",
+  "version": "0.1.2272",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"