@yemi33/minions 0.1.2258 → 0.1.2260

package/dashboard.js

@@ -13390,7 +13390,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       }
     }},
 
-    { method: 'POST', path: '/api/pull-requests/delete', desc: 'Remove a PR from tracking', params: 'id, project?', handler: async (req, res) => {
+    { method: 'POST', path: '/api/pull-requests/delete', desc: 'Remove a PR from tracking (sets userDeleted tombstone so pollers do not re-add it)', params: 'id, project?', handler: async (req, res) => {
       const body = await readBody(req);
       const { id } = body;
       if (!id) return jsonReply(res, 400, { error: 'id required' });
@@ -13403,12 +13403,19 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       let found = false;
       for (const prPath of prPaths) {
         if (found) break;
-        mutateJsonFileLocked(prPath, (prs) => {
+        // Issue #384: use a tombstone (userDeleted:true) instead of splice so
+        // the next poller cycle cannot re-add the PR. The entry stays in the
+        // file but is filtered from API responses and skipped by pollers.
+        shared.mutatePullRequests(prPath, (prs) => {
           if (!Array.isArray(prs)) return prs;
-          const idx = prs.findIndex(p => p.id === id);
-          if (idx >= 0) { prs.splice(idx, 1); found = true; }
+          const pr = prs.find(p => p.id === id);
+          if (pr) {
+            pr.userDeleted = true;
+            pr.userDeletedAt = shared.ts();
+            found = true;
+          }
           return prs;
-        }, { defaultValue: [] });
+        });
       }
       if (!found) return jsonReply(res, 404, { error: 'PR not found' });
       invalidateStatusCache();

package/engine/dispatch.js

@@ -1123,7 +1123,7 @@ function cleanDispatchEntries(matchFn) {
         const { execFileSync } = require('child_process');
         execFileSync('taskkill', ['/PID', String(safePid), '/F', '/T'], { stdio: 'pipe', timeout: 5000, windowsHide: true });
       } else {
-        process.kill(safePid, 'SIGTERM');
+        shared.killGracefully({ pid: safePid }, 5000);
       }
     } catch { /* may already be dead */ }
   }

package/engine/pipeline.js

@@ -722,7 +722,7 @@ async function executeApiStage(stage, stageState, run) {
   const timeoutMs = ENGINE_DEFAULTS.pipelineApiTimeoutMs;
 
   for (const call of calls) {
-    const port = shared.readDashboardPortFile(MINIONS_DIR)?.port || (process.env.MINIONS_PORT && parseInt(process.env.MINIONS_PORT, 10)) || 7331;
+    const port = shared.readDashboardPortFile(MINIONS_DIR)?.port || 7331;
     const url = `http://localhost:${port}${call.endpoint}`;
     const body = typeof call.body === 'string' ? call.body : JSON.stringify(call.body || {});
 

package/engine/queries.js

@@ -981,6 +981,8 @@ function getPullRequests(config) {
   const groupsById = new Map();
   for (const pr of sqlPrs) {
     if (!pr || !pr.id) continue;
+    // Issue #384: skip tombstoned records (user explicitly deleted)
+    if (pr.userDeleted === true) continue;
     if (!groupsById.has(pr.id)) {
       const g = [];
       groupsById.set(pr.id, g);

package/engine/shared.js

@@ -5720,14 +5720,32 @@ function resolveProjectRootDir(localPath, minionsDir) {
  * unaffected — it uses GH_TOKEN / the OS credential store, not files under the
  * home — and the operator's real `~/.copilot` (interactive copilot) is untouched.
  *
- * Placed on the MINIONS_DIR volume (copilot's session-store can grow to GBs, so
- * keep it off a possibly-full system drive) but OUTSIDE the repo, at the drive
- * root, so concurrent git branch switches in the working tree can never delete or
- * dirty it. Stable path so copilot session resume (`--resume`) stays consistent
- * across spawns. Falls back to the user home when no minionsDir is given.
+ * Placed OUTSIDE the repo so concurrent git branch switches in the working tree
+ * can never delete or dirty it, on the MINIONS_DIR volume (copilot's session-store
+ * can grow to GBs, so keep it off a possibly-full system drive). Stable path so
+ * copilot session resume (`--resume`) stays consistent across spawns. Falls back
+ * to the user home when no minionsDir is given.
+ *
+ * Base selection is cross-platform (W-copilot-home-posix-root): on Windows the
+ * MINIONS_DIR drive root (`C:\`, `D:\`, or a UNC share root) is user-writable, so
+ * we anchor there. On POSIX the filesystem root (`/`) is NOT user-writable — a
+ * home placed there can never be created (`mkdir` EACCES), `ensureAgentCopilotHome`
+ * fail-opens and returns the uncreatable path anyway, and every spawned
+ * `copilot --acp` / copilot agent then inherits a `COPILOT_HOME` it can't use and
+ * exits code 1 silently (surfaced in CC as "Load failed"). So when the drive root
+ * is the bare POSIX root we fall back to the user home — repo-external, writable,
+ * and on the user's own volume.
  */
 function resolveAgentCopilotHome(minionsDir) {
-  const base = minionsDir ? path.parse(path.resolve(String(minionsDir))).root : os.homedir();
+  let base;
+  if (minionsDir) {
+    const root = path.parse(path.resolve(String(minionsDir))).root;
+    // The POSIX filesystem root ('/') is not user-writable; Windows drive/UNC
+    // roots are. Anchor at the user home in the unwritable-root case.
+    base = (root === '/' || root === path.sep) ? os.homedir() : root;
+  } else {
+    base = os.homedir();
+  }
   return path.join(base, '.minions-agent-copilot-home');
 }
 
@@ -7003,6 +7021,13 @@ function upsertPullRequestRecord(prPath, entry, { project = null, itemId = null,
   mutatePullRequests(prPath, (prs) => {
     normalizePrRecords(prs, project);
     let target = findPrRecord(prs, normalizedEntry, project);
+    // Issue #384: tombstoned records (userDeleted:true) must not be re-activated
+    // by any poller path. Return skipped so reconcilePrs / shared-branch-reconcile
+    // cannot resurrect a PR the user explicitly removed.
+    if (target && target.userDeleted === true) {
+      skipped = true;
+      return prs;
+    }
     if (!target && typeof beforeInsert === 'function' && beforeInsert(prs, normalizedEntry) === false) {
       skipped = true;
       return prs;

package/engine.js

@@ -6622,6 +6622,8 @@ async function discoverFromPrs(config, project) {
 
   for (const pr of prs) {
     if (pr.status !== PR_STATUS.ACTIVE) continue;
+    // Issue #384: skip tombstoned PRs (user explicitly deleted via dashboard)
+    if (pr.userDeleted === true) continue;
     if (shared.isContextOnlyPrRecord(pr)) {
       _logPrDispatchSkipOnce(pr, 'context-only');
       continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2258",
+  "version": "0.1.2260",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"