@yemi33/minions 0.1.2245 → 0.1.2247

package/engine/lifecycle.js

@@ -3906,12 +3906,47 @@ function _deferRetryWithCounter(meta, detection, counterField, maxCount, pending
   if (!wiPath) return reason;
 
   let finalStatus = WI_STATUS.PENDING;
+  let systematicPhantom = null;
   try {
     mutateJsonFileLocked(wiPath, data => {
       if (!Array.isArray(data)) return data;
       const w = data.find(i => i.id === itemId);
       if (!w) return data;
       const retries = w[counterField] || 0;
+
+      // Systematic phantom detection: after 2+ phantom completions spanning
+      // 2+ different agents, the failure is likely content-filter or prompt-
+      // malformed. Mark non-retryable immediately so human can intervene.
+      if (counterField === '_phantomRetryCount') {
+        const phantomAgent = meta?._agentId || w.dispatched_to;
+        if (!w._phantomAgents || typeof w._phantomAgents !== 'object' || Array.isArray(w._phantomAgents)) {
+          w._phantomAgents = {};
+        }
+        if (phantomAgent) {
+          w._phantomAgents[phantomAgent] = (w._phantomAgents[phantomAgent] || 0) + 1;
+        }
+        const distinctAgents = Object.keys(w._phantomAgents);
+        if (distinctAgents.length >= 2 && retries >= 1) {
+          w.status = WI_STATUS.FAILED;
+          w.failReason = `Systematic phantom completion across ${distinctAgents.length} agents ` +
+            `(${distinctAgents.join(', ')}) — likely a content filter triggered by the task description ` +
+            `or a malformed prompt. Manual intervention required.`;
+          w._failureClass = 'phantom-all-agents';
+          w.failedAt = ts();
+          delete w.completedAt;
+          delete w.dispatched_at;
+          delete w.dispatched_to;
+          delete w._pendingReason;
+          delete w._phantomCompletion;
+          delete w._phantomBranch;
+          finalStatus = WI_STATUS.FAILED;
+          systematicPhantom = { distinctCount: distinctAgents.length, agents: distinctAgents };
+          log('warn', `Work item ${itemId} systematically phantoms across ${distinctAgents.length} agents ` +
+            `(${distinctAgents.join(', ')}) — marking non-retryable (phantom-all-agents)`);
+          return data;
+        }
+      }
+
       if (retries < maxCount) {
         w.status = WI_STATUS.PENDING;
         w[counterField] = retries + 1;
@@ -3963,6 +3998,20 @@ function _deferRetryWithCounter(meta, detection, counterField, maxCount, pending
   } catch (err) {
     log('warn', `${pendingReason} gate: ${err.message}`);
   }
+  // Post diagnostic inbox note when systematic phantom detection fired.
+  if (systematicPhantom) {
+    shared.writeToInbox('engine', `phantom-all-agents-${itemId}`,
+      `# Systematic phantom completion for ${itemId}\n\n` +
+      `**Work item:** \`${itemId}\` — ${meta.item?.title || ''}\n` +
+      `**Agents that all phantom-completed:** ${systematicPhantom.agents.join(', ')}\n\n` +
+      `All ${systematicPhantom.distinctCount} agents produced phantom completions ` +
+      `(process exited 0 but emitted no result event). This pattern is typically caused by:\n` +
+      `- A runtime content filter triggered by credential-shaped strings in the task description\n` +
+      `- A malformed prompt that causes the runtime to bail out silently\n\n` +
+      `The work item has been marked non-retryable. **Manual intervention required.**\n`,
+      null,
+      { sourceItem: itemId, reason: 'phantom-all-agents' });
+  }
   return reason;
 }
 
@@ -5019,6 +5068,9 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
         log('info', `Phantom-completion recovered for ${meta.item.id} via ls-remote + PR auto-link — no retry needed`);
       } else {
         skipDoneStatus = true;
+        // Stamp agentId on meta so _deferRetryWithCounter can track
+        // phantom completions per agent (systematic phantom detection).
+        if (!meta._agentId) meta._agentId = agentId;
         const reason = isPhantomDetection
           ? deferPhantomCompletion(meta, nonTerminalCompletion)
           : deferNonTerminalCompletion(meta, nonTerminalCompletion);

package/engine/shared.js

@@ -415,6 +415,21 @@ function redactSecrets(value, options = {}) {
   return value;
 }
 
+// Authorization header pattern broader than _BEARER_RE: catches already-redacted
+// placeholder forms (e.g. `Authorization: Bearer <REDACTED>`) that still look
+// credential-shaped to Copilot CLI safety filters and cause silent phantom exits.
+const _AUTH_HEADER_RE = /\bAuthorization\s*:\s*Bearer\s+\S+/gi;
+
+// Redactor applied to WI description text before it is injected into an agent
+// prompt. Applies the standard log redactor (_redactString) first, then catches
+// any remaining Authorization: Bearer header — including already-redacted forms
+// with placeholder values — that would trigger Copilot CLI safety bail-outs.
+function redactPromptDescription(s) {
+  if (s == null) return s;
+  if (typeof s !== 'string' || s.length === 0) return s;
+  return _redactString(s).replace(_AUTH_HEADER_RE, 'Authorization: Bearer [REDACTED-IN-DESC]');
+}
+
 // ── Log Buffering ──────────────────────────────────────────────────────────
 // Buffer log entries in memory and flush to disk periodically to reduce lock
 // contention (~139 calls/tick → 1 lock acquisition per flush).
@@ -9089,6 +9104,7 @@ module.exports = {
   openAppendLogFd,
   flushLogs,
   redactSecrets,
+  redactPromptDescription,
   slugify,
   getPrAutomationCauses,
   hasPrAutomationCause,

package/engine.js

@@ -7337,9 +7337,9 @@ function renderProjectWorkItemPromptForAgent(item, workType, agentId, config, pr
     item_id: item.id,
     item_name: item.title || item.id,
     item_priority: item.priority || 'medium',
-    item_description: item.description || '',
+    item_description: shared.redactPromptDescription(item.description || ''),
     item_complexity: item.complexity || item.estimated_complexity || 'medium',
-    task_description: item.title + (item.description ? '\n\n' + item.description : ''),
+    task_description: shared.redactPromptDescription(item.title + (item.description ? '\n\n' + item.description : '')),
     task_id: item.id,
     work_type: workType,
     source_plan: item.sourcePlan || '',
@@ -8575,9 +8575,9 @@ function discoverCentralWorkItems(config) {
         item_id: item.id,
         item_name: item.title || item.id,
         item_priority: item.priority || 'medium',
-        item_description: item.description || '',
+        item_description: shared.redactPromptDescription(item.description || ''),
         item_complexity: item.complexity || item.estimated_complexity || 'medium',
-        task_description: item.title + (item.description ? '\n\n' + item.description : ''),
+        task_description: shared.redactPromptDescription(item.title + (item.description ? '\n\n' + item.description : '')),
         task_id: item.id,
         work_type: workType,
         additional_context: item.prompt ? `## Additional Context\n\n${item.prompt}` : '',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2245",
+  "version": "0.1.2247",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"