@yemi33/minions 0.1.2244 → 0.1.2246

package/dashboard/js/refresh.js

@@ -147,7 +147,7 @@ const RENDER_VERSIONS = {
   dispatch: 2,
   engineLog: 2,
   metrics: 1,
-  workItems: 4,
+  workItems: 5,
   skills: 1,
   commands: 1,
   mcpServers: 1,

package/dashboard/js/render-work-items.js

@@ -171,6 +171,14 @@ function wiRow(item) {
     : (item.branchStrategy === 'shared-branch' && item.status === 'done')
       ? '<span style="font-size:var(--text-xs);color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
       : '<span style="color:var(--muted)">—</span>';
+  // W-mqrdn6qq — Non-retryable failures surface their red failReason snippet in
+  // the PR column (not the Agent column). The engine prefixes failReason with
+  // "Non-retryable failure:" and stamps item._failureClass on non-retryable
+  // demotion (engine/dispatch.js writeDispatchResult / force-demote path).
+  var isNonRetryableFail = !!item._failureClass || /^Non-retryable failure:/i.test(item.failReason || '');
+  var failSnippet = item.failReason
+    ? '<span style="display:block;font-size:var(--text-xs);color:var(--red)" title="' + escapeHtml(item.failReason) + '">' + escapeHtml(item.failReason.slice(0, 30)) + '</span>'
+    : '';
   // PR follow-up chip (W-mpej3cox00099466) — surfaced when the WI was spun
   // off from a PR comment via meta.pr_followup. Links to the parent PR.
   var prFollowup = item.meta && item.meta.pr_followup;
@@ -183,7 +191,7 @@ function wiRow(item) {
   }
   return '<tr data-wi-id="' + escapeHtml(item.id) + '" style="cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openWorkItemDetail(\'' + escapeHtml(item.id) + '\')">' +
     '<td><span class="pr-id">' + escapeHtml(item.id || '') + '</span></td>' +
-    '<td style="max-width:220px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escapeHtml((item.title || '').slice(0, 200)) + '">' + escapeHtml(item.title || '') + followupChip + '</td>' +
+    '<td style="min-width:280px;max-width:320px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escapeHtml((item.title || '').slice(0, 200)) + '">' + escapeHtml(item.title || '') + followupChip + '</td>' +
     '<td><span style="font-size:var(--text-sm);color:var(--muted)">' + escapeHtml(item._source || '') + '</span>' +
       (item.scope === 'fan-out' ? ' <span class="pr-badge ' + (item.status === 'done' || item.status === 'failed' ? 'draft' : 'building') + '" style="font-size:var(--text-xs)">fan-out</span>' : '') + '</td>' +
     '<td>' + typeBadge(item.type) + '</td>' +
@@ -217,9 +225,9 @@ function wiRow(item) {
       (item.completedAgents && item.completedAgents.length > 0
         ? '<span class="pr-agent">' + escapeHtml(item.completedAgents.join(', ')) + '</span>'
         : '<span class="pr-agent">' + escapeHtml(item.dispatched_to || item.agent || '—') + '</span>') +
-      (item.failReason ? '<span style="display:block;font-size:var(--text-xs);color:var(--red)" title="' + escapeHtml(item.failReason) + '">' + escapeHtml(item.failReason.slice(0, 30)) + '</span>' : '') +
+      (failSnippet && !isNonRetryableFail ? failSnippet : '') +
     '</td>' +
-    '<td>' + prLink + '</td>' +
+    '<td>' + prLink + (failSnippet && isNonRetryableFail ? failSnippet : '') + '</td>' +
     '<td><span class="pr-date">' + escapeHtml((item.created || '').slice(0, 16).replace('T', ' ')) + '</span></td>' +
     '<td style="white-space:nowrap;font-size:var(--text-xs);color:var(--muted)">' +
       (function() {
@@ -278,7 +286,7 @@ function renderWorkItems(items, opts) {
   const start = wiPage * WI_PER_PAGE;
   const pageItems = items.slice(start, start + WI_PER_PAGE);
 
-  let html = '<div class="pr-table-wrap"><table class="pr-table"><thead><tr><th>ID</th><th>Title</th><th>Source</th><th>Type</th><th>Priority</th><th>Status</th><th>Agent</th><th>PR</th><th>Created</th><th></th><th></th></tr></thead><tbody>';
+  let html = '<div class="pr-table-wrap"><table class="pr-table"><thead><tr><th>ID</th><th>Title</th><th>Project</th><th>Type</th><th>Priority</th><th>Status</th><th>Agent</th><th>PR</th><th>Created</th><th></th><th></th></tr></thead><tbody>';
   html += pageItems.map(wiRow).join('');
   html += '</tbody></table></div>';
 
@@ -479,7 +487,7 @@ async function toggleWorkItemArchive() {
       items.map(function(i) {
         return '<tr style="opacity:0.6">' +
           '<td><span class="pr-id">' + escapeHtml(i.id || '') + '</span></td>' +
-          '<td style="max-width:200px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap">' + escapeHtml(i.title || '') + '</td>' +
+          '<td style="min-width:240px;max-width:280px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap">' + escapeHtml(i.title || '') + '</td>' +
           '<td><span class="dispatch-type ' + (i.type || '') + '">' + escapeHtml(i.type || '') + '</span></td>' +
           '<td style="color:' + (i.status === 'done' ? 'var(--green)' : 'var(--red)') + '">' + escapeHtml(i.status || '') + '</td>' +
           '<td>' + escapeHtml(i.dispatched_to || '—') + '</td>' +
@@ -746,7 +754,7 @@ function _wiRenderDetail(item) {
   }
   html += field('Description', '<div id="wi-detail-desc" style="font-size:var(--text-md);max-height:320px;overflow-y:auto;padding:8px 10px;background:var(--surface2);border:1px solid var(--border);border-radius:var(--radius-sm)">' + _descHtml + '</div>');
   html += field('Agent', escapeHtml(item.dispatched_to || item.agent || 'Auto'));
-  html += field('Source', escapeHtml(item._source || 'central'));
+  html += field('Project', escapeHtml(item._source || 'central'));
   // P-714ef144 — surface meta.workdir in the detail modal so operators can
   // confirm the agent's actual cwd. Renders nothing when unset (which is
   // the back-compat default = project root). Code-tagged so the path is
@@ -1053,7 +1061,7 @@ function openWorkItemDetail(id) {
 
 function openAllWorkItems() {
   document.getElementById('modal-title').textContent = 'All Work Items (' + allWorkItems.length + ')';
-  const html = '<div class="pr-table-wrap"><table class="pr-table"><thead><tr><th>ID</th><th>Title</th><th>Source</th><th>Type</th><th>Priority</th><th>Status</th><th>Agent</th><th>PR</th><th>Created</th><th></th><th></th></tr></thead><tbody>' +
+  const html = '<div class="pr-table-wrap"><table class="pr-table"><thead><tr><th>ID</th><th>Title</th><th>Project</th><th>Type</th><th>Priority</th><th>Status</th><th>Agent</th><th>PR</th><th>Created</th><th></th><th></th></tr></thead><tbody>' +
     allWorkItems.map(wiRow).join('') + '</tbody></table></div>';
   // eslint-disable-next-line no-unsanitized/property -- reason: structural HTML is a string literal; all user data wrapped in escapeHtml() by wiRow() (fields: work item id/title/source/status/agent/PR links/dates/follow-up metadata)
   document.getElementById('modal-body').innerHTML = html;

package/dashboard/slim/body.html

@@ -112,6 +112,11 @@
             <div class="cockpit-value dim">0</div>
             <div class="cockpit-detail">pinned context, notes &amp; KB</div>
           </div>
+          <div class="cockpit-tile" data-tile="plans">
+            <div class="cockpit-label"><span class="cockpit-dot"></span> Plans</div>
+            <div class="cockpit-value dim">0</div>
+            <div class="cockpit-detail">drafts &amp; materialized PRDs</div>
+          </div>
         </div>
       </div>
     </div>
@@ -212,6 +217,29 @@
   </div>
 </div>
 
+<!-- Plans + PRD control panel — opened from the "Plans" status tile. Two tabs:
+     Plans (.md plan drafts) and PRD (materialized PRDs). Each tab is rendered
+     lazily by dashboard/slim/js/plans.js into #slim-plans-body. Backed by the
+     existing endpoints (no new server routes):
+       Plans — /api/plans (list), /api/plans/:file (read), and the lifecycle
+               POSTs (/api/plans/{approve,execute,reject,pause,regenerate,
+               archive,delete,unarchive}).
+       PRD   — the .json entries from /api/plans plus /api/prd and the
+               read-only subset of /api/prd-items. -->
+<div class="modal-bg" id="slim-plans-modal">
+  <div class="modal slim-plans-modal-inner">
+    <div class="modal-header">
+      <h3>Plans</h3>
+      <div class="kn-tabs" id="slim-plans-tabs" role="tablist">
+        <button class="kn-tab active" id="slim-plans-tab-plans" data-plans-tab="plans" type="button" role="tab" aria-selected="true" aria-controls="slim-plans-body">Plans</button>
+        <button class="kn-tab" id="slim-plans-tab-prd" data-plans-tab="prd" type="button" role="tab" aria-selected="false" aria-controls="slim-plans-body">PRD</button>
+      </div>
+      <button id="slim-plans-close" class="icon-btn" title="Close" style="margin-left:auto">&times;</button>
+    </div>
+    <div class="modal-body" id="slim-plans-body" role="tabpanel" tabindex="0" aria-labelledby="slim-plans-tab-plans"></div>
+  </div>
+</div>
+
 <!-- Pin editor — create (Pin Content action / "+ Pin") or edit an existing
      note. Submits to POST /api/pinned (create) or /api/pinned/update (edit). -->
 <div class="modal-bg" id="slim-pin-edit-modal">

package/dashboard/slim/js/chat.js

@@ -27,8 +27,27 @@
 
   var sessionId = null;
   var messages = [];
-  var sending = false;
-  var abortController = null;
+  // Per-tab streaming runtime (W-mqqvba66). Stream state lives here, keyed by
+  // tabId, so an in-flight turn keeps running AND accumulating when the user
+  // switches to another tab — mirroring the classic dashboard's per-tab
+  // tab._sending / _abortController / _segments model (command-center.js). The
+  // old module-global `sending` / `abortController` (one turn at a time) caused
+  // a mid-stream tab switch to abort the server turn and push the captured
+  // partial onto the wrong (now-active) tab. Each entry:
+  //   { sending, abortController, streamedText, toolList, stream, userAborted }
+  // `stream` is the live DOM bubble handle — only set while that tab is the
+  // visible pane (null on background tabs; re-created on switch-back).
+  var tabStreams = {};
+  function _streamState(id) {
+    return tabStreams[id] || (tabStreams[id] = {
+      sending: false, abortController: null, streamedText: '',
+      toolList: [], stream: null, userAborted: false,
+    });
+  }
+  function _isTabSending(id) {
+    var st = tabStreams[id];
+    return !!(st && st.sending);
+  }
   // Per-tab queue of follow-up messages submitted while a turn is streaming
   // (W-mqayw3x6). Keyed by tabId so each chat tab keeps its own queue across
   // tab switches. In-memory only — a hard refresh drops the queue by design.
@@ -129,14 +148,19 @@
     if (m.severity) out.severity = m.severity;
     return out;
   }
-  function _deriveTitle() {
-    for (var i = 0; i < messages.length; i++) {
-      if (messages[i] && messages[i].role === 'user' && messages[i].text) {
-        return messages[i].text.slice(0, 40);
+  function _deriveTitleFrom(msgs) {
+    for (var i = 0; i < (msgs || []).length; i++) {
+      var m = msgs[i];
+      if (m && m.role === 'user') {
+        var t = (typeof m.text === 'string') ? m.text : _htmlToText(m.html);
+        if (t) return t.slice(0, 40);
       }
     }
     return 'New chat';
   }
+  function _deriveTitle() {
+    return _deriveTitleFrom(messages);
+  }
 
   function loadState() {
     try {
@@ -168,6 +192,70 @@
     }, 300);
   }
 
+  // Append a message to a SPECIFIC tab (W-mqqvba66). For the active (visible)
+  // tab we reuse the in-memory `messages` array + debounced saveState; for a
+  // background tab — one whose turn is still streaming while the user views a
+  // different tab — we write straight through to the shared cc-tabs store so the
+  // response is recorded on its OWN tab and never mis-attributed to the live
+  // `messages`/`tabId`. The originating tabId is captured at send time and
+  // threaded through every append (see command-send.js _performSend).
+  function recordTabMessage(id, msg) {
+    if (id === tabId) {
+      messages.push(msg);
+      saveState();
+    } else {
+      _persistBackgroundMessage(id, msg);
+    }
+  }
+  function _persistBackgroundMessage(id, msg) {
+    try {
+      var tabs = _readCcTabs();
+      var idx = _findTabIdx(tabs, id);
+      if (idx < 0) return;   // tab was closed/removed — drop rather than resurrect it
+      var tab = tabs[idx];
+      var msgs = Array.isArray(tab.messages) ? tab.messages : [];
+      msgs.push(_slimToStored(msg));
+      tab.messages = msgs.slice(-SLIM_MAX_MESSAGES);
+      tab.title = _deriveTitleFrom(tab.messages);
+      tabs[idx] = tab;
+      _writeCcTabs(tabs);
+    } catch (_e) { /* localStorage full */ }
+  }
+  // Resolve / persist a tab's server session id, targeting the right store entry
+  // regardless of which tab is currently visible.
+  function _getTabSessionId(id) {
+    if (id === tabId) return sessionId;
+    try {
+      var tabs = _readCcTabs();
+      var idx = _findTabIdx(tabs, id);
+      return idx >= 0 ? (tabs[idx].sessionId || null) : null;
+    } catch (_e) { return null; }
+  }
+  function _setTabSessionId(id, sid) {
+    if (id === tabId) { sessionId = sid; saveState(); return; }
+    try {
+      var tabs = _readCcTabs();
+      var idx = _findTabIdx(tabs, id);
+      if (idx < 0) return;
+      tabs[idx].sessionId = sid;
+      _writeCcTabs(tabs);
+    } catch (_e) { /* localStorage full */ }
+  }
+  // True if a given tab already has at least one user message (drives the
+  // first-message title-chip refresh), targeting the active in-memory array or
+  // the persisted store for a background tab.
+  function _tabHasUserMessage(id) {
+    if (id === tabId) {
+      return messages.some(function(m) { return m && m.role === 'user'; });
+    }
+    try {
+      var tabs = _readCcTabs();
+      var idx = _findTabIdx(tabs, id);
+      if (idx < 0) return false;
+      return (tabs[idx].messages || []).some(function(m) { return m && m.role === 'user'; });
+    } catch (_e) { return false; }
+  }
+
   function escHtmlChat(s) {
     return String(s == null ? '' : s)
       .replace(/&/g, '&amp;')
@@ -425,7 +513,7 @@
     return { panel: panel, scroll: scroll };
   }
 
-  function buildStreamBubble() {
+  function buildStreamBubble(initialText, initialTools) {
     clearEmpty();
     var div = document.createElement('div');
     div.className = 'chat-msg assistant streaming';
@@ -445,11 +533,20 @@
     thinking.innerHTML = 'Thinking<span class="chat-thinking-dots"><span></span><span></span><span></span></span>';
     toolbar.appendChild(thinking);
 
-    var toolList = [];
+    // Reuse the caller's backing tool list (shared by reference) when restoring
+    // a live bubble after a tab switch, so already-streamed tools replay and new
+    // ones keep appending into the SAME per-tab array (W-mqqvba66).
+    var toolList = Array.isArray(initialTools) ? initialTools : [];
     var tp = buildToolsPanel(toolList);
-    tp.panel.style.display = 'none';
+    tp.panel.style.display = toolList.length ? '' : 'none';
     toolbar.appendChild(tp.panel);
 
+    // Seed the partial text accumulated so far (restore-on-switch-back path).
+    if (initialText) {
+      // eslint-disable-next-line no-unsanitized/property -- reason: renderMarkdown() escapes input via escHtmlChat() first; later substitutions only re-insert pre-escaped <pre><code>/<a>/<strong>/<em> spans with scheme-validated hrefs
+      body.innerHTML = renderMarkdown(initialText);
+    }
+
     _appendMsgEl(div);
     scrollToBottom();
 
@@ -489,8 +586,15 @@
     };
   }
 
-  function setSending(on) {
-    sending = on;
+  // Stream state is per-tab now (W-mqqvba66): toggle the originating tab's
+  // sending flag, and only refresh the composer chrome when that tab is the
+  // visible one (the Send/Stop buttons always reflect the ACTIVE tab).
+  function setSendingFor(id, on) {
+    _streamState(id).sending = on;
+    if (id === tabId) _refreshComposerUI();
+  }
+  function _refreshComposerUI() {
+    var on = _isTabSending(tabId);
     // Composer stays interactive while a turn streams so the user can keep
     // typing and queue follow-up messages (W-mqayw3x6 #1). The Send button
     // stays enabled — submitting mid-turn enqueues — and only its label
@@ -561,30 +665,56 @@
     tabsEl.appendChild(add);
   }
 
-  // Switch the visible pane to another shared tab. Aborts an in-flight stream
-  // first (the SSE is bound to the current tabId), then re-hydrates from the
-  // target tab's persisted state.
+  // Detach the active tab's live stream-bubble handle before its transcript DOM
+  // is wiped (rerenderHistory). The background fetch loop checks `st.stream`
+  // every chunk, so nulling it makes the still-running turn stop touching the
+  // DOM while keeping its partial accumulating into st.streamedText / saveState.
+  function _detachActiveStream() {
+    var st = tabStreams[tabId];
+    if (st) st.stream = null;
+  }
+  // Re-attach a live streaming bubble for a tab the user is switching BACK to
+  // while its turn is still in flight, seeded from the tab's accumulated partial
+  // + tool list (mirror classic's _restoreStreamHtml). The running fetch loop
+  // resumes updating st.stream as new chunks arrive; slim has no elapsed-timer
+  // chrome, so unlike classic no 1s restore interval is needed.
+  function _restoreStreamFor(id) {
+    var st = tabStreams[id];
+    if (!st || !st.sending) return;
+    st.stream = buildStreamBubble(st.streamedText, st.toolList);
+  }
+
+  // Switch the visible pane to another shared tab. The previous tab's in-flight
+  // stream is KEPT RUNNING in the background (W-mqqvba66) — we never abort on a
+  // switch — and the target tab is re-hydrated from its own persisted state,
+  // restoring its live streaming bubble if it is mid-turn.
   function switchSlimTab(id) {
     if (!id || id === tabId) return;
-    if (sending) abortInFlight();
+    _detachActiveStream();
     tabId = id;
     try { localStorage.setItem(CC_ACTIVE_KEY, id); } catch (_e) { /* private mode */ }
     sessionId = null;
     messages = [];
     loadState();
     rerenderHistory();
+    _restoreStreamFor(id);
     renderTabBar();
+    _refreshComposerUI();
     inputEl.focus();
   }
 
   function closeSlimTab(id) {
     if (!id) return;
-    if (id === tabId && sending) abortInFlight();
+    // Closing a streaming tab DOES abort + delete its server session (one of the
+    // only two abort paths left, alongside the explicit Stop button).
+    if (_isTabSending(id)) abortTab(id);
     var tabs = _readCcTabs();
     var idx = _findTabIdx(tabs, id);
     if (idx < 0) return;
     tabs.splice(idx, 1);
     _writeCcTabs(tabs);
+    delete queues[id];
+    delete queueSuspended[id];
     // Evict the server-side session for the closed tab (mirrors classic).
     try { fetch('/api/cc-sessions/' + encodeURIComponent(id), { method: 'DELETE' }).catch(function() {}); } catch (_e) { /* ignore */ }
     if (id !== tabId) { renderTabBar(); return; }