@yemi33/minions 0.1.2237 → 0.1.2238

package/dashboard/js/render-other.js

@@ -37,6 +37,10 @@ function _renderProjectBranch(p) {
   if (!p) return '';
   if (p.gitState === 'missing') return '<span class="project-warn" title="Project localPath does not exist on disk">(path not found)</span>';
   if (p.gitState === 'non-git') return '<span class="project-muted" title="Project path exists but is not a git repository">(not a git repo)</span>';
+  // opg-microsoft/minions#312 — the git-status probe timed out (e.g. a slow
+  // \\wsl.localhost\ 9P share). The repository is valid; show a neutral
+  // "checking" chip instead of the misleading "(not a git repo)" label.
+  if (p.gitState === 'probe-timeout') return '<span class="project-muted" title="Git status probe timed out (slow filesystem, e.g. a \\\\wsl.localhost\\ share). The repository is valid and will refresh.">(checking git…)</span>';
   if (p.gitState !== 'ok' || !p.gitBranch) return '';
   // opg-microsoft/minions#295: the engine flags `gitStale: true` when tracked
   // git refs have advanced past the cached snapshot (e.g. the operator ran

package/engine/queries.js

@@ -2301,6 +2301,13 @@ const PROJECT_GIT_STATUS_TTL = 15000;
 const PROJECT_GIT_STATUS_PENDING = Object.freeze({ gitBranch: null, gitDetached: false, gitDirty: false, gitState: 'pending', remoteDefaultBranch: null, ahead: null, behind: null });
 const PROJECT_GIT_STATUS_MISSING = Object.freeze({ gitBranch: null, gitDetached: false, gitDirty: false, gitState: 'missing', remoteDefaultBranch: null, ahead: null, behind: null });
 const PROJECT_GIT_STATUS_NON_GIT = Object.freeze({ gitBranch: null, gitDetached: false, gitDirty: false, gitState: 'non-git', remoteDefaultBranch: null, ahead: null, behind: null });
+// opg-microsoft/minions#312 — distinct state for "the probe could not settle
+// in time" (or the path clearly contains a .git but rev-parse failed). A
+// probe-budget timeout is NOT evidence the path lacks a repository: slow
+// filesystems (\\wsl.localhost\ 9P shares, Defender real-time scanning) can
+// legitimately blow the 10s/15s budget on a valid repo. Collapsing that to
+// `non-git` produced the misleading "(not a git repo)" dashboard label.
+const PROJECT_GIT_STATUS_PROBE_TIMEOUT = Object.freeze({ gitBranch: null, gitDetached: false, gitDirty: false, gitState: 'probe-timeout', remoteDefaultBranch: null, ahead: null, behind: null });
 
 // Probe budget constants (W-mq19314k00101fc7). `PROBE_TIMEOUT_MS` is the
 // per-invocation execFile timeout; `PROBE_WATCHDOG_MS` is an OUTER
@@ -2375,6 +2382,30 @@ function _gitExec(localPath, args) {
   });
 }
 
+// opg-microsoft/minions#312 — classifies a `_gitExec` rejection as a
+// probe-budget timeout (the outer watchdog or execFile's own `timeout`
+// killing the child) rather than a genuine git failure such as an exit-128
+// "fatal: not a git repository". A timeout is not evidence the path lacks a
+// repo, so the caller keeps it out of the `non-git` bucket.
+function _isProbeTimeoutError(err) {
+  if (!err) return false;
+  if (typeof err.message === 'string' && err.message.includes('git probe watchdog')) return true;
+  // execFile timeout: Node force-kills the child (killed=true) with the
+  // configured kill signal, or surfaces an ETIMEDOUT code.
+  if (err.killed === true) return true;
+  if (err.code === 'ETIMEDOUT' || err.signal === 'SIGTERM' || err.signal === 'SIGKILL') return true;
+  return false;
+}
+
+// opg-microsoft/minions#312 — cheap existence check for a `.git` entry
+// (a directory for a normal repo, or a gitlink file for a worktree /
+// submodule). Used to override a failed/slow rev-parse so a path that
+// plainly contains a repository is never mislabelled "(not a git repo)".
+function _hasGitDir(localPath) {
+  try { return fs.existsSync(path.join(localPath, '.git')); }
+  catch { return false; }
+}
+
 // Probe a single project. Returns the resolved status value. Used both by the
 // background refresh path inside getProjectGitStatus and by test code that
 // wants to drive a probe to completion deterministically.
@@ -2388,11 +2419,23 @@ async function _probeProjectGitStatus(localPath, configuredMainBranch) {
   try {
     if (!fs.existsSync(localPath)) return PROJECT_GIT_STATUS_MISSING;
     let isRepo = false;
+    let probeErr = null;
     try {
       const out = (await _gitExec(localPath, ['rev-parse', '--is-inside-work-tree'])).trim();
       isRepo = out === 'true';
-    } catch { isRepo = false; }
-    if (!isRepo) return PROJECT_GIT_STATUS_NON_GIT;
+    } catch (err) { isRepo = false; probeErr = err; }
+    if (!isRepo) {
+      // opg-microsoft/minions#312 — only collapse to non-git when the probe
+      // genuinely found no repository. A probe-budget timeout (slow
+      // \\wsl.localhost\ 9P share + Defender scanning can take >40s on a
+      // valid repo) or a present `.git` entry means the path IS git-managed;
+      // surface a distinct `probe-timeout` state so the dashboard never shows
+      // the misleading "(not a git repo)" label for a valid repo.
+      if (probeErr && (_isProbeTimeoutError(probeErr) || _hasGitDir(localPath))) {
+        return PROJECT_GIT_STATUS_PROBE_TIMEOUT;
+      }
+      return PROJECT_GIT_STATUS_NON_GIT;
+    }
     let branch = null;
     let detached = false;
     try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2237",
+  "version": "0.1.2238",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"