@yemi33/minions 0.1.2236 → 0.1.2237

package/dashboard/js/refresh.js

@@ -147,7 +147,7 @@ const RENDER_VERSIONS = {
   dispatch: 2,
   engineLog: 2,
   metrics: 1,
-  workItems: 3,
+  workItems: 4,
   skills: 1,
   commands: 1,
   mcpServers: 1,

package/dashboard/js/render-work-items.js

@@ -238,6 +238,10 @@ function wiRow(item) {
       })() +
     '</td>' +
     '<td style="white-space:nowrap">' +
+      // W-mqqa76pi — "View live output" opens the agent slide-in panel (live-output
+      // tab auto-selected when the agent is working). Only for genuinely active
+      // dispatches with a resolvable assigned agent id.
+      ((item.status === 'dispatched' && (item.dispatched_to || item.agent)) ? '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:1px 6px;color:var(--green);border-color:var(--green);margin-right:4px" onclick="event.stopPropagation();openArtifact(\'agent\',\'' + escapeHtml(item.dispatched_to || item.agent) + '\')" title="View live output">&#x1F4FA;</button>' : '') +
       ((item.status === 'pending' || item.status === 'failed') ? '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:1px 6px;color:var(--blue);border-color:var(--blue);margin-right:4px" onclick="event.stopPropagation();editWorkItem(\'' + escapeHtml(item.id) + '\',\'' + escapeHtml(item._source || '') + '\')" title="Edit work item">&#x270E;</button>' : '') +
       ((item.status === 'done' || item.status === 'failed') ? '<button class="pr-pager-btn" style="font-size:var(--text-xs);padding:1px 6px;color:var(--muted);border-color:var(--border);margin-right:4px" onclick="event.stopPropagation();archiveWorkItem(\'' + escapeHtml(item.id) + '\',\'' + escapeHtml(item._source || '') + '\')" title="Archive work item">&#x1F4E6;</button>' : '') +
       ((item.status === 'done' || item.status === 'failed') && !item._humanFeedback ? '<button class="btn-action" style="margin-right:4px" onclick="event.stopPropagation();feedbackWorkItem(\'' + escapeHtml(item.id) + '\',\'' + escapeHtml(item._source || '') + '\')" title="Give feedback">&#x1F44D;&#x1F44E;</button>' : (item._humanFeedback ? '<span style="font-size:var(--text-xs)" title="Feedback given">' + (item._humanFeedback.rating === 'up' ? '&#x1F44D;' : '&#x1F44E;') + '</span> ' : '')) +
@@ -699,6 +703,14 @@ function _wiRenderDetail(item) {
       return ' <span class="pr-badge needs-attention" style="font-size:var(--text-xs);margin-left:4px" title="See &quot;Why this is blocked&quot; below">&#x26A0; Needs attention</span>';
     })() +
     '</div>';
+  // W-mqqa76pi — Prominent "View live output" button for an actively-dispatched
+  // WI. Opens the agent slide-in panel via openArtifact('agent', id), which
+  // resets the modal stack and selects the live-output tab when the agent is
+  // working. Gated on status==='dispatched' AND a resolvable assigned agent id.
+  if (item.status === 'dispatched' && (item.dispatched_to || item.agent)) {
+    var _wiLiveAgentId = item.dispatched_to || item.agent;
+    html += '<div style="margin-bottom:12px"><button class="pr-pager-btn" style="font-size:var(--text-base);padding:4px 12px;color:var(--green);border-color:var(--green)" onclick="openArtifact(\'agent\',\'' + escapeHtml(_wiLiveAgentId) + '\')" title="View live output">&#x1F4FA; View live output</button></div>';
+  }
   // Work item id — shown in the modal body (not just the title) so operators can
   // read/copy the canonical id (W-… or sched-…) when deeplinking in from a note.
   html += field('ID', '<code style="font-size:var(--text-sm);background:var(--surface2);padding:2px 6px;border-radius:var(--radius-sm)">' + escapeHtml(item.id || '—') + '</code>');

package/dashboard.js

@@ -1977,6 +1977,61 @@ setInterval(() => checkNpmVersion().catch(() => {}), _getVersionCheckInterval())
 let _diskVersionCache = null;
 let _diskVersionCacheTs = 0;
 const DISK_VERSION_TTL = 60000; // re-check every 60s
+
+// Read the short HEAD commit by parsing `.git` directly — NO `git` subprocess.
+// The old `execSync('git rev-parse --short HEAD', { timeout: 5000 })` spawned a
+// synchronous child process on the dashboard's single event loop; under
+// concurrent agent git activity (worktree add/merge holding repo locks) that
+// subprocess could take its full 5s timeout, and because getDiskVersion runs
+// inside the /api/status rebuild, every in-flight poll blocked for that whole
+// window. Reading `.git/HEAD` + the resolved ref (loose ref, then packed-refs
+// fallback) is a couple of tiny synchronous file reads with zero process spawn.
+// Returns { commit, isGitRepo }: commit is the 7-char short SHA or null.
+function _readGitHeadShort(repoDir) {
+  try {
+    const gitPath = path.join(repoDir, '.git');
+    let gitDir = gitPath;
+    const st = fs.statSync(gitPath); // throws if no `.git` → caught → not a repo
+    if (st.isFile()) {
+      // Linked worktree: `.git` is a file whose first line reads `gitdir: <abs>`.
+      const m = /^gitdir:\s*(.+?)\s*$/m.exec(fs.readFileSync(gitPath, 'utf8'));
+      if (!m) return { commit: null, isGitRepo: false };
+      gitDir = path.isAbsolute(m[1]) ? m[1] : path.resolve(repoDir, m[1]);
+    }
+    const head = fs.readFileSync(path.join(gitDir, 'HEAD'), 'utf8').trim();
+    let sha = null;
+    const refM = /^ref:\s*(.+?)\s*$/.exec(head);
+    if (refM) {
+      const ref = refM[1];
+      try { sha = fs.readFileSync(path.join(gitDir, ref), 'utf8').trim() || null; } catch {}
+      if (!sha) {
+        // packed-refs fallback (git gc packs loose refs). For the main repo
+        // gitDir IS the common gitdir, so packed-refs lives directly under it.
+        try {
+          const line = fs.readFileSync(path.join(gitDir, 'packed-refs'), 'utf8')
+            .split('\n').find(l => l.endsWith(' ' + ref));
+          if (line) sha = line.slice(0, 40);
+        } catch {}
+      }
+    } else if (/^[0-9a-f]{40}$/i.test(head)) {
+      sha = head; // detached HEAD: the SHA is written directly into HEAD
+    }
+    return { commit: sha ? sha.slice(0, 7) : null, isGitRepo: true };
+  } catch {
+    return { commit: null, isGitRepo: false };
+  }
+}
+
+// Two git short-SHA abbreviations name the same commit when one is a prefix of
+// the other. `git rev-parse --short` picks the minimum-unique length (often 8),
+// while _readGitHeadShort emits a fixed 7 — a strict `!==` between them would
+// false-positive into a spurious "version stale" banner. Prefix comparison is
+// the robust check across abbreviation-length differences.
+function _commitsDiffer(a, b) {
+  if (!a || !b) return false;
+  return !(a.startsWith(b) || b.startsWith(a));
+}
+
 function getDiskVersion() {
   const now = Date.now();
   if (_diskVersionCache && (now - _diskVersionCacheTs) < DISK_VERSION_TTL) return _diskVersionCache;
@@ -1990,10 +2045,11 @@ function getDiskVersion() {
   if (!diskVersion) {
     try { diskVersion = require('@yemi33/minions/package.json').version; } catch {}
   }
-  let diskCommit = null;
-  let isGitRepo = false;
-  // Prefer git (authoritative for repo-based dev), fall back to .minions-commit (installed copies)
-  try { diskCommit = require('child_process').execSync('git rev-parse --short HEAD', { cwd: MINIONS_DIR, encoding: 'utf8', timeout: 5000, windowsHide: true }).trim(); isGitRepo = true; } catch {}
+  // Prefer git (authoritative for repo-based dev), fall back to .minions-commit (installed copies).
+  // Parse `.git` directly instead of spawning `git rev-parse` — see _readGitHeadShort.
+  const head = _readGitHeadShort(MINIONS_DIR);
+  let diskCommit = head.commit;
+  let isGitRepo = head.isGitRepo;
   if (!diskCommit) {
     try { diskCommit = fs.readFileSync(path.join(MINIONS_DIR, '.minions-commit'), 'utf8').trim() || null; } catch {}
   }
@@ -2450,9 +2506,9 @@ function _buildStatusSlowState() {
       const engine = getEngineState();
       const { diskVersion, diskCommit, isGitRepo } = getDiskVersion();
       const engineStale = !!(engine.codeVersion && diskVersion && engine.codeVersion !== diskVersion) ||
-                          !!(engine.codeCommit && diskCommit && engine.codeCommit !== diskCommit);
+                          _commitsDiffer(engine.codeCommit, diskCommit);
       const dashboardStale = !!(diskVersion && _dashboardVersion.codeVersion && diskVersion !== _dashboardVersion.codeVersion) ||
-                             !!(diskCommit && _dashboardVersion.codeCommit && diskCommit !== _dashboardVersion.codeCommit);
+                             _commitsDiffer(diskCommit, _dashboardVersion.codeCommit);
       return {
         running: engine.codeVersion || null,
         runningCommit: engine.codeCommit || null,
@@ -3056,17 +3112,34 @@ async function _handleStatusRequest(req, res) {
   try {
     _recordDashboardBrowserPresenceFromRequest(req);
 
-    // Ensure cache is fresh + yields the event loop mid-rebuild so CC SSE
-    // heartbeats keep flowing during slow rebuilds. Synchronous getStatus()
-    // still works for SSE-periodic-push callers that can't await.
-    try { await refreshStatusAsync(); } catch { /* fall through — getStatusJson will sync-rebuild */ }
-
-    // Race-guard fallback: if refresh discarded its result because
-    // invalidateStatusCache() fired mid-rebuild, _statusCache is still null.
-    // Trigger a synchronous rebuild here so the ETag we compute reflects
-    // freshly-built post-invalidate state, not the stale pre-invalidate one.
-    if (!_statusCache) {
-      try { getStatus(); } catch { /* getStatusJson below will retry */ }
+    // Stale-while-revalidate (perf, W-status-swr). Two staleness modes exist:
+    //   • HARD invalidation — invalidateStatusCache() sets _statusCache = null
+    //     because a mutation MUST be reflected before we answer. There is
+    //     nothing valid to serve, so we await one rebuild (cold path below).
+    //   • SOFT staleness — the event-version / mtime signal advanced (e.g. an
+    //     agent emitted a state event) but _statusCache still holds a valid,
+    //     seconds-old snapshot. Under active-agent load this fires on nearly
+    //     every 4s poll. Awaiting the rebuild here is what stalled every
+    //     in-flight poll for 6–15s, because the single-flight rebuild runs
+    //     synchronous fs/git probes to completion before resolving.
+    // When we have ANY snapshot, never block the request: kick the refresh in
+    // the background (its result lands in _statusCache and bumps the ETag for
+    // the NEXT poll) and serve the current cache now. A 4s-old envelope for a
+    // 4s poller is fine; a 15s-blocked request is not.
+    if (_statusCache) {
+      Promise.resolve().then(refreshStatusAsync).catch(() => { /* next poll + SSE push retry */ });
+    } else {
+      // Cold start or post-hard-invalidation: nothing to serve → await one
+      // rebuild. refreshStatusAsync yields the event loop mid-rebuild so CC
+      // SSE heartbeats keep flowing during a slow build.
+      try { await refreshStatusAsync(); } catch { /* fall through — getStatusJson will sync-rebuild */ }
+      // Race-guard fallback: if refresh discarded its result because
+      // invalidateStatusCache() fired mid-rebuild, _statusCache is still null.
+      // Trigger a synchronous rebuild here so the ETag we compute reflects
+      // freshly-built post-invalidate state, not the stale pre-invalidate one.
+      if (!_statusCache) {
+        try { getStatus(); } catch { /* getStatusJson below will retry */ }
+      }
     }
 
     // ETag = monotonic cache version. Bumped on every successful rebuild and
@@ -12530,9 +12603,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       const { diskVersion, diskCommit, isGitRepo } = getDiskVersion();
       const engine = getEngineState();
       const engineStale = !!(engine.codeVersion && diskVersion && engine.codeVersion !== diskVersion) ||
-                          !!(engine.codeCommit && diskCommit && engine.codeCommit !== diskCommit);
+                          _commitsDiffer(engine.codeCommit, diskCommit);
       const dashboardStale = !!(diskVersion && _dashboardVersion.codeVersion && diskVersion !== _dashboardVersion.codeVersion) ||
-                             !!(diskCommit && _dashboardVersion.codeCommit && diskCommit !== _dashboardVersion.codeCommit);
+                             _commitsDiffer(diskCommit, _dashboardVersion.codeCommit);
       return jsonReply(res, 200, {
         current: diskVersion,
         currentCommit: diskCommit,
@@ -14060,6 +14133,11 @@ module.exports = {
   _setStatusRefreshHook,
   _resetStatusCacheForTesting,
   _ifNoneMatchHasEtag,
+  // W-status-swr — exported for direct unit tests of the subprocess-free git
+  // HEAD parser and the prefix-tolerant short-SHA comparison. No production
+  // caller imports these; they are test seams.
+  _readGitHeadShort,
+  _commitsDiffer,
   // Exported for the engine-stale-two-signal test (W-mpof1xxe000ac689) — the
   // staleness verdict it stamps on engine.heartbeatStale is the contract under
   // test. No production caller imports this; it is a test seam.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2236",
+  "version": "0.1.2237",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"