@yemi33/minions 0.1.2229 → 0.1.2230

package/dashboard.js

@@ -6965,9 +6965,28 @@ const server = http.createServer(async (req, res) => {
     // Replay-on-connect: if a terminal event for this agent landed within
     // the ring's TTL, push it immediately so a viewer who opens the live
     // view AFTER completion still sees the verdict.
+    //
+    // W-mqprx2px00076668 — but a STALE terminal failure must not be replayed
+    // as the active blocking banner when the agent has since started a newer
+    // dispatch (e.g. a successful retry of the same work item). Gate the
+    // replay on the agent's live dispatch state: suppress the failure banner
+    // when the agent is actively working a different (newer) dispatch than the
+    // one that produced the event. History is preserved — the raw event still
+    // lives in the JSONL ring and the WI/event history; only the prominent
+    // active-agent banner is gated.
     try {
       const recent = dispatchEvents.getLastTerminalForAgent(agentId);
-      if (recent) sendTerminalEvent(recent);
+      if (recent) {
+        let agentStatus = null;
+        try { agentStatus = queries.getAgentStatus(agentId); } catch { agentStatus = null; }
+        if (dispatchEvents.isStaleTerminalForActiveDispatch(recent, agentStatus)) {
+          // Mark as already-handled so a later file-rotation rewind in the
+          // terminal watcher cannot re-broadcast this suppressed stale banner.
+          if (recent.dispatchId) _sentTerminalDispatchIds.add(recent.dispatchId);
+        } else {
+          sendTerminalEvent(recent);
+        }
+      }
     } catch { /* best-effort replay */ }
 
     const eventsFile = dispatchEvents._eventsFile();

package/engine/dispatch-events.js

@@ -141,6 +141,45 @@ function getLastTerminalForAgent(agentId) {
   return null;
 }
 
+/**
+ * W-mqprx2px00076668 — gate a terminal-FAILURE banner against the agent's
+ * live dispatch state. A stale terminal failure (result !== 'success', e.g.
+ * `error` / `timeout`) MUST NOT be surfaced as the active blocking banner
+ * once the SAME agent is actively working a NEWER dispatch than the one that
+ * produced the event. The active-dispatch state wins over any older terminal
+ * error whose `dispatchId` is not the agent's current dispatch.
+ *
+ * This is a GENERIC rule across all failureClasses — keyed solely on "does
+ * this terminal event belong to the agent's CURRENT dispatch?" — not a
+ * special-case for any one failureClass. Pure (no I/O): the caller passes the
+ * agent's status snapshot so the predicate stays unit-testable and reusable
+ * by both the dashboard replay-on-connect path and the client renderer.
+ *
+ * Returns true when the event should be suppressed as the active banner.
+ * Does NOT delete history — the raw event still lives in the JSONL ring and
+ * the WI/event history; only the prominent active-agent banner is gated.
+ *
+ * @param {object} event - dispatch.terminal event ({ result, dispatchId, ... }).
+ * @param {object} agentStatus - agent status snapshot, e.g. the
+ *   `{ status, dispatch_id }` shape returned by queries.getAgentStatus().
+ * @returns {boolean}
+ */
+function isStaleTerminalForActiveDispatch(event, agentStatus) {
+  if (!event || !event.dispatchId) return false;
+  // Success banners never imply the run is blocked — leave them to the
+  // dispatch.started clear path. Only failure/timeout banners are gated.
+  if (event.result === 'success') return false;
+  // No active work → keep the failure banner. An agent that is genuinely
+  // idle (or in the post-completion `error`/`done` window) after a terminal
+  // failure STILL shows its banner; don't over-suppress.
+  if (!agentStatus || agentStatus.status !== 'working') return false;
+  const current = agentStatus.dispatch_id || null;
+  if (!current) return false;
+  // Agent is actively working a DIFFERENT (newer) dispatch than the one that
+  // produced this terminal failure → suppress it as the active banner.
+  return current !== event.dispatchId;
+}
+
 
 /**
  * Build the terminal event payload from a freshly-completed dispatch entry +
@@ -237,6 +276,7 @@ module.exports = {
   onDispatchTerminal,
   readRecentEvents,
   getLastTerminalForAgent,
+  isStaleTerminalForActiveDispatch,
   buildTerminalEvent,
   // dispatch.started (W-mq1m1wo5000nd78d)
   emitDispatchStarted,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2229",
+  "version": "0.1.2230",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"