@yemi33/minions 0.1.2194 → 0.1.2196

package/dashboard/js/render-prs.js

@@ -204,7 +204,8 @@ function prRow(pr) {
     '<td><span class="pr-badge ' + statusClass + '" title="' + escapeHtml(statusLabel) + '">' + escapeHtml(statusLabel) + '</span></td>' +
     '<td>' + (observeBtn || '<span style="color:var(--muted);font-size:var(--text-base)">—</span>') + '</td>' +
     '<td><span class="pr-date" title="' + escapeHtml(createdLabel) + '">' + escapeHtml(createdLabel) + '</span></td>' +
-    '<td><button class="btn-destructive" style="padding:1px 5px" data-pr-id="' + escapeHtml(String(prId)) + '" onclick="event.stopPropagation();unlinkPr(this.dataset.prId)" title="Remove from tracking">x</button></td>' +
+    '<td><button class="pr-info-pill" data-pr-id="' + escapeHtml(String(prId)) + '" onclick="event.stopPropagation();openPrDetail(this.dataset.prId)" title="Open PR detail (in-stack modal)">&#x2197;</button>' +
+      '<button class="btn-destructive" style="padding:1px 5px;margin-left:4px" data-pr-id="' + escapeHtml(String(prId)) + '" onclick="event.stopPropagation();unlinkPr(this.dataset.prId)" title="Remove from tracking">x</button></td>' +
     '</tr>';
 }
 
@@ -224,7 +225,7 @@ const PRS_COLGROUP =
     '<col style="width:110px">' +   // Status
     '<col style="width:100px">' +   // Observe
     '<col style="width:130px">' +   // Created
-    '<col style="width:50px">' +    // Actions
+    '<col style="width:80px">' +    // Actions (info-pill + remove)
   '</colgroup>';
 
 function prTableHtml(rows) {
@@ -300,6 +301,176 @@ function openAllPrs() {
   document.getElementById('modal').classList.add('open');
 }
 
+// P-79b47b0c — in-stack PR detail modal. Routed from openArtifact('pr', id)
+// in render-utils.js and from the PR-row info-pill in prRow(). Read-only:
+// renders title, status/review/build badges, reviewers, linked-WI chips
+// (joined via item._pr === pr.id from queries enrichment), description, and
+// an "Open on GitHub" secondary button. No POSTs from this modal.
+function openPrDetail(prId) {
+  if (window.getSelection && window.getSelection().toString().length > 0) return;
+  if (!prId) return;
+  // Render an immediate skeleton from the in-memory PR cache (allPrs) so the
+  // modal feels instant. Then hit GET /api/prs/<id> for the canonical record
+  // and re-render via withTopFrame() to respect modal-stack semantics.
+  const cached = (allPrs || []).find(p => p && p.id === prId) ||
+                 ((window._lastPrs) || []).find(p => p && p.id === prId);
+  document.getElementById('modal-title').textContent = (cached && (cached.title || cached.id)) || prId;
+  // eslint-disable-next-line no-unsanitized/property -- reason: _renderPrDetail() escapes all user fields (title, description, agent, reviewers, branch) via escapeHtml() / renderMd() / renderArtifactLink() before assembly
+  document.getElementById('modal-body').innerHTML = _renderPrDetail(cached || { id: prId, _loading: true });
+  document.getElementById('modal-body').style.fontFamily = "'Segoe UI', system-ui, sans-serif";
+  document.getElementById('modal-body').style.whiteSpace = 'normal';
+  document.getElementById('modal').classList.add('open');
+
+  fetch('/api/prs/' + encodeURIComponent(prId))
+    .then(function(r) { if (!r.ok) throw new Error('HTTP ' + r.status); return r.json(); })
+    .then(function(data) {
+      const pr = data && data.pr;
+      if (!pr) return;
+      const apply = function() {
+        document.getElementById('modal-title').textContent = pr.title || pr.id || prId;
+        // eslint-disable-next-line no-unsanitized/property -- reason: _renderPrDetail() escapes all user fields (title, description, agent, reviewers, branch) via escapeHtml() / renderMd() / renderArtifactLink() before assembly
+        document.getElementById('modal-body').innerHTML = _renderPrDetail(pr);
+      };
+      if (typeof withTopFrame === 'function') withTopFrame('pr', prId, apply);
+      else apply();
+    })
+    .catch(function() {
+      const body = document.getElementById('modal-body');
+      if (body) {
+        body.innerHTML = '<p style="color:var(--red)">Failed to load PR ' + escapeHtml(String(prId)) + '.</p>';
+      }
+    });
+}
+
+function _renderPrDetail(pr) {
+  if (!pr) return '<p style="color:var(--muted)">No data.</p>';
+  if (pr._loading) {
+    return '<p style="color:var(--muted)">Loading PR ' + escapeHtml(String(pr.id || '')) + '...</p>';
+  }
+  const sq = pr.minionsReview || {};
+  const reviewLabel = sq.status === 'waiting' ? 'reviewing (minions)' : sq.status ? sq.status + ' (minions)' : (pr.reviewStatus || 'pending');
+  const reviewClass = (sq.status || pr.reviewStatus) === 'approved' ? 'approved' :
+                      ((sq.status || pr.reviewStatus) === 'changes-requested' || (sq.status || pr.reviewStatus) === 'rejected') ? 'rejected' :
+                      (sq.status || pr.reviewStatus) === 'waiting' ? 'building' : 'draft';
+  const buildLabel = pr.buildStatus || 'none';
+  const buildClass = pr._buildStatusStale ? 'build-stale' :
+                     pr.buildStatus === 'passing' ? 'build-pass' :
+                     pr.buildStatus === 'failing' ? 'build-fail' :
+                     pr.buildStatus === 'running' ? 'building' : 'no-build';
+  const statusLabel = pr.status || 'active';
+  const statusClass = statusLabel === 'merged' ? 'pr-merged' :
+                      statusLabel === 'abandoned' ? 'pr-abandoned' :
+                      statusLabel === 'draft' ? 'draft' : 'pr-active';
+
+  const badges =
+    '<span class="pr-badge ' + statusClass + '" title="status">' + escapeHtml(String(statusLabel)) + '</span> ' +
+    '<span class="pr-badge ' + reviewClass + '" title="review">' + escapeHtml(String(reviewLabel)) + '</span> ' +
+    '<span class="pr-badge ' + buildClass + '" title="build">' + escapeHtml(String(buildLabel)) + '</span>';
+
+  // Linked WIs — join via item._pr === pr.id (stamped by engine/queries.js).
+  const wis = (window._lastWorkItems) || [];
+  const linkedWis = wis.filter(w => w && w._pr === pr.id);
+  let linkedChips = '';
+  if (linkedWis.length && typeof renderArtifactLink === 'function') {
+    linkedChips = '<div style="margin-top:10px"><strong style="color:var(--muted);font-size:var(--text-base)">Linked Work Items:</strong><br>' +
+      linkedWis.map(w => renderArtifactLink({ type: 'wi', id: w.id, label: w.id, title: w.title || w.id })).join(' ') +
+      '</div>';
+  }
+
+  // P-e6093f70 — PR ↔ PR linkage. Surface (a) a "Parent PR (follow-up)"
+  // chip when this PR record carries meta.pr_followup.parent_pr_url /
+  // parent_pr_id (mirrors the WI-side rendering at render-work-items.js
+  // _wiRenderDetail, P-79b47b0c) and (b) one chip per pr.depends_on[]
+  // entry. Both surfaces use renderArtifactLink({type:'pr'}) so click
+  // opens the parent / dep PR modal in-stack with browser-Back support.
+  //
+  // Graceful degradation: when parent_pr_url cannot be parsed into a
+  // canonical id (unknown host), fall back to a plain external <a>.
+  // depends_on chips consult the local PR cache (allPrs / window._lastPrs
+  // / window._lastPullRequests) and pass deleted:true when the dep is
+  // unknown so the chip renders struck-out (non-clickable) instead of
+  // silently linking to a 404.
+  let parentChip = '';
+  const followup = pr.meta && pr.meta.pr_followup;
+  if (followup && (followup.parent_pr_id || followup.parent_pr_url) && typeof renderArtifactLink === 'function') {
+    let parentPrId = followup.parent_pr_id || '';
+    if (!parentPrId && followup.parent_pr_url && typeof _wiDeriveCanonicalPrIdFromUrl === 'function') {
+      parentPrId = _wiDeriveCanonicalPrIdFromUrl(followup.parent_pr_url) || '';
+    }
+    if (parentPrId) {
+      parentChip = '<div style="margin-top:10px"><strong style="color:var(--muted);font-size:var(--text-base)">Parent PR (follow-up):</strong> ' +
+        renderArtifactLink({ type: 'pr', id: parentPrId, label: parentPrId, title: 'Follow-up from ' + (followup.parent_pr_url || parentPrId) }) +
+        '</div>';
+    } else if (followup.parent_pr_url) {
+      parentChip = '<div style="margin-top:10px"><strong style="color:var(--muted);font-size:var(--text-base)">Parent PR (follow-up):</strong> ' +
+        '<a href="' + escapeHtml(followup.parent_pr_url) + '" target="_blank" rel="noopener" style="color:var(--blue)">' + escapeHtml(followup.parent_pr_url) + '</a>' +
+        '</div>';
+    }
+  }
+
+  let dependsChips = '';
+  if (Array.isArray(pr.depends_on) && pr.depends_on.length && typeof renderArtifactLink === 'function') {
+    const knownPrIds = new Set();
+    const knownSources = [
+      (typeof allPrs !== 'undefined' && Array.isArray(allPrs)) ? allPrs : null,
+      window._lastPrs,
+      window._lastPullRequests,
+    ];
+    for (const src of knownSources) {
+      if (Array.isArray(src)) for (const p of src) { if (p && p.id) knownPrIds.add(p.id); }
+    }
+    dependsChips = '<div style="margin-top:10px"><strong style="color:var(--muted);font-size:var(--text-base)">Depends On:</strong> ' +
+      pr.depends_on.map(function(d) {
+        const depId = String(d);
+        const isDeleted = knownPrIds.size > 0 && !knownPrIds.has(depId);
+        return renderArtifactLink({
+          type: 'pr',
+          id: depId,
+          label: depId,
+          title: isDeleted ? 'Dependency PR ' + depId + ' is no longer in local state' : 'Depends on ' + depId,
+          deleted: isDeleted,
+        });
+      }).join(' ') +
+      '</div>';
+  }
+
+  // Reviewers list
+  let reviewers = '';
+  if (Array.isArray(pr.reviewers) && pr.reviewers.length) {
+    reviewers = '<div style="margin-top:6px"><strong style="color:var(--muted);font-size:var(--text-base)">Reviewers:</strong> ' +
+      pr.reviewers.map(r => '<code>' + escapeHtml(String(typeof r === 'string' ? r : (r.displayName || r.name || ''))) + '</code>').join(' ') +
+      '</div>';
+  }
+
+  const agent = pr.agent ? '<div><strong style="color:var(--muted);font-size:var(--text-base)">Agent:</strong> ' + escapeHtml(String(pr.agent)) + '</div>' : '';
+  const branch = pr.branch ? '<div><strong style="color:var(--muted);font-size:var(--text-base)">Branch:</strong> <code>' + escapeHtml(String(pr.branch)) + '</code></div>' : '';
+  const created = pr.created ? '<div><strong style="color:var(--muted);font-size:var(--text-base)">Created:</strong> ' + escapeHtml(String(pr.created)) + '</div>' : '';
+  const project = pr._project ? '<div><strong style="color:var(--muted);font-size:var(--text-base)">Project:</strong> ' + escapeHtml(String(pr._project)) + '</div>' : '';
+
+  const descSafe = typeof renderMd === 'function' ? renderMd(pr.description || '') : escapeHtml(pr.description || '');
+  const descBlock = pr.description ?
+    '<div style="margin-top:14px"><strong style="color:var(--muted);font-size:var(--text-base)">Description:</strong><div style="margin-top:6px;font-size:var(--text-md);line-height:1.6">' + descSafe + '</div></div>' :
+    '';
+
+  const openOnHost = pr.url ?
+    '<a class="btn-secondary" style="display:inline-block;margin-top:14px;padding:6px 12px;text-decoration:none" href="' + escapeHtml(safeUrl(pr.url)) + '" target="_blank" rel="noopener">Open on GitHub &#x2197;</a>' :
+    '';
+
+  return '<div style="font-family:\'Segoe UI\',system-ui,sans-serif">' +
+    '<div style="margin-bottom:10px">' +
+      '<code style="color:var(--muted);font-size:var(--text-base)">' + escapeHtml(String(pr.id || '')) + '</code><br>' +
+      badges +
+    '</div>' +
+    agent + branch + project + created +
+    reviewers +
+    linkedChips +
+    parentChip +
+    dependsChips +
+    descBlock +
+    openOnHost +
+  '</div>';
+}
+
 function openModal(i) {
   const item = inboxData[i];
   if (!item) return;
@@ -490,4 +661,4 @@ async function resumePausedCause(btn) {
   }
 }
 
-window.MinionsPrs = { prRow, prTableHtml, renderPrs, prPrev, prNext, openAllPrs, openModal, openAddPrModal, unlinkPr, togglePrObserve, resumePausedCause };
+window.MinionsPrs = { prRow, prTableHtml, renderPrs, prPrev, prNext, openAllPrs, openModal, openAddPrModal, openPrDetail, unlinkPr, togglePrObserve, resumePausedCause };

package/dashboard/js/render-schedules.js

@@ -405,6 +405,18 @@ function openScheduleDetail(id) {
     '<div><strong style="color:var(--muted)">Agent:</strong> ' + escHtml(s.agent || 'auto') + '</div>' +
     '<div><strong style="color:var(--muted)">Status:</strong> ' + enabledLabel + '</div>' +
     '<div><strong style="color:var(--muted)">Last Run:</strong> ' + escHtml(lastRun) + '</div>' +
+    // P-c549d07e — "Recent dispatches" chip row. Each chip routes through
+    // renderArtifactLink({type:'wi'}) → openArtifact() so clicking pushes
+    // the WI detail modal onto the stack. Hard-cap to 5 chips even if the
+    // API returned more (defensive — the API already slices).
+    (Array.isArray(s._recentWorkItemIds) && s._recentWorkItemIds.length > 0
+      ? '<div><strong style="color:var(--muted)">Recent dispatches:</strong>' +
+          '<div style="display:flex;flex-wrap:wrap;gap:4px;margin-top:4px">' +
+            s._recentWorkItemIds.slice(0, 5).map(function(wi) {
+              return renderArtifactLink({ type: 'wi', id: String(wi), label: String(wi), title: 'Open work item ' + wi });
+            }).join('') +
+          '</div></div>'
+      : '') +
     (s.description ? '<div><strong style="color:var(--muted)">Description:</strong><div style="margin-top:4px;padding:8px;background:var(--surface2);border-radius:4px">' + renderMd(s.description) + '</div></div>' : '') +
   '</div>';
 

package/dashboard/js/render-utils.js

@@ -575,4 +575,154 @@ function restoreDashboardScrollState(root, state) {
   });
 }
 
-window.MinionsRenderUtils = { formatToolSummary, renderAgentOutput, renderTerminalBanner, renderPager, pinButton, captureDashboardScrollState, restoreDashboardScrollState };
+// P-ce1e5e47 — universal artifact-modal dispatcher. Chip clicks (and the
+// URL-hash replay path) call openArtifact(type, id); this pushes a stack
+// frame and delegates to the existing per-type opener.
+//
+// Type → handler table:
+//   wi        → openWorkItemDetail(id)
+//   pr        → openPrDetail(id)            (P-79b47b0c; falls back to openPrUrl)
+//   plan/prd  → planView(id)
+//   note      → openInboxNote(id)
+//   kb        → kbOpenItem(category, file)  (id = "category/file")
+//   schedule  → openScheduleDetail(id)
+//   watch     → openWatchDetail(id)
+//   pipeline  → openPipelineDetail(id)
+//   meeting   → openMeetingDetail(id)
+//   agent     → openAgentDetail(id)         ← detail-panel exception (see below)
+//
+// P-30b6cf8a — Detail-panel exception (intentional, documented). The agent
+// type does NOT push a modal-stack frame and does NOT use the modal shell.
+// openAgentDetail() opens the right-side slide-in detail panel (tabs +
+// live-stream + charter editor) which is a peer of the modal stack, not a
+// member of it. Clicking an agent chip from inside a modal therefore:
+//   1. Resets the modal stack (resetModalStack) and physically closes the
+//      modal shell — modal-stack identity goes back to empty.
+//   2. Opens the agent detail panel.
+// The reverse direction is symmetric: clicking a WI/PR/plan chip from
+// inside the panel calls openArtifact('<type>', id), which (per the
+// non-agent branch below) closes the detail panel and starts a fresh
+// modal stack. This one-way exception is the deliberate contract — do
+// NOT "fix" it by adding pushModalFrame for the agent type. See the
+// matching JSDoc on dashboard/js/render-agents.js openAgentDetail().
+function openArtifact(type, id) {
+  if (!type || id === undefined || id === null) return;
+  if (type === 'agent') {
+    if (typeof resetModalStack === 'function') resetModalStack();
+    if (typeof _physicallyCloseModal === 'function') _physicallyCloseModal();
+    if (typeof openAgentDetail === 'function') openAgentDetail(id);
+    return;
+  }
+  // Non-agent (modal) type: dismiss the detail panel if it's open so the
+  // modal-stack peer cleanly takes over the foreground.
+  try {
+    var panelEl = document.getElementById('detail-panel');
+    if (panelEl && panelEl.classList.contains('open') && typeof closeDetail === 'function') {
+      closeDetail();
+    }
+  } catch { /* DOM may not be ready in unit-test eval */ }
+  if (typeof pushModalFrame === 'function') {
+    try {
+      pushModalFrame({ type: type, id: String(id), openFn: openArtifact, openArgs: [type, String(id)] });
+    } catch (e) { try { console.error('pushModalFrame failed', e); } catch {} }
+  }
+  switch (type) {
+    case 'wi':
+      if (typeof openWorkItemDetail === 'function') openWorkItemDetail(id);
+      break;
+    case 'pr':
+      if (typeof openPrDetail === 'function') openPrDetail(id);
+      else if (typeof window !== 'undefined' && window.MinionsPrs && typeof window.MinionsPrs.openPrDetail === 'function') window.MinionsPrs.openPrDetail(id);
+      break;
+    case 'plan':
+    case 'prd':
+      if (typeof planView === 'function') planView(id);
+      break;
+    case 'note':
+      if (typeof openInboxNote === 'function') openInboxNote(id);
+      break;
+    case 'kb': {
+      var idx = String(id).indexOf('/');
+      if (idx > 0 && typeof kbOpenItem === 'function') {
+        kbOpenItem(String(id).slice(0, idx), String(id).slice(idx + 1));
+      }
+      break;
+    }
+    case 'schedule':
+      if (typeof openScheduleDetail === 'function') openScheduleDetail(id);
+      break;
+    case 'watch':
+      if (typeof openWatchDetail === 'function') openWatchDetail(id);
+      break;
+    case 'pipeline':
+      if (typeof openPipelineDetail === 'function') openPipelineDetail(id);
+      break;
+    case 'meeting':
+      if (typeof openMeetingDetail === 'function') openMeetingDetail(id);
+      break;
+    default:
+      try { console.warn('openArtifact: unknown type', type); } catch {}
+  }
+}
+
+// P-e265cd31 — shared artifact-chip renderer. Every chip click routes through
+// openArtifact() so the modal stack push, URL-hash update, and browser-Back
+// integration come for free at every callsite (no more inline
+// pushModalBack(...);openXxxDetail(...) string-built pills).
+//
+// Icon table — keep consistent across the dashboard:
+//   wi=📋  pr=🔀  plan=📋  prd=📄  note=📝  kb=📚
+//   schedule=⏰  watch=👁  pipeline=⛓  meeting=🗣  agent=🤖
+//
+// Options:
+//   type     — one of the icon-table keys (case-sensitive)
+//   id       — artifact identifier; passed verbatim to openArtifact(type, id)
+//   label    — visible chip text (defaults to id)
+//   title    — optional hover tooltip (defaults to empty)
+//   icon     — optional icon override (defaults to ICON_TABLE[type])
+//   deleted  — true → render struck-out, non-clickable chip so dead refs
+//              still show context to the operator
+//
+// Unknown type with no explicit icon falls back to a plain escaped span (no
+// chip styling, no throw) so callers can pass through arbitrary refs safely.
+var _ARTIFACT_ICON_TABLE = {
+  wi: '📋', pr: '🔀', plan: '📋', prd: '📄', note: '📝', kb: '📚',
+  schedule: '⏰', watch: '👁', pipeline: '⛓', meeting: '🗣', agent: '🤖',
+};
+
+function renderArtifactLink(opts) {
+  var o = opts || {};
+  var type = String(o.type == null ? '' : o.type);
+  var id = o.id == null ? '' : String(o.id);
+  var label = o.label == null ? id : String(o.label);
+  var title = o.title == null ? '' : String(o.title);
+  var hasIconOverride = typeof o.icon === 'string' && o.icon.length > 0;
+  var icon = hasIconOverride ? o.icon : (_ARTIFACT_ICON_TABLE[type] || '');
+  var deleted = o.deleted === true;
+
+  if (!Object.prototype.hasOwnProperty.call(_ARTIFACT_ICON_TABLE, type) && !hasIconOverride) {
+    return '<span class="artifact-chip-unknown">' + escHtml(label) + '</span>';
+  }
+
+  var classes = 'artifact-chip' + (deleted ? ' deleted' : '');
+  // JSON.stringify produces a safe JS string literal (handles backslashes,
+  // quotes, control chars). escHtml then makes it safe for the attribute
+  // value; the HTML parser reverses the entity escapes before the JS
+  // evaluator sees them, so the call site always receives the original
+  // string values.
+  var clickAttr = deleted
+    ? ''
+    : ' onclick="event.stopPropagation();openArtifact('
+        + escHtml(JSON.stringify(type)) + ','
+        + escHtml(JSON.stringify(id)) + ')"';
+  var titleAttr = title ? ' title="' + escHtml(title) + '"' : '';
+  return '<span class="' + classes + '"'
+       + ' data-art-type="' + escHtml(type) + '"'
+       + ' data-art-id="' + escHtml(id) + '"'
+       + clickAttr + titleAttr + '>'
+       + (icon ? '<span class="artifact-chip-icon">' + escHtml(icon) + '</span>' : '')
+       + '<span class="artifact-chip-label">' + escHtml(label) + '</span>'
+       + '</span>';
+}
+
+window.MinionsRenderUtils = { formatToolSummary, renderAgentOutput, renderTerminalBanner, renderPager, pinButton, captureDashboardScrollState, restoreDashboardScrollState, openArtifact, renderArtifactLink };

package/dashboard/js/render-watches.js

@@ -101,6 +101,48 @@ function _targetTypeLabel(type) {
   return _WATCH_TARGET_LABELS[type] || (type || '');
 }
 
+// P-1acd4cde — map a watch.targetType to the artifact-chip type understood by
+// renderArtifactLink / openArtifact (defined in render-utils.js). Returns null
+// for targetTypes that don't correspond to a navigable artifact (teams-channel,
+// future plugin types) so callers fall back to plain text rendering. The
+// mapping covers the 8 first-class TARGET_TYPES registered in engine/watches.js
+// (engine/shared.js#WATCH_TARGET_TYPE) — dispatch ids are WI ids in practice
+// so they share the wi chip target.
+var _WATCH_TARGET_TO_ART_TYPE = {
+  'pr': 'pr',
+  'work-item': 'wi',
+  'meeting': 'meeting',
+  'plan': 'plan',
+  'schedule': 'schedule',
+  'pipeline': 'pipeline',
+  'dispatch': 'wi',
+  'agent': 'agent',
+};
+function _watchTargetToArtType(targetType) {
+  if (!targetType) return null;
+  return _WATCH_TARGET_TO_ART_TYPE[targetType] || null;
+}
+
+// P-1acd4cde — render the watch target as a clickable artifact chip when the
+// targetType maps to a known artifact AND the target is a non-empty string id.
+// Object targets (e.g. teams-channel `{teamId, channelId}`) and plugin
+// targetTypes without an artifact equivalent fall back to the legacy
+// _formatWatchTarget plain text so the W-mq1j5f9z00030b8f title-fallback
+// contract still holds for non-artifact watches.
+function _renderWatchTargetChip(w) {
+  var artType = _watchTargetToArtType(w && w.targetType);
+  if (artType && typeof w.target === 'string' && w.target.length > 0
+      && typeof renderArtifactLink === 'function') {
+    return renderArtifactLink({
+      type: artType,
+      id: w.target,
+      label: w.target,
+      title: _targetTypeLabel(w.targetType) + ' ' + w.target,
+    });
+  }
+  return escHtml(_formatWatchTarget(w && w.target, w && w.targetType));
+}
+
 // W-mq1j5f9z00030b8f — `teams-channel` target is `{teamId, channelId}` (object);
 // other targetTypes use strings. Avoid `String(target)` → "[object Object]";
 // route all target rendering here so future object-target plugins inherit safety.
@@ -339,7 +381,7 @@ function openWatchDetail(id) {
 
   var body = '<div style="display:flex;flex-direction:column;gap:10px;font-size:var(--text-md);line-height:1.6">' +
     '<div><strong style="color:var(--muted)">ID:</strong> ' + escHtml(w.id) + '</div>' +
-    '<div><strong style="color:var(--muted)">Target:</strong> ' + escHtml(_formatWatchTarget(w.target, w.targetType)) + '</div>' +
+    '<div><strong style="color:var(--muted)">Target:</strong> ' + _renderWatchTargetChip(w) + '</div>' +
     '<div><strong style="color:var(--muted)">Target Type:</strong> <span class="dispatch-type explore">' + escHtml(targetLabel) + '</span></div>' +
     '<div><strong style="color:var(--muted)">Condition:</strong> <span style="color:var(--blue)">' + escHtml(condLabel) + '</span></div>' +
     '<div><strong style="color:var(--muted)">Check Interval:</strong> ' + escHtml(_intervalToHuman(w.interval)) + '</div>' +
@@ -356,7 +398,7 @@ function openWatchDetail(id) {
     // P-w14e7a8c — Phase 7.1: render cross-target requirements list when
     // the watch carries a non-empty requires[] from the editor.
     _renderWatchRequiresDetail(w.requires) +
-    (w._lastActionResult ? '<div><strong style="color:var(--muted)">Last Action Result:</strong> <span style="color:' + (w._lastActionResult.ok ? 'var(--green)' : 'var(--red)') + '">' + (w._lastActionResult.ok ? 'OK' : 'FAILED') + '</span> — ' + escHtml(w._lastActionResult.summary || '') + (w._lastActionResult.dispatchedItemId ? ' (dispatched: ' + escHtml(w._lastActionResult.dispatchedItemId) + ')' : '') + '</div>' : '') +
+    (w._lastActionResult ? '<div><strong style="color:var(--muted)">Last Action Result:</strong> <span style="color:' + (w._lastActionResult.ok ? 'var(--green)' : 'var(--red)') + '">' + (w._lastActionResult.ok ? 'OK' : 'FAILED') + '</span> — ' + escHtml(w._lastActionResult.summary || '') + (w._lastActionResult.dispatchedItemId && typeof renderArtifactLink === 'function' ? ' ' + renderArtifactLink({ type: 'wi', id: String(w._lastActionResult.dispatchedItemId), label: String(w._lastActionResult.dispatchedItemId), title: 'Dispatched work item ' + w._lastActionResult.dispatchedItemId }) : '') + '</div>' : '') +
     '<div><strong style="color:var(--muted)">Created:</strong> ' + escHtml(createdAt) + '</div>' +
     '<div><strong style="color:var(--muted)">Last Checked:</strong> ' + escHtml(lastChecked) + '</div>' +
     '<div><strong style="color:var(--muted)">Last Triggered:</strong> ' + escHtml(lastTriggered) + '</div>' +
@@ -389,13 +431,22 @@ function openWatchDetail(id) {
       return res.json();
     }).then(function(data) {
       if (!container.isConnected) return; // user closed the modal
-      // eslint-disable-next-line no-unsanitized/property -- reason: _renderWatchHistoryDetail() escapes all user-controlled fields before assembling HTML
-      container.innerHTML = _renderWatchHistoryDetail(data && data.history);
+      // P-ce1e5e47 — skip the history render when the user has stacked
+      // another modal on top of this watch view.
+      var apply = function() {
+        // eslint-disable-next-line no-unsanitized/property -- reason: _renderWatchHistoryDetail() escapes all user-controlled fields before assembling HTML
+        container.innerHTML = _renderWatchHistoryDetail(data && data.history);
+      };
+      if (typeof withTopFrame === 'function') withTopFrame('watch', w.id, apply);
+      else apply();
     }).catch(function() {
       if (!container.isConnected) return;
-      // Fall back to the inline _history from /api/watches (best-effort).
-      // eslint-disable-next-line no-unsanitized/property -- reason: _renderWatchHistoryDetail() escapes all user-controlled fields before assembling HTML
-      container.innerHTML = _renderWatchHistoryDetail(w._history || []);
+      var applyFallback = function() {
+        // eslint-disable-next-line no-unsanitized/property -- reason: _renderWatchHistoryDetail() escapes all user-controlled fields before assembling HTML
+        container.innerHTML = _renderWatchHistoryDetail(w._history || []);
+      };
+      if (typeof withTopFrame === 'function') withTopFrame('watch', w.id, applyFallback);
+      else applyFallback();
     });
   })();
 }
@@ -824,4 +875,7 @@ window.MinionsWatches = {
   // W-mq1j5f9z00030b8f — target / title fallback helpers exposed for unit coverage.
   _formatWatchTarget: _formatWatchTarget,
   _watchTitleFallback: _watchTitleFallback,
+  // P-1acd4cde — watch ↔ target artifact-chip linkage helpers exposed for unit coverage.
+  _watchTargetToArtType: _watchTargetToArtType,
+  _renderWatchTargetChip: _renderWatchTargetChip,
 };