@yemi33/minions 0.1.2188 → 0.1.2189

package/dashboard.js

@@ -13560,13 +13560,28 @@ if (require.main === module) {
     // (engine/shared.js#openUrlInBrowser) now owns the env-var check and
     // emits a debug-level SUPPRESSED log entry so we can prove the kill-
     // switch is firing.
-    const result = shared.openUrlInBrowser(`http://localhost:${PORT}`, {
-      reason: 'dashboard-self-open',
-      callerHint: 'dashboard.js:13124',
-    });
-    if (!result.ok && !result.suppressed) {
-      console.log(`  Could not auto-open browser: ${result.error}`);
-      console.log(`  Please open http://localhost:${PORT} manually.`);
+    //
+    // W-mqef-dashboard-tty — only self-open for an interactive human run
+    // (`node dashboard.js` in a terminal). The CLI spawns the dashboard
+    // DETACHED + non-TTY with MINIONS_NO_AUTO_OPEN=1 and orchestrates the open
+    // itself, so it never relied on this branch. But the dashboard integration
+    // tests — and any agent running `npm test` — spawn dashboard.js with piped
+    // stdio and NO env guard, so this fired for real on every test run, popping
+    // a browser tab to a random localhost port that the test then tore down
+    // (blank window on the operator's desktop). stdout.isTTY is false for every
+    // programmatic spawn (tests, agents, CI, the detached CLI dashboard) and
+    // true only for a real terminal session, so it's the correct discriminator.
+    if (process.stdout.isTTY) {
+      const result = shared.openUrlInBrowser(`http://localhost:${PORT}`, {
+        reason: 'dashboard-self-open',
+        callerHint: 'dashboard.js:13124',
+      });
+      if (!result.ok && !result.suppressed) {
+        console.log(`  Could not auto-open browser: ${result.error}`);
+        console.log(`  Please open http://localhost:${PORT} manually.`);
+      }
+    } else {
+      console.log(`  Open http://localhost:${PORT} in your browser.`);
     }
 
     // Warm the CC runtime binary cache off the request path so the first CC /

package/engine.js

@@ -3306,6 +3306,14 @@ async function spawnAgent(dispatchItem, config) {
   // them unconditionally regardless of repo host.
   childEnv.GIT_TERMINAL_PROMPT = '0';
   childEnv.GCM_INTERACTIVE = 'never';
+  // W-mqef-dashboard-tty — agents run headless and must never pop a browser on
+  // the operator's desktop. Stamp the suppression env so anything an agent runs
+  // that funnels through shared.openUrlInBrowser — notably the dashboard a
+  // `npm test` run boots — inherits the guard. The engine's own process env did
+  // NOT carry this flag, so agent-spawned dashboards were self-opening to a
+  // random localhost port (blank window). Belt-and-suspenders with dashboard.js's
+  // stdout.isTTY gate.
+  childEnv.MINIONS_NO_AUTO_OPEN = '1';
 
   if (getRepoHost(project) === 'ado') {
     // Inject cached ADO token so ADO agents skip re-authentication (#998).
@@ -3756,6 +3764,9 @@ async function spawnAgent(dispatchItem, config) {
       // credential dialogs on `git push` against stale PATs.
       childEnv.GIT_TERMINAL_PROMPT = '0';
       childEnv.GCM_INTERACTIVE = 'never';
+      // W-mqef-dashboard-tty — same browser-popup suppression on steering resume
+      // (see the initial spawn site). Agents must never auto-open a browser.
+      childEnv.MINIONS_NO_AUTO_OPEN = '1';
       if (getRepoHost(project) === 'ado') {
         // Inject cached ADO token for steering session too (#998)
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2188",
+  "version": "0.1.2189",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"