@yemi33/minions 0.1.2183 → 0.1.2185

package/engine/cli.js

@@ -2170,7 +2170,6 @@ module.exports = {
   _parseRuntimeFlags,
   _modelLooksIncompatible,
   _applyRuntimeFlags,
-  _createControlOwner: createControlOwner,
   _controlBelongsToOwner: controlBelongsToOwner,
   _markControlStoppingForOwner: markControlStoppingForOwner,
   _markControlStoppedForOwner: markControlStoppedForOwner,

package/engine/dispatch-events.js

@@ -141,14 +141,6 @@ function getLastTerminalForAgent(agentId) {
   return null;
 }
 
-function getLastTerminalForDispatch(dispatchId) {
-  if (!dispatchId) return null;
-  const events = readRecentEvents();
-  for (let i = events.length - 1; i >= 0; i--) {
-    if (events[i].dispatchId === dispatchId) return events[i];
-  }
-  return null;
-}
 
 /**
  * Build the terminal event payload from a freshly-completed dispatch entry +
@@ -245,7 +237,6 @@ module.exports = {
   onDispatchTerminal,
   readRecentEvents,
   getLastTerminalForAgent,
-  getLastTerminalForDispatch,
   buildTerminalEvent,
   // dispatch.started (W-mq1m1wo5000nd78d)
   emitDispatchStarted,

package/engine/dispatch-store.js

@@ -298,17 +298,10 @@ function _mirrorJsonFromSql() {
   }
 }
 
-// Test seam — clear the dispatches table. Production code never calls this.
-function _resetDispatchTableForTest() {
-  const { getDb } = require('./db');
-  try { getDb().exec('DELETE FROM dispatches'); } catch { /* not initialized */ }
-}
-
 module.exports = {
   readDispatchSectioned,
   applyDispatchMutation,
   _readDispatchSectionedFull,
   _computeDispatchDiff,
   _mirrorJsonFromSql,
-  _resetDispatchTableForTest,
 };

package/engine/github.js

@@ -400,26 +400,16 @@ async function ghApi(endpoint, slug, opts = {}) {
   }
 }
 
-/**
- * Run a `gh api` call with per-slug backoff tracking. Returns null on failure.
- * On success, resets the slug's backoff. On failure, increments it.
- */
-async function ghApiWithBackoff(endpoint, slug) {
-  const result = await ghApi(endpoint, slug);
-  if (result === null) {
-    recordSlugFailure(slug);
-  } else {
-    resetSlugBackoff(slug);
-  }
-  return result;
-}
-
 const BUILD_ERROR_LOG_MAX_LINES = 150;
 
 /**
  * Fetch actual build/compiler error logs from GitHub when a check run fails.
  * Tries annotations first (structured error messages), then falls back to the
  * Actions job log. Returns truncated log text or null if unavailable.
+ *
+ * NOTE: counterpart to ado.js#fetchAdoBuildErrorLog (W-mnp8iyqe0ogn), which IS
+ * wired into the ADO poller. This GitHub variant has source-inspection test
+ * coverage but is not yet called from the GitHub PR poller path.
  */
 async function fetchGhBuildErrorLog(slug, failedRuns) {
   try {

package/engine/lifecycle.js

@@ -10,7 +10,6 @@ const shared = require('./shared');
 const { safeRead, safeJson, safeJsonArr, safeJsonNoRestore, safeWrite, mutateJsonFileLocked, mutateWorkItems, execAsync, projectPrPath, getPrLinks,
   log, ts, dateStamp, WI_STATUS, DONE_STATUSES, PLAN_TERMINAL_STATUSES, WORK_TYPE, PLAN_STATUS, PRD_ITEM_STATUS, PR_STATUS, REVIEW_STATUS, RETRY_DELAY_MS, DISPATCH_RESULT,
   ENGINE_DEFAULTS, DEFAULT_AGENT_METRICS, FAILURE_CLASS } = shared;
-const { trackEngineUsage } = require('./llm');
 const { resolveRuntime } = require('./runtimes');
 const adoGitAuth = require('./ado-git-auth');
 const queries = require('./queries');

package/engine/operator-identity.js

@@ -13,16 +13,15 @@
 //
 // The resolved value is cached in module state. The cache is intentionally
 // process-lifetime: `minions restart` re-resolves; the per-tick dispatch hot
-// path does not. Test helpers expose cache reset + exec/os.username injection
-// so unit tests stay hermetic.
+// path does not. `_resetOperatorLoginCacheForTest` clears the cache when the
+// Settings override changes.
 
 const { execSync } = require('child_process');
 const os = require('os');
 
 let _cached = null;
 
-// Test seams. The default impls shell out; tests inject pure functions.
-let _execImpl = (cmd) => {
+function _execImpl(cmd) {
   try {
     return String(execSync(cmd, {
       encoding: 'utf8',
@@ -32,12 +31,9 @@ let _execImpl = (cmd) => {
   } catch {
     return '';
   }
-};
-
-let _osUsernameOverride = null; // null = call real os.userInfo()
+}
 
 function _osUsername() {
-  if (_osUsernameOverride !== null) return _osUsernameOverride;
   try {
     const u = os.userInfo().username;
     return u ? String(u) : '';
@@ -76,29 +72,11 @@ function resolveOperatorLogin(config, { force = false } = {}) {
   return _cached;
 }
 
-// ── Test helpers (not part of the public API) ────────────────────────────────
-
+// Clear the process-lifetime cache. Called by the dashboard when the operator
+// login override changes in Settings so the next resolve picks up the new value.
 function _resetOperatorLoginCacheForTest() { _cached = null; }
-function _setExecImplForTest(fn) { _execImpl = typeof fn === 'function' ? fn : _execImpl; }
-function _resetExecImplForTest() {
-  _execImpl = (cmd) => {
-    try {
-      return String(execSync(cmd, {
-        encoding: 'utf8',
-        stdio: ['ignore', 'pipe', 'ignore'],
-        timeout: 5000,
-      })).trim();
-    } catch {
-      return '';
-    }
-  };
-}
-function _setOsUsernameForTest(value) { _osUsernameOverride = value; }
 
 module.exports = {
   resolveOperatorLogin,
   _resetOperatorLoginCacheForTest,
-  _setExecImplForTest,
-  _resetExecImplForTest,
-  _setOsUsernameForTest,
 };

package/engine/pipeline.js

@@ -11,7 +11,7 @@ const queries = require('./queries');
 const { safeJson, safeJsonNoRestore, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, mutateWorkItems, mutatePipelineRuns, slugify, formatTranscriptEntry, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, READ_ONLY_ROOT_TASK_TYPES, ENGINE_DEFAULTS, MINIONS_DIR } = shared;
 const routing = require('./routing');
 const http = require('http');
-const { parseCronExpr, shouldRunNow } = require('./scheduler');
+const { shouldRunNow } = require('./scheduler');
 
 // All module-relative paths flow through MINIONS_DIR so MINIONS_TEST_DIR
 // (set by test/unit.test.js createTestMinionsDir) consistently redirects
@@ -440,46 +440,6 @@ function executeTaskStage(stage, stageState, run, config, pipeline = {}) {
   return { status: PIPELINE_STATUS.RUNNING, artifacts };
 }
 
-function executeTaskStageLegacy(stage, stageState, run, config) {
-  const items = stage.items || [{ title: stage.title, description: stage.description || '', type: stage.taskType || 'explore', agent: stage.agent }];
-  const count = stage.count || items.length;
-  const wiPath = CENTRAL_WI_PATH;
-  const createdIds = [];
-
-  mutateWorkItems(wiPath, workItems => {
-    for (let i = 0; i < count; i++) {
-      const item = items[i % items.length];
-      const id = `PL-${run.runId.slice(4, 12)}-${stage.id}-${i}`;
-      if (workItems.some(w => w.id === id)) { createdIds.push(id); continue; }
-      const wiType = routing.normalizeWorkType(item.type || stage.taskType, WORK_TYPE.EXPLORE);
-      // W-mp8ho6w500034a58: read-only stages don't commit, so the branch
-      // label is meaningless — omit it so dispatch takes the read-only path
-      // without recomputing a worktree placement that will never be used.
-      const wiBranch = READ_ONLY_ROOT_TASK_TYPES.has(wiType)
-        ? null
-        : `pipeline/${run.pipelineId}/${stage.id}`;
-      workItems.push({
-        id,
-        title: item.title || stage.title,
-        description: item.description || stage.description || '',
-        type: wiType,
-        priority: item.priority || stage.priority || 'medium',
-        // Agent is a soft routing hint unless agentLock/hardAgent is set.
-        ...(item.agent || stage.agent ? { agent: item.agent || stage.agent } : {}),
-        ...(item.agentLock === true || stage.agentLock === true || item.hardAgent === true || stage.hardAgent === true ? { agentLock: true } : {}),
-        status: WI_STATUS.PENDING,
-        created: ts(),
-        createdBy: 'pipeline:' + run.pipelineId,
-        ...(wiBranch ? { branch: wiBranch } : {}),
-        _pipelineRun: run.runId,
-        _pipelineStage: stage.id,
-      });
-      createdIds.push(id);
-    }
-  });
-  return { status: PIPELINE_STATUS.RUNNING, artifacts: { workItems: createdIds } };
-}
-
 function executeMeetingStage(stage, stageState, run, config) {
   const { createMeeting } = require('./meeting');
   const agents = config.agents || {};

package/engine/pull-requests-store.js

@@ -299,11 +299,6 @@ function _mirrorJsonFromSql(scope, filePath) {
   }
 }
 
-function _resetPullRequestsTableForTest() {
-  const { getDb } = require('./db');
-  try { getDb().exec('DELETE FROM pull_requests'); } catch { /* not initialized */ }
-}
-
 function dropScope(scope) {
   try {
     const { getDb } = require('./db');
@@ -320,5 +315,4 @@ module.exports = {
   dropScope,
   _filePathForScope,
   _mirrorJsonFromSql,
-  _resetPullRequestsTableForTest,
 };

package/engine/qa-sessions.js

@@ -833,22 +833,6 @@ function _summarizeTarget(target) {
   }
 }
 
-/**
- * W-mpq6xqzj000606d0 — Back-compat shim: return the canonical projects[]
- * array for a session, regardless of whether the record was written under
- * the legacy single-`project` schema or the new `projects[]` schema. Returns
- * `[]` for "central" sessions (no project) so callers can simply check
- * `length > 1` for multi-project mode.
- */
-function _resolveSessionProjects(session) {
-  if (!session || typeof session !== 'object') return [];
-  const fromArr = session.spec && Array.isArray(session.spec.projects) ? session.spec.projects : null;
-  if (fromArr && fromArr.length > 0) return fromArr.slice();
-  const fromStr = session.spec && typeof session.spec.project === 'string' && session.spec.project.length > 0
-    ? session.spec.project
-    : null;
-  return fromStr ? [fromStr] : [];
-}
 
 // ── Cross-WI dispatch chain helpers ─────────────────────────────────────────
 //
@@ -1359,5 +1343,4 @@ module.exports = {
   summarizeSessionsForStatus,
   // Internals (exposed for tests)
   _isSafeSessionId,
-  _resolveSessionProjects,
 };

package/engine/queries.js

@@ -2702,13 +2702,6 @@ function _mtimePathsCacheKey(config) {
   const projects = getProjects(config).map(p => (p.name || '') + '|' + (p.localPath || ''));
   return projects.join(';');
 }
-function _invalidateMtimePathsCache() {
-  _fastMtimePathsCache = null;
-  _fastMtimePathsCacheKey = null;
-  _slowMtimePathsCache = null;
-  _slowMtimePathsCacheKey = null;
-}
-
 function getStatusFastStateMtimePaths(config) {
   // Issue #2949 — /api/status was slimmed to just engine/throttle state +
   // skills/mcp/projects/version. dispatch.json, work-items.json,

package/engine/shared.js

@@ -7975,7 +7975,6 @@ module.exports = {
   writeDashboardPortFile,
   clearDashboardPortFile,
   resolveDashboardPort,
-  currentLogPath: _currentLogPath,
   ts,
   normalizeIsoTimestamp, // F6 (P-f6commentedit)
   buildEditsSeen, // F6 (P-f6commentedit)

package/engine/small-state-store.js

@@ -1351,37 +1351,6 @@ function _mirrorDocSessionsJson(filePath) {
   } catch { /* mirror best-effort */ }
 }
 
-// ─── Test seam ─────────────────────────────────────────────────────────────
-
-function _resetAllForTest() {
-  const { getDb } = require('./db');
-  try {
-    const db = getDb();
-    db.exec('DELETE FROM schedule_runs');
-    db.exec('DELETE FROM pipeline_runs');
-    db.exec('DELETE FROM managed_processes');
-    db.exec('DELETE FROM worktree_pool');
-    try { db.exec('DELETE FROM qa_runs'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM qa_sessions'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM pr_links'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM cooldowns'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM pending_rebases'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM cc_sessions'); } catch { /* migration not applied */ }
-    try { db.exec('DELETE FROM doc_sessions'); } catch { /* migration not applied */ }
-  } catch { /* not initialized */ }
-  _scheduleRunsHash = null;
-  _pipelineRunsHash = null;
-  _managedProcessesHash = null;
-  _worktreePoolHash = null;
-  _qaRunsHash = null;
-  _qaSessionsHash = null;
-  _prLinksHash = null;
-  _cooldownsHash = null;
-  _pendingRebasesHash = null;
-  _ccSessionsHash = null;
-  _docSessionsHash = null;
-}
-
 module.exports = {
   // schedule_runs
   readScheduleRuns,
@@ -1427,6 +1396,4 @@ module.exports = {
   readDocSessions,
   applyDocSessionsMutation,
   _mirrorDocSessionsJson,
-  // test seam
-  _resetAllForTest,
 };

package/engine/watch-actions.js

@@ -1189,5 +1189,4 @@ module.exports = {
   validateAction,
   computeWatchDedupKey, // exported for testing (BUG-H10)
   WATCH_DEDUP_ACTIVE_STATUSES, // exported for testing (BUG-H10)
-  _ACTION_TYPES: ACTION_TYPES, // exported for testing
 };

package/engine/watches-store.js

@@ -245,15 +245,8 @@ function _mirrorJsonFromSql(filePath) {
   }
 }
 
-function _resetWatchesTableForTest() {
-  const { getDb } = require('./db');
-  try { getDb().exec('DELETE FROM watches'); } catch { /* not initialized */ }
-  _lastMirrorHash = null;
-}
-
 module.exports = {
   readWatches,
   applyWatchesMutation,
   _mirrorJsonFromSql,
-  _resetWatchesTableForTest,
 };

package/engine/work-items-store.js

@@ -357,12 +357,6 @@ function _mirrorJsonFromSql(scope, filePath) {
   }
 }
 
-// Test seam.
-function _resetWorkItemsTableForTest() {
-  const { getDb } = require('./db');
-  try { getDb().exec('DELETE FROM work_items'); } catch { /* not initialized */ }
-}
-
 // Drop every SQL row for `scope` and forget its mirror-hash. Called by
 // removeProject after the JSON file is archived so safeJson shim reads no
 // longer surface the removed project's records.
@@ -382,5 +376,4 @@ module.exports = {
   dropScope,
   _filePathForScope,
   _mirrorJsonFromSql,
-  _resetWorkItemsTableForTest,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.2183",
+  "version": "0.1.2185",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"